@defra-fish/sales-api-service 1.64.0-rc.15 → 1.64.0-rc.17

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defra-fish/sales-api-service",
-  "version": "1.64.0-rc.15",
+  "version": "1.64.0-rc.17",
   "description": "Rod Licensing Sales API",
   "type": "module",
   "engines": {
@@ -35,9 +35,9 @@
     "test": "echo \"Error: run tests from root\" && exit 1"
   },
   "dependencies": {
-    "@defra-fish/business-rules-lib": "1.64.0-rc.15",
-    "@defra-fish/connectors-lib": "1.64.0-rc.15",
-    "@defra-fish/dynamics-lib": "1.64.0-rc.15",
+    "@defra-fish/business-rules-lib": "1.64.0-rc.17",
+    "@defra-fish/connectors-lib": "1.64.0-rc.17",
+    "@defra-fish/dynamics-lib": "1.64.0-rc.17",
     "@hapi/boom": "9.1.2",
     "@hapi/hapi": "20.1.3",
     "@hapi/inert": "6.0.3",
@@ -52,5 +52,5 @@
     "moment-timezone": "0.5.34",
     "uuid": "8.3.2"
   },
-  "gitHead": "c0fe3ad10eab3dd2601f0cce25f05ab923653a02"
+  "gitHead": "cb3537aa9589865c6ae6ad9354a4c2254b979892"
 }

package/src/server/routes/__tests__/authenticate-new.spec.js

@@ -7,7 +7,7 @@ describe('executeWithErrorLog', () => {
   it('throws error', async () => {
     const debug = jest.fn()
     db.mockReturnValueOnce(debug)
-    executeQuery.mockImplementation(() => {
+    executeQuery.mockImplementationOnce(() => {
       throw new Error()
     })
     contactForLicenseeNoReference.mockReturnValueOnce({ filter: 'query filter test' })

package/src/server/routes/__tests__/authenticate.spec.js

@@ -7,6 +7,13 @@ import {
   MOCK_CONCESSION_PROOF_ENTITY,
   MOCK_CONCESSION
 } from '../../../__mocks__/test-data.js'
+import authenticate from '../authenticate.js'
+
+const [
+  {
+    options: { handler }
+  }
+] = authenticate
 
 jest.mock('@defra-fish/dynamics-lib', () => ({
   ...jest.requireActual('@defra-fish/dynamics-lib'),
@@ -190,4 +197,40 @@ describe('authenticate handler', () => {
       })
     })
   })
+
+  it('changes reference number to uppercase', async () => {
+    const sampleQueryReferenceNumber = 'abc123'
+    const sampleResultReferenceNumber = sampleQueryReferenceNumber.toUpperCase()
+    const makeMockEntity = (obj = {}) => ({
+      ...obj,
+      toJSON: () => obj
+    })
+    executeQuery.mockReturnValueOnce([{ entity: { id: 'hgk-999' } }]).mockReturnValueOnce([
+      {
+        entity: makeMockEntity({
+          referenceNumber: sampleResultReferenceNumber
+        }),
+        expanded: {
+          concessionProofs: [],
+          licensee: { entity: makeMockEntity() },
+          permit: { entity: makeMockEntity() }
+        }
+      }
+    ])
+    const mockRequest = {
+      query: { licenseeBirthDate: '', licenseePostcode: '' },
+      params: { referenceNumber: sampleQueryReferenceNumber }
+    }
+    const mockResponseToolkit = { response: jest.fn(() => ({ code: () => {} })) }
+
+    await handler(mockRequest, mockResponseToolkit)
+
+    expect(mockResponseToolkit.response).toHaveBeenCalledWith(
+      expect.objectContaining({
+        permission: expect.objectContaining({
+          referenceNumber: sampleResultReferenceNumber
+        })
+      })
+    )
+  })
 })

package/src/server/routes/authenticate.js

@@ -29,7 +29,7 @@ export default [
         if (contacts.length > 0) {
           const contactIds = contacts.map(contact => contact.entity.id)
           const permissions = await executeWithErrorLog(permissionForContacts(contactIds))
-          const results = permissions.filter(p => p.entity.referenceNumber.endsWith(request.params.referenceNumber))
+          const results = permissions.filter(p => p.entity.referenceNumber.endsWith(request.params.referenceNumber.toUpperCase()))
           if (results.length === 1) {
             let concessionProofs = []
             if (results[0].expanded.concessionProofs.length > 0) {