@defra-fish/sales-api-service 1.57.0-rc.6 → 1.57.0-rc.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defra-fish/sales-api-service",
-  "version": "1.57.0-rc.6",
+  "version": "1.57.0-rc.8",
   "description": "Rod Licensing Sales API",
   "type": "module",
   "engines": {
@@ -35,9 +35,9 @@
     "test": "echo \"Error: run tests from root\" && exit 1"
   },
   "dependencies": {
-    "@defra-fish/business-rules-lib": "1.57.0-rc.6",
-    "@defra-fish/connectors-lib": "1.57.0-rc.6",
-    "@defra-fish/dynamics-lib": "1.57.0-rc.6",
+    "@defra-fish/business-rules-lib": "1.57.0-rc.8",
+    "@defra-fish/connectors-lib": "1.57.0-rc.8",
+    "@defra-fish/dynamics-lib": "1.57.0-rc.8",
     "@hapi/boom": "^9.1.2",
     "@hapi/hapi": "^20.1.3",
     "@hapi/inert": "^6.0.3",
@@ -52,5 +52,5 @@
     "moment-timezone": "^0.5.34",
     "uuid": "^8.3.2"
   },
-  "gitHead": "5c21e5443b8224f43c980c6a53746c593196500b"
+  "gitHead": "0bec5c50b0ee09c450d0016cf7b5225f00b1556c"
 }

package/src/services/__tests__/recurring-payments.service.spec.js

@@ -326,5 +326,17 @@ describe('recurring payments service', () => {
 
       expect(() => generateRecurringPaymentRecord(sampleTransaction)).toThrow('Invalid dates provided for permission')
     })
+
+    it('returns a false flag when agreementId is not present', () => {
+      const sampleTransaction = createFinalisedSampleTransaction(null, {
+        startDate: '2024-11-22T15:30:45.922Z',
+        issueDate: '2024-11-22T15:00:45.922Z',
+        endDate: '2025-11-21T23:59:59.999Z'
+      })
+
+      const rpRecord = generateRecurringPaymentRecord(sampleTransaction)
+
+      expect(rpRecord.payment.recurring).toBeFalsy()
+    })
   })
 })

package/src/services/recurring-payments.service.js

@@ -20,21 +20,24 @@ const getNextDueDate = (startDate, issueDate, endDate) => {
 }
 
 export const generateRecurringPaymentRecord = (transactionRecord, permission) => {
-  const [{ startDate, issueDate, endDate }] = transactionRecord.permissions
-  return {
-    payment: {
-      recurring: {
-        name: '',
-        nextDueDate: getNextDueDate(startDate, issueDate, endDate),
-        cancelledDate: null,
-        cancelledReason: null,
-        endDate,
-        agreementId: transactionRecord.agreementId,
-        status: 1
-      }
-    },
-    permissions: [permission]
+  if (transactionRecord.agreementId) {
+    const [{ startDate, issueDate, endDate }] = transactionRecord.permissions
+    return {
+      payment: {
+        recurring: {
+          name: '',
+          nextDueDate: getNextDueDate(startDate, issueDate, endDate),
+          cancelledDate: null,
+          cancelledReason: null,
+          endDate,
+          agreementId: transactionRecord.agreementId,
+          status: 1
+        }
+      },
+      permissions: [permission]
+    }
   }
+  return { payment: { recurring: false } }
 }
 
 /**