@defra-fish/recurring-payments-job 1.63.0-rc.8 → 1.63.0-rc.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defra-fish/recurring-payments-job",
-  "version": "1.63.0-rc.8",
+  "version": "1.63.0-rc.9",
   "description": "Rod Licensing Recurring Payments Job",
   "type": "module",
   "engines": {
@@ -36,11 +36,11 @@
     "test": "echo \"Error: run tests from root\" && exit 1"
   },
   "dependencies": {
-    "@defra-fish/business-rules-lib": "1.63.0-rc.8",
-    "@defra-fish/connectors-lib": "1.63.0-rc.8",
+    "@defra-fish/business-rules-lib": "1.63.0-rc.9",
+    "@defra-fish/connectors-lib": "1.63.0-rc.9",
     "commander": "^7.2.0",
     "debug": "^4.3.3",
     "moment-timezone": "^0.5.34"
   },
-  "gitHead": "4376fb63f6e1867708241521e43c4bce5791e08a"
+  "gitHead": "fc11192e1947a9a254138b543c8718ad892f0a15"
 }

package/src/__tests__/recurring-payments-processor.spec.js

@@ -20,17 +20,18 @@ jest.mock('@defra-fish/business-rules-lib', () => ({
 }))
 jest.mock('@defra-fish/connectors-lib', () => ({
   salesApi: {
-    getDueRecurringPayments: jest.fn(() => []),
-    preparePermissionDataForRenewal: jest.fn(() => ({
-      licensee: { countryCode: 'GB-ENG' }
-    })),
+    createPaymentJournal: jest.fn(),
     createTransaction: jest.fn(() => ({
       id: 'test-transaction-id',
       cost: 30
     })),
+    getDueRecurringPayments: jest.fn(() => []),
+    getPaymentJournal: jest.fn(),
+    preparePermissionDataForRenewal: jest.fn(() => ({
+      licensee: { countryCode: 'GB-ENG' }
+    })),
     processRPResult: jest.fn(),
-    updatePaymentJournal: jest.fn(),
-    getPaymentJournal: jest.fn()
+    updatePaymentJournal: jest.fn()
   }
 }))
 
@@ -308,6 +309,31 @@ describe('recurring-payments-processor', () => {
     expect(salesApi.createTransaction).toHaveBeenCalledWith(expectedData)
   })
 
+  it('creates a payment journal entry', async () => {
+    salesApi.getDueRecurringPayments.mockReturnValueOnce([getMockDueRecurringPayment()])
+    const samplePayment = {
+      payment_id: Symbol('payment-id'),
+      created_date: Symbol('created-date')
+    }
+    const sampleTransaction = {
+      id: Symbol('transaction-id'),
+      cost: 99
+    }
+    sendPayment.mockResolvedValueOnce(samplePayment)
+    salesApi.createTransaction.mockResolvedValueOnce(sampleTransaction)
+
+    await processRecurringPayments()
+
+    expect(salesApi.createPaymentJournal).toHaveBeenCalledWith(
+      sampleTransaction.id,
+      expect.objectContaining({
+        paymentReference: samplePayment.payment_id,
+        paymentTimestamp: samplePayment.created_date,
+        paymentStatus: PAYMENT_JOURNAL_STATUS_CODES.InProgress
+      })
+    )
+  })
+
   it('strips the concession name returned by preparePermissionDataForRenewal before passing to createTransaction', async () => {
     salesApi.getDueRecurringPayments.mockReturnValueOnce([getMockDueRecurringPayment()])
 

package/src/recurring-payments-processor.js

@@ -77,6 +77,12 @@ const createNewTransaction = async (referenceNumber, recurringPayment) => {
 const takeRecurringPayment = async (agreementId, transaction) => {
   const preparedPayment = preparePayment(agreementId, transaction)
   const payment = await sendPayment(preparedPayment)
+  await salesApi.createPaymentJournal(transaction.id, {
+    paymentReference: payment.payment_id,
+    paymentTimestamp: payment.created_date,
+    paymentStatus: PAYMENT_JOURNAL_STATUS_CODES.InProgress
+  })
+
   return {
     agreementId,
     paymentId: payment.payment_id,