@defra-fish/recurring-payments-job 1.63.0-rc.10 → 1.63.0-rc.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defra-fish/recurring-payments-job",
-  "version": "1.63.0-rc.10",
+  "version": "1.63.0-rc.11",
   "description": "Rod Licensing Recurring Payments Job",
   "type": "module",
   "engines": {
@@ -36,11 +36,11 @@
     "test": "echo \"Error: run tests from root\" && exit 1"
   },
   "dependencies": {
-    "@defra-fish/business-rules-lib": "1.63.0-rc.10",
-    "@defra-fish/connectors-lib": "1.63.0-rc.10",
+    "@defra-fish/business-rules-lib": "1.63.0-rc.11",
+    "@defra-fish/connectors-lib": "1.63.0-rc.11",
     "commander": "^7.2.0",
     "debug": "^4.3.3",
     "moment-timezone": "^0.5.34"
   },
-  "gitHead": "c4301461b148cbf244c1bb5c834521243ec0a534"
+  "gitHead": "7d0e5dab76d8aebb0dbaecb857c3d44fdc6f79f9"
 }

package/src/__tests__/recurring-payments-processor.spec.js

@@ -20,6 +20,7 @@ jest.mock('@defra-fish/business-rules-lib', () => ({
 }))
 jest.mock('@defra-fish/connectors-lib', () => ({
   salesApi: {
+    cancelRecurringPayment: jest.fn(),
     createPaymentJournal: jest.fn(),
     createTransaction: jest.fn(() => ({
       id: 'test-transaction-id',
@@ -636,6 +637,30 @@ describe('recurring-payments-processor', () => {
     }
   )
 
+  it.each([
+    ['a failure', 'agreement-id', getPaymentStatusFailure()],
+    ['a failure', 'test-agreement-id', getPaymentStatusFailure()],
+    ['a failure', 'another-agreement-id', getPaymentStatusFailure()],
+    ['an error', 'agreement-id', getPaymentStatusError()],
+    ['an error', 'test-agreement-id', getPaymentStatusError()],
+    ['an error', 'another-agreement-id', getPaymentStatusError()]
+  ])('cancelRecurringPayment is called when payment is %s', async (_status, agreementId, mockStatus) => {
+    salesApi.getDueRecurringPayments.mockReturnValueOnce([getMockDueRecurringPayment({ agreementId })])
+    const id = Symbol('recurring-payment-id')
+    salesApi.createTransaction.mockResolvedValueOnce({
+      recurringPayment: {
+        id
+      }
+    })
+    const mockPaymentResponse = { payment_id: 'test-payment-id', created_date: '2025-01-01T00:00:00.000Z' }
+    sendPayment.mockResolvedValueOnce(mockPaymentResponse)
+    getPaymentStatus.mockResolvedValueOnce(mockStatus)
+
+    await processRecurringPayments()
+
+    expect(salesApi.cancelRecurringPayment).toHaveBeenCalledWith(id)
+  })
+
   it('updatePaymentJournal is called with transaction id and failed status code payment is not succesful and payment journal exists', async () => {
     salesApi.getDueRecurringPayments.mockReturnValueOnce([getMockDueRecurringPayment()])
     const transactionId = 'test-transaction-id'

package/src/recurring-payments-processor.js

@@ -154,6 +154,7 @@ const processRecurringPaymentStatus = async payment => {
           paymentStatus: PAYMENT_JOURNAL_STATUS_CODES.Failed
         })
       }
+      await salesApi.cancelRecurringPayment(payment.transaction.recurringPayment.id)
     }
   } catch (error) {
     const status = error.response?.status
@@ -165,5 +166,6 @@ const processRecurringPaymentStatus = async payment => {
     } else {
       debug(`Unexpected error fetching payment status for ${payment.paymentId}.`)
     }
+    await salesApi.cancelRecurringPayment(payment.transaction.recurringPayment.id)
   }
 }