@defra-fish/gafl-webapp-service 1.76.0 → 1.77.0-rc.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defra-fish/gafl-webapp-service",
-  "version": "1.76.0",
+  "version": "1.77.0-rc.2",
   "description": "The websales frontend for the GAFL service",
   "type": "module",
   "engines": {
@@ -36,8 +36,8 @@
     "prepare": "gulp --gulpfile build/gulpfile.cjs"
   },
   "dependencies": {
-    "@defra-fish/business-rules-lib": "1.76.0",
-    "@defra-fish/connectors-lib": "1.76.0",
+    "@defra-fish/business-rules-lib": "1.77.0-rc.2",
+    "@defra-fish/connectors-lib": "1.77.0-rc.2",
     "@defra/hapi-gapi": "2.0.0",
     "@hapi/boom": "9.1.2",
     "@hapi/catbox-redis": "6.0.2",
@@ -79,5 +79,5 @@
       "./gafl-jest-matchers.js"
     ]
   },
-  "gitHead": "2287ca0defd4b61d66cbea6f0df84568265b036f"
+  "gitHead": "d473c2103570546d9096bffc5bf3ba13909e6a3e"
 }

package/src/services/licence-details/__test__/licence-details-service.spec.js

@@ -0,0 +1,71 @@
+import { salesApi } from '@defra-fish/connectors-lib'
+import { licenceDetailsService } from '../licence-details-service'
+jest.mock('@defra-fish/connectors-lib', () => ({
+  salesApi: {
+    getLicenceDetails: jest.fn(() => ({ licences: [] }))
+  }
+}))
+
+const getParams = () => ({
+  firstName: 'Fishy',
+  lastName: 'McFishface',
+  birthDate: '2000-01-01',
+  postcode: 'TE1 1ST'
+})
+
+describe('licence-details-service', () => {
+  it('calls getLicenceDetails with the correct params', async () => {
+    const params = getParams()
+    await licenceDetailsService(params)
+
+    expect(salesApi.getLicenceDetails).toHaveBeenCalledWith(params)
+  })
+
+  it.each([
+    ['there are no matches', { licences: [] }],
+    ['there is one match', { licences: [{ referenceNumber: 'AAAAAA-1' }] }],
+    ['there are multiple matches', { licences: [{ referenceNumber: 'AAAAAA-1' }, { referenceNumber: 'AAAAAA-2' }] }]
+  ])('returns the correct result when %s', async (_description, responseBody) => {
+    salesApi.getLicenceDetails.mockResolvedValueOnce(responseBody)
+
+    const result = await licenceDetailsService(getParams())
+    expect(result).toBe(responseBody.licences)
+  })
+
+  it('returns an empty array when there is no licences object in the result', async () => {
+    salesApi.getLicenceDetails.mockResolvedValueOnce({})
+
+    const result = await licenceDetailsService(getParams())
+    expect(result).toEqual([])
+  })
+
+  describe('if getLicenceDetails throws an error', () => {
+    it('catches the error', async () => {
+      const error = new Error('Something went wrong')
+      salesApi.getLicenceDetails.mockRejectedValueOnce(error)
+
+      await expect(licenceDetailsService(getParams())).resolves.toBeDefined()
+    })
+
+    it('calls console.error with the details', async () => {
+      const error = new Error('Something went wrong')
+      const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(jest.fn())
+      salesApi.getLicenceDetails.mockRejectedValueOnce(error)
+      const params = getParams()
+
+      await licenceDetailsService(params)
+
+      expect(consoleErrorSpy).toHaveBeenCalledWith(`Error retrieving licence details for ${JSON.stringify(params)}`, error)
+      consoleErrorSpy.mockRestore()
+    })
+
+    it('returns an empty array', async () => {
+      const error = new Error('Something went wrong')
+      salesApi.getLicenceDetails.mockRejectedValueOnce(error)
+
+      const results = await licenceDetailsService(getParams())
+
+      expect(results).toEqual([])
+    })
+  })
+})

package/src/services/licence-details/licence-details-service.js

@@ -0,0 +1,15 @@
+import { salesApi } from '@defra-fish/connectors-lib'
+
+const matchingLicences = async contactInfo => {
+  try {
+    return await salesApi.getLicenceDetails(contactInfo)
+  } catch (err) {
+    console.error(`Error retrieving licence details for ${JSON.stringify(contactInfo)}`, err)
+    return {}
+  }
+}
+
+export const licenceDetailsService = async ({ firstName, lastName, birthDate, postcode }) => {
+  const response = await matchingLicences({ firstName, lastName, birthDate, postcode })
+  return response?.licences || []
+}