@defra-fish/gafl-webapp-service 1.57.0-rc.1 → 1.57.0-rc.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defra-fish/gafl-webapp-service",
-  "version": "1.57.0-rc.1",
+  "version": "1.57.0-rc.3",
   "description": "The websales frontend for the GAFL service",
   "type": "module",
   "engines": {
@@ -36,8 +36,8 @@
     "prepare": "gulp --gulpfile build/gulpfile.cjs"
   },
   "dependencies": {
-    "@defra-fish/business-rules-lib": "1.57.0-rc.1",
-    "@defra-fish/connectors-lib": "1.57.0-rc.1",
+    "@defra-fish/business-rules-lib": "1.57.0-rc.3",
+    "@defra-fish/connectors-lib": "1.57.0-rc.3",
     "@defra/hapi-gapi": "^2.0.0",
     "@hapi/boom": "^9.1.2",
     "@hapi/catbox-redis": "^6.0.2",
@@ -80,5 +80,5 @@
       "./gafl-jest-matchers.js"
     ]
   },
-  "gitHead": "1b6d44f5046f91900083fb0fad5f95e2461c92b5"
+  "gitHead": "fffcc3f47679cac0fef84e3220a1111e4a209b2f"
 }

package/src/services/payment/__test__/govuk-pay-service.spec.js

@@ -309,7 +309,7 @@ describe('The govuk-pay-service', () => {
         ok: true,
         json: jest.fn().mockResolvedValue({ success: true, paymentId: 'abc123' })
       }
-      govUkPayApi.createRecurringPayment.mockResolvedValue(mockResponse)
+      govUkPayApi.createRecurringPaymentAgreement.mockResolvedValue(mockResponse)
       const unique = Symbol('payload')
       const payload = {
         reference: 'd81f1a2b-6508-468f-8342-b6770f60f7cd',
@@ -318,7 +318,7 @@ describe('The govuk-pay-service', () => {
         unique
       }
       await sendRecurringPayment(payload)
-      expect(govUkPayApi.createRecurringPayment).toHaveBeenCalledWith(payload)
+      expect(govUkPayApi.createRecurringPaymentAgreement).toHaveBeenCalledWith(payload)
     })
 
     it('should return response body when payment creation is successful', async () => {
@@ -326,7 +326,7 @@ describe('The govuk-pay-service', () => {
         ok: true,
         json: jest.fn().mockResolvedValue({ success: true, paymentId: 'abc123' })
       }
-      govUkPayApi.createRecurringPayment.mockResolvedValue(mockResponse)
+      govUkPayApi.createRecurringPaymentAgreement.mockResolvedValue(mockResponse)
 
       const result = await sendRecurringPayment(preparedPayment)
 
@@ -338,7 +338,7 @@ describe('The govuk-pay-service', () => {
         ok: true,
         json: jest.fn().mockResolvedValue({ success: true, paymentId: 'abc123' })
       }
-      govUkPayApi.createRecurringPayment.mockResolvedValue(mockResponse)
+      govUkPayApi.createRecurringPaymentAgreement.mockResolvedValue(mockResponse)
 
       await sendRecurringPayment(preparedPayment)
 
@@ -352,7 +352,7 @@ describe('The govuk-pay-service', () => {
         json: jest.fn().mockResolvedValue({ message: 'Server error' })
       }
       const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(() => {})
-      govUkPayApi.createRecurringPayment.mockResolvedValue(mockResponse)
+      govUkPayApi.createRecurringPaymentAgreement.mockResolvedValue(mockResponse)
 
       try {
         await sendRecurringPayment(preparedPayment)
@@ -370,7 +370,7 @@ describe('The govuk-pay-service', () => {
     it('should throw error when API call fails with network issue', async () => {
       const mockError = new Error('Network error')
       const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(jest.fn())
-      govUkPayApi.createRecurringPayment.mockRejectedValue(mockError)
+      govUkPayApi.createRecurringPaymentAgreement.mockRejectedValue(mockError)
 
       try {
         await sendRecurringPayment(preparedPayment)
@@ -389,7 +389,7 @@ describe('The govuk-pay-service', () => {
         json: jest.fn().mockResolvedValue({ message: 'Rate limit exceeded' })
       }
       const consoleErrorSpy = jest.spyOn(console, 'info').mockImplementation(jest.fn())
-      govUkPayApi.createRecurringPayment.mockResolvedValue(mockResponse)
+      govUkPayApi.createRecurringPaymentAgreement.mockResolvedValue(mockResponse)
 
       try {
         await sendRecurringPayment(preparedPayment)
@@ -404,7 +404,7 @@ describe('The govuk-pay-service', () => {
         status: 500,
         json: jest.fn().mockResolvedValue({ message: 'Server error' })
       }
-      govUkPayApi.createRecurringPayment.mockResolvedValue(mockResponse)
+      govUkPayApi.createRecurringPaymentAgreement.mockResolvedValue(mockResponse)
 
       try {
         await sendRecurringPayment(preparedPayment)

package/src/services/payment/govuk-pay-service.js

@@ -109,9 +109,9 @@ export const getPaymentStatus = async (paymentId, recurring = false) => {
   }
 }
 
-const createRecurringPayment = async preparedPayment => {
+const createRecurringPaymentAgreement = async preparedPayment => {
   try {
-    return await govUkPayApi.createRecurringPayment(preparedPayment)
+    return await govUkPayApi.createRecurringPaymentAgreement(preparedPayment)
   } catch (err) {
     /*
      * Potentially errors caught here (unreachable, timeouts) may be retried - set origin on the error to indicate
@@ -122,7 +122,7 @@ const createRecurringPayment = async preparedPayment => {
 }
 
 export const sendRecurringPayment = async preparedPayment => {
-  const response = await createRecurringPayment(preparedPayment)
+  const response = await createRecurringPaymentAgreement(preparedPayment)
 
   if (response.ok) {
     const resBody = await response.json()