@defra-fish/connectors-lib 1.77.0-rc.2 → 1.77.0-rc.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defra-fish/connectors-lib",
-  "version": "1.77.0-rc.2",
+  "version": "1.77.0-rc.3",
   "description": "Shared connectors",
   "type": "module",
   "engines": {
@@ -47,5 +47,5 @@
     "node-fetch": "2.7.0",
     "redlock": "4.2.0"
   },
-  "gitHead": "d473c2103570546d9096bffc5bf3ba13909e6a3e"
+  "gitHead": "fa97e97564ae1c2a49ffb2671f690f4328205942"
 }

package/src/__tests__/sales-api-connector.spec.js

@@ -872,8 +872,8 @@ describe('rcp authentication', () => {
 
 describe('getLicenceDetails', () => {
   it.each([
-    { firstName: 'Gandalf', lastName: 'Grey', birthDate: '2000-10-03', postcode: 'AB123CD' },
-    { firstName: 'Bilbo', lastName: 'Baggins', birthDate: '1995-04-15', postcode: 'BS9 4PT' }
+    { firstName: 'Gandalf', lastName: 'Grey', birthDate: '2000-10-03', premises: '59', postcode: 'AB123CD' },
+    { firstName: 'Bilbo', lastName: 'Baggins', birthDate: '1995-04-15', premises: 'Bag End', postcode: 'BS9 4PT' }
   ])('retrieves the licence details payload returned by the Sales API for %p', async licensee => {
     const expectedResponse = { licences: [{ some: 'data' }] }
     fetch.mockReturnValueOnce({ ok: true, status: 200, statusText: 'OK', text: async () => JSON.stringify(expectedResponse) })
@@ -882,14 +882,14 @@ describe('getLicenceDetails', () => {
 
   it.each([
     {
-      input: { firstName: 'Gandalf', lastName: 'Grey', birthDate: '2000-10-03', postcode: 'AB123CD' },
+      input: { firstName: 'Gandalf', lastName: 'Grey', birthDate: '2000-10-03', premises: '59', postcode: 'AB123CD' },
       expectedUrl:
-        'http://0.0.0.0:4000/licenceDetails?licenseeFirstName=Gandalf&licenseeLastName=Grey&licenseePostcode=AB123CD&licenseeBirthDate=2000-10-03'
+        'http://0.0.0.0:4000/licenceDetails?licenseeFirstName=Gandalf&licenseeLastName=Grey&licenseePremises=59&licenseePostcode=AB123CD&licenseeBirthDate=2000-10-03'
     },
     {
-      input: { firstName: 'Bilbo', lastName: 'Baggins', birthDate: '1995-04-15', postcode: 'BS9 4PT' },
+      input: { firstName: 'Bilbo', lastName: 'Baggins', birthDate: '1995-04-15', premises: 'Bag End', postcode: 'BS9 4PT' },
       expectedUrl:
-        'http://0.0.0.0:4000/licenceDetails?licenseeFirstName=Bilbo&licenseeLastName=Baggins&licenseePostcode=BS9%204PT&licenseeBirthDate=1995-04-15'
+        'http://0.0.0.0:4000/licenceDetails?licenseeFirstName=Bilbo&licenseeLastName=Baggins&licenseePremises=Bag%20End&licenseePostcode=BS9%204PT&licenseeBirthDate=1995-04-15'
     }
   ])('calls fetch with the name, postcode and date of birth as query parameters for %p', async ({ input, expectedUrl }) => {
     fetch.mockReturnValueOnce({
@@ -910,7 +910,7 @@ describe('getLicenceDetails', () => {
       text: async () => JSON.stringify({ error: 'Description' })
     })
     await expect(
-      salesApi.getLicenceDetails({ firstName: 'Gandalf', lastName: 'Grey', birthDate: '2000-10-03', postcode: 'AB123CD' })
+      salesApi.getLicenceDetails({ firstName: 'Gandalf', lastName: 'Grey', birthDate: '2000-10-03', premises: '59', postcode: 'AB123CD' })
     ).resolves.toBeNull()
   })
 })

package/src/sales-api-connector.js

@@ -358,16 +358,18 @@ export const retrieveStagedTransaction = async id => {
  * @param {string} firstName
  * @param {string} lastName
  * @param {string} birthDate
+ * @param {string} premises
  * @param {string} postcode
  * @returns {Promise<*>}
  */
-export const getLicenceDetails = async ({ firstName, lastName, birthDate, postcode }) =>
+export const getLicenceDetails = async ({ firstName, lastName, birthDate, premises, postcode }) =>
   exec2xxOrNull(
     call(
       new URL(
         `/licenceDetails?${querystring.stringify({
           licenseeFirstName: firstName,
           licenseeLastName: lastName,
+          licenseePremises: premises,
           licenseePostcode: postcode,
           licenseeBirthDate: birthDate
         })}`,