@defra-fish/connectors-lib 1.64.0-rc.2 → 1.64.0-rc.20

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defra-fish/connectors-lib",
-  "version": "1.64.0-rc.2",
+  "version": "1.64.0-rc.20",
   "description": "Shared connectors",
   "type": "module",
   "engines": {
@@ -34,17 +34,17 @@
     "test": "echo \"Error: run tests from root\" && exit 1"
   },
   "dependencies": {
-    "@airbrake/node": "^2.1.7",
-    "@aws-sdk/client-dynamodb": "^3.0.0",
-    "@aws-sdk/client-s3": "^3.0.0",
-    "@aws-sdk/client-secrets-manager": "^3.0.0",
-    "@aws-sdk/client-sqs": "^3.0.0",
-    "@aws-sdk/lib-dynamodb": "^3.0.0",
-    "debug": "^4.3.3",
-    "http-status-codes": "^2.3.0",
-    "ioredis": "^4.28.5",
-    "node-fetch": "^2.7.0",
-    "redlock": "^4.2.0"
+    "@airbrake/node": "2.1.7",
+    "@aws-sdk/client-dynamodb": "3.777.0",
+    "@aws-sdk/client-s3": "3.779.0",
+    "@aws-sdk/client-secrets-manager": "3.777.0",
+    "@aws-sdk/client-sqs": "3.777.0",
+    "@aws-sdk/lib-dynamodb": "3.778.0",
+    "debug": "4.3.3",
+    "http-status-codes": "2.3.0",
+    "ioredis": "4.28.5",
+    "node-fetch": "2.7.0",
+    "redlock": "4.2.0"
   },
-  "gitHead": "b901cb67affda78c747af57f88753b8039bd2172"
+  "gitHead": "853e2b2a4d2e9ce0160d941b3e108e972a108ae5"
 }

package/src/__tests__/sales-api-connector.spec.js

@@ -822,3 +822,37 @@ describe('sales-api-connector', () => {
     })
   })
 })
+
+describe('rcp authentication', () => {
+  it('returns parsed JSON with successful fetch', async () => {
+    const expectedResponse = { woo: 'hoo' }
+    fetch.mockReturnValueOnce({ ok: true, status: 200, statusText: 'OK', text: async () => JSON.stringify(expectedResponse) })
+    const response = await salesApi.authenticateRecurringPayment('AAAAAA', '1980-03-02', 'BS9 4PT')
+    expect(response).toEqual(expectedResponse)
+  })
+
+  it('calls fetch with the RCP authenticate URL and query params', async () => {
+    const expectedResponse = { woo: 'hoo' }
+    fetch.mockReturnValueOnce({ ok: true, status: 200, statusText: 'OK', text: async () => JSON.stringify(expectedResponse) })
+    await salesApi.authenticateRecurringPayment('AAAAAA', '1980-03-02', 'BS9 4PT')
+    expect(fetch).toHaveBeenCalledWith(
+      'http://0.0.0.0:4000/authenticate/rcp/AAAAAA?licenseeBirthDate=1980-03-02&licenseePostcode=BS9%204PT',
+      {
+        method: 'get',
+        headers: expect.any(Object),
+        timeout: 20000
+      }
+    )
+  })
+
+  it('returns null when the sales API responds with a non-2xx status', async () => {
+    fetch.mockReturnValueOnce({
+      ok: false,
+      status: 400,
+      statusText: 'Bad Request',
+      text: async () => 'Bad Request'
+    })
+    const response = await salesApi.authenticateRecurringPayment('AAAAAA', '1980-03-02', 'BS9 4PT')
+    expect(response).toBeNull()
+  })
+})

package/src/airbrake.js

@@ -21,7 +21,9 @@ export const initialise = () => {
       projectKey: process.env.AIRBRAKE_PROJECT_KEY,
       host: process.env.AIRBRAKE_HOST,
       environment: process.env.NODE_ENV,
-      performanceStats: false
+      performanceStats: false,
+      errorNotifications: true,
+      remoteConfig: false
     })
 
     // Proxy the console.warn and console.error methods, notifying airbrake/errbit asynchronously

package/src/aws.js

@@ -2,7 +2,7 @@ import Config from './config.js'
 import { createDocumentClient } from './documentclient-decorator.js'
 import { DynamoDB } from '@aws-sdk/client-dynamodb'
 import { SQS } from '@aws-sdk/client-sqs'
-import { S3Client, ListObjectsV2Command } from '@aws-sdk/client-s3'
+import { S3Client, ListObjectsV2Command, GetObjectCommand } from '@aws-sdk/client-s3'
 import { SecretsManager } from '@aws-sdk/client-secrets-manager'
 
 export default function () {
@@ -40,6 +40,7 @@ export default function () {
         endpoint: Config.aws.secretsManager.endpoint
       })
     }),
-    ListObjectsV2Command
+    ListObjectsV2Command,
+    GetObjectCommand
   }
 }

package/src/sales-api-connector.js

@@ -1,5 +1,5 @@
 import fetch from 'node-fetch'
-import querystring from 'querystring'
+import querystring from 'node:querystring'
 import db from 'debug'
 const SALES_API_URL_DEFAULT = 'http://0.0.0.0:4000'
 const SALES_API_TIMEOUT_MS_DEFAULT = 20000
@@ -27,7 +27,7 @@ export const call = async (url, method = 'get', payload = null) => {
     ok: response.ok,
     status: response.status,
     statusText: response.statusText,
-    body: response.status !== 204 ? await parseResponseBody(response) : undefined
+    body: response.status === 204 ? undefined : await parseResponseBody(response)
   }
   debug(
     'Request sent (%s): %s %s with payload %o.  Response received (%s): %o',
@@ -269,6 +269,27 @@ export const authenticate = async (referenceNumber, birthDate, postcode) =>
     )
   )
 
+/**
+ * Support for cancelling recurring payment authentication
+ * @param referenceNumber
+ * @param birthDate
+ * @param postcode
+ * @returns {Promise<*>}
+ */
+export const authenticateRecurringPayment = (referenceNumber, birthDate, postcode) =>
+  exec2xxOrNull(
+    call(
+      new URL(
+        `/authenticate/rcp/${referenceNumber}?${querystring.stringify({
+          licenseeBirthDate: birthDate,
+          licenseePostcode: postcode
+        })}`,
+        urlBase
+      ),
+      'get'
+    )
+  )
+
 /**
  * Helper to check if an HTTP status code is classed as a system error
  *