@defra-fish/connectors-lib 1.62.0-rst.1 → 1.63.0-rc.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defra-fish/connectors-lib",
-  "version": "1.62.0-rst.1",
+  "version": "1.63.0-rc.0",
   "description": "Shared connectors",
   "type": "module",
   "engines": {
@@ -45,5 +45,6 @@
     "ioredis": "^4.28.5",
     "node-fetch": "^2.7.0",
     "redlock": "^4.2.0"
-  }
+  },
+  "gitHead": "127bd6db86a97eb1b229f3de30e27046119ffca6"
 }

package/src/__tests__/document-client-decorator.spec.js

@@ -1,6 +1,6 @@
 import { createDocumentClient } from '../documentclient-decorator'
 import { DynamoDB } from '@aws-sdk/client-dynamodb'
-import { DynamoDBDocument, QueryCommand, ScanCommand } from '@aws-sdk/lib-dynamodb'
+import { DynamoDBDocument } from '@aws-sdk/lib-dynamodb'
 
 jest.mock('@aws-sdk/client-dynamodb')
 jest.mock('@aws-sdk/lib-dynamodb')
@@ -9,7 +9,6 @@ describe('document client decorations', () => {
   beforeAll(() => {
     jest.spyOn(global, 'setTimeout').mockImplementation(cb => cb())
     DynamoDBDocument.from.mockReturnValue({
-      send: jest.fn().mockResolvedValue({ Items: [], lastEvaluatedKey: false }),
       query: jest.fn().mockResolvedValue({ Items: [], lastEvaluatedKey: false }),
       scan: jest.fn().mockResolvedValue({ Items: [], lastEvaluatedKey: false }),
       batchWrite: jest.fn().mockResolvedValue({ UnprocessedItems: {} })
@@ -47,30 +46,23 @@ describe('document client decorations', () => {
   })
 
   describe.each`
-    aggregateMethod      | commandType
-    ${'queryAllPromise'} | ${QueryCommand}
-    ${'scanAllPromise'}  | ${ScanCommand}
-  `('$aggregateMethod', ({ aggregateMethod, commandType }) => {
+    aggregateMethod      | baseMethod
+    ${'queryAllPromise'} | ${'query'}
+    ${'scanAllPromise'}  | ${'scan'}
+  `('$aggregateMethod', ({ aggregateMethod, baseMethod }) => {
     it('is added to document client', () => {
       const docClient = createDocumentClient()
       expect(docClient[aggregateMethod]).toBeDefined()
     })
 
-    it(`passes arguments provided for ${aggregateMethod} to ${commandType.name}`, async () => {
+    it(`passes arguments provided for ${aggregateMethod} to ${baseMethod}`, async () => {
       const params = { TableName: 'TEST', KeyConditionExpression: 'id = :id', ExpressionAttributeValues: { ':id': 1 } }
       const docClient = createDocumentClient()
       await docClient[aggregateMethod](params)
-      expect(commandType).toHaveBeenCalledWith(params)
+      expect(docClient[baseMethod]).toHaveBeenCalledWith(params)
     })
 
-    it(`passes created command ${commandType.name} to docClient.send`, async () => {
-      const docClient = createDocumentClient()
-      await docClient[aggregateMethod]()
-      const [command] = commandType.mock.instances
-      expect(docClient.send).toHaveBeenCalledWith(command)
-    })
-
-    it('calls send repeatedly until LastEvaluatedKey evaluates to false, concatenating all returned items', async () => {
+    it(`calls ${baseMethod} repeatedly until LastEvaluatedKey evaluates to false, concatenating all returned items`, async () => {
       const expectedItems = [
         { id: 1, data: Symbol('data1') },
         { id: 2, data: Symbol('data2') },
@@ -79,7 +71,7 @@ describe('document client decorations', () => {
         { id: 5, data: Symbol('data5') }
       ]
       const docClient = createDocumentClient()
-      docClient.send
+      docClient[baseMethod]
         .mockResolvedValueOnce({ Items: expectedItems.slice(0, 2), LastEvaluatedKey: true })
         .mockResolvedValueOnce({ Items: expectedItems.slice(2, 4), LastEvaluatedKey: true })
         .mockResolvedValueOnce({ Items: expectedItems.slice(4), LastEvaluatedKey: false })
@@ -87,12 +79,13 @@ describe('document client decorations', () => {
       expect(actualItems).toEqual(expectedItems)
     })
 
-    it(`whilst concatenating ${commandType.name} results, passes ExclusiveStartKey param`, async () => {
+    it(`whilst concatenating ${baseMethod} results, passes ExclusiveStartKey param`, async () => {
       const expectedKey = Symbol('🔑')
       const docClient = createDocumentClient()
-      docClient.send.mockResolvedValueOnce({ Items: [], LastEvaluatedKey: expectedKey }).mockResolvedValueOnce({ Items: [] })
+      docClient[baseMethod].mockResolvedValueOnce({ Items: [], LastEvaluatedKey: expectedKey }).mockResolvedValueOnce({ Items: [] })
       await docClient[aggregateMethod]()
-      expect(commandType).toHaveBeenLastCalledWith(
+      expect(docClient[baseMethod]).toHaveBeenNthCalledWith(
+        2,
         expect.objectContaining({
           ExclusiveStartKey: expectedKey
         })
@@ -102,7 +95,7 @@ describe('document client decorations', () => {
     it("omits ExclusiveStartKey if previous LastEvaluatedKey isn't available", async () => {
       const docClient = createDocumentClient()
       await docClient[aggregateMethod]()
-      expect(docClient.send).toHaveBeenNthCalledWith(
+      expect(docClient[baseMethod]).toHaveBeenNthCalledWith(
         1,
         expect.not.objectContaining({
           ExclusiveStartKey: expect.anything()

package/src/__tests__/sales-api-connector.spec.js

@@ -746,44 +746,4 @@ describe('sales-api-connector', () => {
       await expect(salesApi.cancelRecurringPayment('id')).rejects.toThrow('Internal Server Error')
     })
   })
-
-  describe('retrieveStagedTransaction', () => {
-    describe.each([['id'], ['abc-123']])("Retrieving staged transaction id '%s'", id => {
-      beforeEach(() => {
-        fetch.mockReturnValue({
-          ok: true,
-          status: 200,
-          statusText: 'OK',
-          text: async () => JSON.stringify({ id })
-        })
-      })
-
-      it('calls the endpoint with the correct parameters', async () => {
-        await salesApi.retrieveStagedTransaction(id)
-
-        expect(fetch).toHaveBeenCalledWith(`http://0.0.0.0:4000/retrieveStagedTransaction/${id}`, {
-          method: 'get',
-          headers: expect.any(Object),
-          timeout: 20000
-        })
-      })
-
-      it('returns the expected response data', async () => {
-        const processedResult = await salesApi.retrieveStagedTransaction(id)
-
-        expect(processedResult).toEqual({ id })
-      })
-    })
-
-    it('throws an error on non-2xx response', async () => {
-      fetch.mockReturnValue({
-        ok: false,
-        status: 500,
-        statusText: 'Internal Server Error',
-        text: async () => 'Server Error'
-      })
-
-      await expect(salesApi.retrieveStagedTransaction('id')).rejects.toThrow('Internal Server Error')
-    })
-  })
 })

package/src/documentclient-decorator.js

@@ -1,6 +1,6 @@
 import db from 'debug'
 import { DynamoDB } from '@aws-sdk/client-dynamodb'
-import { DynamoDBDocument, QueryCommand, ScanCommand } from '@aws-sdk/lib-dynamodb'
+import { DynamoDBDocument } from '@aws-sdk/lib-dynamodb'
 const debug = db('connectors:aws')
 
 export const createDocumentClient = options => {
@@ -13,24 +13,23 @@ export const createDocumentClient = options => {
   })
 
   // Support for large query/scan operations which return results in pages
-  const wrapPagedDocumentClientOperation = CommandType => {
+  const wrapPagedDocumentClientOperation = operationName => {
     return async params => {
       const items = []
       let lastEvaluatedKey = null
       do {
-        const command = new CommandType({
+        const response = await docClient[operationName]({
           ...params,
           ...(lastEvaluatedKey && { ExclusiveStartKey: lastEvaluatedKey })
         })
-        const response = await docClient.send(command)
         lastEvaluatedKey = response.LastEvaluatedKey
         response.Items && items.push(...response.Items)
       } while (lastEvaluatedKey)
       return items
     }
   }
-  docClient.queryAllPromise = wrapPagedDocumentClientOperation(QueryCommand)
-  docClient.scanAllPromise = wrapPagedDocumentClientOperation(ScanCommand)
+  docClient.queryAllPromise = wrapPagedDocumentClientOperation('query')
+  docClient.scanAllPromise = wrapPagedDocumentClientOperation('scan')
 
   /**
    * Handles batch writes which may return UnprocessedItems. If UnprocessedItems are returned then they will be retried with exponential backoff

package/src/sales-api-connector.js

@@ -319,14 +319,3 @@ export const processRPResult = async (transactionId, paymentId, createdDate) =>
 export const cancelRecurringPayment = async id => {
   return exec2xxOrThrow(call(new URL(`/cancelRecurringPayment/${id}`, urlBase), 'get'))
 }
-
-/**
- * Retrieve a staged transaction
- *
- * @param id
- * @returns {Promise<*>}
- * @throws on a non-2xx response
- */
-export const retrieveStagedTransaction = async id => {
-  return exec2xxOrThrow(call(new URL(`/retrieveStagedTransaction/${id}`, urlBase), 'get'))
-}