@defold-typescript/transpiler 0.40.0 → 0.41.0

package/dist/index.d.ts

@@ -32,6 +32,8 @@ export type { SceneMessage } from "./scene-text-format";
 export { parseSceneTextFormat, SceneTextFormatError } from "./scene-text-format";
 export type { TranspileSession } from "./session";
 export { createTranspileSession } from "./session";
+export type { TextScriptPropertyFinding } from "./text-script-property";
+export { findTextScriptProperties } from "./text-script-property";
 export { TIMERS_REQUIRE_NAME } from "./timers-runtime";
 export type { TranspileDiagnostic, TranspileProjectInput, TranspileProjectResult, TranspileResult, } from "./transpile";
 export { transpile, transpileProject } from "./transpile";

package/dist/index.js

@@ -270,11 +270,11 @@ function emitInitMerge(fn, context, property) {
   const initFn = createFunctionExpression2(createBlock2([stateDecl, guard]), [createIdentifier2("self")], undefined, NodeFlags2.Declaration, fn);
   return [builderDecl, createAssignmentStatement(createIdentifier2("init"), initFn, property)];
 }
-function emitPropertyRegistrations(property, context) {
+function propertyMembers(property) {
   if (!ts2.isPropertyAssignment(property) || !ts2.isObjectLiteralExpression(property.initializer)) {
     return [];
   }
-  const registrations = [];
+  const members = [];
   for (const member of property.initializer.properties) {
     if (!ts2.isPropertyAssignment(member)) {
       continue;
@@ -283,21 +283,34 @@ function emitPropertyRegistrations(property, context) {
     if (!ts2.isIdentifier(key) && !ts2.isStringLiteral(key)) {
       continue;
     }
-    registrations.push(createExpressionStatement(createCallExpression2(createTableIndexExpression(createIdentifier2("go"), createStringLiteral2("property")), [createStringLiteral2(key.text), context.transformExpression(member.initializer)])));
+    members.push({ name: key.text, initializer: member.initializer });
   }
-  return registrations;
+  return members;
 }
-function eraseFactoryCall(expression, context) {
+function factoryHooks(expression, checker) {
   if (!ts2.isCallExpression(expression)) {
     return;
   }
-  if (!resolvesToFactoryExport(expression.expression, context.checker)) {
+  if (!resolvesToFactoryExport(expression.expression, checker)) {
     return;
   }
   const hooks = expression.arguments[0];
   if (hooks === undefined || !ts2.isObjectLiteralExpression(hooks)) {
     return;
   }
+  return hooks;
+}
+function isPropertiesHook(property) {
+  return hookName(property) === "properties";
+}
+function emitPropertyRegistrations(property, context) {
+  return propertyMembers(property).map(({ name, initializer }) => createExpressionStatement(createCallExpression2(createTableIndexExpression(createIdentifier2("go"), createStringLiteral2("property")), [createStringLiteral2(name), context.transformExpression(initializer)])));
+}
+function eraseFactoryCall(expression, context) {
+  const hooks = factoryHooks(expression, context.checker);
+  if (hooks === undefined) {
+    return;
+  }
   const registrations = [];
   const statements = [];
   for (const property of hooks.properties) {
@@ -2061,176 +2074,13 @@ function computeOutputRel(rel, config, kind) {
 import * as ts9 from "typescript";
 import * as tstl from "typescript-to-lua";
 
-// src/array-index-option-lowering.ts
+// src/message-guard-lowering.ts
 import * as ts5 from "typescript";
 import {
   createBinaryExpression as createBinaryExpression3,
-  createNumericLiteral,
-  getOriginalPos,
-  isCallExpression as isCallExpression3,
-  isNumericLiteral as isNumericLiteral3,
-  isStringLiteral as isStringLiteral5,
-  isTableExpression,
-  SyntaxKind as SyntaxKind7,
-  setNodePosition
-} from "typescript-to-lua";
-var ONE_BASED_INDEX_OPTION_APIS = new Set([
-  "go.get",
-  "go.set",
-  "gui.get",
-  "gui.set"
-]);
-var INDEX_OPTION_VARIABLE_MESSAGE = "`options.index` is zero-based and is converted to Defold's 1-based index only in an object literal written at the call; pass the options inline.";
-var INDEX_OPTION_SPREAD_MESSAGE = "A spread carrying `index` cannot be converted to Defold's 1-based index; write `index` explicitly after the spread.";
-var INDEX_OPTION_UNDEFINED_MESSAGE = "`options.index` may be undefined here, so it cannot be converted to Defold's 1-based index; pass a number, or leave `index` out.";
-var OPTIONS_PARAMETER = "options";
-var INDEX_KEY = "index";
-var loweredLiterals = new WeakSet;
-function oneBasedApi(declaration, checker) {
-  let node = declaration;
-  while (node !== undefined && !ts5.isFunctionDeclaration(node))
-    node = node.parent;
-  if (node?.name === undefined)
-    return false;
-  const symbol = checker.getSymbolAtLocation(node.name);
-  if (symbol === undefined)
-    return false;
-  const fqn = checker.getFullyQualifiedName(symbol);
-  return fqn.startsWith("global.") && ONE_BASED_INDEX_OPTION_APIS.has(fqn.slice("global.".length));
-}
-function optionsArgument(call, checker) {
-  const declaration = checker.getResolvedSignature(call)?.declaration;
-  if (declaration === undefined || !ts5.isFunctionLike(declaration))
-    return;
-  if (!oneBasedApi(declaration, checker))
-    return;
-  const index = declaration.parameters.findIndex((parameter) => parameter.dotDotDotToken === undefined && ts5.isIdentifier(parameter.name) && parameter.name.text === OPTIONS_PARAMETER);
-  return index === -1 ? undefined : call.arguments[index];
-}
-function unwrap(expression) {
-  let current = expression;
-  while (ts5.isParenthesizedExpression(current) || ts5.isAsExpression(current) || ts5.isSatisfiesExpression(current) || ts5.isNonNullExpression(current) || ts5.isTypeAssertionExpression(current)) {
-    current = current.expression;
-  }
-  return current;
-}
-function someConstituent(type, predicate) {
-  return type.isUnion() ? type.types.some(predicate) : predicate(type);
-}
-function carriesIndex(type) {
-  return someConstituent(type, (t) => t.getProperty(INDEX_KEY) !== undefined);
-}
-function admitsUndefined(type) {
-  return someConstituent(type, (t) => (t.flags & (ts5.TypeFlags.Undefined | ts5.TypeFlags.Void)) !== 0);
-}
-function propertyName(property, checker) {
-  const name = property.name;
-  if (name === undefined)
-    return;
-  if (ts5.isIdentifier(name) || ts5.isStringLiteral(name) || ts5.isNumericLiteral(name)) {
-    return name.text;
-  }
-  if (ts5.isComputedPropertyName(name)) {
-    const type = checker.getTypeAtLocation(name.expression);
-    if (type.isStringLiteral())
-      return type.value;
-  }
-  return;
-}
-function indexValueType(property, checker) {
-  if (ts5.isPropertyAssignment(property))
-    return checker.getTypeAtLocation(property.initializer);
-  if (ts5.isShorthandPropertyAssignment(property))
-    return checker.getTypeAtLocation(property.name);
-  return;
-}
-function rejection(node, messageText) {
-  const file = node.getSourceFile();
-  const start = node.getStart(file);
-  return {
-    file,
-    start,
-    length: node.getEnd() - start,
-    category: ts5.DiagnosticCategory.Error,
-    code: 0,
-    messageText
-  };
-}
-function rejectOptions(options, checker) {
-  const literal = unwrap(options);
-  if (!ts5.isObjectLiteralExpression(literal)) {
-    return carriesIndex(checker.getTypeAtLocation(literal)) ? rejection(options, INDEX_OPTION_VARIABLE_MESSAGE) : undefined;
-  }
-  let uncoveredSpread;
-  let explicitIndex;
-  for (const property of literal.properties) {
-    if (ts5.isSpreadAssignment(property)) {
-      if (carriesIndex(checker.getTypeAtLocation(property.expression)))
-        uncoveredSpread = property;
-    } else if (propertyName(property, checker) === INDEX_KEY) {
-      uncoveredSpread = undefined;
-      explicitIndex = property;
-    }
-  }
-  if (uncoveredSpread !== undefined)
-    return rejection(uncoveredSpread, INDEX_OPTION_SPREAD_MESSAGE);
-  const valueType = explicitIndex && indexValueType(explicitIndex, checker);
-  if (explicitIndex !== undefined && valueType !== undefined && admitsUndefined(valueType)) {
-    return rejection(explicitIndex, INDEX_OPTION_UNDEFINED_MESSAGE);
-  }
-  return;
-}
-function plusOne(value) {
-  if (isNumericLiteral3(value)) {
-    return setNodePosition(createNumericLiteral(value.value + 1), getOriginalPos(value));
-  }
-  return setNodePosition(createBinaryExpression3(value, createNumericLiteral(1), SyntaxKind7.AdditionOperator), getOriginalPos(value));
-}
-function offsetEffectiveIndexField(tables) {
-  for (const field of tables.flatMap((table) => table.fields).reverse()) {
-    if (field.key !== undefined && isStringLiteral5(field.key) && field.key.value === INDEX_KEY) {
-      field.value = plusOne(field.value);
-      return;
-    }
-  }
-}
-var arrayIndexOptionLoweringPlugin = {
-  visitors: {
-    [ts5.SyntaxKind.CallExpression]: (node, context) => {
-      const options = optionsArgument(node, context.checker);
-      if (options !== undefined) {
-        const diagnostic = rejectOptions(options, context.checker);
-        if (diagnostic !== undefined) {
-          context.diagnostics.push(diagnostic);
-        } else {
-          const literal = unwrap(options);
-          if (ts5.isObjectLiteralExpression(literal))
-            loweredLiterals.add(literal);
-        }
-      }
-      return context.superTransformExpression(node);
-    },
-    [ts5.SyntaxKind.ObjectLiteralExpression]: (node, context) => {
-      const result = context.superTransformExpression(node);
-      if (!loweredLiterals.has(node))
-        return result;
-      if (isTableExpression(result)) {
-        offsetEffectiveIndexField([result]);
-      } else if (isCallExpression3(result)) {
-        offsetEffectiveIndexField(result.params.filter(isTableExpression));
-      }
-      return result;
-    }
-  }
-};
-
-// src/message-guard-lowering.ts
-import * as ts6 from "typescript";
-import {
-  createBinaryExpression as createBinaryExpression4,
   createCallExpression as createCallExpression3,
   createIdentifier as createIdentifier3,
-  SyntaxKind as SyntaxKind9
+  SyntaxKind as SyntaxKind7
 } from "typescript-to-lua";
 var GUARD_MODULE = "@defold-typescript/types";
 var GUARD_NAME = "isMessage";
@@ -2239,7 +2089,7 @@ function resolvesToGuardExport(callee, checker) {
   if (symbol === undefined) {
     return false;
   }
-  if (symbol.flags & ts6.SymbolFlags.Alias) {
+  if (symbol.flags & ts5.SymbolFlags.Alias) {
     symbol = checker.getAliasedSymbol(symbol);
   }
   if (symbol.getName() !== GUARD_NAME) {
@@ -2253,12 +2103,12 @@ function resolvesToGuardExport(callee, checker) {
 }
 var messageGuardLoweringPlugin = {
   visitors: {
-    [ts6.SyntaxKind.CallExpression]: (node, context) => {
+    [ts5.SyntaxKind.CallExpression]: (node, context) => {
       const [messageIdArg, , expectedArg] = node.arguments;
       if (node.arguments.length === 3 && messageIdArg !== undefined && expectedArg !== undefined && resolvesToGuardExport(node.expression, context.checker)) {
         const messageId = context.transformExpression(messageIdArg);
         const expected = context.transformExpression(expectedArg);
-        return createBinaryExpression4(messageId, createCallExpression3(createIdentifier3("hash"), [expected]), SyntaxKind9.EqualityOperator, node);
+        return createBinaryExpression3(messageId, createCallExpression3(createIdentifier3("hash"), [expected]), SyntaxKind7.EqualityOperator, node);
       }
       return context.superTransformExpression(node);
     }
@@ -2266,34 +2116,64 @@ var messageGuardLoweringPlugin = {
 };
 
 // src/timers-lowering.ts
-import * as ts7 from "typescript";
+import * as ts6 from "typescript";
 import { LuaLibFeature } from "typescript-to-lua";
 function isTimersSpecifier(node) {
-  return ts7.isStringLiteral(node) && node.text === TIMERS_MODULE_SPECIFIER;
+  return ts6.isStringLiteral(node) && node.text === TIMERS_MODULE_SPECIFIER;
 }
 function importsTimersModule(sourceFile) {
-  return sourceFile.statements.some((statement) => ts7.isImportDeclaration(statement) && isTimersSpecifier(statement.moduleSpecifier));
+  return sourceFile.statements.some((statement) => ts6.isImportDeclaration(statement) && isTimersSpecifier(statement.moduleSpecifier));
 }
 var TIMERS_REQUIRE_PATH = `@NoResolution:${TIMERS_REQUIRE_NAME}`;
 var timersLoweringPlugin = {
   visitors: {
-    [ts7.SyntaxKind.ImportDeclaration]: (node, context) => {
+    [ts6.SyntaxKind.ImportDeclaration]: (node, context) => {
       if (!isTimersSpecifier(node.moduleSpecifier)) {
         return context.superTransformStatements(node);
       }
       context.usedLuaLibFeatures.add(LuaLibFeature.Promise);
       context.usedLuaLibFeatures.add(LuaLibFeature.New);
-      const rewritten = ts7.factory.updateImportDeclaration(node, node.modifiers, node.importClause, ts7.factory.createStringLiteral(TIMERS_REQUIRE_PATH), node.attributes);
+      const rewritten = ts6.factory.updateImportDeclaration(node, node.modifiers, node.importClause, ts6.factory.createStringLiteral(TIMERS_REQUIRE_PATH), node.attributes);
       return context.superTransformStatements(rewritten);
     }
   }
 };
 
+// src/type-application-erasure.ts
+import * as ts7 from "typescript";
+var TYPE_APPLICATION_APIS = new Set(["go.get", "go.set"]);
+function isTypeApplication(call, checker) {
+  if (call.arguments.length !== 0)
+    return false;
+  const declaration = checker.getResolvedSignature(call)?.declaration;
+  if (declaration === undefined || !ts7.isFunctionDeclaration(declaration))
+    return false;
+  if (declaration.parameters.length !== 0 || declaration.typeParameters === undefined)
+    return false;
+  if (declaration.name === undefined)
+    return false;
+  const symbol = checker.getSymbolAtLocation(declaration.name);
+  if (symbol === undefined)
+    return false;
+  const fqn = checker.getFullyQualifiedName(symbol);
+  return fqn.startsWith("global.") && TYPE_APPLICATION_APIS.has(fqn.slice("global.".length));
+}
+var typeApplicationErasurePlugin = {
+  visitors: {
+    [ts7.SyntaxKind.CallExpression]: (node, context) => {
+      if (isTypeApplication(node, context.checker)) {
+        return context.transformExpression(node.expression);
+      }
+      return context.superTransformExpression(node);
+    }
+  }
+};
+
 // src/window-event-guard-lowering.ts
 import * as ts8 from "typescript";
 import {
-  createBinaryExpression as createBinaryExpression5,
-  SyntaxKind as SyntaxKind12
+  createBinaryExpression as createBinaryExpression4,
+  SyntaxKind as SyntaxKind11
 } from "typescript-to-lua";
 var GUARD_MODULE2 = "@defold-typescript/types";
 var GUARD_NAME2 = "isWindowEvent";
@@ -2321,7 +2201,7 @@ var windowEventGuardLoweringPlugin = {
       if (node.arguments.length === 3 && eventArg !== undefined && expectedArg !== undefined && resolvesToGuardExport2(node.expression, context.checker)) {
         const event = context.transformExpression(eventArg);
         const expected = context.transformExpression(expectedArg);
-        return createBinaryExpression5(event, expected, SyntaxKind12.EqualityOperator, node);
+        return createBinaryExpression4(event, expected, SyntaxKind11.EqualityOperator, node);
       }
       return context.superTransformExpression(node);
     }
@@ -2335,7 +2215,7 @@ var LUA_PLUGINS = [
   windowEventGuardLoweringPlugin,
   messageDispatchLoweringPlugin,
   timersLoweringPlugin,
-  arrayIndexOptionLoweringPlugin
+  typeApplicationErasurePlugin
 ];
 var noopWriteFile = () => {};
 function isAmbient(fileName) {
@@ -2930,18 +2810,18 @@ import {
   createTableIndexExpression as createTableIndexExpression2,
   createVariableDeclarationStatement as createVariableDeclarationStatement3,
   isBlock as isBlock3,
-  isCallExpression as isCallExpression5,
+  isCallExpression as isCallExpression4,
   isDoStatement,
   isForInStatement as isForInStatement2,
   isForStatement,
   isFunctionDefinition,
   isFunctionExpression as isFunctionExpression4,
-  isIdentifier as isIdentifier5,
+  isIdentifier as isIdentifier4,
   isMethodCallExpression,
   isRepeatStatement,
   isReturnStatement as isReturnStatement2,
-  isStringLiteral as isStringLiteral8,
-  isTableExpression as isTableExpression2,
+  isStringLiteral as isStringLiteral6,
+  isTableExpression,
   isVariableDeclarationStatement,
   LuaPrinter
 } from "typescript-to-lua";
@@ -3013,7 +2893,7 @@ function freeNames(statements) {
     if (node === undefined) {
       return;
     }
-    if (isIdentifier5(node)) {
+    if (isIdentifier4(node)) {
       if (!isBound(node.text)) {
         free.add(node.text);
       }
@@ -3119,14 +2999,14 @@ function resolvedRequirePaths(sourceFile, checker) {
 function resolveMovedRequires(statements, paths) {
   for (const statement of statements) {
     forEachLuaNode(statement, (node) => {
-      if (!isCallExpression5(node) || !isIdentifier5(node.expression)) {
+      if (!isCallExpression4(node) || !isIdentifier4(node.expression)) {
         return;
       }
       if (node.expression.text !== "require" || node.params.length !== 1) {
         return;
       }
       const [argument] = node.params;
-      if (argument === undefined || !isStringLiteral8(argument)) {
+      if (argument === undefined || !isStringLiteral6(argument)) {
         return;
       }
       const resolved = paths.get(argument.value);
@@ -3142,14 +3022,14 @@ function withResolvedRequire(statement, paths) {
   }
   const name = statement.left[0];
   const [value] = statement.right ?? [];
-  if (name === undefined || value === undefined || !isCallExpression5(value)) {
+  if (name === undefined || value === undefined || !isCallExpression4(value)) {
     return statement;
   }
-  if (!isIdentifier5(value.expression) || value.expression.text !== "require") {
+  if (!isIdentifier4(value.expression) || value.expression.text !== "require") {
     return statement;
   }
   const [argument] = value.params;
-  if (argument === undefined || !isStringLiteral8(argument)) {
+  if (argument === undefined || !isStringLiteral6(argument)) {
     return statement;
   }
   const resolved = paths.get(argument.value);
@@ -3185,7 +3065,7 @@ function copiedPrelude(halves, importBindings) {
 function namesIdentifier(statement, names) {
   let found = false;
   forEachLuaNode(statement, (node) => {
-    if (isIdentifier5(node) && names.has(node.text)) {
+    if (isIdentifier4(node) && names.has(node.text)) {
       found = true;
     }
   });
@@ -3196,14 +3076,14 @@ function isExportsTableInit(statement) {
     return false;
   }
   const [single] = statement.right ?? [];
-  return statement.left[0]?.text === EXPORTS_NAME && single !== undefined && isTableExpression2(single);
+  return statement.left[0]?.text === EXPORTS_NAME && single !== undefined && isTableExpression(single);
 }
 function isExportsReturn(statement) {
   if (!isReturnStatement2(statement) || statement.expressions.length !== 1) {
     return false;
   }
   const [single] = statement.expressions;
-  return single !== undefined && isIdentifier5(single) && single.text === EXPORTS_NAME;
+  return single !== undefined && isIdentifier4(single) && single.text === EXPORTS_NAME;
 }
 function isHoistedNameDeclaration(statement) {
   return isVariableDeclarationStatement(statement) && statement.right === undefined;
@@ -3631,7 +3511,7 @@ function transpileProject(input) {
       { plugin: windowEventGuardLoweringPlugin },
       { plugin: messageDispatchLoweringPlugin },
       { plugin: timersLoweringPlugin },
-      { plugin: arrayIndexOptionLoweringPlugin },
+      { plugin: typeApplicationErasurePlugin },
       { plugin: companionEmit.plugin }
     ]
   });
@@ -3662,7 +3542,7 @@ function compilerOptions(companionEmit) {
       { plugin: windowEventGuardLoweringPlugin },
       { plugin: messageDispatchLoweringPlugin },
       { plugin: timersLoweringPlugin },
-      { plugin: arrayIndexOptionLoweringPlugin },
+      { plugin: typeApplicationErasurePlugin },
       { plugin: companionEmit.plugin }
     ]
   };
@@ -3779,8 +3659,71 @@ function createTranspileSession() {
     getProgram: () => program
   };
 }
-// src/url-address-slots.ts
+// src/text-script-property.ts
 import * as ts14 from "typescript";
+function findTextScriptProperties(program, fileNames) {
+  const checker = program.getTypeChecker();
+  const findings = [];
+  for (const file of fileNames) {
+    const sourceFile = program.getSourceFile(file);
+    if (sourceFile === undefined) {
+      continue;
+    }
+    const located = [];
+    const visit = (node) => {
+      if (ts14.isCallExpression(node)) {
+        const hooks = factoryHooks(node, checker);
+        for (const property of hooks?.properties ?? []) {
+          if (!isPropertiesHook(property)) {
+            continue;
+          }
+          for (const { name, initializer } of propertyMembers(property)) {
+            if (mayHoldString(checker.getTypeAtLocation(initializer), checker)) {
+              located.push({ name, value: initializer });
+            }
+          }
+        }
+      }
+      ts14.forEachChild(node, visit);
+    };
+    visit(sourceFile);
+    for (const call of findDirectGoPropertyCalls(sourceFile)) {
+      const [nameArgument, value] = call.arguments;
+      if (nameArgument === undefined || value === undefined) {
+        continue;
+      }
+      if (mayHoldString(checker.getTypeAtLocation(value), checker)) {
+        const name = ts14.isStringLiteralLike(nameArgument) ? nameArgument.text : nameArgument.getText(sourceFile);
+        located.push({ name, value });
+      }
+    }
+    located.sort((left, right) => left.value.getStart(sourceFile) - right.value.getStart(sourceFile));
+    for (const { name, value } of located) {
+      const position = sourceFile.getLineAndCharacterOfPosition(value.getStart(sourceFile));
+      findings.push({ name, file, line: position.line + 1, column: position.character + 1 });
+    }
+  }
+  return findings;
+}
+function mayHoldString(type, checker, visited = new Set) {
+  if (visited.has(type)) {
+    return false;
+  }
+  visited.add(type);
+  if (type.flags & ts14.TypeFlags.StringLike) {
+    return true;
+  }
+  if (type.isUnionOrIntersection()) {
+    return type.types.some((member) => mayHoldString(member, checker, visited));
+  }
+  if (type.flags & ts14.TypeFlags.Instantiable) {
+    const constraint = checker.getBaseConstraintOfType(type);
+    return constraint !== undefined && constraint !== type ? mayHoldString(constraint, checker, visited) : false;
+  }
+  return false;
+}
+// src/url-address-slots.ts
+import * as ts15 from "typescript";
 var ADDRESS_CLASSES = {
   "game-object": true,
   component: true,
@@ -3799,7 +3742,7 @@ function isFragmentCaret(slot, position) {
   return slot.fragmentStart !== -1 && position >= slot.fragmentStart;
 }
 function tableKey(checker, callee) {
-  const symbol = checker.getSymbolAtLocation(ts14.isIdentifier(callee) ? callee : callee.name);
+  const symbol = checker.getSymbolAtLocation(ts15.isIdentifier(callee) ? callee : callee.name);
   if (!symbol)
     return;
   const fqn = checker.getFullyQualifiedName(symbol);
@@ -3807,43 +3750,43 @@ function tableKey(checker, callee) {
 }
 function parameterName(checker, call, index) {
   const declaration = checker.getResolvedSignature(call)?.declaration;
-  if (!declaration || !ts14.isFunctionLike(declaration))
+  if (!declaration || !ts15.isFunctionLike(declaration))
     return;
   const parameter = declaration.parameters[index];
-  if (!parameter || parameter.dotDotDotToken || !ts14.isIdentifier(parameter.name))
+  if (!parameter || parameter.dotDotDotToken || !ts15.isIdentifier(parameter.name))
     return;
   return parameter.name.text;
 }
 var EQUALITY_OPERATORS = new Set([
-  ts14.SyntaxKind.EqualsEqualsEqualsToken,
-  ts14.SyntaxKind.ExclamationEqualsEqualsToken,
-  ts14.SyntaxKind.EqualsEqualsToken,
-  ts14.SyntaxKind.ExclamationEqualsToken
+  ts15.SyntaxKind.EqualsEqualsEqualsToken,
+  ts15.SyntaxKind.ExclamationEqualsEqualsToken,
+  ts15.SyntaxKind.EqualsEqualsToken,
+  ts15.SyntaxKind.ExclamationEqualsToken
 ]);
 function comparisonSatisfied(checker, entry, call) {
   if (entry.comparedParameter === undefined)
     return true;
   let node = call;
-  while (ts14.isParenthesizedExpression(node.parent))
+  while (ts15.isParenthesizedExpression(node.parent))
     node = node.parent;
   const comparison = node.parent;
-  if (!ts14.isBinaryExpression(comparison))
+  if (!ts15.isBinaryExpression(comparison))
     return false;
   if (!EQUALITY_OPERATORS.has(comparison.operatorToken.kind))
     return false;
   const other = comparison.left === node ? comparison.right : comparison.left;
   const symbol = checker.getSymbolAtLocation(other);
-  return (symbol?.declarations ?? []).some((declaration) => ts14.isParameter(declaration) && ts14.isIdentifier(declaration.name) && declaration.name.text === entry.comparedParameter);
+  return (symbol?.declarations ?? []).some((declaration) => ts15.isParameter(declaration) && ts15.isIdentifier(declaration.name) && declaration.name.text === entry.comparedParameter);
 }
 function classifiedEntryOfArgument(checker, table, argument) {
   const call = argument.parent;
-  if (!ts14.isCallExpression(call))
+  if (!ts15.isCallExpression(call))
     return;
   const argumentIndex = call.arguments.indexOf(argument);
   if (argumentIndex === -1)
     return;
   const callee = call.expression;
-  if (!ts14.isPropertyAccessExpression(callee) && !ts14.isIdentifier(callee))
+  if (!ts15.isPropertyAccessExpression(callee) && !ts15.isIdentifier(callee))
     return;
   const fqn = tableKey(checker, callee);
   if (fqn === undefined)
@@ -3860,10 +3803,10 @@ function classifiedEntryOfArgument(checker, table, argument) {
 }
 function slotThroughHashedCall(checker, table, literal) {
   const call = literal.parent;
-  if (!ts14.isCallExpression(call))
+  if (!ts15.isCallExpression(call))
     return;
   const callee = call.expression;
-  if (!ts14.isPropertyAccessExpression(callee) && !ts14.isIdentifier(callee))
+  if (!ts15.isPropertyAccessExpression(callee) && !ts15.isIdentifier(callee))
     return;
   if (tableKey(checker, callee) !== "hash")
     return;
@@ -3881,24 +3824,24 @@ function addressTextOf(checker, entry, call) {
   if (entry.addressParameter === undefined)
     return;
   const declaration = checker.getResolvedSignature(call)?.declaration;
-  if (!declaration || !ts14.isFunctionLike(declaration))
+  if (!declaration || !ts15.isFunctionLike(declaration))
     return;
-  const index = declaration.parameters.findIndex((parameter) => !parameter.dotDotDotToken && ts14.isIdentifier(parameter.name) && parameter.name.text === entry.addressParameter);
+  const index = declaration.parameters.findIndex((parameter) => !parameter.dotDotDotToken && ts15.isIdentifier(parameter.name) && parameter.name.text === entry.addressParameter);
   if (index === -1)
     return;
   const argument = call.arguments[index];
-  return argument && ts14.isStringLiteralLike(argument) ? argument.text : undefined;
+  return argument && ts15.isStringLiteralLike(argument) ? argument.text : undefined;
 }
 function innermostLiteralAt(sourceFile, position) {
   let found;
   const visit = (node) => {
     if (position < node.getStart(sourceFile) || position > node.getEnd())
       return;
-    if (ts14.isStringLiteralLike(node))
+    if (ts15.isStringLiteralLike(node))
       found = node;
-    ts14.forEachChild(node, visit);
+    ts15.forEachChild(node, visit);
   };
-  ts14.forEachChild(sourceFile, visit);
+  ts15.forEachChild(sourceFile, visit);
   return found;
 }
 function resolveClassifiedSlotAtPosition(input) {
@@ -3932,23 +3875,23 @@ function resolveClassifiedSlotAtPosition(input) {
   };
 }
 // src/url-cross-world-address.ts
-import * as ts16 from "typescript";
+import * as ts17 from "typescript";
 
 // src/url-address-literals.ts
-import * as ts15 from "typescript";
+import * as ts16 from "typescript";
 function isAmbient2(fileName) {
   return /[\\/]node_modules[\\/]/.test(fileName) || /(^|[\\/])lib\.[^\\/]*\.d\.ts$/.test(fileName);
 }
 function referenceTargetSymbol(type) {
-  if ((type.flags & ts15.TypeFlags.Object) === 0)
+  if ((type.flags & ts16.TypeFlags.Object) === 0)
     return;
-  if ((type.objectFlags & ts15.ObjectFlags.Reference) === 0)
+  if ((type.objectFlags & ts16.ObjectFlags.Reference) === 0)
     return;
   return type.target.symbol;
 }
 function ambientHashAliasTargets(checker, anchor) {
   const targets = new Set;
-  for (const symbol of checker.getSymbolsInScope(anchor, ts15.SymbolFlags.Type)) {
+  for (const symbol of checker.getSymbolsInScope(anchor, ts16.SymbolFlags.Type)) {
     if (symbol.name !== "Hash")
       continue;
     const target = referenceTargetSymbol(checker.getDeclaredTypeOfSymbol(symbol));
@@ -3964,7 +3907,7 @@ function canonicalHashSymbols(checker, program) {
   if (!anchor)
     return canonical;
   const aliased = ambientHashAliasTargets(checker, anchor);
-  for (const symbol of checker.getSymbolsInScope(anchor, ts15.SymbolFlags.Function)) {
+  for (const symbol of checker.getSymbolsInScope(anchor, ts16.SymbolFlags.Function)) {
     if (symbol.name !== "hash")
       continue;
     const declaration = symbol.declarations?.[0];
@@ -3986,7 +3929,7 @@ function hashedSourceOfType(checker, type, canonical) {
   return source?.isStringLiteral() ? source.value : undefined;
 }
 function staticAddressTextOf(checker, node, canonical) {
-  return ts15.isStringLiteralLike(node) ? node.text : hashedSourceOfType(checker, checker.getTypeAtLocation(node), canonical);
+  return ts16.isStringLiteralLike(node) ? node.text : hashedSourceOfType(checker, checker.getTypeAtLocation(node), canonical);
 }
 
 // src/url-cross-world-address.ts
@@ -4010,7 +3953,7 @@ function checkCrossWorldAddresses(input) {
     if (worlds.length === 0)
       continue;
     const visit = (node) => {
-      if (ts16.isExpression(node)) {
+      if (ts17.isExpression(node)) {
         const entry = addressEntryOfArgument(checker, table, node);
         if (entry !== undefined && slotRejectsForeignSocket(entry)) {
           const address = staticAddressTextOf(checker, node, canonical);
@@ -4027,14 +3970,14 @@ function checkCrossWorldAddresses(input) {
           }
         }
       }
-      ts16.forEachChild(node, visit);
+      ts17.forEachChild(node, visit);
     };
-    ts16.forEachChild(sourceFile, visit);
+    ts17.forEachChild(sourceFile, visit);
   }
   return findings;
 }
 // src/url-fragment-reachability.ts
-import * as ts17 from "typescript";
+import * as ts18 from "typescript";
 function pathOfKey(key) {
   const socket = socketOfAddress(key);
   return socket === undefined ? key : key.slice(socket.length + 1);
@@ -4079,7 +4022,7 @@ function checkUrlFragmentReachability(input) {
     if (isAmbient2(sourceFile.fileName))
       continue;
     const visit = (node) => {
-      if (ts17.isExpression(node) && isAddressClass(addressClassOfArgument(checker, table, node))) {
+      if (ts18.isExpression(node) && isAddressClass(addressClassOfArgument(checker, table, node))) {
         const text = staticAddressTextOf(checker, node, canonical);
         if (text !== undefined) {
           const hash = text.indexOf("#");
@@ -4098,9 +4041,9 @@ function checkUrlFragmentReachability(input) {
           }
         }
       }
-      ts17.forEachChild(node, visit);
+      ts18.forEachChild(node, visit);
     };
-    ts17.forEachChild(sourceFile, visit);
+    ts18.forEachChild(sourceFile, visit);
   }
   return { kind: "checked", findings };
 }
@@ -4145,6 +4088,7 @@ export {
   displayPathOf,
   findEmittedRequires,
   findMainEntryFactoryImports,
+  findTextScriptProperties,
   getProgramDiagnostics,
   guiScriptResourceOf,
   guiScriptResourcesOf,

package/dist/lifecycle-erasure.d.ts

@@ -3,5 +3,12 @@ import { type Plugin } from "typescript-to-lua";
 export declare const FACTORY_MODULE = "@defold-typescript/types";
 export declare const FACTORY_NAMES: Set<string>;
 export declare function resolvesToFactoryExport(callee: ts.Expression, checker: ts.TypeChecker): boolean;
+export interface PropertyMember {
+    readonly name: string;
+    readonly initializer: ts.Expression;
+}
+export declare function propertyMembers(property: ts.ObjectLiteralElementLike): PropertyMember[];
+export declare function factoryHooks(expression: ts.Expression, checker: ts.TypeChecker): ts.ObjectLiteralExpression | undefined;
+export declare function isPropertiesHook(property: ts.ObjectLiteralElementLike): boolean;
 export declare function isFactoryOnlyImport(node: ts.ImportDeclaration): boolean;
 export declare const lifecycleErasurePlugin: Plugin;

package/dist/text-script-property.d.ts

@@ -0,0 +1,16 @@
+import * as ts from "typescript";
+export interface TextScriptPropertyFinding {
+    readonly name: string;
+    readonly file: string;
+    /** 1-based line of the default's initializer or the direct call's value. */
+    readonly line: number;
+    /** 1-based column of the default's initializer or the direct call's value. */
+    readonly column: number;
+}
+export declare function findTextScriptProperties(program: ts.Program, fileNames: readonly string[]): TextScriptPropertyFinding[];
+/**
+ * Whether a value of `type` may be a string at runtime: a string-like type, a
+ * union or intersection with such a member, or a type parameter or other
+ * instantiable type whose constraint may hold one.
+ */
+export declare function mayHoldString(type: ts.Type, checker: ts.TypeChecker, visited?: Set<ts.Type>): boolean;

package/dist/type-application-erasure.d.ts

@@ -0,0 +1,3 @@
+import type { Plugin } from "typescript-to-lua";
+export declare const TYPE_APPLICATION_APIS: ReadonlySet<string>;
+export declare const typeApplicationErasurePlugin: Plugin;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defold-typescript/transpiler",
-  "version": "0.40.0",
+  "version": "0.41.0",
   "description": "TypeScript-to-Lua build pipeline tuned for Defold's runtime.",
   "license": "MIT",
   "repository": {
@@ -35,7 +35,7 @@
     "test": "bun test"
   },
   "dependencies": {
-    "@defold-typescript/types": "0.40.0",
+    "@defold-typescript/types": "0.41.0",
     "@typescript-to-lua/language-extensions": "1.19.0",
     "typescript-to-lua": "^1.36.0"
   }

package/src/index.ts

@@ -86,6 +86,8 @@ export type { SceneMessage } from "./scene-text-format";
 export { parseSceneTextFormat, SceneTextFormatError } from "./scene-text-format";
 export type { TranspileSession } from "./session";
 export { createTranspileSession } from "./session";
+export type { TextScriptPropertyFinding } from "./text-script-property";
+export { findTextScriptProperties } from "./text-script-property";
 export { TIMERS_REQUIRE_NAME } from "./timers-runtime";
 export type {
   TranspileDiagnostic,

package/src/lifecycle-erasure.ts

@@ -208,18 +208,19 @@ function emitInitMerge(
   return [builderDecl, createAssignmentStatement(createIdentifier("init"), initFn, property)];
 }
 
-// The value-keyed `properties` field maps each `key: default` to a chunk-scope
-// `go.property("key", default)` the editor reads. Emitted before the hook
-// assignments and after the source's `local` consts, so a default referencing a
-// module const resolves.
-function emitPropertyRegistrations(
-  property: ts.ObjectLiteralElementLike,
-  context: TransformationContext,
-): Statement[] {
+export interface PropertyMember {
+  readonly name: string;
+  readonly initializer: ts.Expression;
+}
+
+// The `key: default` members of a factory's `properties` field that register as
+// script properties: a property assignment keyed by an identifier or a string
+// literal. Shared by the emitter and every analysis of what it registers.
+export function propertyMembers(property: ts.ObjectLiteralElementLike): PropertyMember[] {
   if (!ts.isPropertyAssignment(property) || !ts.isObjectLiteralExpression(property.initializer)) {
     return [];
   }
-  const registrations: Statement[] = [];
+  const members: PropertyMember[] = [];
   for (const member of property.initializer.properties) {
     if (!ts.isPropertyAssignment(member)) {
       continue;
@@ -228,32 +229,60 @@ function emitPropertyRegistrations(
     if (!ts.isIdentifier(key) && !ts.isStringLiteral(key)) {
       continue;
     }
-    registrations.push(
-      createExpressionStatement(
-        createCallExpression(
-          createTableIndexExpression(createIdentifier("go"), createStringLiteral("property")),
-          [createStringLiteral(key.text), context.transformExpression(member.initializer)],
-        ),
-      ),
-    );
+    members.push({ name: key.text, initializer: member.initializer });
   }
-  return registrations;
+  return members;
 }
 
-function eraseFactoryCall(
+// The hooks object literal of a call to a lifecycle factory, or `undefined` when
+// the expression is not one the erasure rewrites.
+export function factoryHooks(
   expression: ts.Expression,
-  context: TransformationContext,
-): Statement[] | undefined {
+  checker: ts.TypeChecker,
+): ts.ObjectLiteralExpression | undefined {
   if (!ts.isCallExpression(expression)) {
     return undefined;
   }
-  if (!resolvesToFactoryExport(expression.expression, context.checker)) {
+  if (!resolvesToFactoryExport(expression.expression, checker)) {
     return undefined;
   }
   const hooks = expression.arguments[0];
   if (hooks === undefined || !ts.isObjectLiteralExpression(hooks)) {
     return undefined;
   }
+  return hooks;
+}
+
+export function isPropertiesHook(property: ts.ObjectLiteralElementLike): boolean {
+  return hookName(property) === "properties";
+}
+
+// The value-keyed `properties` field maps each `key: default` to a chunk-scope
+// `go.property("key", default)` the editor reads. Emitted before the hook
+// assignments and after the source's `local` consts, so a default referencing a
+// module const resolves.
+function emitPropertyRegistrations(
+  property: ts.ObjectLiteralElementLike,
+  context: TransformationContext,
+): Statement[] {
+  return propertyMembers(property).map(({ name, initializer }) =>
+    createExpressionStatement(
+      createCallExpression(
+        createTableIndexExpression(createIdentifier("go"), createStringLiteral("property")),
+        [createStringLiteral(name), context.transformExpression(initializer)],
+      ),
+    ),
+  );
+}
+
+function eraseFactoryCall(
+  expression: ts.Expression,
+  context: TransformationContext,
+): Statement[] | undefined {
+  const hooks = factoryHooks(expression, context.checker);
+  if (hooks === undefined) {
+    return undefined;
+  }
   const registrations: Statement[] = [];
   const statements: Statement[] = [];
   for (const property of hooks.properties) {

package/src/program-diagnostics.ts

@@ -1,10 +1,10 @@
 import * as ts from "typescript";
 import * as tstl from "typescript-to-lua";
-import { arrayIndexOptionLoweringPlugin } from "./array-index-option-lowering";
 import { lifecycleErasurePlugin } from "./lifecycle-erasure";
 import { messageDispatchLoweringPlugin } from "./message-dispatch-lowering";
 import { messageGuardLoweringPlugin } from "./message-guard-lowering";
 import { timersLoweringPlugin } from "./timers-lowering";
+import { typeApplicationErasurePlugin } from "./type-application-erasure";
 import { windowEventGuardLoweringPlugin } from "./window-event-guard-lowering";
 
 // The same lua plugins the build path lists (transpile.ts / session.ts), so the
@@ -15,7 +15,7 @@ const LUA_PLUGINS: tstl.Plugin[] = [
   windowEventGuardLoweringPlugin,
   messageDispatchLoweringPlugin,
   timersLoweringPlugin,
-  arrayIndexOptionLoweringPlugin,
+  typeApplicationErasurePlugin,
 ];
 
 const noopWriteFile: ts.WriteFileCallback = () => {};

package/src/session.ts

@@ -3,7 +3,6 @@ import { createRequire } from "node:module";
 import * as path from "node:path";
 import * as ts from "typescript";
 import * as tstl from "typescript-to-lua";
-import { arrayIndexOptionLoweringPlugin } from "./array-index-option-lowering";
 import { type CompanionEmitter, createCompanionEmitPlugin } from "./companion-emit";
 import { editorScriptErasurePlugin } from "./editor-script-erasure";
 import { lifecycleErasurePlugin } from "./lifecycle-erasure";
@@ -11,6 +10,7 @@ import { messageDispatchLoweringPlugin } from "./message-dispatch-lowering";
 import { messageGuardLoweringPlugin } from "./message-guard-lowering";
 import { timersLoweringPlugin } from "./timers-lowering";
 import { AMBIENT_FILES, collectOutputs, type TranspileProjectResult } from "./transpile";
+import { typeApplicationErasurePlugin } from "./type-application-erasure";
 import { windowEventGuardLoweringPlugin } from "./window-event-guard-lowering";
 
 export interface TranspileSession {
@@ -44,7 +44,7 @@ function compilerOptions(companionEmit: CompanionEmitter): tstl.CompilerOptions
       { plugin: windowEventGuardLoweringPlugin },
       { plugin: messageDispatchLoweringPlugin },
       { plugin: timersLoweringPlugin },
-      { plugin: arrayIndexOptionLoweringPlugin },
+      { plugin: typeApplicationErasurePlugin },
       { plugin: companionEmit.plugin },
     ],
   };

package/src/text-script-property.ts

@@ -0,0 +1,100 @@
+import * as ts from "typescript";
+import { findDirectGoPropertyCalls } from "./go-property-direct-call";
+import { factoryHooks, isPropertiesHook, propertyMembers } from "./lifecycle-erasure";
+
+export interface TextScriptPropertyFinding {
+  readonly name: string;
+  readonly file: string;
+  /** 1-based line of the default's initializer or the direct call's value. */
+  readonly line: number;
+  /** 1-based column of the default's initializer or the direct call's value. */
+  readonly column: number;
+}
+
+// The script properties whose default may hold a string, declared either in a
+// `properties` field or by a direct `go.property` call. Defold registers a
+// string `go.property` only from 1.13.2, so a build for an older target must
+// refuse them; typed rather than literal-driven, so a const holding a string
+// counts.
+export function findTextScriptProperties(
+  program: ts.Program,
+  fileNames: readonly string[],
+): TextScriptPropertyFinding[] {
+  const checker = program.getTypeChecker();
+  const findings: TextScriptPropertyFinding[] = [];
+
+  for (const file of fileNames) {
+    const sourceFile = program.getSourceFile(file);
+    if (sourceFile === undefined) {
+      continue;
+    }
+    const located: { name: string; value: ts.Node }[] = [];
+    const visit = (node: ts.Node): void => {
+      if (ts.isCallExpression(node)) {
+        const hooks = factoryHooks(node, checker);
+        for (const property of hooks?.properties ?? []) {
+          if (!isPropertiesHook(property)) {
+            continue;
+          }
+          for (const { name, initializer } of propertyMembers(property)) {
+            if (mayHoldString(checker.getTypeAtLocation(initializer), checker)) {
+              located.push({ name, value: initializer });
+            }
+          }
+        }
+      }
+      ts.forEachChild(node, visit);
+    };
+    visit(sourceFile);
+    for (const call of findDirectGoPropertyCalls(sourceFile)) {
+      const [nameArgument, value] = call.arguments;
+      if (nameArgument === undefined || value === undefined) {
+        continue;
+      }
+      if (mayHoldString(checker.getTypeAtLocation(value), checker)) {
+        const name = ts.isStringLiteralLike(nameArgument)
+          ? nameArgument.text
+          : nameArgument.getText(sourceFile);
+        located.push({ name, value });
+      }
+    }
+    located.sort(
+      (left, right) => left.value.getStart(sourceFile) - right.value.getStart(sourceFile),
+    );
+    for (const { name, value } of located) {
+      const position = sourceFile.getLineAndCharacterOfPosition(value.getStart(sourceFile));
+      findings.push({ name, file, line: position.line + 1, column: position.character + 1 });
+    }
+  }
+
+  return findings;
+}
+
+/**
+ * Whether a value of `type` may be a string at runtime: a string-like type, a
+ * union or intersection with such a member, or a type parameter or other
+ * instantiable type whose constraint may hold one.
+ */
+export function mayHoldString(
+  type: ts.Type,
+  checker: ts.TypeChecker,
+  visited: Set<ts.Type> = new Set(),
+): boolean {
+  if (visited.has(type)) {
+    return false;
+  }
+  visited.add(type);
+  if (type.flags & ts.TypeFlags.StringLike) {
+    return true;
+  }
+  if (type.isUnionOrIntersection()) {
+    return type.types.some((member) => mayHoldString(member, checker, visited));
+  }
+  if (type.flags & ts.TypeFlags.Instantiable) {
+    const constraint = checker.getBaseConstraintOfType(type);
+    return constraint !== undefined && constraint !== type
+      ? mayHoldString(constraint, checker, visited)
+      : false;
+  }
+  return false;
+}

package/src/transpile.ts

@@ -3,7 +3,6 @@ import { createRequire } from "node:module";
 import * as path from "node:path";
 import type * as ts from "typescript";
 import * as tstl from "typescript-to-lua";
-import { arrayIndexOptionLoweringPlugin } from "./array-index-option-lowering";
 import { createCompanionEmitPlugin } from "./companion-emit";
 import { editorScriptErasurePlugin } from "./editor-script-erasure";
 import {
@@ -15,6 +14,7 @@ import { messageDispatchLoweringPlugin } from "./message-dispatch-lowering";
 import { messageGuardLoweringPlugin } from "./message-guard-lowering";
 import { importsTimersModule, timersLoweringPlugin } from "./timers-lowering";
 import { TIMERS_RUNTIME } from "./timers-runtime";
+import { typeApplicationErasurePlugin } from "./type-application-erasure";
 import { windowEventGuardLoweringPlugin } from "./window-event-guard-lowering";
 
 export interface TranspileResult {
@@ -322,7 +322,7 @@ export function transpileProject(input: TranspileProjectInput): TranspileProject
       { plugin: windowEventGuardLoweringPlugin },
       { plugin: messageDispatchLoweringPlugin },
       { plugin: timersLoweringPlugin },
-      { plugin: arrayIndexOptionLoweringPlugin },
+      { plugin: typeApplicationErasurePlugin },
       { plugin: companionEmit.plugin },
     ],
   });

package/src/type-application-erasure.ts

@@ -0,0 +1,34 @@
+import * as ts from "typescript";
+import type { Expression, Plugin } from "typescript-to-lua";
+
+// The Defold functions declared with a curried type-application overload,
+// `go.get<P>()(url, property)`: the empty call only fixes `P` for the checker.
+export const TYPE_APPLICATION_APIS: ReadonlySet<string> = new Set(["go.get", "go.set"]);
+
+// Keyed by the declaration's fully qualified name: only a symbol declared in
+// an ambient `declare global` block carries the `global.` prefix, so a
+// project's own `go` never matches.
+function isTypeApplication(call: ts.CallExpression, checker: ts.TypeChecker): boolean {
+  if (call.arguments.length !== 0) return false;
+  const declaration = checker.getResolvedSignature(call)?.declaration;
+  if (declaration === undefined || !ts.isFunctionDeclaration(declaration)) return false;
+  if (declaration.parameters.length !== 0 || declaration.typeParameters === undefined) return false;
+  if (declaration.name === undefined) return false;
+  const symbol = checker.getSymbolAtLocation(declaration.name);
+  if (symbol === undefined) return false;
+  const fqn = checker.getFullyQualifiedName(symbol);
+  return fqn.startsWith("global.") && TYPE_APPLICATION_APIS.has(fqn.slice("global.".length));
+}
+
+// `go.get<P>()` becomes `go.get`, so the curried call reaches the engine as
+// `go.get(url, property)` and a stored `go.get<P>()` is the function itself.
+export const typeApplicationErasurePlugin: Plugin = {
+  visitors: {
+    [ts.SyntaxKind.CallExpression]: (node, context): Expression => {
+      if (isTypeApplication(node, context.checker)) {
+        return context.transformExpression(node.expression);
+      }
+      return context.superTransformExpression(node);
+    },
+  },
+};

package/dist/array-index-option-lowering.d.ts

@@ -1,6 +0,0 @@
-import { type Plugin } from "typescript-to-lua";
-export declare const ONE_BASED_INDEX_OPTION_APIS: ReadonlySet<string>;
-export declare const INDEX_OPTION_VARIABLE_MESSAGE = "`options.index` is zero-based and is converted to Defold's 1-based index only in an object literal written at the call; pass the options inline.";
-export declare const INDEX_OPTION_SPREAD_MESSAGE = "A spread carrying `index` cannot be converted to Defold's 1-based index; write `index` explicitly after the spread.";
-export declare const INDEX_OPTION_UNDEFINED_MESSAGE = "`options.index` may be undefined here, so it cannot be converted to Defold's 1-based index; pass a number, or leave `index` out.";
-export declare const arrayIndexOptionLoweringPlugin: Plugin;

package/src/array-index-option-lowering.ts

@@ -1,212 +0,0 @@
-import * as ts from "typescript";
-import {
-  createBinaryExpression,
-  createNumericLiteral,
-  type Expression,
-  getOriginalPos,
-  isCallExpression,
-  isNumericLiteral,
-  isStringLiteral,
-  isTableExpression,
-  type Plugin,
-  SyntaxKind,
-  setNodePosition,
-  type TableExpression,
-} from "typescript-to-lua";
-
-// The Defold functions whose `options.index` upstream documents as "index into
-// array property (1 based)". TypeScript authors it zero-based; the lowering
-// adds the one Lua expects.
-export const ONE_BASED_INDEX_OPTION_APIS: ReadonlySet<string> = new Set([
-  "go.get",
-  "go.set",
-  "gui.get",
-  "gui.set",
-]);
-
-export const INDEX_OPTION_VARIABLE_MESSAGE =
-  "`options.index` is zero-based and is converted to Defold's 1-based index only in an object literal written at the call; pass the options inline.";
-export const INDEX_OPTION_SPREAD_MESSAGE =
-  "A spread carrying `index` cannot be converted to Defold's 1-based index; write `index` explicitly after the spread.";
-export const INDEX_OPTION_UNDEFINED_MESSAGE =
-  "`options.index` may be undefined here, so it cannot be converted to Defold's 1-based index; pass a number, or leave `index` out.";
-
-const OPTIONS_PARAMETER = "options";
-const INDEX_KEY = "index";
-
-const loweredLiterals = new WeakSet<ts.Node>();
-
-// Keyed like `tableKey` in url-address-slots.ts: only a symbol declared in an
-// ambient `declare global` block carries the `global.` prefix, so a project's
-// own `go` or `gui` never matches. Walking up from the signature declaration
-// reaches `go.get<P>()` from the function type its curried inner call resolves to.
-function oneBasedApi(declaration: ts.Declaration, checker: ts.TypeChecker): boolean {
-  let node: ts.Node | undefined = declaration;
-  while (node !== undefined && !ts.isFunctionDeclaration(node)) node = node.parent;
-  if (node?.name === undefined) return false;
-  const symbol = checker.getSymbolAtLocation(node.name);
-  if (symbol === undefined) return false;
-  const fqn = checker.getFullyQualifiedName(symbol);
-  return fqn.startsWith("global.") && ONE_BASED_INDEX_OPTION_APIS.has(fqn.slice("global.".length));
-}
-
-function optionsArgument(
-  call: ts.CallExpression,
-  checker: ts.TypeChecker,
-): ts.Expression | undefined {
-  const declaration = checker.getResolvedSignature(call)?.declaration;
-  if (declaration === undefined || !ts.isFunctionLike(declaration)) return undefined;
-  if (!oneBasedApi(declaration, checker)) return undefined;
-  const index = declaration.parameters.findIndex(
-    (parameter) =>
-      parameter.dotDotDotToken === undefined &&
-      ts.isIdentifier(parameter.name) &&
-      parameter.name.text === OPTIONS_PARAMETER,
-  );
-  return index === -1 ? undefined : call.arguments[index];
-}
-
-function unwrap(expression: ts.Expression): ts.Expression {
-  let current = expression;
-  while (
-    ts.isParenthesizedExpression(current) ||
-    ts.isAsExpression(current) ||
-    ts.isSatisfiesExpression(current) ||
-    ts.isNonNullExpression(current) ||
-    ts.isTypeAssertionExpression(current)
-  ) {
-    current = current.expression;
-  }
-  return current;
-}
-
-function someConstituent(type: ts.Type, predicate: (type: ts.Type) => boolean): boolean {
-  return type.isUnion() ? type.types.some(predicate) : predicate(type);
-}
-
-function carriesIndex(type: ts.Type): boolean {
-  return someConstituent(type, (t) => t.getProperty(INDEX_KEY) !== undefined);
-}
-
-function admitsUndefined(type: ts.Type): boolean {
-  return someConstituent(
-    type,
-    (t) => (t.flags & (ts.TypeFlags.Undefined | ts.TypeFlags.Void)) !== 0,
-  );
-}
-
-function propertyName(
-  property: ts.ObjectLiteralElementLike,
-  checker: ts.TypeChecker,
-): string | undefined {
-  const name = property.name;
-  if (name === undefined) return undefined;
-  if (ts.isIdentifier(name) || ts.isStringLiteral(name) || ts.isNumericLiteral(name)) {
-    return name.text;
-  }
-  if (ts.isComputedPropertyName(name)) {
-    const type = checker.getTypeAtLocation(name.expression);
-    if (type.isStringLiteral()) return type.value;
-  }
-  return undefined;
-}
-
-function indexValueType(
-  property: ts.ObjectLiteralElementLike,
-  checker: ts.TypeChecker,
-): ts.Type | undefined {
-  if (ts.isPropertyAssignment(property)) return checker.getTypeAtLocation(property.initializer);
-  if (ts.isShorthandPropertyAssignment(property)) return checker.getTypeAtLocation(property.name);
-  return undefined;
-}
-
-function rejection(node: ts.Node, messageText: string): ts.Diagnostic {
-  const file = node.getSourceFile();
-  const start = node.getStart(file);
-  return {
-    file,
-    start,
-    length: node.getEnd() - start,
-    category: ts.DiagnosticCategory.Error,
-    code: 0,
-    messageText,
-  };
-}
-
-// The first reason `options` cannot be lowered, or `undefined` when it can.
-function rejectOptions(options: ts.Expression, checker: ts.TypeChecker): ts.Diagnostic | undefined {
-  const literal = unwrap(options);
-  if (!ts.isObjectLiteralExpression(literal)) {
-    return carriesIndex(checker.getTypeAtLocation(literal))
-      ? rejection(options, INDEX_OPTION_VARIABLE_MESSAGE)
-      : undefined;
-  }
-  let uncoveredSpread: ts.SpreadAssignment | undefined;
-  let explicitIndex: ts.ObjectLiteralElementLike | undefined;
-  for (const property of literal.properties) {
-    if (ts.isSpreadAssignment(property)) {
-      if (carriesIndex(checker.getTypeAtLocation(property.expression))) uncoveredSpread = property;
-    } else if (propertyName(property, checker) === INDEX_KEY) {
-      uncoveredSpread = undefined;
-      explicitIndex = property;
-    }
-  }
-  if (uncoveredSpread !== undefined) return rejection(uncoveredSpread, INDEX_OPTION_SPREAD_MESSAGE);
-  const valueType = explicitIndex && indexValueType(explicitIndex, checker);
-  if (explicitIndex !== undefined && valueType !== undefined && admitsUndefined(valueType)) {
-    return rejection(explicitIndex, INDEX_OPTION_UNDEFINED_MESSAGE);
-  }
-  return undefined;
-}
-
-function plusOne(value: Expression): Expression {
-  if (isNumericLiteral(value)) {
-    return setNodePosition(createNumericLiteral(value.value + 1), getOriginalPos(value));
-  }
-  return setNodePosition(
-    createBinaryExpression(value, createNumericLiteral(1), SyntaxKind.AdditionOperator),
-    getOriginalPos(value),
-  );
-}
-
-// `rejectOptions` guarantees the last `index` field is the effective one: a
-// spread carrying `index` after it is rejected. Every earlier one is shadowed
-// and keeps its source value.
-function offsetEffectiveIndexField(tables: readonly TableExpression[]): void {
-  for (const field of tables.flatMap((table) => table.fields).reverse()) {
-    if (field.key !== undefined && isStringLiteral(field.key) && field.key.value === INDEX_KEY) {
-      field.value = plusOne(field.value);
-      return;
-    }
-  }
-}
-
-export const arrayIndexOptionLoweringPlugin: Plugin = {
-  visitors: {
-    [ts.SyntaxKind.CallExpression]: (node, context): Expression => {
-      const options = optionsArgument(node, context.checker);
-      if (options !== undefined) {
-        const diagnostic = rejectOptions(options, context.checker);
-        if (diagnostic !== undefined) {
-          context.diagnostics.push(diagnostic);
-        } else {
-          const literal = unwrap(options);
-          if (ts.isObjectLiteralExpression(literal)) loweredLiterals.add(literal);
-        }
-      }
-      return context.superTransformExpression(node);
-    },
-    // A spread lowers the literal to `__TS__ObjectAssign({}, base, {index = …})`,
-    // so the table carrying `index` can sit one call deep.
-    [ts.SyntaxKind.ObjectLiteralExpression]: (node, context): Expression => {
-      const result = context.superTransformExpression(node);
-      if (!loweredLiterals.has(node)) return result;
-      if (isTableExpression(result)) {
-        offsetEffectiveIndexField([result]);
-      } else if (isCallExpression(result)) {
-        offsetEffectiveIndexField(result.params.filter(isTableExpression));
-      }
-      return result;
-    },
-  },
-};