@defisaver/positions-sdk 2.1.137-audit-dev → 2.1.138

package/cjs/types/aaveV4.d.ts

@@ -44,6 +44,11 @@ export interface AaveV4SpokeInfo {
     value: AaveV4SpokesType;
     url: string;
     address: EthAddress;
+    /**
+     * Known hub addresses, used only to prefetch hub data in parallel with the spoke data.
+     * The on-chain reserves are the source of truth — hubs found there but missing here are
+     * fetched dynamically, so this list going stale can't break spoke loading.
+     */
     hubs: EthAddress[];
 }
 export interface AaveV4SpokeData {

package/esm/aaveV4/index.js

@@ -13,7 +13,7 @@ import { getViemProvider } from '../services/viem';
 import { IncentiveKind, } from '../types';
 import { AaveV4ViewContractViem } from '../contracts';
 import { getStakingApy, STAKING_ASSETS } from '../staking';
-import { isMaxUint, wethToEth, wethToEthByAddress } from '../services/utils';
+import { isMaxUint, shortenAddress, wethToEth, wethToEthByAddress, } from '../services/utils';
 import { aaveV4GetAggregatedPositionData, calcUserRiskPremiumBps } from '../helpers/aaveV4Helpers';
 import { findAaveV4SpokeByAddress, getAaveV4HubByAddress } from '../markets/aaveV4';
 import { aprToApy } from '../moneymarket';
@@ -39,16 +39,16 @@ const fetchHubData = (viewContract, hubAddress) => __awaiter(void 0, void 0, voi
     };
 });
 const formatReserveAsset = (reserveAsset, hubAsset, reserveId, oracleDecimals, network) => __awaiter(void 0, void 0, void 0, function* () {
-    var _a, _b, _c, _d, _e, _f;
+    var _a, _b, _c, _d, _e, _f, _g, _h;
     const assetInfo = getAssetInfoByAddress(reserveAsset.underlying, network);
     // `@defisaver/tokens` returns a placeholder ('?', decimals NaN) when the underlying is not in the
     // tokens package. Flag it so consumers can render it read-only instead of feeding NaN into amounts.
     const isUnsupported = assetInfo.symbol === '?';
     const symbol = wethToEth(assetInfo.symbol);
+    // The hub registry only provides display metadata — a hub missing from it (newly deployed by
+    // Aave, SDK not yet updated) must not prevent the reserve from loading, so fall back to a
+    // generated label instead of failing.
     const hubInfo = getAaveV4HubByAddress(network, reserveAsset.hub);
-    if (!hubInfo) {
-        throw new Error(`Hub not found with address: ${reserveAsset.hub}`);
-    }
     const isStakingAsset = STAKING_ASSETS.includes(symbol);
     const supplyIncentives = [];
     const borrowIncentives = [];
@@ -108,8 +108,8 @@ const formatReserveAsset = (reserveAsset, hubAsset, reserveId, oracleDecimals, n
         decimals: reserveAsset.decimals,
         isUnsupported,
         underlying: reserveAsset.underlying,
-        hub: hubInfo.address,
-        hubName: hubInfo === null || hubInfo === void 0 ? void 0 : hubInfo.label,
+        hub: (_g = hubInfo === null || hubInfo === void 0 ? void 0 : hubInfo.address) !== null && _g !== void 0 ? _g : reserveAsset.hub,
+        hubName: (_h = hubInfo === null || hubInfo === void 0 ? void 0 : hubInfo.label) !== null && _h !== void 0 ? _h : `Hub ${shortenAddress(reserveAsset.hub)}`,
         assetId: reserveAsset.assetId,
         reserveId,
         paused: reserveAsset.paused,
@@ -147,14 +147,30 @@ export function _getAaveV4SpokeData(provider_1, network_1, market_1) {
     return __awaiter(this, arguments, void 0, function* (provider, network, market, blockNumber = 'latest') {
         const viewContract = AaveV4ViewContractViem(provider, network, blockNumber);
         const hubsData = {};
+        const loadHubData = (hubAddress) => __awaiter(this, void 0, void 0, function* () {
+            hubsData[hubAddress.toLowerCase()] = yield fetchHubData(viewContract, hubAddress);
+        });
+        // market.hubs is only a prefetch hint (lets known hubs load in parallel with the spoke data), so
+        // failures are tolerated here — any hub the reserves actually reference is (re)fetched below.
         const [spokeData, merklCampaigns] = yield Promise.all([
             viewContract.read.getSpokeDataFull([market.address]),
             getAaveV4MerkleCampaigns(network),
-            ...market.hubs.map((hubAddress) => __awaiter(this, void 0, void 0, function* () {
-                hubsData[hubAddress] = yield fetchHubData(viewContract, hubAddress);
-            })),
+            ...market.hubs.map((hubAddress) => loadHubData(hubAddress).catch(() => { })),
         ]);
-        const reserveAssetsArray = yield Promise.all(spokeData[1].map((reserveAssetOnChain, index) => __awaiter(this, void 0, void 0, function* () { return formatReserveAsset(reserveAssetOnChain, hubsData[reserveAssetOnChain.hub].assets[reserveAssetOnChain.assetId], index, +spokeData[0].oracleDecimals.toString(), network); })));
+        // The on-chain reserves are the source of truth for which hubs the spoke uses — fetch any hub
+        // the prefetch didn't cover, so an asset listed from a hub unknown to the SDK can't break the spoke.
+        const missingHubs = [...new Set(spokeData[1].map((reserveAsset) => reserveAsset.hub.toLowerCase()))]
+            .filter((hubAddress) => !hubsData[hubAddress]);
+        yield Promise.all(missingHubs.map(loadHubData));
+        const reserveAssetsArray = (yield Promise.all(spokeData[1].map((reserveAssetOnChain, index) => __awaiter(this, void 0, void 0, function* () {
+            var _a;
+            const hubAsset = (_a = hubsData[reserveAssetOnChain.hub.toLowerCase()]) === null || _a === void 0 ? void 0 : _a.assets[reserveAssetOnChain.assetId];
+            // A reserve whose hub-side asset data can't be resolved is skipped instead of failing the
+            // whole spoke (position math degrades for that one asset only).
+            if (!hubAsset)
+                return null;
+            return formatReserveAsset(reserveAssetOnChain, hubAsset, index, +spokeData[0].oracleDecimals.toString(), network);
+        })))).filter((asset) => asset !== null);
         const enrichedAssets = reserveAssetsArray.map((asset) => attachAaveV4MerklIncentives(asset, market.address, merklCampaigns));
         return {
             assetsData: enrichedAssets.reduce((acc, reserveAsset) => {