@definitelytyped/eslint-plugin 0.0.203 → 0.0.204

package/test/__file_snapshots__/types/strict-export-declare-modifiers/good9.d.ts.lint

@@ -1,7 +0,0 @@
-No errors
-
-==== types/strict-export-declare-modifiers/good9.d.ts ====
-
-    import * as bar from "bar";
-    import bar = require("bar");
-    export as namespace Bar;

package/test/__file_snapshots__/types/strict-export-declare-modifiers/strict-export-declare-modifiers-tests.ts.lint

@@ -1,10 +0,0 @@
-types/strict-export-declare-modifiers/strict-export-declare-modifiers-tests.ts
-  1:1  error  File has no content  @definitelytyped/no-useless-files
-
-✖ 1 problem (1 error, 0 warnings)
-
-==== types/strict-export-declare-modifiers/strict-export-declare-modifiers-tests.ts ====
-
-    
-    ~
-!!! @definitelytyped/no-useless-files: File has no content.

package/test/__snapshots__/plugin.test.ts.snap

@@ -1,262 +0,0 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
-
-exports[`plugin should have the expected exports 1`] = `
-{
-  "configs": {
-    "all": {
-      "overrides": [
-        {
-          "files": [
-            "*.cts",
-            "*.mts",
-            "*.ts",
-            "*.tsx",
-          ],
-          "parser": "@typescript-eslint/parser",
-          "parserOptions": {
-            "project": true,
-            "warnOnUnsupportedTypeScriptVersion": false,
-          },
-          "rules": {
-            "@definitelytyped/expect": "error",
-            "@definitelytyped/export-just-namespace": "error",
-            "@definitelytyped/no-any-union": "error",
-            "@definitelytyped/no-bad-reference": "error",
-            "@definitelytyped/no-const-enum": "error",
-            "@definitelytyped/no-dead-reference": "error",
-            "@definitelytyped/no-declare-current-package": "error",
-            "@definitelytyped/no-import-default-of-export-equals": "error",
-            "@definitelytyped/no-import-of-dev-dependencies": "error",
-            "@definitelytyped/no-old-dt-header": "error",
-            "@definitelytyped/no-relative-import-in-test": "error",
-            "@definitelytyped/no-self-import": "error",
-            "@definitelytyped/no-single-declare-module": "error",
-            "@definitelytyped/no-single-element-tuple-type": "error",
-            "@definitelytyped/no-unnecessary-generics": "error",
-            "@definitelytyped/no-useless-files": "error",
-            "@definitelytyped/prefer-declare-function": "error",
-            "@definitelytyped/redundant-undefined": "error",
-            "@definitelytyped/strict-export-declare-modifiers": "error",
-            "@typescript-eslint/adjacent-overload-signatures": "error",
-            "@typescript-eslint/array-type": [
-              "error",
-              {
-                "default": "array-simple",
-              },
-            ],
-            "@typescript-eslint/ban-ts-comment": [
-              "error",
-              {
-                "ts-check": false,
-                "ts-expect-error": false,
-                "ts-ignore": "allow-with-description",
-                "ts-nocheck": true,
-              },
-            ],
-            "@typescript-eslint/ban-types": [
-              "error",
-              {
-                "extendDefaults": true,
-                "types": {
-                  "{}": false,
-                },
-              },
-            ],
-            "@typescript-eslint/consistent-type-definitions": "error",
-            "@typescript-eslint/explicit-member-accessibility": [
-              "error",
-              {
-                "accessibility": "no-public",
-              },
-            ],
-            "@typescript-eslint/naming-convention": [
-              "error",
-              {
-                "custom": {
-                  "match": false,
-                  "regex": "^I[A-Z]",
-                },
-                "format": [],
-                "selector": "interface",
-              },
-            ],
-            "@typescript-eslint/no-empty-interface": "error",
-            "@typescript-eslint/no-invalid-void-type": [
-              "error",
-              {
-                "allowAsThisParameter": true,
-                "allowInGenericTypeArguments": true,
-              },
-            ],
-            "@typescript-eslint/no-misused-new": "error",
-            "@typescript-eslint/prefer-namespace-keyword": "error",
-            "@typescript-eslint/triple-slash-reference": [
-              "error",
-              {
-                "path": "always",
-                "types": "prefer-import",
-              },
-            ],
-            "no-duplicate-imports": "error",
-            "unicode-bom": [
-              "error",
-              "never",
-            ],
-          },
-        },
-      ],
-      "plugins": [
-        "@definitelytyped",
-        "@typescript-eslint",
-        "jsdoc",
-      ],
-      "rules": {
-        "jsdoc/check-tag-names": [
-          "error",
-          {
-            "definedTags": [
-              "addVersion",
-              "also",
-              "api",
-              "author",
-              "beta",
-              "brief",
-              "category",
-              "cfg",
-              "chainable",
-              "check",
-              "checkReturnValue",
-              "classDescription",
-              "condparamprivilege",
-              "constraint",
-              "credits",
-              "declaration",
-              "defApiFeature",
-              "defaultValue",
-              "detail",
-              "end",
-              "eventproperty",
-              "experimental",
-              "export",
-              "expose",
-              "extendscript",
-              "factory",
-              "field",
-              "final",
-              "fixme",
-              "fluent",
-              "for",
-              "governance",
-              "header",
-              "hidden-property",
-              "hidden",
-              "id",
-              "jsx",
-              "jsxImportSource",
-              "label",
-              "language",
-              "legacy",
-              "link",
-              "listen",
-              "locus",
-              "methodOf",
-              "minVersion",
-              "ngdoc",
-              "nonstandard",
-              "note",
-              "npm",
-              "observable",
-              "option",
-              "optionobject",
-              "options",
-              "packageDocumentation",
-              "param",
-              "parent",
-              "platform",
-              "plugin",
-              "preserve",
-              "privateRemarks",
-              "privilegeLevel",
-              "privilegeName",
-              "proposed",
-              "range",
-              "readOnly",
-              "related",
-              "remark",
-              "remarks",
-              "required",
-              "requires",
-              "restriction",
-              "returnType",
-              "section",
-              "see",
-              "since",
-              "const",
-              "singleton",
-              "source",
-              "struct",
-              "suppress",
-              "targetfolder",
-              "enum",
-              "title",
-              "record",
-              "title",
-              "TODO",
-              "trigger",
-              "triggers",
-              "typeparam",
-              "typeParam",
-              "unsupported",
-              "url",
-              "usage",
-              "warn",
-              "warning",
-              "version",
-            ],
-            "typed": true,
-          },
-        ],
-      },
-      "settings": {
-        "jsdoc": {
-          "tagNamePreference": {
-            "argument": "argument",
-            "exception": "exception",
-            "function": "function",
-            "method": "method",
-            "param": "param",
-            "return": "return",
-            "returns": "returns",
-          },
-        },
-      },
-    },
-  },
-  "meta": {
-    "name": "@definitelytyped/eslint-plugin",
-    "version": "version",
-  },
-  "rules": [
-    "export-just-namespace",
-    "no-any-union",
-    "no-bad-reference",
-    "no-const-enum",
-    "no-dead-reference",
-    "no-declare-current-package",
-    "no-import-default-of-export-equals",
-    "no-relative-import-in-test",
-    "no-self-import",
-    "no-single-element-tuple-type",
-    "no-unnecessary-generics",
-    "no-useless-files",
-    "prefer-declare-function",
-    "redundant-undefined",
-    "strict-export-declare-modifiers",
-    "no-single-declare-module",
-    "no-old-dt-header",
-    "no-import-of-dev-dependencies",
-    "npm-naming",
-    "expect",
-  ],
-}
-`;

package/test/eslint.test.ts

@@ -1,134 +0,0 @@
-import { ESLint, Linter } from "eslint";
-import path from "path";
-import stripAnsi from "strip-ansi";
-import { globSync } from "glob";
-import { fixtureRoot } from "./util";
-import { toMatchFile } from "jest-file-snapshot";
-import * as plugin from "../src/index";
-import fs from "fs";
-
-expect.extend({ toMatchFile });
-const snapshotDir = path.join(__dirname, "__file_snapshots__");
-
-const allFixtures = globSync(["**/*.ts", "**/*.cts", "**/*.mts", "**/*.tsx"], { cwd: fixtureRoot });
-
-function getLintSnapshotPath(fixture: string): string {
-  return path.join(snapshotDir, `${fixture}.lint`);
-}
-
-function getAllLintSnapshots() {
-  return new Set(globSync("**/*.lint", { cwd: snapshotDir, absolute: true }));
-}
-
-function getAllExpectedLintSnapshots() {
-  return new Set(allFixtures.map(getLintSnapshotPath));
-}
-
-let eslint: ESLint;
-
-beforeAll(() => {
-  eslint = new ESLint({
-    cwd: fixtureRoot,
-    plugins: { [plugin.meta.name]: plugin },
-  });
-});
-
-afterAll(() => {
-  eslint = undefined as any;
-});
-
-// Force one test per fixture so we can see when a file has no errors.
-for (const fixture of allFixtures) {
-  describe(`fixture ${fixture}`, () => {
-    it("should lint", async () => {
-      const results = await eslint.lintFiles([fixture]);
-      for (const result of results) {
-        result.filePath = path.relative(fixtureRoot, result.filePath);
-      }
-      const formatter = await eslint.loadFormatter("stylish");
-      const formatted = await formatter.format(results);
-      const resultText = stripAnsi(formatted).trim() || "No errors";
-      expect(resultText).not.toContain("Parsing error");
-      const newOutput = formatResultsWithInlineErrors(results);
-      expect(resultText + "\n\n" + newOutput).toMatchFile(getLintSnapshotPath(fixture));
-    });
-  });
-}
-
-function formatResultsWithInlineErrors(results: ESLint.LintResult[]): string {
-  const output: string[] = [];
-
-  function pushMessage(message: Linter.LintMessage): void {
-    const ruleId = message.ruleId;
-    if (!ruleId) {
-      throw new Error("Expected ruleId");
-    }
-    const lines = message.message.split(/\r?\n/);
-    for (let i = 0; i < lines.length; i++) {
-      const line = lines[i];
-      const prefix = `!!! ${i === 0 ? ruleId : " ".repeat(ruleId.length)}: `;
-      output.push(prefix + line);
-    }
-  }
-
-  const indent = "    ";
-
-  for (const result of results) {
-    output.push(`==== ${result.filePath} ====`);
-    output.push("");
-
-    const sourceText = fs.readFileSync(path.join(fixtureRoot, result.filePath), "utf-8");
-
-    const lines = sourceText.split(/\r?\n/);
-
-    for (let i = 0; i < lines.length; i++) {
-      const line = lines[i];
-      output.push(indent + line);
-
-      for (const message of result.messages) {
-        const startLine = message.line - 1;
-        const endLine = message.endLine === undefined ? startLine : message.endLine - 1;
-        const startColumn = message.column - 1;
-        const endColumn = message.endColumn === undefined ? startColumn : message.endColumn - 1;
-        if (i < startLine || i > endLine) {
-          continue;
-        }
-        if (i === startLine) {
-          const squiggle = "~".repeat(Math.max(1, endColumn - startColumn));
-          output.push(indent + " ".repeat(startColumn) + squiggle);
-          pushMessage(message);
-        } else {
-          const squiggle = "~".repeat(Math.max(1, line.length - startColumn));
-          output.push(indent + squiggle);
-        }
-      }
-    }
-
-    output.push("");
-  }
-
-  return output.join("\n").trim() + "\n";
-}
-
-// Similar to https://github.com/storybookjs/storybook/blob/df357020e010f49e7c325942f0c891e6702527d6/code/addons/storyshots-core/src/api/integrityTestTemplate.ts
-describe("lint snapshots", () => {
-  it("abandoned snapshots", () => {
-    const expectedSnapshots = getAllExpectedLintSnapshots();
-    const actualSnapshots = getAllLintSnapshots();
-    const abandonedSnapshots = [...actualSnapshots].filter((s) => !expectedSnapshots.has(s));
-
-    if (abandonedSnapshots.length === 0) {
-      return;
-    }
-
-    // https://github.com/jestjs/jest/issues/8732#issuecomment-516445064
-    if (expect.getState().snapshotState._updateSnapshot === "all") {
-      for (const abandoned of abandonedSnapshots) {
-        fs.rmSync(abandoned);
-      }
-      return;
-    }
-
-    expect(abandonedSnapshots).toHaveLength(0);
-  });
-});

package/test/fixtures/.eslintrc.cjs

@@ -1,4 +0,0 @@
-module.exports = {
-    root: true,
-    extends: ["plugin:@definitelytyped/all"],
-};

package/test/fixtures/notNeededPackages.json

@@ -1,3 +0,0 @@
-{
-    "packages": {}
-}

package/test/fixtures/package.json

@@ -1,4 +0,0 @@
-{
-    "name": "definitely-typed",
-    "private": "true"
-}

package/test/fixtures/types/expect/expect-tests.ts

@@ -1,49 +0,0 @@
-// eslint-disable-next-line @definitelytyped/no-relative-import-in-test
-import * as expect from "./";
-
-
-// $ExpectType number
-expect.foo;
-
-
-// $ExpectType 1234
-expect.foo;
-
-
-// $ExpectType NotRightAtAll
-expect.foo;
-
-
-// $ExpectType string | number | undefined
-expect.aUnion;
-
-// $ExpectType string | undefined | number
-expect.aUnion;
-
-// $ExpectType number | string | undefined
-expect.aUnion;
-
-// $ExpectType number | undefined | string
-expect.aUnion;
-
-// $ExpectType undefined | string | number
-expect.aUnion;
-
-// $ExpectType undefined | number | string
-expect.aUnion;
-
-// $ExpectType any || undefined | number | string
-expect.aUnion;
-
-// $ExpectType { prop1: "a" | "b" | "c"; prop2: readonly (string | number)[]; prop3: readonly (string | number)[]; }
-expect.complicatedUnion(1, 2);
-
-// $ExpectType { prop1: "c" | "b" | "a"; prop2: ReadonlyArray<number | string>; prop3: ReadonlyArray<string | number>; }
-expect.complicatedUnion(1, 2);
-
-
-// $ExpectType NotMatched
-// Whoops
-
-
-// $ExpectType NotMatched

package/test/fixtures/types/expect/index.d.ts

@@ -1,9 +0,0 @@
-export const foo = 1234;
-
-export const aUnion: string | number | undefined;
-
-export function complicatedUnion<T extends string | number>(x: T, y: T): {
-    prop1: "a" | "b" | "c";
-    prop2: readonly (string | number)[];
-    prop3: ReadonlyArray<string | number>;
-};

package/test/fixtures/types/expect/package.json

@@ -1,5 +0,0 @@
-{
-    "name": "@types/expect",
-    "version": "2.0.9999",
-    "owners": []
-}

package/test/fixtures/types/expect/tsconfig.json

@@ -1,20 +0,0 @@
-{
-    "compilerOptions": {
-        "module": "commonjs",
-        "lib": [
-            "es6",
-            "dom"
-        ],
-        "noImplicitAny": true,
-        "noImplicitThis": true,
-        "strictFunctionTypes": true,
-        "strictNullChecks": true,
-        "types": [],
-        "noEmit": true,
-        "forceConsistentCasingInFileNames": true
-    },
-    "files": [
-        "index.d.ts",
-        "expect-tests.ts"
-    ]
-}

package/test/fixtures/types/export-just-namespace/bad1.d.ts

@@ -1,2 +0,0 @@
-export = Stuff;
-namespace Stuff {}

package/test/fixtures/types/export-just-namespace/bad2.d.ts

@@ -1,2 +0,0 @@
-namespace Stuff {}
-export = Stuff;

package/test/fixtures/types/export-just-namespace/bad3.d.ts

@@ -1,3 +0,0 @@
-namespace Stuff {}
-const other = "code";
-export = Stuff;

package/test/fixtures/types/export-just-namespace/good1.d.ts

@@ -1 +0,0 @@
-export const value = 3;

package/test/fixtures/types/export-just-namespace/good2.d.ts

@@ -1 +0,0 @@
-export default class Hello {}

package/test/fixtures/types/export-just-namespace/good3.d.ts

@@ -1 +0,0 @@
-import * as fs from "fs";

package/test/fixtures/types/export-just-namespace/good4.d.ts

@@ -1 +0,0 @@
-const value = 123;

package/test/fixtures/types/export-just-namespace/good5.d.ts

@@ -1 +0,0 @@
-export = stuff;

package/test/fixtures/types/export-just-namespace/good6.d.ts

@@ -1 +0,0 @@
-export = createStuff();

package/test/fixtures/types/export-just-namespace/good7.d.ts

@@ -1,3 +0,0 @@
-class Stuff {}
-namespace Stuff {}
-export = Stuff;

package/test/fixtures/types/export-just-namespace/good8.d.ts

@@ -1,3 +0,0 @@
-export = First
-namespace First {}
-declare function First()

package/test/fixtures/types/export-just-namespace/good9.d.ts

@@ -1,3 +0,0 @@
-declare namespace Second {}
-export = Second
-declare function Second<U, S>(s: U): S

package/test/fixtures/types/export-just-namespace/package.json

@@ -1,8 +0,0 @@
-{
-    "name": "@types/export-just-namespace",
-    "version": "2.0.9999",
-    "owners": [],
-    "devDependencies": {
-        "@types/export-just-namespace": "workspace:."
-    }
-}

package/test/fixtures/types/export-just-namespace/tsconfig.json

@@ -1,31 +0,0 @@
-{
-    "compilerOptions": {
-        "module": "commonjs",
-        "lib": [
-            "es6",
-            "dom"
-        ],
-        "noImplicitAny": true,
-        "noImplicitThis": true,
-        "strictFunctionTypes": true,
-        "strictNullChecks": true,
-        "types": [],
-        "noEmit": true,
-        "forceConsistentCasingInFileNames": true
-    },
-    "files": [
-        "good1.d.ts",
-        "good2.d.ts",
-        "good3.d.ts",
-        "good4.d.ts",
-        "good5.d.ts",
-        "good6.d.ts",
-        "good7.d.ts",
-        "good8.d.ts",
-        "good9.d.ts",
-        "bad1.d.ts",
-        "bad2.d.ts",
-        "bad3.d.ts",
-        "export-just-namespace-tests.ts"
-    ]
-}

package/test/fixtures/types/foo/index.d.ts

@@ -1 +0,0 @@
-export const foo = 1234;

package/test/fixtures/types/foo/package.json

@@ -1,5 +0,0 @@
-{
-    "name": "@types/foo",
-    "version": "2.0.9999",
-    "owners": []
-}

package/test/fixtures/types/foo/tsconfig.json

@@ -1,20 +0,0 @@
-{
-    "compilerOptions": {
-        "module": "commonjs",
-        "lib": [
-            "es6",
-            "dom"
-        ],
-        "noImplicitAny": true,
-        "noImplicitThis": true,
-        "strictFunctionTypes": true,
-        "strictNullChecks": true,
-        "types": [],
-        "noEmit": true,
-        "forceConsistentCasingInFileNames": true
-    },
-    "files": [
-        "index.d.ts",
-        "foo-tests.ts"
-    ]
-}

package/test/fixtures/types/foo/v1/index.d.ts

@@ -1 +0,0 @@
-export const foo = 1234;

package/test/fixtures/types/foo/v1/package.json

@@ -1,5 +0,0 @@
-{
-    "name": "@types/foo",
-    "version": "1.0.9999",
-    "owners": []
-}