@definitelytyped/eslint-plugin 0.0.192 → 0.0.193

package/test/__file_snapshots__/types/no-relative-references/index.d.ts.lint

@@ -7,9 +7,11 @@ types/no-relative-references/index.d.ts
    6:23  error  The import "./v1" resolves outside of the package. Use a bare import to reference other packages                              @definitelytyped/no-bad-reference
    7:23  error  The import "../foo/v1" resolves outside of the package. Use a bare import to reference other packages                         @definitelytyped/no-bad-reference
    9:16  error  Instead of declaring a module with `declare module "no-relative-references"`, write its contents in directly in "index.d.ts"  @definitelytyped/no-declare-current-package
+  10:3   error  Declaration file should not use a global import of itself. Use a relative import                                              @definitelytyped/no-self-import
+  11:3   error  Declaration file should not use a global import of itself. Use a relative import                                              @definitelytyped/no-self-import
   11:22  error  The import "no-relative-references/v1" resolves outside of the package. Use a bare import to reference other packages         @definitelytyped/no-bad-reference
 
-✖ 9 problems (9 errors, 0 warnings)
+✖ 11 problems (11 errors, 0 warnings)
 
 ==== types/no-relative-references/index.d.ts ====
 
@@ -39,7 +41,11 @@ types/no-relative-references/index.d.ts
                    ~~~~~~~~~~~~~~~~~~~~~~~~
 !!! @definitelytyped/no-declare-current-package: Instead of declaring a module with `declare module "no-relative-references"`, write its contents in directly in "index.d.ts".
       import A = require("no-relative-references/blah"); // Okay; relative
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Declaration file should not use a global import of itself. Use a relative import.
       import B = require("no-relative-references/v1"); // Bad; versioned subdir
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Declaration file should not use a global import of itself. Use a relative import.
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! @definitelytyped/no-bad-reference: The import "no-relative-references/v1" resolves outside of the package. Use a bare import to reference other packages.
     }

package/test/__file_snapshots__/types/no-relative-references/v1/index.d.ts.lint

@@ -8,9 +8,11 @@ types/no-relative-references/v1/index.d.ts
    8:23  error  The import "../../foo/v1" resolves outside of the package. Use a bare import to reference other packages                      @definitelytyped/no-bad-reference
    9:22  error  The import "../index" resolves outside of the package. Use a bare import to reference other packages                          @definitelytyped/no-bad-reference
   11:16  error  Instead of declaring a module with `declare module "no-relative-references"`, write its contents in directly in "index.d.ts"  @definitelytyped/no-declare-current-package
+  12:3   error  Declaration file should not use a global import of itself. Use a relative import                                              @definitelytyped/no-self-import
+  13:3   error  Declaration file should not use a global import of itself. Use a relative import                                              @definitelytyped/no-self-import
   14:22  error  The import "../index" resolves outside of the package. Use a bare import to reference other packages                          @definitelytyped/no-bad-reference
 
-✖ 10 problems (10 errors, 0 warnings)
+✖ 12 problems (12 errors, 0 warnings)
 
 ==== types/no-relative-references/v1/index.d.ts ====
 
@@ -44,7 +46,11 @@ types/no-relative-references/v1/index.d.ts
                    ~~~~~~~~~~~~~~~~~~~~~~~~
 !!! @definitelytyped/no-declare-current-package: Instead of declaring a module with `declare module "no-relative-references"`, write its contents in directly in "index.d.ts".
       import A = require("no-relative-references/blah"); // Okay; relative
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Declaration file should not use a global import of itself. Use a relative import.
       import B = require("no-relative-references/v1"); // Okay; no versioned dir here
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Declaration file should not use a global import of itself. Use a relative import.
       import C = require("../index"); // Bad; parent dir
                          ~~~~~~~~~~
 !!! @definitelytyped/no-bad-reference: The import "../index" resolves outside of the package. Use a bare import to reference other packages.

package/test/__file_snapshots__/types/no-self-import/bad.d.ts.lint

@@ -1,13 +1,20 @@
 types/no-self-import/bad.d.ts
-  1:1  error  Declaration file should not use a global import of itself. Use a relative import  @definitelytyped/no-self-import
-  2:1  error  Declaration file should not use a global import of itself. Use a relative import  @definitelytyped/no-self-import
-  4:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
-  5:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
-  6:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
-  7:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
-  8:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
+   1:1  error  Declaration file should not use a global import of itself. Use a relative import  @definitelytyped/no-self-import
+   2:1  error  Declaration file should not use a global import of itself. Use a relative import  @definitelytyped/no-self-import
+   4:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
+   5:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
+   6:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
+   7:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
+   8:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
+  10:1  error  Declaration file should not use a global import of itself. Use a relative import  @definitelytyped/no-self-import
+  11:1  error  Declaration file should not use a global import of itself. Use a relative import  @definitelytyped/no-self-import
+  13:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
+  14:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
+  15:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
+  16:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
+  17:1  error  Don't import an old version of the current package                                @definitelytyped/no-self-import
 
-✖ 7 problems (7 errors, 0 warnings)
+✖ 14 problems (14 errors, 0 warnings)
 
 ==== types/no-self-import/bad.d.ts ====
 
@@ -33,3 +40,26 @@ types/no-self-import/bad.d.ts
     import old5 from "./v0.1/index"
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! @definitelytyped/no-self-import: Don't import an old version of the current package.
+    
+    import myselfRequired = require("no-self-import");
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Declaration file should not use a global import of itself. Use a relative import.
+    import abcRequired = require("no-self-import/abc.d.ts");
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Declaration file should not use a global import of itself. Use a relative import.
+    
+    import old1Required = require("./v11");
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Don't import an old version of the current package.
+    import old2Required = require("./v11/index");
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Don't import an old version of the current package.
+    import old3Required = require("./v11/subdir/file");
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Don't import an old version of the current package.
+    import old4Required = require("./v0.1");
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Don't import an old version of the current package.
+    import old5Required = require("./v0.1/index");
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Don't import an old version of the current package.

package/test/__file_snapshots__/types/no-self-import/index.d.ts.lint

@@ -9,3 +9,11 @@ No errors
     import old from "./v1gardenpath"
     
     import old from "./v1verb/other"
+    
+    import otherRequired = require("other-package");
+    
+    import otherRequired = require("other-package/this-package");
+    
+    import oldRequired = require("./v1gardenpath");
+    
+    import oldRequired = require("./v1verb/other");

package/test/__file_snapshots__/types/no-self-import/no-self-import-tests.ts.lint

@@ -1,24 +1,39 @@
 types/no-self-import/no-self-import-tests.ts
   1:1  error  Do not use a triple slash reference for devdep, use `import` style instead       @typescript-eslint/triple-slash-reference
+  1:1  error  Do not use a triple slash reference for devdep, use `import` style instead       @typescript-eslint/triple-slash-reference
+  2:1  error  Do not use a triple slash reference for otherdevdep, use `import` style instead  @typescript-eslint/triple-slash-reference
   2:1  error  Do not use a triple slash reference for otherdevdep, use `import` style instead  @typescript-eslint/triple-slash-reference
   3:1  error  Do not use a triple slash reference for other, use `import` style instead        @typescript-eslint/triple-slash-reference
+  3:1  error  Do not use a triple slash reference for other, use `import` style instead        @typescript-eslint/triple-slash-reference
 
-✖ 3 problems (3 errors, 0 warnings)
+✖ 6 problems (6 errors, 0 warnings)
 
 ==== types/no-self-import/no-self-import-tests.ts ====
 
     /// <reference types="devdep"/>
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @typescript-eslint/triple-slash-reference: Do not use a triple slash reference for devdep, use `import` style instead.
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! @typescript-eslint/triple-slash-reference: Do not use a triple slash reference for devdep, use `import` style instead.
     /// <reference types="otherdevdep"/>
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @typescript-eslint/triple-slash-reference: Do not use a triple slash reference for otherdevdep, use `import` style instead.
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! @typescript-eslint/triple-slash-reference: Do not use a triple slash reference for otherdevdep, use `import` style instead.
     /// <reference types="other"/>
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! @typescript-eslint/triple-slash-reference: Do not use a triple slash reference for other, use `import` style instead.
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @typescript-eslint/triple-slash-reference: Do not use a triple slash reference for other, use `import` style instead.
     
     import other from "other";
     import self from "no-import-of-dev-dependencies";
     
     import devdep from "devdep";
     import * as otherdevdep from "otherdevdep";
+    
+    import otherRequired = require("other");
+    import selfRequired = require("no-import-of-dev-dependencies");
+    
+    import devdepRequired = require("devdep");
+    import otherdevdepRequired = require("otherdevdep");

package/test/__file_snapshots__/types/scoped__no-relative-references/index.d.ts.lint

@@ -7,9 +7,11 @@ types/scoped__no-relative-references/index.d.ts
    6:23  error  The import "./v1" resolves outside of the package. Use a bare import to reference other packages                                      @definitelytyped/no-bad-reference
    7:23  error  The import "../foo/v1" resolves outside of the package. Use a bare import to reference other packages                                 @definitelytyped/no-bad-reference
    9:16  error  Instead of declaring a module with `declare module "@scoped/no-relative-references"`, write its contents in directly in "index.d.ts"  @definitelytyped/no-declare-current-package
+  10:3   error  Declaration file should not use a global import of itself. Use a relative import                                                      @definitelytyped/no-self-import
+  11:3   error  Declaration file should not use a global import of itself. Use a relative import                                                      @definitelytyped/no-self-import
   11:22  error  The import "@scoped/no-relative-references/v1" resolves outside of the package. Use a bare import to reference other packages         @definitelytyped/no-bad-reference
 
-✖ 9 problems (9 errors, 0 warnings)
+✖ 11 problems (11 errors, 0 warnings)
 
 ==== types/scoped__no-relative-references/index.d.ts ====
 
@@ -39,7 +41,11 @@ types/scoped__no-relative-references/index.d.ts
                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! @definitelytyped/no-declare-current-package: Instead of declaring a module with `declare module "@scoped/no-relative-references"`, write its contents in directly in "index.d.ts".
       import A = require("@scoped/no-relative-references/blah"); // Okay; relative
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Declaration file should not use a global import of itself. Use a relative import.
       import B = require("@scoped/no-relative-references/v1"); // Bad; versioned subdir
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Declaration file should not use a global import of itself. Use a relative import.
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! @definitelytyped/no-bad-reference: The import "@scoped/no-relative-references/v1" resolves outside of the package. Use a bare import to reference other packages.
     }

package/test/__file_snapshots__/types/scoped__no-relative-references/v1/index.d.ts.lint

@@ -8,9 +8,11 @@ types/scoped__no-relative-references/v1/index.d.ts
    8:23  error  The import "../../foo/v1" resolves outside of the package. Use a bare import to reference other packages                              @definitelytyped/no-bad-reference
    9:22  error  The import "../index" resolves outside of the package. Use a bare import to reference other packages                                  @definitelytyped/no-bad-reference
   11:16  error  Instead of declaring a module with `declare module "@scoped/no-relative-references"`, write its contents in directly in "index.d.ts"  @definitelytyped/no-declare-current-package
+  12:3   error  Declaration file should not use a global import of itself. Use a relative import                                                      @definitelytyped/no-self-import
+  13:3   error  Declaration file should not use a global import of itself. Use a relative import                                                      @definitelytyped/no-self-import
   14:22  error  The import "../index" resolves outside of the package. Use a bare import to reference other packages                                  @definitelytyped/no-bad-reference
 
-✖ 10 problems (10 errors, 0 warnings)
+✖ 12 problems (12 errors, 0 warnings)
 
 ==== types/scoped__no-relative-references/v1/index.d.ts ====
 
@@ -44,7 +46,11 @@ types/scoped__no-relative-references/v1/index.d.ts
                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! @definitelytyped/no-declare-current-package: Instead of declaring a module with `declare module "@scoped/no-relative-references"`, write its contents in directly in "index.d.ts".
       import A = require("@scoped/no-relative-references/blah"); // Okay; relative
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Declaration file should not use a global import of itself. Use a relative import.
       import B = require("@scoped/no-relative-references/v1"); // Okay; no versioned dir here
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! @definitelytyped/no-self-import: Declaration file should not use a global import of itself. Use a relative import.
       import C = require("../index"); // Bad; parent dir
                          ~~~~~~~~~~
 !!! @definitelytyped/no-bad-reference: The import "../index" resolves outside of the package. Use a bare import to reference other packages.

package/test/eslint.test.ts

@@ -29,7 +29,7 @@ let eslint: ESLint;
 beforeAll(() => {
   eslint = new ESLint({
     cwd: fixtureRoot,
-    plugins: { "@definitelytyped/eslint-plugin": plugin as unknown as ESLint.Plugin },
+    plugins: { [plugin.meta.name]: plugin },
   });
 });
 

package/test/fixtures/types/no-import-of-dev-dependencies/bad.d.ts

@@ -3,3 +3,6 @@
 
 import devdep from "devdep";
 import * as otherdevdep from "otherdevdep";
+
+import devdep2 = require("devdep");
+import otherdevdep2 = require("otherdevdep");

package/test/fixtures/types/no-import-of-dev-dependencies/index.d.ts

@@ -2,3 +2,6 @@
 
 import other from "other";
 import self from "no-import-of-dev-dependencies";
+
+import other2 = require("other");
+import self2 = require("no-import-of-dev-dependencies");

package/test/fixtures/types/no-import-of-dev-dependencies/no-import-of-dev-dependencies-tests.ts

@@ -7,3 +7,9 @@ import self from "no-import-of-dev-dependencies";
 
 import devdep from "devdep";
 import * as otherdevdep from "otherdevdep";
+
+import other2 = require("other");
+import self2 = require("no-import-of-dev-dependencies");
+
+import devdep2 = require("devdep");
+import otherdevdep2 = require("otherdevdep");

package/test/fixtures/types/no-relative-import-in-test/index.d.ts

@@ -0,0 +1 @@
+export function getFoo(): "foo";

package/test/fixtures/types/no-relative-import-in-test/no-relative-import-in-test-tests3.ts

@@ -0,0 +1 @@
+import util = require('./');

package/test/fixtures/types/no-relative-import-in-test/tsconfig.json

@@ -18,6 +18,7 @@
         "bad.d.ts",
         "no-relative-import-in-test-tests.ts",
         "no-relative-import-in-test-tests2.ts",
+        "no-relative-import-in-test-tests3.ts",
         "./abc.d.ts",
         "./no-relative-import-in-test/abc.d.ts"
     ]

package/test/fixtures/types/no-self-import/bad.d.ts

@@ -6,3 +6,12 @@ import old2 from "./v11/index";
 import old3 from "./v11/subdir/file";
 import old4 from "./v0.1"
 import old5 from "./v0.1/index"
+
+import myselfRequired = require("no-self-import");
+import abcRequired = require("no-self-import/abc.d.ts");
+
+import old1Required = require("./v11");
+import old2Required = require("./v11/index");
+import old3Required = require("./v11/subdir/file");
+import old4Required = require("./v0.1");
+import old5Required = require("./v0.1/index");

package/test/fixtures/types/no-self-import/index.d.ts

@@ -5,3 +5,11 @@ import other from "other-package/this-package";
 import old from "./v1gardenpath"
 
 import old from "./v1verb/other"
+
+import otherRequired = require("other-package");
+
+import otherRequired = require("other-package/this-package");
+
+import oldRequired = require("./v1gardenpath");
+
+import oldRequired = require("./v1verb/other");

package/test/fixtures/types/no-self-import/no-self-import-tests.ts

@@ -7,3 +7,9 @@ import self from "no-import-of-dev-dependencies";
 
 import devdep from "devdep";
 import * as otherdevdep from "otherdevdep";
+
+import otherRequired = require("other");
+import selfRequired = require("no-import-of-dev-dependencies");
+
+import devdepRequired = require("devdep");
+import otherdevdepRequired = require("otherdevdep");