@definitelytyped/eslint-plugin 0.0.187 → 0.0.189

package/test/fixtures/types/no-self-import/index.d.ts

@@ -0,0 +1,7 @@
+import other from "other-package";
+
+import other from "other-package/this-package";
+
+import old from "./v1gardenpath"
+
+import old from "./v1verb/other"

package/test/fixtures/types/no-self-import/no-self-import-tests.ts

@@ -0,0 +1,9 @@
+/// <reference types="devdep"/>
+/// <reference types="otherdevdep"/>
+/// <reference types="other"/>
+
+import other from "other";
+import self from "no-import-of-dev-dependencies";
+
+import devdep from "devdep";
+import * as otherdevdep from "otherdevdep";

package/test/fixtures/types/no-self-import/package.json

@@ -0,0 +1,11 @@
+{
+    "name": "@types/no-self-import",
+    "version": "2.0.9999",
+    "owners": [],
+    "dependencies": {
+        "other-package": "*"
+    },
+    "devDependencies": {
+        "@types/no-self-import": "workspace:."
+    }
+}

package/test/fixtures/types/no-self-import/tsconfig.json

@@ -0,0 +1,20 @@
+{
+    "compilerOptions": {
+        "module": "commonjs",
+        "lib": [
+            "es6",
+            "dom"
+        ],
+        "noImplicitAny": true,
+        "noImplicitThis": true,
+        "strictFunctionTypes": true,
+        "strictNullChecks": true,
+        "types": [],
+        "noEmit": true,
+        "forceConsistentCasingInFileNames": true
+    },
+    "files": [
+        "index.d.ts",
+        "no-import-of-dev-dependencies-tests.ts"
+    ]
+}

package/test/fixtures/types/other/index.d.ts

@@ -0,0 +1 @@
+export const foo = 1234;

package/test/fixtures/types/other/package.json

@@ -0,0 +1,5 @@
+{
+    "name": "@types/other",
+    "version": "2.0.9999",
+    "owners": []
+}

package/test/fixtures/types/other/tsconfig.json

@@ -0,0 +1,20 @@
+{
+    "compilerOptions": {
+        "module": "commonjs",
+        "lib": [
+            "es6",
+            "dom"
+        ],
+        "noImplicitAny": true,
+        "noImplicitThis": true,
+        "strictFunctionTypes": true,
+        "strictNullChecks": true,
+        "types": [],
+        "noEmit": true,
+        "forceConsistentCasingInFileNames": true
+    },
+    "files": [
+        "index.d.ts",
+        "foo-tests.ts"
+    ]
+}

package/test/fixtures/types/other/v1/index.d.ts

@@ -0,0 +1 @@
+export const foo = 1234;

package/test/fixtures/types/other/v1/package.json

@@ -0,0 +1,5 @@
+{
+    "name": "@types/other",
+    "version": "1.0.9999",
+    "owners": []
+}

package/test/fixtures/types/other/v1/tsconfig.json

@@ -0,0 +1,20 @@
+{
+    "compilerOptions": {
+        "module": "commonjs",
+        "lib": [
+            "es6",
+            "dom"
+        ],
+        "noImplicitAny": true,
+        "noImplicitThis": true,
+        "strictFunctionTypes": true,
+        "strictNullChecks": true,
+        "types": [],
+        "noEmit": true,
+        "forceConsistentCasingInFileNames": true
+    },
+    "files": [
+        "index.d.ts",
+        "foo-tests.ts"
+    ]
+}

package/test/fixtures/types/scoped__foo/index.d.ts

@@ -0,0 +1 @@
+export const foo = 1234;

package/test/fixtures/types/scoped__foo/package.json

@@ -0,0 +1,5 @@
+{
+    "name": "@types/scoped__foo",
+    "version": "2.0.9999",
+    "owners": []
+}

package/test/fixtures/types/scoped__foo/tsconfig.json

@@ -0,0 +1,20 @@
+{
+    "compilerOptions": {
+        "module": "commonjs",
+        "lib": [
+            "es6",
+            "dom"
+        ],
+        "noImplicitAny": true,
+        "noImplicitThis": true,
+        "strictFunctionTypes": true,
+        "strictNullChecks": true,
+        "types": [],
+        "noEmit": true,
+        "forceConsistentCasingInFileNames": true
+    },
+    "files": [
+        "index.d.ts",
+        "foo-tests.ts"
+    ]
+}

package/test/fixtures/types/scoped__foo/v1/index.d.ts

@@ -0,0 +1 @@
+export const foo = 1234;

package/test/fixtures/types/scoped__foo/v1/package.json

@@ -0,0 +1,5 @@
+{
+    "name": "@types/scoped__foo",
+    "version": "1.0.9999",
+    "owners": []
+}

package/test/fixtures/types/scoped__foo/v1/tsconfig.json

@@ -0,0 +1,20 @@
+{
+    "compilerOptions": {
+        "module": "commonjs",
+        "lib": [
+            "es6",
+            "dom"
+        ],
+        "noImplicitAny": true,
+        "noImplicitThis": true,
+        "strictFunctionTypes": true,
+        "strictNullChecks": true,
+        "types": [],
+        "noEmit": true,
+        "forceConsistentCasingInFileNames": true
+    },
+    "files": [
+        "index.d.ts",
+        "foo-tests.ts"
+    ]
+}

package/test/fixtures/types/scoped__no-declare-current-package/index.d.ts

@@ -0,0 +1 @@
+declare module "@scoped/no-declare-current-package" { }

package/test/fixtures/types/scoped__no-declare-current-package/package.json

@@ -0,0 +1,8 @@
+{
+    "name": "@types/scoped__no-declare-current-package",
+    "version": "2.0.9999",
+    "owners": [],
+    "devDependencies": {
+        "@types/scoped__no-declare-current-package": "workspace:."
+    }
+}

package/test/fixtures/types/scoped__no-declare-current-package/test/deep/import.d.ts

@@ -0,0 +1 @@
+declare module "@scoped/no-declare-current-package/deep/import" { }

package/test/fixtures/types/scoped__no-declare-current-package/tsconfig.json

@@ -0,0 +1,20 @@
+{
+    "compilerOptions": {
+        "module": "commonjs",
+        "lib": [
+            "es6",
+            "dom"
+        ],
+        "noImplicitAny": true,
+        "noImplicitThis": true,
+        "strictFunctionTypes": true,
+        "strictNullChecks": true,
+        "types": [],
+        "noEmit": true,
+        "forceConsistentCasingInFileNames": true
+    },
+    "files": [
+        "index.d.ts",
+        "no-import-of-dev-dependencies-tests.ts"
+    ]
+}

package/test/fixtures/types/scoped__no-relative-references/index.d.ts

@@ -0,0 +1,12 @@
+/// <reference path="../foo/index.d.ts" />
+/// <reference path="./v1/index.d.ts" />
+/// <reference path="../foo/v1/index.d.ts" />
+
+import * as foo from "../foo";
+import * as foo2 from "./v1";
+import * as foo3 from "../foo/v1";
+
+declare module "@scoped/no-relative-references" {
+  import A = require("@scoped/no-relative-references/blah"); // Okay; relative
+  import B = require("@scoped/no-relative-references/v1"); // Bad; versioned subdir
+}

package/test/fixtures/types/scoped__no-relative-references/other/other.d.ts

@@ -0,0 +1,7 @@
+/// <reference path="../../foo/index.d.ts" />
+/// <reference path="../v1/index.d.ts" />
+/// <reference path="../../foo/v1/index.d.ts" />
+
+import * as foo from "../../foo";
+import * as foo2 from "../v1";
+import * as foo3 from "../../foo/v1";

package/test/fixtures/types/scoped__no-relative-references/package.json

@@ -0,0 +1,5 @@
+{
+    "name": "@types/scoped__no-relative-references",
+    "version": "2.0.9999",
+    "owners": []
+}

package/test/fixtures/types/scoped__no-relative-references/tsconfig.json

@@ -0,0 +1,20 @@
+{
+    "compilerOptions": {
+        "module": "commonjs",
+        "lib": [
+            "es6",
+            "dom"
+        ],
+        "noImplicitAny": true,
+        "noImplicitThis": true,
+        "strictFunctionTypes": true,
+        "strictNullChecks": true,
+        "types": [],
+        "noEmit": true,
+        "forceConsistentCasingInFileNames": true
+    },
+    "files": [
+        "index.d.ts",
+        "no-relative-references-tests.ts"
+    ]
+}

package/test/fixtures/types/scoped__no-relative-references/v1/index.d.ts

@@ -0,0 +1,15 @@
+/// <reference path="../../foo/index.d.ts" />
+/// <reference path="../v1/index.d.ts" />
+/// <reference path="../../foo/v1/index.d.ts" />
+/// <reference path="../index.d.ts" />
+
+import * as foo from "../../foo";
+import * as foo2 from "../v1";
+import * as foo3 from "../../foo/v1";
+import * as va4 from "../index";
+
+declare module "@scoped/no-relative-references" {
+  import A = require("@scoped/no-relative-references/blah"); // Okay; relative
+  import B = require("@scoped/no-relative-references/v1"); // Okay; no versioned dir here
+  import C = require("../index"); // Bad; parent dir
+}

package/test/fixtures/types/scoped__no-relative-references/v1/other/other.d.ts

@@ -0,0 +1,7 @@
+/// <reference path="../../../foo/index.d.ts" />
+/// <reference path="../../v1/index.d.ts" />
+/// <reference path="../../../foo/v1/index.d.ts" />
+
+import * as foo from "../../../foo";
+import * as foo2 from "../../v1";
+import * as foo3 from "../../../foo/v1";

package/test/fixtures/types/scoped__no-relative-references/v1/package.json

@@ -0,0 +1,5 @@
+{
+    "name": "@types/scoped__no-relative-references",
+    "version": "1.0.9999",
+    "owners": []
+}

package/test/fixtures/types/scoped__no-relative-references/v1/tsconfig.json

@@ -0,0 +1,20 @@
+{
+    "compilerOptions": {
+        "module": "commonjs",
+        "lib": [
+            "es6",
+            "dom"
+        ],
+        "noImplicitAny": true,
+        "noImplicitThis": true,
+        "strictFunctionTypes": true,
+        "strictNullChecks": true,
+        "types": [],
+        "noEmit": true,
+        "forceConsistentCasingInFileNames": true
+    },
+    "files": [
+        "index.d.ts",
+        "no-relative-references-tests.ts"
+    ]
+}

package/test/no-bad-reference.test.ts

@@ -1,134 +1,127 @@
-import { ESLintUtils } from "@typescript-eslint/utils";
+import { runTestsWithFixtures } from "./fixtureTester";
+import * as rule from "../src/rules/no-bad-reference";
 
-import * as noBadReference from "../src/rules/no-bad-reference";
-
-const ruleTester = new ESLintUtils.RuleTester({
-  parser: "@typescript-eslint/parser",
-});
-
-ruleTester.run("@definitelytyped/no-bad-reference", noBadReference, {
+runTestsWithFixtures("@definitelytyped/no-bad-reference", rule, {
+  valid: [
+    {
+      filename: "types/foo/index.d.ts",
+    },
+  ],
   invalid: [
     {
-      code: `/// <reference path="../other" />`,
+      filename: "types/no-relative-references/index.d.ts",
       errors: [
-        {
-          column: 20,
-          endColumn: 28,
-          line: 1,
-          messageId: "referencePathTest",
-        },
+        { messageId: "referenceOutside", data: { text: "../foo/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "./v1/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../foo/v1/index.d.ts" } },
+        { messageId: "importOutside", data: { text: "../foo" } },
+        { messageId: "importOutside", data: { text: "./v1" } },
+        { messageId: "importOutside", data: { text: "../foo/v1" } },
+        { messageId: "importOutside", data: { text: "no-relative-references/v1" } },
       ],
-      filename: "types.ts",
     },
     {
-      code: `/// <reference path="other" />`,
+      filename: "types/no-relative-references/other/other.d.ts",
       errors: [
-        {
-          column: 20,
-          endColumn: 25,
-          line: 1,
-          messageId: "referencePathTest",
-        },
+        { messageId: "referenceOutside", data: { text: "../../foo/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../v1/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../../foo/v1/index.d.ts" } },
+        { messageId: "importOutside", data: { text: "../../foo" } },
+        { messageId: "importOutside", data: { text: "../v1" } },
+        { messageId: "importOutside", data: { text: "../../foo/v1" } },
       ],
-      filename: "types.ts",
     },
     {
-      code: `/// <reference path="../other" />`,
+      filename: "types/no-relative-references/v1/index.d.ts",
       errors: [
-        {
-          column: 20,
-          endColumn: 28,
-          line: 1,
-          messageId: "referencePathPackage",
-        },
+        { messageId: "referenceOutside", data: { text: "../../foo/index.d.ts" } },
+        { messageId: "referenceLeaves", data: { text: "../v1/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../../foo/v1/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../index.d.ts" } },
+        { messageId: "importOutside", data: { text: "../../foo" } },
+        { messageId: "importLeaves", data: { text: "../v1" } },
+        { messageId: "importOutside", data: { text: "../../foo/v1" } },
+        { messageId: "importOutside", data: { text: "../index" } },
+        { messageId: "importOutside", data: { text: "../index" } },
       ],
-      filename: "types.d.ts",
     },
     {
-      code: `/// <reference path="./v11" />`,
+      filename: "types/no-relative-references/v1/other/other.d.ts",
       errors: [
-        {
-          column: 20,
-          endColumn: 25,
-          line: 1,
-          messageId: "referencePathOldVersion",
-        },
+        { messageId: "referenceOutside", data: { text: "../../../foo/index.d.ts" } },
+        { messageId: "referenceLeaves", data: { text: "../../v1/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../../../foo/v1/index.d.ts" } },
+        { messageId: "importOutside", data: { text: "../../../foo" } },
+        { messageId: "importLeaves", data: { text: "../../v1" } },
+        { messageId: "importOutside", data: { text: "../../../foo/v1" } },
       ],
-      filename: "types.d.ts",
     },
     {
-      code: `/// <reference path="./v11/index" />`,
+      filename: "types/scoped__no-relative-references/index.d.ts",
       errors: [
-        {
-          column: 20,
-          endColumn: 31,
-          line: 1,
-          messageId: "referencePathOldVersion",
-        },
+        { messageId: "referenceOutside", data: { text: "../foo/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "./v1/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../foo/v1/index.d.ts" } },
+        { messageId: "importOutside", data: { text: "../foo" } },
+        { messageId: "importOutside", data: { text: "./v1" } },
+        { messageId: "importOutside", data: { text: "../foo/v1" } },
+        { messageId: "importOutside", data: { text: "@scoped/no-relative-references/v1" } },
       ],
-      filename: "types.d.ts",
     },
     {
-      code: `/// <reference path="./v11/subdir/file" />`,
+      filename: "types/scoped__no-relative-references/other/other.d.ts",
       errors: [
-        {
-          column: 20,
-          endColumn: 37,
-          line: 1,
-          messageId: "referencePathOldVersion",
-        },
+        { messageId: "referenceOutside", data: { text: "../../foo/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../v1/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../../foo/v1/index.d.ts" } },
+        { messageId: "importOutside", data: { text: "../../foo" } },
+        { messageId: "importOutside", data: { text: "../v1" } },
+        { messageId: "importOutside", data: { text: "../../foo/v1" } },
       ],
-      filename: "types.d.ts",
     },
     {
-      code: `/// <reference path="./v0.1" />`,
+      filename: "types/scoped__no-relative-references/v1/index.d.ts",
       errors: [
-        {
-          column: 20,
-          endColumn: 26,
-          line: 1,
-          messageId: "referencePathOldVersion",
-        },
+        { messageId: "referenceOutside", data: { text: "../../foo/index.d.ts" } },
+        { messageId: "referenceLeaves", data: { text: "../v1/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../../foo/v1/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../index.d.ts" } },
+        { messageId: "importOutside", data: { text: "../../foo" } },
+        { messageId: "importLeaves", data: { text: "../v1" } },
+        { messageId: "importOutside", data: { text: "../../foo/v1" } },
+        { messageId: "importOutside", data: { text: "../index" } },
+        { messageId: "importOutside", data: { text: "../index" } },
       ],
-      filename: "types.d.ts",
     },
     {
-      code: `/// <reference path="./v0.1/index" />`,
+      filename: "types/scoped__no-relative-references/v1/other/other.d.ts",
       errors: [
-        {
-          column: 20,
-          endColumn: 32,
-          line: 1,
-          messageId: "referencePathOldVersion",
-        },
+        { messageId: "referenceOutside", data: { text: "../../../foo/index.d.ts" } },
+        { messageId: "referenceLeaves", data: { text: "../../v1/index.d.ts" } },
+        { messageId: "referenceOutside", data: { text: "../../../foo/v1/index.d.ts" } },
+        { messageId: "importOutside", data: { text: "../../../foo" } },
+        { messageId: "importLeaves", data: { text: "../../v1" } },
+        { messageId: "importOutside", data: { text: "../../../foo/v1" } },
       ],
-      filename: "types.d.ts",
     },
-  ],
-  valid: [
-    ``,
-    `// unrelated comment`,
-    `/// similar (reference path) comment`,
     {
-      code: `/// <reference path="other" />`,
-      filename: "types.d.ts",
-    },
-    {
-      code: `/// <reference path="./other" />`,
-      filename: "types.d.ts",
-    },
-    {
-      code: `/// <reference path="./v1gardenpath" />`,
-      filename: "types.d.ts",
-    },
-    {
-      code: `/// <reference path="./v1verb/other" />`,
-      filename: "types.d.ts",
+      filename: "types/no-bad-reference/index.d.ts",
+      errors: [
+        { messageId: "referenceOutside", data: { text: "../other" } },
+        { messageId: "referenceOutside", data: { text: "./v11" } },
+        { messageId: "referenceOutside", data: { text: "./v11/index" } },
+        { messageId: "referenceOutside", data: { text: "./v11/subdir/file" } },
+        { messageId: "referenceOutside", data: { text: "./v0.1" } },
+        { messageId: "referenceOutside", data: { text: "./v0.1/index" } },
+        { messageId: "backslashes", line: 13 },
+      ],
     },
     {
-      code: `/// <reference path="other" />
-/// <reference path="other2" />`,
-      filename: "types.d.ts",
+      filename: "types/no-bad-reference/no-bad-reference-tests.ts",
+      errors: [
+        { messageId: "testReference", data: { text: "../other" } },
+        { messageId: "testReference", data: { text: "other" } },
+      ],
     },
   ],
 });