@definitelytyped/eslint-plugin 0.0.179 → 0.0.181

package/src/rules/dt-header.ts

@@ -1,74 +0,0 @@
-import { renderExpected, validate } from "@definitelytyped/header-parser";
-import { createRule, isMainFile } from "../util";
-
-type MessageId =
-  | "definitionsBy"
-  | "minimumTypeScriptVersion"
-  | "parseError"
-  | "typeDefinitionsFor"
-  | "typescriptVersion";
-
-const rule = createRule({
-  name: "dt-header",
-  defaultOptions: [],
-  meta: {
-    type: "problem",
-    docs: {
-      description: "Ensure consistency of DefinitelyTyped headers.",
-      recommended: "error",
-    },
-    messages: {
-      definitionsBy: "Author name should be your name, not the default.",
-      minimumTypeScriptVersion: "TypeScript version should be specified under header in `index.d.ts`.",
-      parseError: "Error parsing header. Expected: {{expected}}",
-      typeDefinitionsFor: "Header should only be in `index.d.ts` of the root.",
-      typescriptVersion: "Minimum TypeScript version should be specified under header in `index.d.ts`.",
-    },
-    schema: [],
-  },
-  create(context) {
-    const sourceCode = context.getSourceCode();
-    const { lines, text } = sourceCode;
-
-    const lookFor = (search: string, messageId: MessageId) => {
-      for (let i = 0; i < lines.length; i += 1) {
-        if (lines[i].startsWith(search)) {
-          context.report({
-            loc: {
-              end: { line: i + 1, column: search.length },
-              start: { line: i + 1, column: 0 },
-            },
-            messageId,
-          });
-        }
-      }
-    };
-
-    if (!isMainFile(context.getFilename(), /*allowNested*/ true)) {
-      lookFor("// Type definitions for", "typeDefinitionsFor");
-      lookFor("// TypeScript Version", "typescriptVersion");
-      lookFor("// Minimum TypeScript Version", "minimumTypeScriptVersion");
-      return {};
-    }
-
-    lookFor("// Definitions by: My Self", "definitionsBy");
-
-    const error = validate(text);
-    if (error) {
-      context.report({
-        data: {
-          expected: renderExpected(error.expected),
-        },
-        loc: {
-          column: error.column,
-          line: error.line,
-        },
-        messageId: "parseError",
-      });
-    }
-
-    return {};
-  },
-});
-
-export = rule;

package/src/rules/no-outside-dependencies.ts

@@ -1,42 +0,0 @@
-import { createRule, isMainFile } from "../util";
-import { ESLintUtils } from "@typescript-eslint/utils";
-const rule = createRule({
-  name: "no-outside-dependencies",
-  defaultOptions: [],
-  meta: {
-    type: "problem",
-    docs: {
-      description: "Don't import things in `DefinitelyTyped/node_modules`.",
-      recommended: "error",
-    },
-    messages: {
-      noOutsideDependencies: `File {{fileName}} comes from a \`node_modules\` but is not declared in this type's \`package.json\`. `,
-    },
-    schema: [],
-  },
-  create(context) {
-    if (isMainFile(context.getFilename(), /*allowNested*/ true)) {
-      const parserServices = ESLintUtils.getParserServices(context);
-      const hasNodeReference = parserServices.program
-        .getSourceFiles()
-        .some((f) => f.typeReferenceDirectives.some((dir) => dir.fileName === "node"));
-      for (const sourceFile of parserServices.program.getSourceFiles()) {
-        const fileName = sourceFile.fileName;
-        if (
-          fileName.includes("/DefinitelyTyped/node_modules/") &&
-          !parserServices.program.isSourceFileDefaultLibrary(sourceFile) &&
-          !(hasNodeReference && fileName.includes("buffer"))
-        ) {
-          context.report({
-            messageId: "noOutsideDependencies",
-            data: { fileName },
-            loc: { column: 0, line: 1 },
-          });
-        }
-      }
-    }
-    return {};
-  },
-});
-
-export = rule;

package/test/dt-header.test.ts

@@ -1,189 +0,0 @@
-import { ESLintUtils } from "@typescript-eslint/utils";
-
-import * as dtHeader from "../src/rules/dt-header";
-
-const ruleTester = new ESLintUtils.RuleTester({
-  parser: "@typescript-eslint/parser",
-});
-
-ruleTester.run("@definitelytyped/dt-header", dtHeader, {
-  invalid: [
-    {
-      code: ``,
-      errors: [
-        {
-          column: 2,
-          data: {
-            expected: "/\\/\\/ Type definitions for (non-npm package )?/",
-          },
-          line: 1,
-          messageId: "parseError",
-        },
-      ],
-      filename: "types/blank/index.d.ts",
-    },
-    {
-      code: `
-      // ...
-      `,
-      errors: [
-        {
-          column: 1,
-          data: {
-            expected: "/\\/\\/ Type definitions for (non-npm package )?/",
-          },
-          line: 2,
-          messageId: "parseError",
-        },
-      ],
-      filename: "types/only-comment/index.d.ts",
-    },
-    {
-      code: `
-// Type definitions for dt-header 0.75
-// Project: https://github.com/bobby-headers/dt-header
-// Definitions by: Jane Doe <https://github.com/janedoe>
-// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-// Minimum TypeScript Version: 3.1
-      
-`,
-      errors: [
-        {
-          column: 1,
-          data: {
-            expected: "/\\/\\/ Type definitions for (non-npm package )?/",
-          },
-          line: 2,
-          messageId: "parseError",
-        },
-      ],
-      filename: "types/start-with-whitespace/index.d.ts",
-    },
-    {
-      code: `// Type definitions for dt-header 1.0
-// Project: https://github.com/bobby-headers/dt-header
-// Definitions by: Jane Doe <https://github.ORG/janedoe>
-// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-`,
-      errors: [
-        {
-          column: 30,
-          data: {
-            expected: "/\\<https\\:\\/\\/github\\.com\\/([a-zA-Z\\d\\-]+)\\/?\\>/",
-          },
-          line: 3,
-          messageId: "parseError",
-        },
-      ],
-      filename: "types/bad-url-github-org/index.d.ts",
-    },
-    {
-      code: `// Type definitions for dt-header 1.0
-// Project: https://github.com/bobby-headers/dt-header
-// Definitions by: Jane Doe <https://github.com/jane doe>
-// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-`,
-      errors: [
-        {
-          column: 30,
-          data: {
-            expected: "/\\<https\\:\\/\\/github\\.com\\/([a-zA-Z\\d\\-]+)\\/?\\>/",
-          },
-          line: 3,
-          messageId: "parseError",
-        },
-      ],
-      filename: "types/bad-url-space/index.d.ts",
-    },
-    {
-      code: `// Type definitions for dt-header 1.0
-// Project: https://github.com/not/important
-// Definitions by: My Self <https://github.com/me>
-// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-      
-`,
-      errors: [
-        {
-          column: 1,
-          endColumn: 27,
-          line: 3,
-          messageId: "definitionsBy",
-        },
-      ],
-      filename: "types/bad-username/index.d.ts",
-    },
-    {
-      code: `// Type definitions for dt-header v1.0.3
-// Project: https://github.com/bobby-headers/dt-header
-// Definitions by: Jane Doe <https://github.com/janedoe>
-// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-`,
-      errors: [
-        {
-          column: 26,
-          data: {
-            expected: "foo MAJOR.MINOR (patch version not allowed)",
-          },
-          line: 1,
-          messageId: "parseError",
-        },
-      ],
-      filename: "types/foo/index.d.ts",
-    },
-    {
-      code: `// Type definitions for
-`,
-      errors: [
-        {
-          column: 1,
-          endColumn: 24,
-          line: 1,
-          messageId: "typeDefinitionsFor",
-        },
-      ],
-      filename: "types/foo/notIndex.d.ts",
-    },
-  ],
-  valid: [
-    ``,
-    {
-      code: `// This isn't the main index
-`,
-      filename: "types/foo/bar/index.d.ts",
-    },
-    {
-      code: `// Type definitions for dt-header 0.75
-// Project: https://github.com/bobby-headers/dt-header
-// Definitions by: Jane Doe <https://github.com/janedoe>
-// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-// Minimum TypeScript Version: 3.1
-      
-`,
-      filename: "types/foo/v0.75/index.d.ts",
-    },
-    {
-      code: `// Type definitions for dt-header 1.0
-// Project: https://github.com/bobby-headers/dt-header
-// Definitions by: Jane Doe <https://github.com/janedoe>
-// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-// Minimum TypeScript Version: 3.1
-      
-`,
-      filename: "types/foo/v1/index.d.ts",
-    },
-    {
-      code: `// Type definitions for dt-header 2.0
-// Project: https://github.com/bobby-headers/dt-header
-// Definitions by: Jane Doe <https://github.com/janedoe>
-// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
-// Minimum TypeScript Version: 3.1
-      
-`,
-      filename: "types/foo/index.d.ts",
-    },
-    {
-      code: ``,
-      filename: "types/foo/notIndex.d.ts",
-    },
-  ],
-});