@defend-tech/opencode-optima 0.1.64 → 0.1.66

package/dist/index.js

@@ -9337,7 +9337,7 @@ async function syncOpenChamberWorktreeVisibility({ openchamberBaseUrl, opencodeB
     gitWorktree,
     projectId: project.id
   };
-  if (!visibility.worktree || !visibility.workspace || !visibility.projectDirectory) {
+  if (!visibility.worktree || !visibility.projectDirectory) {
     throw new Error(`OpenCode visibility verification failed for ${worktreePath}: ${JSON.stringify(visibility)}`);
   }
   return visibility;
@@ -9978,17 +9978,11 @@ function createClickUpApiClient(config, fetchImpl = globalThis.fetch) {
         body: JSON.stringify({ value })
       });
     },
-    async postTaskComment({ taskId, comment }) {
-      return request(`https://api.clickup.com/api/v2/task/${encodeURIComponent(taskId)}/comment`, {
-        method: "POST",
-        body: JSON.stringify({ comment_text: comment })
-      });
+    async postTaskComment() {
+      throw new Error("Optima runtime does not post ClickUp task comments; use local logs for process failures.");
     },
-    async addTaskTag({ taskId, tagName = CLICKUP_BLOCKER_TAG_NAME } = {}) {
-      return request(`https://api.clickup.com/api/v2/task/${encodeURIComponent(taskId)}/tag/${encodeURIComponent(tagName)}`, {
-        method: "POST",
-        body: JSON.stringify({})
-      });
+    async addTaskTag() {
+      throw new Error("Optima runtime does not add ClickUp task tags; use local logs for process failures.");
     },
     async listAssignedTasks({ assigneeId, statuses = [], limit = CLICKUP_WEBHOOK_STARTUP_TASK_LIMIT } = {}) {
       const params = new URLSearchParams();
@@ -10548,15 +10542,54 @@ async function createOpenCodeSession(client, { title, directory, agent } = {}) {
     throw error || new Error("OpenCode session create failed.");
   }
 }
-async function waitForOpenCodeReadiness(client, { worktree = process.cwd(), attempts = 10, delayMs = 500, now = () => /* @__PURE__ */ new Date() } = {}) {
-  if (typeof client?.session?.create !== "function") return { ok: true, skipped: true, reason: "session_create_probe_unavailable" };
+function normalizeOpenCodeSessionCollection(value) {
+  if (Array.isArray(value)) return value;
+  if (!isPlainObject(value)) return [];
+  for (const key of ["sessions", "items", "data", "result", "results"]) {
+    const nested = value[key];
+    if (Array.isArray(nested)) return nested;
+    if (isPlainObject(nested)) {
+      const normalized = normalizeOpenCodeSessionCollection(nested);
+      if (normalized.length > 0) return normalized;
+    }
+  }
+  return [];
+}
+async function listOpenCodeSessionsReadiness(client, { directory = "" } = {}) {
+  if (typeof client?.session?.list !== "function") return null;
+  const attempts = [
+    { query: directory ? { directory } : {} },
+    directory ? { directory } : {}
+  ];
+  for (const attempt of attempts) {
+    try {
+      const result = await client.session.list(attempt);
+      return { ok: true, method: "session_list", sessions: normalizeOpenCodeSessionCollection(result?.data ?? result).length };
+    } catch {
+    }
+  }
+  return null;
+}
+async function listOpenCodeSessionsReadinessHttp({ baseUrl, directory = "", fetchImpl = globalThis.fetch } = {}) {
+  const root = normalizeOpenCodeBaseUrl(baseUrl, "");
+  if (!root || typeof fetchImpl !== "function") return null;
+  const url = openChamberUrl(root, "/session", directory ? { directory } : {});
+  const response = await fetchImpl(url, { method: "GET" });
+  const contentType = response.headers?.get?.("content-type") || "";
+  const raw = await response.text();
+  if (!response.ok) throw new Error(`OpenCode session list readiness failed with status ${response.status}.`);
+  if (responseLooksLikeHtml(contentType, raw)) throw new Error("OpenCode session list readiness returned an HTML app shell.");
+  const data = raw.trim() ? JSON.parse(raw) : [];
+  return { ok: true, method: "session_list_http", sessions: normalizeOpenCodeSessionCollection(data).length };
+}
+async function waitForOpenCodeReadiness(client, { worktree = process.cwd(), attempts = 10, delayMs = 500, opencodeBaseUrl = "", fetchImpl = globalThis.fetch } = {}) {
   let lastError = "opencode_not_ready";
   const maxAttempts = Math.max(1, Number(attempts) || 1);
   for (let attempt = 1; attempt <= maxAttempts; attempt += 1) {
     try {
-      const sessionId = await createOpenCodeSession(client, { title: `Optima startup readiness probe ${now().toISOString()}`, directory: worktree });
-      if (await openCodeSessionExists(client, sessionId)) return { ok: true, method: "session_create_probe", sessionId, attempts: attempt };
-      lastError = "readiness_probe_session_not_visible";
+      const listed = await listOpenCodeSessionsReadiness(client, { directory: worktree }) || await listOpenCodeSessionsReadinessHttp({ baseUrl: opencodeBaseUrl, directory: worktree, fetchImpl });
+      if (listed?.ok) return { ...listed, attempts: attempt };
+      return { ok: true, skipped: true, reason: "session_list_probe_unavailable", attempts: attempt };
     } catch (error) {
       lastError = error.message || "opencode_not_ready";
     }
@@ -10929,18 +10962,9 @@ async function postClickUpLaunchFailureComment({ clickupClient, worktree, taskId
   return { ok: false, skipped: true, reason: "local_log_only" };
 }
 async function applyClickUpBlockerTag({ clickupClient, worktree, taskId, reason, source, tagName = CLICKUP_BLOCKER_TAG_NAME } = {}) {
-  if (typeof clickupClient?.addTaskTag !== "function") {
-    appendClickUpWebhookLocalLog(worktree, { type: "blocker_tag_unavailable", taskId, reason, source, tagName });
-    return { ok: false, skipped: true, reason: "add_task_tag_unavailable", tagName };
-  }
-  try {
-    await clickupClient.addTaskTag({ taskId, tagName });
-    appendClickUpWebhookLocalLog(worktree, { type: "blocker_tag_applied", taskId, reason, source, tagName });
-    return { ok: true, tagName };
-  } catch (error) {
-    appendClickUpWebhookLocalLog(worktree, { type: "blocker_tag_failed", taskId, reason, source, tagName, message: error.message });
-    return { ok: false, error: error.message, tagName };
-  }
+  void clickupClient;
+  appendClickUpWebhookLocalLog(worktree, { type: "blocker_tag_skipped", taskId, reason, source, tagName, policy: "metadata_only_task_writes" });
+  return { ok: false, skipped: true, reason: "metadata_only_task_writes", tagName };
 }
 function openCodeBlockingPromptVerification(result, sessionId) {
   if (result?.__optimaPromptDelivery !== "prompt") return null;
@@ -11287,7 +11311,9 @@ async function routeClickUpWebhookEventUnlocked({ payload, config, state = {}, w
   const sessionTitle = formatClickUpSessionTitle({ taskId, payloadTask: payload.task, task });
   const existingMetadata = clickUpTaskAgentMetadata(task, config.routing.metadataFieldId);
   const metadata = normalizeAgentMetadataJson(existingMetadata);
-  const existingSessionId = getNestedMetadataValue(metadata, config.routing.metadataKey);
+  const rawExistingSessionId = getNestedMetadataValue(metadata, config.routing.metadataKey);
+  const existingSessionId = typeof rawExistingSessionId === "string" && rawExistingSessionId.startsWith("ses_") ? rawExistingSessionId : "";
+  if (rawExistingSessionId !== void 0 && !existingSessionId) appendClickUpWebhookLocalLog(worktree, { type: "pm_session_metadata_ignored", taskId, valueType: typeof rawExistingSessionId, reason: "not_session_id" });
   const taskType = clickUpTaskType(task);
   const parentTaskId = clickUpParentTaskId(task) || taskId;
   const subtaskId = parentTaskId && parentTaskId !== taskId ? taskId : "";
@@ -11317,6 +11343,12 @@ async function routeClickUpWebhookEventUnlocked({ payload, config, state = {}, w
   const prompt = formatClickUpWebhookPrompt({ eventType, taskId, payload, branch: taskRoute.branch, worktree: taskRoute.worktree, deliveryEvidencePath, humanRoleContext });
   if (!existingSessionId) {
     let pendingSessionId = getNestedMetadataValue(metadata, clickUpPendingSessionKey(config.routing.metadataKey)) || state.pendingSessions?.[taskId];
+    if (pendingSessionId && !await sessionExists(openCodeClient, pendingSessionId, { directory: taskRoute.worktree })) {
+      appendClickUpWebhookLocalLog(worktree, { type: "pending_session_stale", taskId, sessionId: pendingSessionId, worktree: taskRoute.worktree });
+      const { [taskId]: _stalePending, ...remainingPending2 } = stateToPersist.pendingSessions || {};
+      stateToPersist = { ...stateToPersist, pendingSessions: remainingPending2 };
+      pendingSessionId = "";
+    }
     if (!pendingSessionId) {
       try {
         pendingSessionId = await createSession(openCodeClient, { title: sessionTitle, directory: taskRoute.worktree, agent: config.routing.targetAgent });
@@ -11422,7 +11454,7 @@ async function reconcileClickUpStartup({ config, state = {}, worktree = process.
     clickUpWebhookLifecycleLog(worktree, { type: "startup_reconciliation_finished", ...skipped });
     return skipped;
   }
-  const readiness = await waitForReadiness(openCodeClient, { worktree, now });
+  const readiness = await waitForReadiness(openCodeClient, { worktree, now, opencodeBaseUrl: config.opencode?.baseUrl });
   appendClickUpWebhookLocalLog(worktree, { type: readiness.ok ? "startup_reconciliation_readiness_ready" : "startup_reconciliation_readiness_failed", ...readiness });
   if (!readiness.ok) {
     const failed = { ok: false, skipped: true, reason: "opencode_not_ready", readiness, assigned: 0, comments: 0, ignored: 0, errors: 1, undelivered: 1, tasks: [], validation: { undelivered: 1, emptyPromptSessions: [] } };

package/dist/sanitize_cli.js

@@ -9344,7 +9344,7 @@ async function syncOpenChamberWorktreeVisibility({ openchamberBaseUrl, opencodeB
     gitWorktree,
     projectId: project.id
   };
-  if (!visibility.worktree || !visibility.workspace || !visibility.projectDirectory) {
+  if (!visibility.worktree || !visibility.projectDirectory) {
     throw new Error(`OpenCode visibility verification failed for ${worktreePath}: ${JSON.stringify(visibility)}`);
   }
   return visibility;
@@ -9985,17 +9985,11 @@ function createClickUpApiClient(config, fetchImpl = globalThis.fetch) {
         body: JSON.stringify({ value })
       });
     },
-    async postTaskComment({ taskId, comment }) {
-      return request(`https://api.clickup.com/api/v2/task/${encodeURIComponent(taskId)}/comment`, {
-        method: "POST",
-        body: JSON.stringify({ comment_text: comment })
-      });
+    async postTaskComment() {
+      throw new Error("Optima runtime does not post ClickUp task comments; use local logs for process failures.");
     },
-    async addTaskTag({ taskId, tagName = CLICKUP_BLOCKER_TAG_NAME } = {}) {
-      return request(`https://api.clickup.com/api/v2/task/${encodeURIComponent(taskId)}/tag/${encodeURIComponent(tagName)}`, {
-        method: "POST",
-        body: JSON.stringify({})
-      });
+    async addTaskTag() {
+      throw new Error("Optima runtime does not add ClickUp task tags; use local logs for process failures.");
     },
     async listAssignedTasks({ assigneeId, statuses = [], limit = CLICKUP_WEBHOOK_STARTUP_TASK_LIMIT } = {}) {
       const params = new URLSearchParams();
@@ -10555,15 +10549,54 @@ async function createOpenCodeSession(client, { title, directory, agent } = {}) {
     throw error || new Error("OpenCode session create failed.");
   }
 }
-async function waitForOpenCodeReadiness(client, { worktree = process.cwd(), attempts = 10, delayMs = 500, now = () => /* @__PURE__ */ new Date() } = {}) {
-  if (typeof client?.session?.create !== "function") return { ok: true, skipped: true, reason: "session_create_probe_unavailable" };
+function normalizeOpenCodeSessionCollection(value) {
+  if (Array.isArray(value)) return value;
+  if (!isPlainObject(value)) return [];
+  for (const key of ["sessions", "items", "data", "result", "results"]) {
+    const nested = value[key];
+    if (Array.isArray(nested)) return nested;
+    if (isPlainObject(nested)) {
+      const normalized = normalizeOpenCodeSessionCollection(nested);
+      if (normalized.length > 0) return normalized;
+    }
+  }
+  return [];
+}
+async function listOpenCodeSessionsReadiness(client, { directory = "" } = {}) {
+  if (typeof client?.session?.list !== "function") return null;
+  const attempts = [
+    { query: directory ? { directory } : {} },
+    directory ? { directory } : {}
+  ];
+  for (const attempt of attempts) {
+    try {
+      const result = await client.session.list(attempt);
+      return { ok: true, method: "session_list", sessions: normalizeOpenCodeSessionCollection(result?.data ?? result).length };
+    } catch {
+    }
+  }
+  return null;
+}
+async function listOpenCodeSessionsReadinessHttp({ baseUrl, directory = "", fetchImpl = globalThis.fetch } = {}) {
+  const root = normalizeOpenCodeBaseUrl(baseUrl, "");
+  if (!root || typeof fetchImpl !== "function") return null;
+  const url = openChamberUrl(root, "/session", directory ? { directory } : {});
+  const response = await fetchImpl(url, { method: "GET" });
+  const contentType = response.headers?.get?.("content-type") || "";
+  const raw = await response.text();
+  if (!response.ok) throw new Error(`OpenCode session list readiness failed with status ${response.status}.`);
+  if (responseLooksLikeHtml(contentType, raw)) throw new Error("OpenCode session list readiness returned an HTML app shell.");
+  const data = raw.trim() ? JSON.parse(raw) : [];
+  return { ok: true, method: "session_list_http", sessions: normalizeOpenCodeSessionCollection(data).length };
+}
+async function waitForOpenCodeReadiness(client, { worktree = process.cwd(), attempts = 10, delayMs = 500, opencodeBaseUrl = "", fetchImpl = globalThis.fetch } = {}) {
   let lastError = "opencode_not_ready";
   const maxAttempts = Math.max(1, Number(attempts) || 1);
   for (let attempt = 1; attempt <= maxAttempts; attempt += 1) {
     try {
-      const sessionId = await createOpenCodeSession(client, { title: `Optima startup readiness probe ${now().toISOString()}`, directory: worktree });
-      if (await openCodeSessionExists(client, sessionId)) return { ok: true, method: "session_create_probe", sessionId, attempts: attempt };
-      lastError = "readiness_probe_session_not_visible";
+      const listed = await listOpenCodeSessionsReadiness(client, { directory: worktree }) || await listOpenCodeSessionsReadinessHttp({ baseUrl: opencodeBaseUrl, directory: worktree, fetchImpl });
+      if (listed?.ok) return { ...listed, attempts: attempt };
+      return { ok: true, skipped: true, reason: "session_list_probe_unavailable", attempts: attempt };
     } catch (error) {
       lastError = error.message || "opencode_not_ready";
     }
@@ -10936,18 +10969,9 @@ async function postClickUpLaunchFailureComment({ clickupClient, worktree, taskId
   return { ok: false, skipped: true, reason: "local_log_only" };
 }
 async function applyClickUpBlockerTag({ clickupClient, worktree, taskId, reason, source, tagName = CLICKUP_BLOCKER_TAG_NAME } = {}) {
-  if (typeof clickupClient?.addTaskTag !== "function") {
-    appendClickUpWebhookLocalLog(worktree, { type: "blocker_tag_unavailable", taskId, reason, source, tagName });
-    return { ok: false, skipped: true, reason: "add_task_tag_unavailable", tagName };
-  }
-  try {
-    await clickupClient.addTaskTag({ taskId, tagName });
-    appendClickUpWebhookLocalLog(worktree, { type: "blocker_tag_applied", taskId, reason, source, tagName });
-    return { ok: true, tagName };
-  } catch (error) {
-    appendClickUpWebhookLocalLog(worktree, { type: "blocker_tag_failed", taskId, reason, source, tagName, message: error.message });
-    return { ok: false, error: error.message, tagName };
-  }
+  void clickupClient;
+  appendClickUpWebhookLocalLog(worktree, { type: "blocker_tag_skipped", taskId, reason, source, tagName, policy: "metadata_only_task_writes" });
+  return { ok: false, skipped: true, reason: "metadata_only_task_writes", tagName };
 }
 function openCodeBlockingPromptVerification(result, sessionId) {
   if (result?.__optimaPromptDelivery !== "prompt") return null;
@@ -11294,7 +11318,9 @@ async function routeClickUpWebhookEventUnlocked({ payload, config, state = {}, w
   const sessionTitle = formatClickUpSessionTitle({ taskId, payloadTask: payload.task, task });
   const existingMetadata = clickUpTaskAgentMetadata(task, config.routing.metadataFieldId);
   const metadata = normalizeAgentMetadataJson(existingMetadata);
-  const existingSessionId = getNestedMetadataValue(metadata, config.routing.metadataKey);
+  const rawExistingSessionId = getNestedMetadataValue(metadata, config.routing.metadataKey);
+  const existingSessionId = typeof rawExistingSessionId === "string" && rawExistingSessionId.startsWith("ses_") ? rawExistingSessionId : "";
+  if (rawExistingSessionId !== void 0 && !existingSessionId) appendClickUpWebhookLocalLog(worktree, { type: "pm_session_metadata_ignored", taskId, valueType: typeof rawExistingSessionId, reason: "not_session_id" });
   const taskType = clickUpTaskType(task);
   const parentTaskId = clickUpParentTaskId(task) || taskId;
   const subtaskId = parentTaskId && parentTaskId !== taskId ? taskId : "";
@@ -11324,6 +11350,12 @@ async function routeClickUpWebhookEventUnlocked({ payload, config, state = {}, w
   const prompt = formatClickUpWebhookPrompt({ eventType, taskId, payload, branch: taskRoute.branch, worktree: taskRoute.worktree, deliveryEvidencePath, humanRoleContext });
   if (!existingSessionId) {
     let pendingSessionId = getNestedMetadataValue(metadata, clickUpPendingSessionKey(config.routing.metadataKey)) || state.pendingSessions?.[taskId];
+    if (pendingSessionId && !await sessionExists(openCodeClient, pendingSessionId, { directory: taskRoute.worktree })) {
+      appendClickUpWebhookLocalLog(worktree, { type: "pending_session_stale", taskId, sessionId: pendingSessionId, worktree: taskRoute.worktree });
+      const { [taskId]: _stalePending, ...remainingPending2 } = stateToPersist.pendingSessions || {};
+      stateToPersist = { ...stateToPersist, pendingSessions: remainingPending2 };
+      pendingSessionId = "";
+    }
     if (!pendingSessionId) {
       try {
         pendingSessionId = await createSession(openCodeClient, { title: sessionTitle, directory: taskRoute.worktree, agent: config.routing.targetAgent });
@@ -11429,7 +11461,7 @@ async function reconcileClickUpStartup({ config, state = {}, worktree = process.
     clickUpWebhookLifecycleLog(worktree, { type: "startup_reconciliation_finished", ...skipped });
     return skipped;
   }
-  const readiness = await waitForReadiness(openCodeClient, { worktree, now });
+  const readiness = await waitForReadiness(openCodeClient, { worktree, now, opencodeBaseUrl: config.opencode?.baseUrl });
   appendClickUpWebhookLocalLog(worktree, { type: readiness.ok ? "startup_reconciliation_readiness_ready" : "startup_reconciliation_readiness_failed", ...readiness });
   if (!readiness.ok) {
     const failed = { ok: false, skipped: true, reason: "opencode_not_ready", readiness, assigned: 0, comments: 0, ignored: 0, errors: 1, undelivered: 1, tasks: [], validation: { undelivered: 1, emptyPromptSessions: [] } };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defend-tech/opencode-optima",
-  "version": "0.1.64",
+  "version": "0.1.66",
   "repository": {
     "type": "git",
     "url": "git+ssh://git@github.com/defend-tech/opencode-optima.git"