@defend-tech/opencode-optima 0.1.63 → 0.1.65

package/dist/index.js

@@ -9337,16 +9337,11 @@ async function syncOpenChamberWorktreeVisibility({ openchamberBaseUrl, opencodeB
     gitWorktree,
     projectId: project.id
   };
-  if (!visibility.worktree || !visibility.workspace || !visibility.projectDirectory) {
+  if (!visibility.worktree || !visibility.projectDirectory) {
     throw new Error(`OpenCode visibility verification failed for ${worktreePath}: ${JSON.stringify(visibility)}`);
   }
   return visibility;
 }
-function assertOpenChamberClickUpWorktreePath({ baseWorktree, worktreePath } = {}) {
-  if (!isClickUpDerivedWorktreeSibling(worktreePath, baseWorktree)) {
-    throw new Error(`OpenChamber worktree path is outside the configured ClickUp sibling scope: ${worktreePath}`);
-  }
-}
 async function createOpenChamberClickUpWorktree({ openchamberBaseUrl, baseUrl, baseWorktree, branch, worktreePath, startPoint, branchExists = false, fetchImpl = globalThis.fetch } = {}) {
   const effectiveOpenChamberBaseUrl = openchamberBaseUrl || baseUrl;
   const worktreeName = clickUpOpenChamberWorktreeName(branch);
@@ -9369,7 +9364,6 @@ async function createOpenChamberClickUpWorktree({ openchamberBaseUrl, baseUrl, b
   return { created, worktree: path5.resolve(createdDirectory), branch: createdBranch, verified };
 }
 async function registerOpenChamberClickUpWorktree({ openchamberBaseUrl, opencodeBaseUrl, baseUrl, baseWorktree, branch, worktreePath, fetchImpl = globalThis.fetch, source = "reuse" } = {}) {
-  assertOpenChamberClickUpWorktreePath({ baseWorktree, worktreePath });
   const visibility = await syncOpenChamberWorktreeVisibility({ openchamberBaseUrl: openchamberBaseUrl || baseUrl, opencodeBaseUrl: opencodeBaseUrl || baseUrl, baseWorktree, worktreePath, branch, fetchImpl });
   return { branch, worktree: path5.resolve(worktreePath), reused: true, provider: "openchamber", openChamber: { source, visibility } };
 }
@@ -9423,30 +9417,6 @@ async function ensureClickUpTaskWorktreeForWebhook({ opencodeBaseUrl = "", openc
   } catch (error) {
     const message = `OpenChamber worktree provisioning failed for ${options.taskId || "unknown task"}; raw git fallback is disabled to avoid invisible worktrees. ${error.message}`;
     appendClickUpWebhookLocalLog(webhookWorktree, { type: "openchamber_worktree_failed", taskId: options.taskId || null, message });
-    if (typeof clickupClient?.postTaskComment === "function") {
-      const taskId = options.taskId || "unknown task";
-      const ledgerPath = clickUpCommentLedgerPath(webhookWorktree);
-      const comment = `${message}
-
-Optima did not run raw git worktree fallback. Please verify clickup.openchamber.base_url and OpenCode/OpenChamber endpoint configuration.`;
-      let dedupe = { post: true, key: clickUpWorktreeFailureCommentKey({ taskId, message }) };
-      try {
-        dedupe = shouldPostClickUpWorktreeFailureComment({ ledgerPath, taskId, message });
-      } catch (ledgerError) {
-        appendClickUpWebhookLocalLog(webhookWorktree, { type: "openchamber_worktree_comment_dedupe_failed", taskId, message: ledgerError.message });
-      }
-      if (dedupe.post) {
-        try {
-          await clickupClient.postTaskComment({ taskId: options.taskId, comment });
-          recordClickUpWorktreeFailureComment({ ledgerPath, taskId, message, posted: true });
-        } catch (commentError) {
-          appendClickUpWebhookLocalLog(webhookWorktree, { type: "openchamber_worktree_blocker_comment_failed", taskId: options.taskId || null, message: commentError.message });
-        }
-      } else {
-        appendClickUpWebhookLocalLog(webhookWorktree, { type: "openchamber_worktree_blocker_comment_deduped", taskId, key: dedupe.key, reason: dedupe.reason });
-        recordClickUpWorktreeFailureComment({ ledgerPath, taskId, message, posted: false, skippedReason: dedupe.reason });
-      }
-    }
     throw new Error(message);
   }
 }
@@ -10392,35 +10362,6 @@ function recordClickUpCommentVersionProcessed({ ledgerPath, key, taskId, eventTy
     recordedAt: at.toISOString()
   });
 }
-function clickUpWorktreeFailureCommentKey({ taskId, message } = {}) {
-  const hash = crypto.createHash("sha256").update(String(message || "")).digest("hex").slice(0, 16);
-  return [String(taskId || "unknown").trim() || "unknown", "worktree_failure", hash].join(":");
-}
-function shouldPostClickUpWorktreeFailureComment({ ledgerPath, taskId, message, now = /* @__PURE__ */ new Date(), windowMs = CLICKUP_WORKTREE_FAILURE_COMMENT_DEDUPE_MS } = {}) {
-  const key = clickUpWorktreeFailureCommentKey({ taskId, message });
-  const nowMs = now instanceof Date ? now.getTime() : new Date(now).getTime();
-  for (const entry of readClickUpCommentLedgerEntries(ledgerPath).reverse()) {
-    if (entry?.key !== key) continue;
-    const postedAtMs = new Date(entry.postedAt || entry.recordedAt || entry.at || 0).getTime();
-    if (Number.isFinite(postedAtMs) && Number.isFinite(nowMs) && nowMs - postedAtMs <= windowMs) {
-      return { post: false, key, reason: "recent_duplicate" };
-    }
-    if (entry?.message === message) return { post: false, key, reason: "latest_equivalent" };
-  }
-  return { post: true, key };
-}
-function recordClickUpWorktreeFailureComment({ ledgerPath, taskId, message, posted = true, skippedReason = null, at = /* @__PURE__ */ new Date() } = {}) {
-  appendClickUpCommentLedgerEntry(ledgerPath, {
-    key: clickUpWorktreeFailureCommentKey({ taskId, message }),
-    taskId,
-    eventType: "worktree_failure",
-    action: posted ? "worktree_failure_comment_posted" : "worktree_failure_comment_skipped",
-    message,
-    posted,
-    skippedReason,
-    postedAt: at.toISOString()
-  });
-}
 function clickUpTaskIdFromPayload(payload = {}) {
   return String(payload.task_id || payload.taskId || payload.task?.id || payload.task?.task_id || "").trim();
 }
@@ -10983,15 +10924,9 @@ async function verifyOpenCodeSessionEventDelivery(client, { sessionId, directory
   return { ok: false, reason: lastError };
 }
 async function postClickUpLaunchFailureComment({ clickupClient, worktree, taskId, reason, source } = {}) {
-  if (typeof clickupClient?.postTaskComment !== "function") return { ok: false, skipped: true, reason: "post_comment_unavailable" };
-  try {
-    await clickupClient.postTaskComment({ taskId, comment: `Optima launch failure: ${reason || "launch_failed"}. Worktree visibility alone is not successful routing; Optima requires an OpenCode session plus verified prompt admission/delivery.` });
-    appendClickUpWebhookLocalLog(worktree, { type: "launch_failure_comment_posted", taskId, reason, source });
-    return { ok: true };
-  } catch (error) {
-    appendClickUpWebhookLocalLog(worktree, { type: "launch_failure_comment_failed", taskId, reason, source, message: error.message });
-    return { ok: false, error: error.message };
-  }
+  void clickupClient;
+  appendClickUpWebhookLocalLog(worktree, { type: "launch_failure_comment_skipped", taskId, reason, source, policy: "local_log_only" });
+  return { ok: false, skipped: true, reason: "local_log_only" };
 }
 async function applyClickUpBlockerTag({ clickupClient, worktree, taskId, reason, source, tagName = CLICKUP_BLOCKER_TAG_NAME } = {}) {
   if (typeof clickupClient?.addTaskTag !== "function") {
@@ -11352,7 +11287,9 @@ async function routeClickUpWebhookEventUnlocked({ payload, config, state = {}, w
   const sessionTitle = formatClickUpSessionTitle({ taskId, payloadTask: payload.task, task });
   const existingMetadata = clickUpTaskAgentMetadata(task, config.routing.metadataFieldId);
   const metadata = normalizeAgentMetadataJson(existingMetadata);
-  const existingSessionId = getNestedMetadataValue(metadata, config.routing.metadataKey);
+  const rawExistingSessionId = getNestedMetadataValue(metadata, config.routing.metadataKey);
+  const existingSessionId = typeof rawExistingSessionId === "string" && rawExistingSessionId.startsWith("ses_") ? rawExistingSessionId : "";
+  if (rawExistingSessionId !== void 0 && !existingSessionId) appendClickUpWebhookLocalLog(worktree, { type: "pm_session_metadata_ignored", taskId, valueType: typeof rawExistingSessionId, reason: "not_session_id" });
   const taskType = clickUpTaskType(task);
   const parentTaskId = clickUpParentTaskId(task) || taskId;
   const subtaskId = parentTaskId && parentTaskId !== taskId ? taskId : "";
@@ -11382,6 +11319,12 @@ async function routeClickUpWebhookEventUnlocked({ payload, config, state = {}, w
   const prompt = formatClickUpWebhookPrompt({ eventType, taskId, payload, branch: taskRoute.branch, worktree: taskRoute.worktree, deliveryEvidencePath, humanRoleContext });
   if (!existingSessionId) {
     let pendingSessionId = getNestedMetadataValue(metadata, clickUpPendingSessionKey(config.routing.metadataKey)) || state.pendingSessions?.[taskId];
+    if (pendingSessionId && !await sessionExists(openCodeClient, pendingSessionId, { directory: taskRoute.worktree })) {
+      appendClickUpWebhookLocalLog(worktree, { type: "pending_session_stale", taskId, sessionId: pendingSessionId, worktree: taskRoute.worktree });
+      const { [taskId]: _stalePending, ...remainingPending2 } = stateToPersist.pendingSessions || {};
+      stateToPersist = { ...stateToPersist, pendingSessions: remainingPending2 };
+      pendingSessionId = "";
+    }
     if (!pendingSessionId) {
       try {
         pendingSessionId = await createSession(openCodeClient, { title: sessionTitle, directory: taskRoute.worktree, agent: config.routing.targetAgent });

package/dist/sanitize_cli.js

@@ -9344,16 +9344,11 @@ async function syncOpenChamberWorktreeVisibility({ openchamberBaseUrl, opencodeB
     gitWorktree,
     projectId: project.id
   };
-  if (!visibility.worktree || !visibility.workspace || !visibility.projectDirectory) {
+  if (!visibility.worktree || !visibility.projectDirectory) {
     throw new Error(`OpenCode visibility verification failed for ${worktreePath}: ${JSON.stringify(visibility)}`);
   }
   return visibility;
 }
-function assertOpenChamberClickUpWorktreePath({ baseWorktree, worktreePath } = {}) {
-  if (!isClickUpDerivedWorktreeSibling(worktreePath, baseWorktree)) {
-    throw new Error(`OpenChamber worktree path is outside the configured ClickUp sibling scope: ${worktreePath}`);
-  }
-}
 async function createOpenChamberClickUpWorktree({ openchamberBaseUrl, baseUrl, baseWorktree, branch, worktreePath, startPoint, branchExists = false, fetchImpl = globalThis.fetch } = {}) {
   const effectiveOpenChamberBaseUrl = openchamberBaseUrl || baseUrl;
   const worktreeName = clickUpOpenChamberWorktreeName(branch);
@@ -9376,7 +9371,6 @@ async function createOpenChamberClickUpWorktree({ openchamberBaseUrl, baseUrl, b
   return { created, worktree: path5.resolve(createdDirectory), branch: createdBranch, verified };
 }
 async function registerOpenChamberClickUpWorktree({ openchamberBaseUrl, opencodeBaseUrl, baseUrl, baseWorktree, branch, worktreePath, fetchImpl = globalThis.fetch, source = "reuse" } = {}) {
-  assertOpenChamberClickUpWorktreePath({ baseWorktree, worktreePath });
   const visibility = await syncOpenChamberWorktreeVisibility({ openchamberBaseUrl: openchamberBaseUrl || baseUrl, opencodeBaseUrl: opencodeBaseUrl || baseUrl, baseWorktree, worktreePath, branch, fetchImpl });
   return { branch, worktree: path5.resolve(worktreePath), reused: true, provider: "openchamber", openChamber: { source, visibility } };
 }
@@ -9430,30 +9424,6 @@ async function ensureClickUpTaskWorktreeForWebhook({ opencodeBaseUrl = "", openc
   } catch (error) {
     const message = `OpenChamber worktree provisioning failed for ${options.taskId || "unknown task"}; raw git fallback is disabled to avoid invisible worktrees. ${error.message}`;
     appendClickUpWebhookLocalLog(webhookWorktree, { type: "openchamber_worktree_failed", taskId: options.taskId || null, message });
-    if (typeof clickupClient?.postTaskComment === "function") {
-      const taskId = options.taskId || "unknown task";
-      const ledgerPath = clickUpCommentLedgerPath(webhookWorktree);
-      const comment = `${message}
-
-Optima did not run raw git worktree fallback. Please verify clickup.openchamber.base_url and OpenCode/OpenChamber endpoint configuration.`;
-      let dedupe = { post: true, key: clickUpWorktreeFailureCommentKey({ taskId, message }) };
-      try {
-        dedupe = shouldPostClickUpWorktreeFailureComment({ ledgerPath, taskId, message });
-      } catch (ledgerError) {
-        appendClickUpWebhookLocalLog(webhookWorktree, { type: "openchamber_worktree_comment_dedupe_failed", taskId, message: ledgerError.message });
-      }
-      if (dedupe.post) {
-        try {
-          await clickupClient.postTaskComment({ taskId: options.taskId, comment });
-          recordClickUpWorktreeFailureComment({ ledgerPath, taskId, message, posted: true });
-        } catch (commentError) {
-          appendClickUpWebhookLocalLog(webhookWorktree, { type: "openchamber_worktree_blocker_comment_failed", taskId: options.taskId || null, message: commentError.message });
-        }
-      } else {
-        appendClickUpWebhookLocalLog(webhookWorktree, { type: "openchamber_worktree_blocker_comment_deduped", taskId, key: dedupe.key, reason: dedupe.reason });
-        recordClickUpWorktreeFailureComment({ ledgerPath, taskId, message, posted: false, skippedReason: dedupe.reason });
-      }
-    }
     throw new Error(message);
   }
 }
@@ -10399,35 +10369,6 @@ function recordClickUpCommentVersionProcessed({ ledgerPath, key, taskId, eventTy
     recordedAt: at.toISOString()
   });
 }
-function clickUpWorktreeFailureCommentKey({ taskId, message } = {}) {
-  const hash = crypto.createHash("sha256").update(String(message || "")).digest("hex").slice(0, 16);
-  return [String(taskId || "unknown").trim() || "unknown", "worktree_failure", hash].join(":");
-}
-function shouldPostClickUpWorktreeFailureComment({ ledgerPath, taskId, message, now = /* @__PURE__ */ new Date(), windowMs = CLICKUP_WORKTREE_FAILURE_COMMENT_DEDUPE_MS } = {}) {
-  const key = clickUpWorktreeFailureCommentKey({ taskId, message });
-  const nowMs = now instanceof Date ? now.getTime() : new Date(now).getTime();
-  for (const entry of readClickUpCommentLedgerEntries(ledgerPath).reverse()) {
-    if (entry?.key !== key) continue;
-    const postedAtMs = new Date(entry.postedAt || entry.recordedAt || entry.at || 0).getTime();
-    if (Number.isFinite(postedAtMs) && Number.isFinite(nowMs) && nowMs - postedAtMs <= windowMs) {
-      return { post: false, key, reason: "recent_duplicate" };
-    }
-    if (entry?.message === message) return { post: false, key, reason: "latest_equivalent" };
-  }
-  return { post: true, key };
-}
-function recordClickUpWorktreeFailureComment({ ledgerPath, taskId, message, posted = true, skippedReason = null, at = /* @__PURE__ */ new Date() } = {}) {
-  appendClickUpCommentLedgerEntry(ledgerPath, {
-    key: clickUpWorktreeFailureCommentKey({ taskId, message }),
-    taskId,
-    eventType: "worktree_failure",
-    action: posted ? "worktree_failure_comment_posted" : "worktree_failure_comment_skipped",
-    message,
-    posted,
-    skippedReason,
-    postedAt: at.toISOString()
-  });
-}
 function clickUpTaskIdFromPayload(payload = {}) {
   return String(payload.task_id || payload.taskId || payload.task?.id || payload.task?.task_id || "").trim();
 }
@@ -10990,15 +10931,9 @@ async function verifyOpenCodeSessionEventDelivery(client, { sessionId, directory
   return { ok: false, reason: lastError };
 }
 async function postClickUpLaunchFailureComment({ clickupClient, worktree, taskId, reason, source } = {}) {
-  if (typeof clickupClient?.postTaskComment !== "function") return { ok: false, skipped: true, reason: "post_comment_unavailable" };
-  try {
-    await clickupClient.postTaskComment({ taskId, comment: `Optima launch failure: ${reason || "launch_failed"}. Worktree visibility alone is not successful routing; Optima requires an OpenCode session plus verified prompt admission/delivery.` });
-    appendClickUpWebhookLocalLog(worktree, { type: "launch_failure_comment_posted", taskId, reason, source });
-    return { ok: true };
-  } catch (error) {
-    appendClickUpWebhookLocalLog(worktree, { type: "launch_failure_comment_failed", taskId, reason, source, message: error.message });
-    return { ok: false, error: error.message };
-  }
+  void clickupClient;
+  appendClickUpWebhookLocalLog(worktree, { type: "launch_failure_comment_skipped", taskId, reason, source, policy: "local_log_only" });
+  return { ok: false, skipped: true, reason: "local_log_only" };
 }
 async function applyClickUpBlockerTag({ clickupClient, worktree, taskId, reason, source, tagName = CLICKUP_BLOCKER_TAG_NAME } = {}) {
   if (typeof clickupClient?.addTaskTag !== "function") {
@@ -11359,7 +11294,9 @@ async function routeClickUpWebhookEventUnlocked({ payload, config, state = {}, w
   const sessionTitle = formatClickUpSessionTitle({ taskId, payloadTask: payload.task, task });
   const existingMetadata = clickUpTaskAgentMetadata(task, config.routing.metadataFieldId);
   const metadata = normalizeAgentMetadataJson(existingMetadata);
-  const existingSessionId = getNestedMetadataValue(metadata, config.routing.metadataKey);
+  const rawExistingSessionId = getNestedMetadataValue(metadata, config.routing.metadataKey);
+  const existingSessionId = typeof rawExistingSessionId === "string" && rawExistingSessionId.startsWith("ses_") ? rawExistingSessionId : "";
+  if (rawExistingSessionId !== void 0 && !existingSessionId) appendClickUpWebhookLocalLog(worktree, { type: "pm_session_metadata_ignored", taskId, valueType: typeof rawExistingSessionId, reason: "not_session_id" });
   const taskType = clickUpTaskType(task);
   const parentTaskId = clickUpParentTaskId(task) || taskId;
   const subtaskId = parentTaskId && parentTaskId !== taskId ? taskId : "";
@@ -11389,6 +11326,12 @@ async function routeClickUpWebhookEventUnlocked({ payload, config, state = {}, w
   const prompt = formatClickUpWebhookPrompt({ eventType, taskId, payload, branch: taskRoute.branch, worktree: taskRoute.worktree, deliveryEvidencePath, humanRoleContext });
   if (!existingSessionId) {
     let pendingSessionId = getNestedMetadataValue(metadata, clickUpPendingSessionKey(config.routing.metadataKey)) || state.pendingSessions?.[taskId];
+    if (pendingSessionId && !await sessionExists(openCodeClient, pendingSessionId, { directory: taskRoute.worktree })) {
+      appendClickUpWebhookLocalLog(worktree, { type: "pending_session_stale", taskId, sessionId: pendingSessionId, worktree: taskRoute.worktree });
+      const { [taskId]: _stalePending, ...remainingPending2 } = stateToPersist.pendingSessions || {};
+      stateToPersist = { ...stateToPersist, pendingSessions: remainingPending2 };
+      pendingSessionId = "";
+    }
     if (!pendingSessionId) {
       try {
         pendingSessionId = await createSession(openCodeClient, { title: sessionTitle, directory: taskRoute.worktree, agent: config.routing.targetAgent });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defend-tech/opencode-optima",
-  "version": "0.1.63",
+  "version": "0.1.65",
   "repository": {
     "type": "git",
     "url": "git+ssh://git@github.com/defend-tech/opencode-optima.git"