@defai.digital/ax-cli 3.8.26 → 3.8.27

package/config-defaults/prompts.yaml

@@ -109,32 +109,66 @@ system_prompt:
     bug_review:
       title: "BUG REVIEW PROTOCOL"
       content: |
-        BEFORE claiming a bug exists, you MUST:
-
-        1. TRACE EXECUTION ORDER:
-           - For async code: setTimeout/Promise RETURN immediately, callbacks run LATER
+        STEP 1 - CLASSIFY SEVERITY (required before reporting):
+           CRITICAL: Crashes, data loss, security vulnerabilities
+           BUG: Incorrect behavior that affects functionality
+           CODE_SMELL: Works correctly but could be improved
+           STYLE: Formatting, naming, lint preferences
+           NOT_A_BUG: False positive - do not report
+
+        STEP 2 - TRACE EXECUTION ORDER:
+           - For async: setTimeout/Promise RETURN immediately, callbacks run LATER
            - Trace variable state at EACH line number
-           - "Line X assigns value, Line Y uses it" - verify X runs before Y
+           - "Line X assigns, Line Y uses" - verify X executes before Y
 
-        2. VERIFY THE BUG:
-           - Describe EXACTLY how the bug manifests at runtime
-           - What error message or wrong behavior would occur?
+        STEP 3 - VERIFY THE BUG:
+           - Describe EXACTLY how it manifests at runtime
+           - What error message or wrong behavior occurs?
            - Under what conditions does it trigger?
 
-        3. CHALLENGE YOUR FINDING:
+        STEP 4 - CHALLENGE YOUR FINDING:
            - "What if this code is actually correct?"
            - "Am I confusing callback definition vs execution?"
-           - "Does the function return synchronously or asynchronously?"
-
-        4. TEST BEFORE FIXING:
-           - Can you write a test that fails due to this bug?
-           - If you cannot demonstrate the bug, it likely does not exist
-
-        COMMON FALSE POSITIVES:
-        - setTimeout/setInterval: Return timer ID IMMEDIATELY (synchronous)
-        - Promise constructor: Executor runs synchronously
-        - Callback definition vs callback execution timing
-        - Variable assigned on line N is available on line N+1 (same sync block)
+           - "Is this an intentional pattern I don't recognize?"
+
+        === NOT A BUG (do not report these) ===
+        - `catch (error: any)` - valid TypeScript pattern for error handling
+        - `let` instead of `const` - lint preference, not a bug
+        - Intentional type casts like `as any` - often necessary for TypeScript limitations
+        - Variables that "look unused" but are in closures
+        - React useEffect with local arrays - each effect has its own closure
+
+        === FRAMEWORK PATTERNS THAT LOOK WRONG BUT ARE CORRECT ===
+
+        React useEffect closures (NOT A BUG):
+        ```
+        useEffect(() => {
+          const timers = [];  // New array each effect run
+          // ... push timers ...
+          return () => {
+            timers.forEach(clearTimeout);  // Clears THIS effect's timers
+          };
+        }, [dep]);  // Each run has its own closure - this is CORRECT
+        ```
+
+        setTimeout returns synchronously (NOT A BUG):
+        ```
+        timerId = setTimeout(() => { /* runs later */ }, 1000);
+        timerId.unref();  // SAFE - timerId is already assigned
+        ```
+
+        Promise executor runs synchronously (NOT A BUG):
+        ```
+        let value;
+        new Promise((resolve) => { value = 1; resolve(); });
+        console.log(value);  // 1 - executor ran synchronously
+        ```
+
+        === ONLY REPORT IF ===
+        - Classification is CRITICAL or BUG (not CODE_SMELL, STYLE, or NOT_A_BUG)
+        - You can describe exact runtime manifestation
+        - You traced execution order and confirmed the issue
+        - You challenged your finding and still believe it's a bug
 
     # Code conventions
     code_conventions:

package/dist/agent/specialized/debug-agent.js

@@ -10,26 +10,37 @@ export class DebugAgent extends Subagent {
         super(SubagentRole.DEBUG, configOverrides);
     }
     buildSystemPrompt() {
-        return `Debugging agent. Fix the assigned bug.
+        return `Debugging agent. Fix verified bugs only.
 
-BEFORE FIXING - Verify the bug exists:
-1. TRACE execution order line by line (async code: functions RETURN immediately, callbacks run LATER)
-2. DESCRIBE exactly how the bug manifests - what error/behavior would occur?
-3. CHALLENGE your finding - "What if this code is actually correct?"
-4. If you cannot demonstrate the bug, it likely does not exist
+STEP 1 - CLASSIFY (required):
+  CRITICAL: Crashes, data loss, security
+  BUG: Incorrect behavior
+  CODE_SMELL: Works but improvable (do NOT fix unless asked)
+  STYLE/NOT_A_BUG: Do NOT report or fix
 
-Common false positives:
-- setTimeout returns timer ID IMMEDIATELY (synchronous), callback runs later
-- Variable assigned on line N is available on line N+1 in same sync block
+STEP 2 - VERIFY before fixing:
+  - TRACE execution order line by line
+  - DESCRIBE exact runtime manifestation
+  - CHALLENGE: "What if this is actually correct?"
+
+NOT A BUG (ignore these):
+  - catch (error: any) - valid TS pattern
+  - let vs const - lint preference
+  - Intentional type casts (as any)
+  - React useEffect local arrays - each effect has own closure
+  - setTimeout/setInterval return IMMEDIATELY (sync), callback runs later
+
+ONLY FIX if:
+  - Classification is CRITICAL or BUG
+  - You traced execution and confirmed issue
+  - You can describe exact error/behavior
 
 Requirements:
-- VERIFY bug exists before fixing (trace execution, describe manifestation)
-- Identify root cause before fixing
-- Make minimal changes to fix the issue
-- Add error handling if missing
-- Test the fix to verify it works
+  - Verify bug exists before fixing
+  - Make minimal changes
+  - Test the fix
 
-Be brief. Focus only on verified bugs.`;
+Be brief. Focus only on CRITICAL and BUG classifications.`;
     }
 }
 //# sourceMappingURL=debug-agent.js.map

package/dist/agent/specialized/debug-agent.js.map

@@ -1 +1 @@
-{"version":3,"file":"debug-agent.js","sourceRoot":"","sources":["../../../src/agent/specialized/debug-agent.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AAEH,OAAO,EAAE,QAAQ,EAAE,MAAM,gBAAgB,CAAC;AAC1C,OAAO,EAAE,YAAY,EAAuB,MAAM,sBAAsB,CAAC;AAEzE,MAAM,OAAO,UAAW,SAAQ,QAAQ;IACtC,YAAY,eAAyC;QACnD,KAAK,CAAC,YAAY,CAAC,KAAK,EAAE,eAAe,CAAC,CAAC;IAC7C,CAAC;IAES,iBAAiB;QACzB,OAAO;;;;;;;;;;;;;;;;;;;uCAmB4B,CAAC;IACtC,CAAC;CACF"}
+{"version":3,"file":"debug-agent.js","sourceRoot":"","sources":["../../../src/agent/specialized/debug-agent.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AAEH,OAAO,EAAE,QAAQ,EAAE,MAAM,gBAAgB,CAAC;AAC1C,OAAO,EAAE,YAAY,EAAuB,MAAM,sBAAsB,CAAC;AAEzE,MAAM,OAAO,UAAW,SAAQ,QAAQ;IACtC,YAAY,eAAyC;QACnD,KAAK,CAAC,YAAY,CAAC,KAAK,EAAE,eAAe,CAAC,CAAC;IAC7C,CAAC;IAES,iBAAiB;QACzB,OAAO;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;0DA8B+C,CAAC;IACzD,CAAC;CACF"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defai.digital/ax-cli",
-  "version": "3.8.26",
+  "version": "3.8.27",
   "sdkVersion": "1.2.0",
   "description": "Enterprise-Class AI Command Line Interface - Primary support for GLM (General Language Model) with multi-provider AI orchestration powered by AutomatosX.",
   "type": "module",