@defai.digital/automatosx 11.2.5 → 11.2.6

package/dist/mcp/index.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 import * as path4 from 'path';
-import path4__default, { dirname, join, extname as extname$1, basename, resolve, isAbsolute, sep, parse, delimiter } from 'path';
+import path4__default, { dirname, join, extname as extname$1, basename, resolve, relative, sep, isAbsolute, parse, delimiter } from 'path';
 import { fileURLToPath } from 'url';
 import { mkdir, appendFile, readFile, readdir, writeFile, rename, unlink, copyFile, access, stat, realpath } from 'fs/promises';
 import { existsSync, readFileSync, promises, mkdirSync, createWriteStream, writeFileSync, unlinkSync, constants } from 'fs';
@@ -690,7 +690,7 @@ var init_process_manager = __esm({
           if (child.killed || child.exitCode !== null) {
             continue;
           }
-          killPromises.push(new Promise((resolve4) => {
+          killPromises.push(new Promise((resolve5) => {
             let mainTimeoutId = null;
             let fallbackTimeoutId = null;
             let resolved = false;
@@ -705,7 +705,7 @@ var init_process_manager = __esm({
               }
               if (!resolved) {
                 resolved = true;
-                resolve4();
+                resolve5();
               }
             };
             child.once("exit", () => {
@@ -730,8 +730,8 @@ var init_process_manager = __esm({
         try {
           await Promise.race([
             Promise.all(killPromises),
-            new Promise((resolve4) => {
-              finalTimeoutId = setTimeout(resolve4, timeout);
+            new Promise((resolve5) => {
+              finalTimeoutId = setTimeout(resolve5, timeout);
             })
           ]);
         } finally {
@@ -2320,7 +2320,8 @@ var init_base_provider = __esm({
         try {
           const cliCommand = this.getCLICommand();
           const cliArgs = await this.getCLIArgs();
-          const argsString = cliArgs.length > 0 ? cliArgs.join(" ") + " " : "";
+          const escapedArgs = cliArgs.map((arg) => this.escapeShellArg(arg));
+          const argsString = escapedArgs.length > 0 ? escapedArgs.join(" ") + " " : "";
           const escapedPrompt = this.escapeShellArg(prompt);
           const fullCommand = `${cliCommand} ${argsString}${escapedPrompt}`;
           const commandLength = fullCommand.length;
@@ -2363,7 +2364,7 @@ var init_base_provider = __esm({
        * @returns Promise resolving to stdout and stderr
        */
       async executeWithSpawn(command, cliCommand) {
-        return new Promise((resolve4, reject) => {
+        return new Promise((resolve5, reject) => {
           const child = spawn(command, [], {
             shell: true,
             // Auto-detects: cmd.exe on Windows, /bin/sh on Unix
@@ -2462,11 +2463,16 @@ var init_base_provider = __esm({
             if (stderr) {
               logger.debug(`${cliCommand} CLI stderr output`, { stderr: stderr.trim() });
             }
-            if (code === 0 || code === null) {
+            if ((code === 0 || code === null) && !signal) {
               if (progressParser) {
                 progressParser.succeed(`${cliCommand} completed successfully`);
               }
-              resolve4({ stdout, stderr });
+              resolve5({ stdout, stderr });
+            } else if (signal) {
+              if (progressParser) {
+                progressParser.fail(`${cliCommand} killed by signal ${signal}`);
+              }
+              reject(new Error(`${cliCommand} CLI killed by signal ${signal}. stderr: ${stderr || "none"}`));
             } else {
               if (progressParser) {
                 progressParser.fail(`${cliCommand} failed with code ${code}`);
@@ -2516,7 +2522,7 @@ var init_base_provider = __esm({
        * @returns Promise resolving to stdout and stderr
        */
       async executeWithStdin(cliCommand, cliArgs, prompt) {
-        return new Promise((resolve4, reject) => {
+        return new Promise((resolve5, reject) => {
           const commandArgs = cliArgs ? cliArgs.split(" ").filter(Boolean) : [];
           logger.debug(`Executing ${cliCommand} CLI with stdin`, {
             command: cliCommand,
@@ -2629,7 +2635,7 @@ var init_base_provider = __esm({
               if (progressParser) {
                 progressParser.succeed(`${cliCommand} completed successfully`);
               }
-              resolve4({ stdout, stderr });
+              resolve5({ stdout, stderr });
             } else {
               if (progressParser) {
                 progressParser.fail(`${cliCommand} failed with code ${code}`);
@@ -2752,6 +2758,10 @@ ${fullPrompt}
               errors: responseValidation.error.issues,
               response
             });
+            throw new ProviderError(
+              `Provider returned invalid response structure: ${responseValidation.error.issues.map((i) => i.message).join(", ")}`,
+              "E1305" /* PROVIDER_EXEC_ERROR */
+            );
           }
           return response;
         } catch (error) {
@@ -3381,7 +3391,7 @@ var init_cli_wrapper = __esm({
        * Spawn codex process
        */
       async spawnProcess(args2, prompt, timeout) {
-        return new Promise((resolve4, reject) => {
+        return new Promise((resolve5, reject) => {
           let stdout = "";
           let stderr = "";
           let hasTimedOut = false;
@@ -3438,7 +3448,7 @@ var init_cli_wrapper = __esm({
               return;
             }
             if (code === 0) {
-              resolve4({ stdout, stderr, exitCode: code });
+              resolve5({ stdout, stderr, exitCode: code });
             } else {
               reject(
                 new CodexError(
@@ -3471,7 +3481,7 @@ var init_cli_wrapper = __esm({
        * Spawn codex process with streaming support
        */
       async spawnProcessWithStreaming(args2, prompt, timeout, renderer) {
-        return new Promise((resolve4, reject) => {
+        return new Promise((resolve5, reject) => {
           let stdout = "";
           let stderr = "";
           let hasTimedOut = false;
@@ -3541,7 +3551,7 @@ var init_cli_wrapper = __esm({
               if (renderer) {
                 renderer.succeed("Execution complete");
               }
-              resolve4({ stdout, stderr, exitCode: code });
+              resolve5({ stdout, stderr, exitCode: code });
             } else {
               if (renderer) {
                 renderer.fail(`Process exited with code ${code}`);
@@ -5219,7 +5229,7 @@ var PRECOMPILED_CONFIG = {
     "enableFreeTierPrioritization": true,
     "enableWorkloadAwareRouting": true
   },
-  "version": "11.2.5"
+  "version": "11.2.6"
 };
 
 // src/core/config-schemas.ts
@@ -8289,23 +8299,29 @@ var Router = class {
         const isCircuitOpen = this.circuitBreaker.isOpen(provider.name);
         healthMultipliers.set(provider.name, isCircuitOpen ? 0.5 : 1);
       }
-      const scores = await getProviderMetricsTracker().getAllScores(
-        providerNames,
-        strategyManager.getWeights(),
-        healthMultipliers
-      );
-      if (scores.length > 0) {
-        const scoreMap = new Map(scores.map((s) => [s.provider, s.totalScore]));
-        const originalOrder = providersToTry.map((p) => p.name);
-        providersToTry = [...providersToTry].sort((a, b) => {
-          const scoreA = scoreMap.get(a.name) ?? 0;
-          const scoreB = scoreMap.get(b.name) ?? 0;
-          return scoreB - scoreA;
-        });
-        logger.debug("Provider order after multi-factor routing", {
-          original: originalOrder,
-          reordered: providersToTry.map((p) => p.name),
-          scores: Object.fromEntries(scoreMap)
+      try {
+        const scores = await getProviderMetricsTracker().getAllScores(
+          providerNames,
+          strategyManager.getWeights(),
+          healthMultipliers
+        );
+        if (scores.length > 0) {
+          const scoreMap = new Map(scores.map((s) => [s.provider, s.totalScore]));
+          const originalOrder = providersToTry.map((p) => p.name);
+          providersToTry = [...providersToTry].sort((a, b) => {
+            const scoreA = scoreMap.get(a.name) ?? 0;
+            const scoreB = scoreMap.get(b.name) ?? 0;
+            return scoreB - scoreA;
+          });
+          logger.debug("Provider order after multi-factor routing", {
+            original: originalOrder,
+            reordered: providersToTry.map((p) => p.name),
+            scores: Object.fromEntries(scoreMap)
+          });
+        }
+      } catch (scoringError) {
+        logger.warn("Multi-factor scoring failed, using priority order", {
+          error: scoringError.message
         });
       }
     }
@@ -10183,8 +10199,11 @@ var MemoryManager = class _MemoryManager {
       }
       const tempPath = `${this.config.dbPath}.restore.tmp`;
       const srcDb = new Database2(srcPath, { readonly: true });
-      await srcDb.backup(tempPath);
-      srcDb.close();
+      try {
+        await srcDb.backup(tempPath);
+      } finally {
+        srcDb.close();
+      }
       try {
         const tempDb = new Database2(tempPath, { readonly: true });
         tempDb.prepare("SELECT COUNT(*) FROM memory_entries").get();
@@ -12940,7 +12959,7 @@ var __filename2 = fileURLToPath(import.meta.url);
 var __dirname3 = dirname(__filename2);
 function getPackageRoot() {
   const currentDir = __dirname3;
-  if (currentDir.includes("/dist")) {
+  if (currentDir.includes(`${sep}dist`) || currentDir.includes("/dist")) {
     return join(currentDir, "..");
   } else {
     return join(currentDir, "../..");
@@ -13633,7 +13652,7 @@ var __filename3 = fileURLToPath(import.meta.url);
 var __dirname4 = dirname(__filename3);
 function getPackageRoot2() {
   const currentDir = __dirname4;
-  if (currentDir.includes("/dist")) {
+  if (currentDir.includes(`${sep}dist`) || currentDir.includes("/dist")) {
     return join(currentDir, "..");
   } else {
     return join(currentDir, "../..");
@@ -13933,6 +13952,7 @@ var TeamManager = class {
 // src/core/conversation-context-store.ts
 init_esm_shims();
 init_logger();
+var VALID_ID_PATTERN = /^[A-Za-z0-9_-]{1,64}$/;
 var ConversationContextStore = class {
   storePath;
   maxEntries;
@@ -13942,6 +13962,33 @@ var ConversationContextStore = class {
     this.maxEntries = options.maxEntries ?? 100;
     this.ttlMs = options.ttlMs ?? 24 * 60 * 60 * 1e3;
   }
+  /**
+   * Validate and sanitize context ID to prevent path traversal attacks
+   *
+   * SECURITY: This is critical to prevent path traversal vulnerabilities.
+   * A malicious ID like "../../.ssh/id_rsa" could read/write/delete files
+   * outside the context store directory.
+   *
+   * @param id - Context ID to validate
+   * @returns Sanitized file path within storePath
+   * @throws Error if ID is invalid or path escapes storePath
+   */
+  validateAndResolvePath(id) {
+    if (!VALID_ID_PATTERN.test(id)) {
+      throw new Error(
+        `Invalid context ID: "${id}". IDs must be 1-64 characters, alphanumeric with underscores/hyphens only.`
+      );
+    }
+    const filePath = join(this.storePath, `${id}.json`);
+    const resolvedPath = resolve(filePath);
+    const resolvedStorePath = resolve(this.storePath);
+    const relativePath = relative(resolvedStorePath, resolvedPath);
+    if (relativePath.startsWith("..") || relativePath.includes("/..") || relativePath.includes("\\..")) {
+      logger.error("[ContextStore] Path traversal attempt blocked", { id, resolvedPath });
+      throw new Error(`Security violation: context ID "${id}" would escape store directory`);
+    }
+    return resolvedPath;
+  }
   /**
    * Initialize store (create directory if needed)
    */
@@ -13959,7 +14006,7 @@ var ConversationContextStore = class {
    */
   async save(context) {
     await this.initialize();
-    const filePath = join(this.storePath, `${context.id}.json`);
+    const filePath = this.validateAndResolvePath(context.id);
     const data = JSON.stringify(context, null, 2);
     try {
       await writeFile(filePath, data, "utf-8");
@@ -13978,7 +14025,7 @@ var ConversationContextStore = class {
    * Get conversation context by ID
    */
   async get(id) {
-    const filePath = join(this.storePath, `${id}.json`);
+    const filePath = this.validateAndResolvePath(id);
     try {
       const data = await readFile(filePath, "utf-8");
       const context = JSON.parse(data);
@@ -14032,7 +14079,7 @@ var ConversationContextStore = class {
    * Delete context entry
    */
   async delete(id) {
-    const filePath = join(this.storePath, `${id}.json`);
+    const filePath = this.validateAndResolvePath(id);
     try {
       await unlink(filePath);
       logger.info("[ContextStore] Context deleted", { id });
@@ -16466,7 +16513,7 @@ ${context.task}`;
    * @param signal - Optional AbortSignal to cancel the sleep
    */
   sleep(ms, signal) {
-    return new Promise((resolve4, reject) => {
+    return new Promise((resolve5, reject) => {
       if (signal?.aborted) {
         reject(new Error("Sleep cancelled"));
         return;
@@ -16476,7 +16523,7 @@ ${context.task}`;
         if (abortHandler && signal) {
           signal.removeEventListener("abort", abortHandler);
         }
-        resolve4();
+        resolve5();
       }, ms);
       if (signal) {
         abortHandler = () => {
@@ -17894,10 +17941,10 @@ var McpClient = class extends EventEmitter {
       return;
     }
     if (this.state.status === "connecting") {
-      return new Promise((resolve4, reject) => {
+      return new Promise((resolve5, reject) => {
         const onConnected = () => {
           this.off("error", onError);
-          resolve4();
+          resolve5();
         };
         const onError = (err) => {
           this.off("connected", onConnected);
@@ -18064,14 +18111,14 @@ var McpClient = class extends EventEmitter {
       method,
       params
     };
-    return new Promise((resolve4, reject) => {
+    return new Promise((resolve5, reject) => {
       const timeoutMs = timeout ?? this.config.timeout;
       const timeoutHandle = setTimeout(() => {
         this.pendingRequests.delete(id);
         reject(new Error(`Request timed out after ${timeoutMs}ms: ${method}`));
       }, timeoutMs);
       this.pendingRequests.set(id, {
-        resolve: resolve4,
+        resolve: resolve5,
         reject,
         timeout: timeoutHandle
       });
@@ -18529,15 +18576,15 @@ var McpClientPool = class extends EventEmitter {
     }
   }
   async waitForConnection(provider, pool) {
-    return new Promise((resolve4, reject) => {
+    return new Promise((resolve5, reject) => {
       const timeout = setTimeout(() => {
-        const index = pool.waitQueue.findIndex((w) => w.resolve === resolve4);
+        const index = pool.waitQueue.findIndex((w) => w.resolve === resolve5);
         if (index !== -1) {
           pool.waitQueue.splice(index, 1);
         }
         reject(new ConnectionTimeoutError(provider, this.config.acquireTimeoutMs));
       }, this.config.acquireTimeoutMs);
-      pool.waitQueue.push({ resolve: resolve4, reject, timeout });
+      pool.waitQueue.push({ resolve: resolve5, reject, timeout });
       logger.debug("[MCP Pool] Waiting for connection", {
         provider,
         queuePosition: pool.waitQueue.length
@@ -20014,6 +20061,8 @@ var McpServer = class _McpServer {
   initializationPromise = null;
   initializationMutex = new Mutex();
   // BUG FIX (v9.0.1): Prevent concurrent initialization
+  stdinMutex = new Mutex();
+  // BUG FIX: Prevent race conditions in stdin message processing
   version;
   ajv;
   compiledValidators = /* @__PURE__ */ new Map();
@@ -20389,7 +20438,15 @@ var McpServer = class _McpServer {
    * v10.5.0: Capture clientInfo for Smart Routing
    */
   async handleInitialize(request, id) {
-    const clientInfo = request.params.clientInfo;
+    const clientInfo = request.params?.clientInfo;
+    if (!clientInfo || typeof clientInfo.name !== "string" || typeof clientInfo.version !== "string") {
+      logger.warn("[MCP Server] Invalid initialize request: missing or invalid clientInfo", {
+        hasParams: !!request.params,
+        hasClientInfo: !!clientInfo,
+        clientInfo
+      });
+      return this.createErrorResponse(id, -32600 /* InvalidRequest */, "Invalid initialize request: clientInfo with name and version is required");
+    }
     logger.info("[MCP Server] Initialize request received (fast handshake mode)", { clientInfo });
     this.session = {
       clientInfo: {
@@ -20515,67 +20572,77 @@ ${json}`;
     logger.info("[MCP Server] Starting stdio JSON-RPC server...");
     let buffer = "";
     let contentLength = null;
-    process.stdin.on("data", async (chunk) => {
-      buffer += chunk.toString("utf-8");
-      if (buffer.length > STDIO_MAX_BUFFER_SIZE) {
-        logger.error("[MCP Server] Buffer size exceeded maximum", {
-          bufferSize: buffer.length,
-          maxSize: STDIO_MAX_BUFFER_SIZE
-        });
-        buffer = "";
-        contentLength = null;
-        return;
-      }
-      let iterations = 0;
-      while (iterations < STDIO_MAX_ITERATIONS) {
-        iterations++;
-        if (contentLength === null) {
-          const delimiter2 = buffer.includes("\r\n\r\n") ? "\r\n\r\n" : buffer.includes("\n\n") ? "\n\n" : null;
-          if (!delimiter2) break;
-          const headerEndIndex = buffer.indexOf(delimiter2);
-          const headerBlock = buffer.slice(0, headerEndIndex);
-          for (const line of headerBlock.split(delimiter2 === "\r\n\r\n" ? "\r\n" : "\n")) {
-            const [key, value] = line.split(":", 2).map((s) => s.trim());
-            if (key && key.toLowerCase() === "content-length" && value) {
-              contentLength = parseInt(value, 10);
-              if (isNaN(contentLength) || contentLength <= 0 || contentLength > STDIO_MAX_MESSAGE_SIZE) {
-                logger.error("[MCP Server] Invalid Content-Length", { contentLength });
-                buffer = buffer.slice(headerEndIndex + delimiter2.length);
-                contentLength = null;
-                continue;
+    process.stdin.on("data", (chunk) => {
+      void this.stdinMutex.runExclusive(async () => {
+        buffer += chunk.toString("utf-8");
+        if (buffer.length > STDIO_MAX_BUFFER_SIZE) {
+          logger.error("[MCP Server] Buffer size exceeded maximum", {
+            bufferSize: buffer.length,
+            maxSize: STDIO_MAX_BUFFER_SIZE
+          });
+          buffer = "";
+          contentLength = null;
+          return;
+        }
+        let iterations = 0;
+        while (iterations < STDIO_MAX_ITERATIONS) {
+          iterations++;
+          if (contentLength === null) {
+            const delimiter2 = buffer.includes("\r\n\r\n") ? "\r\n\r\n" : buffer.includes("\n\n") ? "\n\n" : null;
+            if (!delimiter2) break;
+            const headerEndIndex = buffer.indexOf(delimiter2);
+            const headerBlock = buffer.slice(0, headerEndIndex);
+            for (const line of headerBlock.split(delimiter2 === "\r\n\r\n" ? "\r\n" : "\n")) {
+              const [key, value] = line.split(":", 2).map((s) => s.trim());
+              if (key && key.toLowerCase() === "content-length" && value) {
+                contentLength = parseInt(value, 10);
+                if (isNaN(contentLength) || contentLength <= 0 || contentLength > STDIO_MAX_MESSAGE_SIZE) {
+                  logger.error("[MCP Server] Invalid Content-Length", { contentLength });
+                  this.writeResponse({
+                    jsonrpc: "2.0",
+                    id: null,
+                    error: {
+                      code: -32600 /* InvalidRequest */,
+                      message: `Invalid Content-Length: ${contentLength}`
+                    }
+                  });
+                  buffer = buffer.slice(headerEndIndex + delimiter2.length);
+                  contentLength = null;
+                  continue;
+                }
               }
             }
-          }
-          if (contentLength === null) {
-            logger.error("[MCP Server] No Content-Length header found");
+            if (contentLength === null) {
+              logger.error("[MCP Server] No Content-Length header found");
+              buffer = buffer.slice(headerEndIndex + delimiter2.length);
+              continue;
+            }
             buffer = buffer.slice(headerEndIndex + delimiter2.length);
-            continue;
           }
-          buffer = buffer.slice(headerEndIndex + delimiter2.length);
-        }
-        if (Buffer.byteLength(buffer, "utf-8") < contentLength) break;
-        const messageBuffer = Buffer.from(buffer, "utf-8");
-        const jsonMessage = messageBuffer.slice(0, contentLength).toString("utf-8");
-        buffer = messageBuffer.slice(contentLength).toString("utf-8");
-        contentLength = null;
-        try {
-          const request = JSON.parse(jsonMessage);
-          logger.debug("[MCP Server] Request received", { method: request.method, id: request.id });
-          const response = await this.handleRequest(request);
-          if (request.id !== void 0 && request.id !== null) {
-            this.writeResponse(response);
+          if (Buffer.byteLength(buffer, "utf-8") < contentLength) break;
+          const messageBuffer = Buffer.from(buffer, "utf-8");
+          const jsonMessage = messageBuffer.slice(0, contentLength).toString("utf-8");
+          buffer = messageBuffer.slice(contentLength).toString("utf-8");
+          contentLength = null;
+          try {
+            const request = JSON.parse(jsonMessage);
+            logger.debug("[MCP Server] Request received", { method: request.method, id: request.id });
+            const response = await this.handleRequest(request);
+            if (request.id !== void 0 && request.id !== null) {
+              this.writeResponse(response);
+            }
+          } catch (error) {
+            logger.error("[MCP Server] Failed to parse or handle request", { jsonMessage, error });
+            this.writeResponse({ jsonrpc: "2.0", id: null, error: { code: -32700 /* ParseError */, message: "Parse error: Invalid JSON" } });
           }
-        } catch (error) {
-          logger.error("[MCP Server] Failed to parse or handle request", { jsonMessage, error });
-          this.writeResponse({ jsonrpc: "2.0", id: null, error: { code: -32700 /* ParseError */, message: "Parse error: Invalid JSON" } });
         }
-      }
-      if (iterations >= STDIO_MAX_ITERATIONS) {
-        logger.warn("[MCP Server] Maximum iterations reached in message processing", {
-          iterations,
-          bufferSize: buffer.length
-        });
-      }
+        if (iterations >= STDIO_MAX_ITERATIONS) {
+          logger.warn("[MCP Server] Maximum iterations reached in message processing", {
+            iterations,
+            bufferSize: buffer.length
+          });
+        }
+      });
     });
     const shutdown = (reason) => {
       logger.info(`[MCP Server] ${reason}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@defai.digital/automatosx",
-  "version": "11.2.5",
+  "version": "11.2.6",
   "description": "Provider-agnostic AI orchestration platform with 20+ specialized agents, persistent memory, and multi-provider routing for Claude Code, Gemini CLI, Codex CLI, and ax-cli",
   "type": "module",
   "publishConfig": {