@deeeed/metamask-harness 0.94.1 → 0.94.3

package/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 ## Unreleased
 
+## 0.94.3 - 2026-10-25
+
+### Fixed
+
+- Extension testnet `close_visible_position` with `cleanup_only` binds one position by market and exact visible size. Fresh and resumed cleanup prove the accepted full close and zero target-market positions/orders without reconciling unrelated account-balance changes; the result names the cleaned market. Same-market orders still block, and mainnet keeps its global cleanup and balance guards.
+
+## 0.94.2 - 2026-10-24
+
+### Fixed
+
+- Treat disappeared or reused companion processes as already stopped, preserving the unrelated PID and allowing repeated slot cleanup.
+
 ## 0.94.1 - 2026-10-22
 
 ### Fixed

package/adapters/mobile/lib/idb-companion.sh

@@ -41,8 +41,6 @@ stop_checkout_idb_companions() {
     else
       status=$?
       [ "$status" -eq 1 ] && continue
-      printf 'Companion ownership is unknown. Next: mm-harness status --target "%s"\n' "$repo" >&2
-      return 1
     fi
     if ! stop_verified_process "$pid" "$identity" 'TERM KILL' 0.1 _idb_companion_owned "$repo" "$udid" "$pid" "$identity"; then
       printf 'Companion %s cleanup was not confirmed. Next: mm-harness status --target "%s"\n' "$pid" "$repo" >&2

package/adapters/shared/process-identity.sh

@@ -15,7 +15,9 @@ stop_verified_process() {
   fi
   for signal in $signals; do
     if ! "$@"; then
-      if [ -z "$(process_identity "$pid")" ] && ! kill -0 "$pid" 2>/dev/null; then return 0; fi
+      current="$(process_identity "$pid")"
+      if [ -n "$current" ] && [ "$current" != "$identity" ]; then return 0; fi
+      if [ -z "$current" ] && ! kill -0 "$pid" 2>/dev/null; then return 0; fi
       printf 'Process %s ownership changed before stop.\n' "$pid" >&2
       return 1
     fi
@@ -23,6 +25,7 @@ stop_verified_process() {
     for attempt in $(seq 1 20); do
       current="$(process_identity "$pid")"
       if [ -z "$current" ] && ! kill -0 "$pid" 2>/dev/null; then return 0; fi
+      if [ -n "$current" ] && [ "$current" != "$identity" ]; then return 0; fi
       if [ "$current" != "$identity" ]; then
         printf 'Process %s identity changed during stop.\n' "$pid" >&2
         return 1

package/library/actions/extension/perps/close_visible_position.mjs

@@ -208,9 +208,10 @@ async function prepareCloseModal(page, partialAmount) {
   return confirmation;
 }
 
-async function proveGlobalCleanup(page, balanceBeforeBaseUnits, releaseBaseUnits, toleranceBaseUnits, timeoutMs = 20_000) {
+async function proveCleanup(page, balanceBeforeBaseUnits, releaseBaseUnits, toleranceBaseUnits, market = null, timeoutMs = 20_000) {
   await page.navigateHash('#/perps-home');
-  const state = await waitForStableGlobalPerpsHome(page, { timeoutMs, requireZero: true });
+  const state = await waitForStableGlobalPerpsHome(page, { timeoutMs, requireZero: true, market });
+  if (market) return { market, positionCount: 0, orderCount: 0 };
   const expectedBalanceAfterBaseUnits = `${BigInt(balanceBeforeBaseUnits) + BigInt(releaseBaseUnits ?? '0')}`;
   const balanceDeltaBaseUnits = absoluteDelta(state.balanceBaseUnits, expectedBalanceAfterBaseUnits);
   if (BigInt(balanceDeltaBaseUnits) > BigInt(toleranceBaseUnits)) {
@@ -293,6 +294,7 @@ export async function closeVisiblePosition(input) {
     roundingToleranceBaseUnits,
     ...(cleanupOnly ? { positionSize: fundingPositionSize, cleanupOnly: true } : {}),
   });
+  const cleanupMarket = cleanupOnly && identity.network === 'testnet' ? market : null;
   const closeBudget = trustedExternalMutationBudget(input, 'perps-close-position');
   const existingReceipt = await readExternalMutationReceipt(input, identity);
   if (existingReceipt) {
@@ -334,11 +336,12 @@ export async function closeVisiblePosition(input) {
                 if (releaseBaseUnits != null && !/^-?(?:0|[1-9][0-9]{0,29})$/u.test(String(releaseBaseUnits))) {
                   throw new Error('Resumed close receipt has an invalid close release amount.');
                 }
-                const cleanup = await proveGlobalCleanup(
+                const cleanup = await proveCleanup(
                   page,
                   balanceBeforeBaseUnits,
                   releaseBaseUnits,
                   balanceToleranceBaseUnits,
+                  cleanupMarket,
                 );
                 return {
                   success: true,
@@ -374,8 +377,9 @@ export async function closeVisiblePosition(input) {
   let cleanupHomeBefore = null;
   if (cleanupOnly) {
     await page.navigateHash('#/perps-home');
-    cleanupHomeBefore = await waitForStableGlobalPerpsHome(page, { timeoutMs: 20_000, requireZero: false });
+    cleanupHomeBefore = await waitForStableGlobalPerpsHome(page, { timeoutMs: 20_000, requireZero: false, market: cleanupMarket });
     if (cleanupHomeBefore.positionCount !== 1 || cleanupHomeBefore.orderCount !== 0) {
+      if (cleanupMarket) throw new Error('Cleanup-only close requires exactly one position and zero orders in the target market.');
       throw new Error('Cleanup-only close requires exactly one primary position and globally zero orders.');
     }
   }
@@ -451,7 +455,7 @@ export async function closeVisiblePosition(input) {
     dispatch: async () => {
       let dispatchTarget;
       try {
-        await requireCurrentVisibleFundingBalance(input, page, timeoutMs, fundingBalance.observedBaseUnits);
+        await requireCurrentVisibleFundingBalance(input, page, timeoutMs, cleanupMarket ? undefined : fundingBalance.observedBaseUnits);
         assertTrustedExternalMutationTarget(input, page, identity);
         const current = await readVisibleClosePosition(page, market);
         const currentPosition = parsePositionDetail({ pair: `${market}-USD`, ...current });
@@ -522,11 +526,12 @@ export async function closeVisiblePosition(input) {
             `Boolean(document.querySelector('[data-testid="perps-position-size-value"]'))`,
           );
           if (exactAbsent) {
-            const cleanup = await proveGlobalCleanup(
+            const cleanup = await proveCleanup(
               page,
               balanceBeforeBaseUnits,
               closeReleaseBaseUnits,
               balanceToleranceBaseUnits,
+              cleanupMarket,
             );
             return {
               success: true,

package/library/actions/extension/perps/visible-mutation-identity.mjs

@@ -1,5 +1,5 @@
 // Parse and match visible Perps position and order identities using USD base-unit tolerances.
-// Also wait for a stable, loaded Perps home view, optionally requiring zero positions and orders.
+// Also wait for a stable Perps home view, with optional global or market-scoped cleanup checks.
 const INTEGER = /^(0|[1-9][0-9]{0,29})$/u;
 
 export function parseUsdBaseUnits(value) {
@@ -119,18 +119,21 @@ export async function waitForStableGlobalPerpsHome(page, options = {}) {
   const timeoutMs = Number(options.timeoutMs ?? 20_000);
   const stableMs = Number(options.stableMs ?? 1_000);
   const requireZero = options.requireZero !== false;
+  const market = options.market ?? null;
   const deadline = Date.now() + timeoutMs;
   let stableSince = null;
   let last = null;
   while (Date.now() <= deadline) {
     last = await page.evaluate(`(() => {
+      const market = ${JSON.stringify(market)};
       const visible = (element) => {
         if (!element) return false;
         const rect = element.getBoundingClientRect();
         const style = getComputedStyle(element);
         return rect.width > 0 && rect.height > 0 && style.display !== 'none' && style.visibility !== 'hidden';
       };
-      const visibleCount = (selector) => [...document.querySelectorAll(selector)].filter(visible).length;
+      const visibleCount = (selector, childSelector = null) => [...document.querySelectorAll(selector)]
+        .filter(element => visible(element) && (!childSelector || element.querySelector(childSelector))).length;
       const balance = document.querySelector('[data-testid="perps-balance-actions-available-value"]')
         ?? document.querySelector('[data-testid="perps-balance-dropdown-balance"]');
       return {
@@ -139,8 +142,10 @@ export async function waitForStableGlobalPerpsHome(page, options = {}) {
           ?? document.querySelector('[data-testid="perps-view"]')),
         loading: visibleCount('[data-testid$="-skeleton"], [data-testid*="loading"]') > 0,
         marketCount: visibleCount('[data-testid="perps-explore-markets-row"]'),
-        positionCount: visibleCount('[data-testid^="position-card-"]:not([data-testid^="position-card-roe-"])'),
-        orderCount: visibleCount('[data-testid^="order-card-"]'),
+        positionCount: visibleCount(market ? '[data-testid="position-card-' + market + '" i]'
+          : '[data-testid^="position-card-"]:not([data-testid^="position-card-roe-"])'),
+        orderCount: visibleCount('[data-testid^="order-card-"]', market
+          ? '[data-testid="perps-token-logo-' + market.replace(/:/gu, '-') + '" i]' : null),
         balance: visible(balance) ? String(balance.innerText || '').replace(/\\s+/gu, ' ').trim().slice(0, 200) : null,
       };
     })()`);
@@ -162,6 +167,7 @@ export async function waitForStableGlobalPerpsHome(page, options = {}) {
     await new Promise((resolve) => setTimeout(resolve, 250));
   }
   if (requireZero && last && (last.positionCount !== 0 || last.orderCount !== 0)) {
+    if (market) throw new Error(`Loaded Perps Home must have zero positions and orders in ${market} before cleanup.`);
     throw new Error('Loaded Perps Home must have globally zero positions and orders before external mutation or cleanup.');
   }
   throw new Error('Loaded skeleton-free Perps Home did not become stable before timeout.');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.94.1",
+  "version": "0.94.3",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"