@deeeed/metamask-harness 0.92.21 → 0.92.23

package/CHANGELOG.md

@@ -2,6 +2,49 @@
 
 ## Unreleased
 
+## 0.92.23 - 2026-10-18
+
+### Changed
+
+- Pin `@farmslot/recipe-cli` 0.23.1 and `@farmslot/adapter-web` 0.10.15. A browser-extension launch no longer fails with `spawnSync ps ENOBUFS` on a host whose process list is over 1 MB.
+- `task init` and `execution-template` now run through the shared Farmslot handlers. Their output is unchanged.
+- `logs` now runs through the shared Farmslot handler:
+  - `--events` reaches the compact viewer as its argument; `logs` no longer sets `RECIPE_LOG_EVENTS` in its own environment.
+  - `--window` needs the dev-server log itself: when it is missing, `logs --window` exits 2 with `The primary log window is unavailable.` instead of opening a window on the missing file.
+  - `--full` runs `tail` as its own child, so stopping `mm-harness logs` also stops `tail`.
+  - A headless platform that declares logs is tailed; only one without logs is refused, naming that platform instead of always `core`.
+  - The "nothing running" error names the requested log only (on Extension it listed every log file).
+  - `--json` results include `target`.
+- `recipe-quality` now runs through the shared Farmslot handler: `plan` and `advise` use the detected platform when `--adapter` is absent, instead of exiting 2.
+- `checklist` now runs through the shared Farmslot handler:
+  - `mark` with `--checklist` or `--signal` checks the terminal signal and the check-diff gate against those files, not the defaults.
+  - `mark <task-dir> start` resumes a task whose signal is `blocked`.
+  - An explicit `--checklist` is used even when `checklist-target.json` is invalid.
+- `status` now runs through the shared Farmslot handler. The dashboard is unchanged: it still saves an explicit `--device` choice and shows no command journal.
+  - `status --task` and `status --watch` JSON, and each line under `--watch --json`, end with a `context` field (target and slot).
+  - The task view no longer reports another checkout's runtime context (an inherited `RECIPE_RUNTIME_CONTEXT`, or one whose `repoRoot` is elsewhere) as this checkout's slot, device and ports.
+- `doctor` now runs through the shared Farmslot handler. It still saves an explicit `--device` choice, and `--print-ready` still prints the Farmslot ready indicator.
+  - `--fix` prints one stderr progress line per repair stage, such as `[1/3] runtime-context: done, created, 0s` or `[3/3] host repair: failed, wallet-fixture, 0s`, with a heartbeat on a long stage. Stdout and the JSON are unchanged.
+  - A failing recorder without a next step no longer prints `Next: undefined`.
+  - Under `--expect-live --json`, a `RECORDER_UNAVAILABLE` error whose recorder gives no next step takes the runtime's next step as its `userAction`.
+  - `--fix` waits for a platform repair that returns a promise, and reports a rejected repair as failed instead of fixed.
+  - On a platform with both a recorder and live checks, the recorder check comes before the live checks in `checks` and `requiredChecks.failed`.
+- `review` and `domain` now run through the shared Farmslot handler. They keep every library this machine resolves (`RECIPE_LIBRARY_PATH`, `mm-harness config`, sibling checkouts, the fetch cache), `MM_HARNESS_DOMAIN`, and the checklist header, steps and verdict. `help review` is unchanged.
+  - `domain` names where a declared domain came from: `domain: declared via --domain` or `domain: declared via MM_HARNESS_DOMAIN` (it printed `declared via --domain or MM_HARNESS_DOMAIN`).
+  - `domain --domain <name> --json` outside a review checkout reports `"adapter": "unscoped"`, as `review --json` does (it reported `null`).
+  - When `domain` classifies against an `owned-paths.json` with an empty `domain` or invalid globs for the reviewed platform, it exits 2 with `Invalid owned-paths.json: <file>` or `Invalid owned paths for <platform>: <file>` (it exited 1 with a different message). `review checklist --domain` no longer reads the library's `owned-paths.json`.
+  - Setup step 2 names `review/antipatterns.<platform>.md` when the library has only that file (it named `review/antipatterns.md`).
+- `prepare` now runs through the shared Farmslot handler. Its steps, readiness record, refusals, Mobile device choice and exit codes are unchanged.
+  - Under `--json`, or when stdout or stderr is not a terminal, stderr gets a stage line per step (`[1/3] doctor --fix: started`, then `done` or `failed, <reason>`, with a heartbeat on a long step) and each step's own stage lines, prefixed with the step (`[1/3] doctor --fix › [1/3] runtime-context: done, created`). Stdout is unchanged.
+  - In a terminal, the running step's row shows its latest stage line instead of its hint.
+  - A platform plugin that declares `readiness.prepare` can be prepared.
+
+## 0.92.22 - 2026-10-18
+
+### Fixed
+
+- Mobile: the recipe HUD no longer satisfies or blocks a text-only `ui.wait_for` whose own HUD text (badge, intent or detail) contains the asserted text. Each poll hides the HUD (an earlier node's HUD included), then checks every 50 ms, for about 1 s, that the intent has left the app tree before it queries. It hides again if a late HUD update brings the HUD back. That node's HUD comes back with the next update. Such a wait reports `hud: "hidden"`. A poll that can't confirm the HUD left decides nothing. If the app itself shows the whole intent text, the wait times out and says so; reword the intent. Before, `expected: absent` never passed and `expected: visible` could pass on the HUD text alone. Waits with a `test_id` and waits that don't collide with the HUD are unchanged.
+
 ## 0.92.21 - 2026-10-17
 
 ### Added

package/dist/adapters/core/surface.js

@@ -93,9 +93,8 @@ const coreSurface = defineAdapter({
       };
     }
   },
-  readiness: coreReadiness,
-  fixtures: { operations: ["init", "sync", "set"] },
-  prepare: corePrepare
+  readiness: { ...coreReadiness, prepare: corePrepare },
+  fixtures: { operations: ["init", "sync", "set"] }
 });
 adapterRegistry.register(coreSurface);
 export {

package/dist/adapters/extension/surface.js

@@ -148,12 +148,11 @@ const extensionSurface = defineAdapter({
   actions: extensionActions,
   harness: extensionHarness,
   runtimeContext: extensionRuntimeContext,
-  readiness: extensionReadiness,
+  readiness: { ...extensionReadiness, prepare: extensionPrepare },
   fixtures: {
     operations: ["init", "sync", "set", "reset", "generate", "finalize"],
     apply: async (context) => (await import("./fixtures.js")).applyExtensionFixture(context)
   },
-  prepare: extensionPrepare,
   debug: {
     refuse: ({ devMenu }) => devMenu ? { message: "--dev-menu is mobile-only (RN developer menu). Use --worker on the extension.", userAction: "mm-harness debug --worker" } : void 0,
     args: ({ worker }) => [

package/dist/adapters/mobile/devices.js

@@ -17,7 +17,6 @@ const mobileDevices = {
   renderList: renderMobileDeviceList,
   renderAdditional: renderAdditionalReachableDevices,
   renderLive: renderMobileLiveBlock,
-  renderPortHints: renderAndroidPortHints,
   renderHints: (live, paint) => renderAndroidPortHints(live.androidPortHints, paint),
   nextForLive
 };

package/dist/adapters/mobile/overlay.js

@@ -1,4 +1,4 @@
-import { mobilePlatformFromConfiguredTarget, mobilePlatformFromDevices, readRuntimeContextTarget } from "./prepare-target.js";
+import { mobilePlatformFromConfiguredTarget, mobilePlatformFromDevices, mobileTargetAmbiguityError, readRuntimeContextTarget } from "./prepare-target.js";
 const mobileHarness = {
   install: { entry: "adapters/mobile/inject.sh", fallback: "scripts/inject-mobile-harness.sh" },
   cleanup: { entry: "adapters/mobile/cleanup.sh", fallback: "scripts/cleanup-mobile-harness.sh", fromInstalledRunner: true },
@@ -18,7 +18,8 @@ const mobileRuntimeContext = {
 };
 const mobilePrepare = {
   clearMetro: true,
-  devicePlatform: (target, devices) => mobilePlatformFromConfiguredTarget(process.env, readRuntimeContextTarget(target)) ?? mobilePlatformFromDevices(devices)
+  devicePlatform: (target, devices) => mobilePlatformFromConfiguredTarget(process.env, readRuntimeContextTarget(target)) ?? mobilePlatformFromDevices(devices),
+  ambiguousTarget: mobileTargetAmbiguityError
 };
 export {
   mobileHarness,

package/dist/adapters/mobile/prepare-target.js

@@ -31,8 +31,21 @@ function mobilePlatformFromDevices(devices) {
   ];
   return platforms.length === 1 ? platforms[0] : void 0;
 }
+function mobileTargetAmbiguityError() {
+  const choices = [
+    "1. iOS     mm-harness prepare --platform mobile --mobile-platform ios",
+    "2. Android mm-harness prepare --platform mobile --mobile-platform android"
+  ];
+  return {
+    code: "PREPARE_MOBILE_TARGET_AMBIGUOUS",
+    message: "could not infer the mobile target from the connected devices",
+    userAction: `choose the mobile target, then rerun this command:
+${choices.join("\n")}`
+  };
+}
 export {
   mobilePlatformFromConfiguredTarget,
   mobilePlatformFromDevices,
+  mobileTargetAmbiguityError,
   readRuntimeContextTarget
 };

package/dist/adapters/mobile/surface.js

@@ -107,12 +107,11 @@ const mobileSurface = defineAdapter({
   actions: mobileActions,
   harness: mobileHarness,
   runtimeContext: mobileRuntimeContext,
-  readiness: mobileReadiness,
+  readiness: { ...mobileReadiness, prepare: mobilePrepare },
   fixtures: {
     operations: ["init", "sync", "set", "reset"],
     apply: async (context) => (await import("./fixtures.js")).applyMobileFixture(context)
   },
-  prepare: mobilePrepare,
   debug: {
     refuse: ({ worker }) => worker ? { message: "--worker is extension-only (service-worker DevTools). Use --dev-menu on mobile.", userAction: "mm-harness debug --dev-menu" } : void 0,
     args: ({ devMenu }) => [

package/dist/adapters/mobile/ui.js

@@ -1,5 +1,6 @@
 import { execFile } from "node:child_process";
 import { promisify } from "node:util";
+import { hudIntentDisplay } from "@farmslot/protocol/recipe";
 import { bridgeCommand, evalAsync, evalSync, MOBILE_BRIDGE_ERROR_CODES, selectBridgeStatusEntry, simulatorScreenshot } from "../../../library/actions/mobile/platform/bridge.mjs";
 import { observeNativeUi } from "../../../library/actions/mobile/platform/observe-ui.mjs";
 import { nativeAgentDeviceStateDir } from "../../../library/actions/mobile/platform/native-session-name.mjs";
@@ -188,6 +189,16 @@ async function hiddenRouteOnly(input, probeInput, payload, testId, deadline) {
   const nativeVisible = visible.items.some((item) => isRecord(item) && item.test_id === testId && item.visible !== false);
   return nativeVisible ? null : { hiddenRoute: true, nativeVisible: false };
 }
+const HUD_HIDE_SETTLE_MS = 1e3;
+function hudIntentCollidingWith(payload, testId, expectedText) {
+  if (testId || !expectedText || typeof payload.intent !== "string") return null;
+  const intent = hudIntentDisplay(payload.intent).text;
+  if (!intent) return null;
+  const detail = typeof payload.detail === "string" ? payload.detail : "";
+  const needle = expectedText.toLowerCase();
+  const inBadge = ["run", "pass", "fail"].some((word) => `${word} 0/0`.includes(needle.replace(/\d+/gu, "0")));
+  return inBadge || [intent, detail].some((text) => text.toLowerCase().includes(needle)) ? intent : null;
+}
 async function waitForMobileTarget(input, payload) {
   const timeoutMs = Number(payload.timeout_ms ?? payload.timeoutMs ?? 1e4);
   const deadline = Date.now() + timeoutMs;
@@ -197,13 +208,43 @@ async function waitForMobileTarget(input, payload) {
     ...expectedText && textMatch === "contains" ? { textContains: expectedText } : {},
     visibility
   };
+  const hudIntent = hudIntentCollidingWith(payload, testId, expectedText);
   const queryExpression = `(function(){
     const api = globalThis.__AGENTIC__;
     if (!api || typeof api.queryUiTarget !== 'function') {
       return Promise.resolve(JSON.stringify({ unsupported: true }));
     }
-    return api.queryUiTarget(${JSON.stringify(query)}).then(function(result){
-      return JSON.stringify(result);
+    const query = function(){
+      return Promise.resolve(api.queryUiTarget(${JSON.stringify(query)}));
+    };
+    const hudIntent = ${JSON.stringify(hudIntent)};
+    if (hudIntent === null || typeof api.hideStep !== 'function') {
+      return query().then(function(result){ return JSON.stringify(result); });
+    }
+    const hudShown = function(){
+      return Promise.resolve(api.queryUiTarget({ textContains: hudIntent, visibility: 'tree' }))
+        .then(function(found){ return Boolean(found && found.present); });
+    };
+    // Hide, let React commit it, then look: an earlier node's HUD can still be
+    // up, and the tree only drops it after the commit. Hide again while this
+    // node's intent is shown, since a late HUD update can land after a hide.
+    const settle = function(waitedMs){
+      api.hideStep();
+      return new Promise(function(resolve){ setTimeout(resolve, 50); })
+        .then(hudShown)
+        .then(function(shown){
+          if (!shown) return true;
+          if (waitedMs + 50 >= ${HUD_HIDE_SETTLE_MS}) return false;
+          return settle(waitedMs + 50);
+        });
+    };
+    return settle(0).then(function(hidden){
+      if (!hidden) return JSON.stringify({ hudShown: true });
+      return query().then(function(result){
+        return hudShown().then(function(shown){
+          return JSON.stringify(shown ? { hudShown: true } : Object.assign({}, result, { hud: 'hidden' }));
+        });
+      });
     });
   })()`;
   const textExpression = testId ? `(function(){
@@ -241,6 +282,10 @@ async function waitForMobileTarget(input, payload) {
       );
     }
     lastResult = result;
+    if (result.hudShown === true) {
+      await sleep(100);
+      continue;
+    }
     let present = result.present === true;
     let visible = result.visible === true;
     let cachedRoute = null;
@@ -280,7 +325,8 @@ async function waitForMobileTarget(input, payload) {
         visible,
         visibility,
         ...cachedRoute ?? {},
-        ...isRecord(result.rect) ? { rect: result.rect } : {}
+        ...isRecord(result.rect) ? { rect: result.rect } : {},
+        ...typeof result.hud === "string" ? { hud: result.hud } : {}
       };
     }
     await sleep(250);
@@ -291,8 +337,9 @@ async function waitForMobileTarget(input, payload) {
   ].filter(Boolean).join(" with ");
   const exactReason = textMatch === "exact" ? `; last text=${JSON.stringify(lastText)}` : "";
   const bridgeReason = lastBridgeError ? `; last bridge error=${traceText(lastBridgeError)}` : "";
+  const hudReason = lastResult?.hudShown === true ? `; the recipe HUD showing this node's intent never left the app tree, so the text was not checked without it (if the app itself shows the intent text, reword the intent)` : "";
   throw new Error(
-    `Timed out waiting for mobile ${target} to be ${expected}; last result=${JSON.stringify(lastResult)}${exactReason}${bridgeReason}.`
+    `Timed out waiting for mobile ${target} to be ${expected}; last result=${JSON.stringify(lastResult)}${exactReason}${bridgeReason}${hudReason}.`
   );
 }
 const MOBILE_BRIDGE_HANDLERS = {