@deeeed/metamask-harness 0.92.20 → 0.92.22

package/CHANGELOG.md

@@ -2,6 +2,29 @@
 
 ## Unreleased
 
+## 0.92.22 - 2026-10-18
+
+### Fixed
+
+- Mobile: the recipe HUD no longer satisfies or blocks a text-only `ui.wait_for` whose own HUD text (badge, intent or detail) contains the asserted text. Each poll hides the HUD (an earlier node's HUD included), then checks every 50 ms, for about 1 s, that the intent has left the app tree before it queries. It hides again if a late HUD update brings the HUD back. That node's HUD comes back with the next update. Such a wait reports `hud: "hidden"`. A poll that can't confirm the HUD left decides nothing. If the app itself shows the whole intent text, the wait times out and says so; reword the intent. Before, `expected: absent` never passed and `expected: visible` could pass on the HUD text alone. Waits with a `test_id` and waits that don't collide with the HUD are unchanged.
+
+## 0.92.21 - 2026-10-17
+
+### Added
+
+- Restore `mm-harness pr-body render` as a thin command over the shared Farmslot renderer.
+
+### Changed
+
+- Pin the `@farmslot` packages to the release set with `@farmslot/recipe-cli` 0.23.0 (protocol 0.54.0, recipe-runner 0.39.0, adapter-sdk 0.18.0, agent-runtime 0.29.0, adapter-web 0.10.14, adapter-node 0.1.34, adapter-rn 0.22.23).
+
+### Fixed
+
+- `pr-body render` takes the Validation Recipe from the selected attempt's captured `recipe.json` (or the task's single retained package), not the editable `artifacts/recipe.json`, and names the run, runner, runner revision and recipe digest above its log.
+- `pr-body render` refuses a selected attempt that fails artifact validation or lacks its recipe or report, and refuses two candidate packages when no attempt is selected; it writes nothing in either case.
+- `pr-body render --out` refuses to overwrite the authored description, recipe, workflow, attempt selection or retained evidence.
+- `pr-body render` refuses symlinked or oversized (over 4 MiB) inputs, converts CRLF in fenced logs to LF, and creates new output files owner-only without following a symlink.
+
 ## 0.92.20 - 2026-10-17
 
 ### Removed

package/README.md

@@ -400,16 +400,16 @@ check for upstream updates. Keep the selected library unchanged during a run.
 ```bash
 # Write artifacts/pr-description.md in the repository PR template shape (prose
 # only), then render the publishable body.
-farmslot recipe artifacts temp/tasks/dev/TAT-1 --format markdown \
-  --out temp/tasks/dev/TAT-1/artifacts/pr-body.md \
-  --command 'farmslot recipe run artifacts/recipe.json'
+mm-harness pr-body render temp/tasks/dev/TAT-1 --command 'mm-harness run artifacts/recipe.json'
 ```
 
-The Markdown renderer writes `artifacts/pr-body.md`: the description with the "Validation
+`pr-body render` writes `artifacts/pr-body.md`: the description with the "Validation
 Recipe" and "Validation Logs" sections rendered from `artifacts/recipe.json` and
 `artifacts/recipe-run/report.md` (and "Recipe Workflow" from `artifacts/workflow.mmd`
 when it exists), replacing any pasted by hand. The worker never pastes artifacts
-into markdown, so fences cannot break.
+into markdown, so fences cannot break. When a passing run recorded the task's
+selected attempt, both sections come from that attempt's validated package; a package
+that fails validation is refused, and nothing is written.
 
 ## Review a change
 

package/dist/adapters/mobile/ui.js

@@ -1,5 +1,6 @@
 import { execFile } from "node:child_process";
 import { promisify } from "node:util";
+import { hudIntentDisplay } from "@farmslot/protocol/recipe";
 import { bridgeCommand, evalAsync, evalSync, MOBILE_BRIDGE_ERROR_CODES, selectBridgeStatusEntry, simulatorScreenshot } from "../../../library/actions/mobile/platform/bridge.mjs";
 import { observeNativeUi } from "../../../library/actions/mobile/platform/observe-ui.mjs";
 import { nativeAgentDeviceStateDir } from "../../../library/actions/mobile/platform/native-session-name.mjs";
@@ -188,6 +189,16 @@ async function hiddenRouteOnly(input, probeInput, payload, testId, deadline) {
   const nativeVisible = visible.items.some((item) => isRecord(item) && item.test_id === testId && item.visible !== false);
   return nativeVisible ? null : { hiddenRoute: true, nativeVisible: false };
 }
+const HUD_HIDE_SETTLE_MS = 1e3;
+function hudIntentCollidingWith(payload, testId, expectedText) {
+  if (testId || !expectedText || typeof payload.intent !== "string") return null;
+  const intent = hudIntentDisplay(payload.intent).text;
+  if (!intent) return null;
+  const detail = typeof payload.detail === "string" ? payload.detail : "";
+  const needle = expectedText.toLowerCase();
+  const inBadge = ["run", "pass", "fail"].some((word) => `${word} 0/0`.includes(needle.replace(/\d+/gu, "0")));
+  return inBadge || [intent, detail].some((text) => text.toLowerCase().includes(needle)) ? intent : null;
+}
 async function waitForMobileTarget(input, payload) {
   const timeoutMs = Number(payload.timeout_ms ?? payload.timeoutMs ?? 1e4);
   const deadline = Date.now() + timeoutMs;
@@ -197,13 +208,43 @@ async function waitForMobileTarget(input, payload) {
     ...expectedText && textMatch === "contains" ? { textContains: expectedText } : {},
     visibility
   };
+  const hudIntent = hudIntentCollidingWith(payload, testId, expectedText);
   const queryExpression = `(function(){
     const api = globalThis.__AGENTIC__;
     if (!api || typeof api.queryUiTarget !== 'function') {
       return Promise.resolve(JSON.stringify({ unsupported: true }));
     }
-    return api.queryUiTarget(${JSON.stringify(query)}).then(function(result){
-      return JSON.stringify(result);
+    const query = function(){
+      return Promise.resolve(api.queryUiTarget(${JSON.stringify(query)}));
+    };
+    const hudIntent = ${JSON.stringify(hudIntent)};
+    if (hudIntent === null || typeof api.hideStep !== 'function') {
+      return query().then(function(result){ return JSON.stringify(result); });
+    }
+    const hudShown = function(){
+      return Promise.resolve(api.queryUiTarget({ textContains: hudIntent, visibility: 'tree' }))
+        .then(function(found){ return Boolean(found && found.present); });
+    };
+    // Hide, let React commit it, then look: an earlier node's HUD can still be
+    // up, and the tree only drops it after the commit. Hide again while this
+    // node's intent is shown, since a late HUD update can land after a hide.
+    const settle = function(waitedMs){
+      api.hideStep();
+      return new Promise(function(resolve){ setTimeout(resolve, 50); })
+        .then(hudShown)
+        .then(function(shown){
+          if (!shown) return true;
+          if (waitedMs + 50 >= ${HUD_HIDE_SETTLE_MS}) return false;
+          return settle(waitedMs + 50);
+        });
+    };
+    return settle(0).then(function(hidden){
+      if (!hidden) return JSON.stringify({ hudShown: true });
+      return query().then(function(result){
+        return hudShown().then(function(shown){
+          return JSON.stringify(shown ? { hudShown: true } : Object.assign({}, result, { hud: 'hidden' }));
+        });
+      });
     });
   })()`;
   const textExpression = testId ? `(function(){
@@ -241,6 +282,10 @@ async function waitForMobileTarget(input, payload) {
       );
     }
     lastResult = result;
+    if (result.hudShown === true) {
+      await sleep(100);
+      continue;
+    }
     let present = result.present === true;
     let visible = result.visible === true;
     let cachedRoute = null;
@@ -280,7 +325,8 @@ async function waitForMobileTarget(input, payload) {
         visible,
         visibility,
         ...cachedRoute ?? {},
-        ...isRecord(result.rect) ? { rect: result.rect } : {}
+        ...isRecord(result.rect) ? { rect: result.rect } : {},
+        ...typeof result.hud === "string" ? { hud: result.hud } : {}
       };
     }
     await sleep(250);
@@ -291,8 +337,9 @@ async function waitForMobileTarget(input, payload) {
   ].filter(Boolean).join(" with ");
   const exactReason = textMatch === "exact" ? `; last text=${JSON.stringify(lastText)}` : "";
   const bridgeReason = lastBridgeError ? `; last bridge error=${traceText(lastBridgeError)}` : "";
+  const hudReason = lastResult?.hudShown === true ? `; the recipe HUD showing this node's intent never left the app tree, so the text was not checked without it (if the app itself shows the intent text, reword the intent)` : "";
   throw new Error(
-    `Timed out waiting for mobile ${target} to be ${expected}; last result=${JSON.stringify(lastResult)}${exactReason}${bridgeReason}.`
+    `Timed out waiting for mobile ${target} to be ${expected}; last result=${JSON.stringify(lastResult)}${exactReason}${bridgeReason}${hudReason}.`
   );
 }
 const MOBILE_BRIDGE_HANDLERS = {

package/dist/cli-commands.js

@@ -11,6 +11,7 @@ const SPEC = {
     { name: "help", desc: "Load version-matched recipe guidance (help review composes the review guide)", args: ["review"], flags: ["--json", "--adapter", "--target", "--domain"] },
     { name: "review", desc: "Materialize a review checklist composed from the base review and a team library", args: ["checklist"], flags: ["--domain", "--since", "--base", "--out", "--adapter", "--target", "--json"] },
     { name: "domain", desc: "Which team library owns the change (declared value, else owned-paths.json)", flags: ["--domain", "--base", "--adapter", "--target", "--json"] },
+    { name: "pr-body", desc: "Render the publishable PR body: pr-description.md plus the recipe and run sections built from artifacts", args: ["render", "<task-dir>"], flags: ["--command", "--out", "--json"] },
     { name: "config", desc: "Per-engineer locations and optional advisor settings", args: ["list", "path", "get", "set", "unset"], flags: ["--json"] },
     { name: "tutorial", desc: "Open the visual recipe tutorial", flags: ["--json", "--no-open"] },
     { name: "setup-base", desc: "Bootstrap numbered product checkouts", flags: ["--dir", "--counts", "--only", "--dry-run", "--force", "--json", "--show-config", "--reset-config", "--skip-harness-update"] },

package/dist/command-contract.js

@@ -175,6 +175,40 @@ Example:
       })
     }
   },
+  {
+    name: "pr-body",
+    summary: "Render the publishable PR body: the authored description plus the recipe and run log sections built from artifacts.",
+    example: "mm-harness pr-body render temp/tasks/dev/TAT-1",
+    helpText: `mm-harness pr-body render <task-dir> [flags]
+
+  Reads <task-dir>/artifacts/pr-description.md (the PR body the worker wrote in
+  the repository PR template shape) and inserts the machine sections rendered
+  from artifacts: "Validation Recipe" from artifacts/recipe.json, "Validation
+  Logs" from artifacts/recipe-run/report.md, and "Recipe Workflow" from
+  artifacts/workflow.mmd when it exists. Any such section the worker pasted by
+  hand is replaced. The sections go before the first checklist section, else at
+  the end. Fences are always longer than any backtick run in the content and
+  close on their own line. Writes <task-dir>/artifacts/pr-body.md.
+
+  When a passing run recorded the task's selected attempt, both sections come
+  from that attempt's package, which must pass validation or nothing is written.
+
+  --command <text>  Recipe invocation to show above the run log
+  --out <file>      Write elsewhere than artifacts/pr-body.md (never over an
+                    authored input or retained evidence)
+  --json            Machine-readable result
+
+Example:
+  mm-harness pr-body render temp/tasks/dev/TAT-1 --json`,
+    contract: {
+      options: options(HELP, JSON, {
+        "--command": value(),
+        "--out": value()
+      }),
+      positionals: [{ label: "action", choices: ["render"] }, { label: "task-dir" }],
+      minimumPositionals: 2
+    }
+  },
   {
     name: "config",
     summary: "Per-engineer locations and optional recipe advisor settings.",

package/dist/commands/pr-body.js

@@ -0,0 +1,29 @@
+import { optionFlag, optionString, parseArgs, renderRetainedArtifactsMarkdown, usageError } from "@farmslot/recipe-cli/harness";
+import fs from "node:fs";
+import path from "node:path";
+const USAGE = "Usage: mm-harness pr-body render <task-dir> [--command <text>] [--out <file>] [--json]";
+async function handlePrBody(argv) {
+  const parsed = parseArgs(argv);
+  const [action, taskArg] = parsed.positional;
+  if (action !== "render" || !taskArg) throw usageError(USAGE);
+  const taskDir = path.resolve(taskArg);
+  if (!fs.existsSync(path.join(taskDir, "artifacts"))) {
+    throw usageError(`${taskDir} has no artifacts/ directory; pass the task directory mm-harness task init wrote.`);
+  }
+  const command = optionString(parsed.options, "command");
+  const out = path.resolve(optionString(parsed.options, "out") ?? path.join(taskDir, "artifacts", "pr-body.md"));
+  const { result } = await renderRetainedArtifactsMarkdown({ directory: taskDir, command, out, format: "markdown" });
+  const { sections = [], recipe, run, workflow } = result;
+  if (optionFlag(parsed.options, "json")) {
+    process.stdout.write(`${JSON.stringify({ command: "pr-body", subcommand: "render", status: "ok", taskDir, out, sections, recipe, run, workflow }, null, 2)}
+`);
+  } else {
+    process.stdout.write(`pr body: ${out}
+  ${sections.join("\n  ")}
+`);
+  }
+  return 0;
+}
+export {
+  handlePrBody
+};

package/dist/mm-harness-cli.js

@@ -48,6 +48,7 @@ import { handleHelp } from "./commands/help.js";
 import { handleLogs } from "./commands/logs.js";
 import { overlayCommandOptions } from "./commands/overlay.js";
 import { handlePin } from "./commands/pin.js";
+import { handlePrBody } from "./commands/pr-body.js";
 import { handlePrepare } from "./commands/prepare.js";
 import { handleProvision } from "./commands/provision.js";
 import { handleRecipeQuality } from "./commands/recipe-quality.js";
@@ -138,6 +139,7 @@ const PUBLIC_RUN = {
   help: { run: (args) => handleHelp(args, { packageRoot, harnessVersion: hostVersion() }), nudge: false },
   review: { run: handleReview },
   domain: { run: handleDomain },
+  "pr-body": { run: handlePrBody },
   config: { run: handleConfig },
   tutorial: { run: (args) => handleTutorial(args, { harnessVersion: hostVersion() }), exit: "now", nudge: false },
   "setup-base": { run: handleSetupBase, raw: true, exit: "now", nudge: false },
@@ -196,7 +198,7 @@ const HELP_GROUPS = [
   {
     title: "PROVE",
     blurb: "run recipes and inspect readiness",
-    commands: ["run", "last", "doctor", "check", "checklist", "review", "recipe-quality"]
+    commands: ["run", "last", "doctor", "check", "checklist", "review", "pr-body", "recipe-quality"]
   },
   {
     title: "RUNTIME OVERLAY",

package/docs/cli-contract.md

@@ -62,7 +62,8 @@ Callers scanned (2026-10-02):
 | Command | Caller | Consumes | G: |
 |---|---|---|---|
 | `checklist mark <taskDir> {start\|<n>\|complete [--mark-last]\|blocked --reason <s>\|no-change --reason <s>\|--help}` | `{{TASK_DIR}}/mark` shim (`mark_cmd`) | exit code; `SIGNAL.json`, `CHECKLIST.md` | `task/mark-*` |
-| `farmslot recipe artifacts <taskDir> --format markdown --out <file> --json` | migrated pack hooks and PR-description skills | successful exit, structured `error.message`, explicit `out`; no implicit output file | shared recipe-cli artifact contracts; retained Markdown baselines |
+| `pr-body render <taskDir> [--out <file>] --json` (cwd = task dir) | MetaMask engineers and skills; the gateway `pr-body-render.ts` when a pack's `pr_body_cmd` names it | on failure `JSON.parse(stdout).error`, else stderr; then `--out`, else `artifacts/pr-body.md` | `task/pr-body-render-*` |
+| `farmslot recipe artifacts <taskDir> --format markdown --out <file> --json` | farm pack hooks (`vars.pr_body_cmd`) and PR-description skills on the farm | successful exit, structured `error.message`, explicit `out`; no implicit output file | shared recipe-cli artifact contracts; retained Markdown baselines |
 | `review checklist --out <file> [--domain <d>] [--since <sha>]` | domain fixtures, review templates | the written file | `task/review-checklist` |
 | `check diff …`, `recipe-quality build …` | templates | exit code | not covered: run repo lint/test tooling |
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.92.20",
+  "version": "0.92.22",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"
@@ -21,15 +21,15 @@
     "check:syntax": "find . -name '*.mjs' -print0 | xargs -0 -n1 node --check"
   },
   "dependencies": {
-    "@farmslot/adapter-node": "0.1.33",
-    "@farmslot/adapter-rn": "0.22.22",
-    "@farmslot/adapter-sdk": "0.17.1",
-    "@farmslot/adapter-web": "0.10.13",
-    "@farmslot/agent-runtime": "0.28.0",
+    "@farmslot/adapter-node": "0.1.34",
+    "@farmslot/adapter-rn": "0.22.23",
+    "@farmslot/adapter-sdk": "0.18.0",
+    "@farmslot/adapter-web": "0.10.14",
+    "@farmslot/agent-runtime": "0.29.0",
     "@farmslot/handoff": "^0.3.1",
-    "@farmslot/protocol": "0.53.0",
-    "@farmslot/recipe-cli": "0.22.5",
-    "@farmslot/recipe-runner": "0.38.4",
+    "@farmslot/protocol": "0.54.0",
+    "@farmslot/recipe-cli": "0.23.0",
+    "@farmslot/recipe-runner": "0.39.0",
     "agent-device": "0.19.3",
     "commander": "^12.0.0",
     "esbuild": "0.28.1",