@deeeed/metamask-harness 0.86.0 → 0.86.1

package/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 ## Unreleased
 
+## 0.86.1 - 2026-10-09
+
+### Fixed
+
+- Extension `metamask.perps.close_visible_position cleanup_only=true` reconciles the final balance against the margin the close releases. With no placement receipt, the baseline is the available balance read while the position is still open. That baseline excludes the position's margin, so a clean full close went over the $1 tolerance and left an `outcome-unknown` receipt. A 0.11 SOL testnet close moved $524.42 to $536.45 and failed this way. The action now reads the close modal's "You'll receive" amount before dispatch and records it in the receipt as `closeReleaseBaseUnits`. It then checks the final balance against baseline + receive, with the same tolerance. If the amount is not visible, the action refuses before publishing a receipt or clicking. Closes backed by a placement receipt still reconcile against the pre-order balance. Cleanup output adds `releaseBaseUnits` and `expectedBalanceAfterBaseUnits`.
+- Mobile `metamask.perps.read_visible_state` on iOS sees Perps Text test IDs. iOS accessibility lists React Native Text as a StaticText with no identifier, so a visible Lite market price (`perps-market-header-price`) failed `require_features: ["price"]`. On a non-opaque iOS run, `ui.visible` now reads each mounted `perps-` Text's test ID, string and size over the dev bridge. It gives that test ID to the on-screen StaticText with the same label and size, when exactly one test ID matches. Offscreen StaticText stays unbound, and so does a same-text twin of another size (the collapsed header price). Other Text, such as a revealed Secret Recovery Phrase word, is not read. This reaches every iOS `ui.visible` consumer: `ui.locators`, native-navigation test-ID waits, `readVisiblePerpsTestIds`, `configure_order`, and the assets and swap-bridge `read_visible_state`. Opaque runtimes and Android are unchanged. A non-opaque run with Metro down pays one bridge attempt (at most 2 s) per observation and gets a `ui.visible` warning; a read over 500 Texts is truncated with a warning.
+- An empty `METAMASK_RECIPE_MOBILE_BRIDGE_SCRIPT` means the bundled `cdp-bridge.cjs` everywhere the TypeScript side spawns the Mobile bridge, as `run` and the action library already treated it. `launch`'s feature-flag reads and pins (and `doctor`'s) and the `status` live probe read the variable with `??`. An empty value made them check for a script named `""`, so they reported no runtime and never spawned a bridge. All TypeScript callers now share one `mobileBridgeScript()`; the action library keeps the same rule in its own `bridgeScript()` because it cannot import `src/`.
+
 ## 0.86.0 - 2026-10-09
 
 ### Added

package/dist/adapters/mobile/bridge-script.js

@@ -0,0 +1,12 @@
+import path from "node:path";
+import { runnerDir } from "../../paths.js";
+function mobileBridgeScriptOverride() {
+  return process.env.METAMASK_RECIPE_MOBILE_BRIDGE_SCRIPT || void 0;
+}
+function mobileBridgeScript() {
+  return mobileBridgeScriptOverride() ?? path.join(runnerDir, "adapters", "mobile", "bridge-runtime", "cdp-bridge.cjs");
+}
+export {
+  mobileBridgeScript,
+  mobileBridgeScriptOverride
+};

package/dist/adapters/mobile/feature-flags.js

@@ -1,11 +1,7 @@
 import { spawn } from "node:child_process";
 import fs from "node:fs";
-import path from "node:path";
-import { runnerDir } from "../../paths.js";
+import { mobileBridgeScript } from "./bridge-script.js";
 const DEFAULT_TIMEOUT_MS = 1e4;
-function bridgeScriptPath() {
-  return process.env.METAMASK_RECIPE_MOBILE_BRIDGE_SCRIPT ?? path.join(runnerDir, "adapters", "mobile", "bridge-runtime", "cdp-bridge.cjs");
-}
 const CONTROLLER_PREAMBLE = `
   var ctx = globalThis.Engine && globalThis.Engine.context;
   var c = ctx && ctx.RemoteFeatureFlagController;
@@ -19,7 +15,7 @@ function evalExpression(body) {
   return `(function(){ try {${CONTROLLER_PREAMBLE}${body} } catch (e) { return JSON.stringify({ ok: false, error: e && (e.message || String(e)) }); } })()`;
 }
 function runBridgeEval(target, expression, timeoutMs) {
-  const script = bridgeScriptPath();
+  const script = mobileBridgeScript();
   if (!fs.existsSync(script)) return Promise.resolve(null);
   return new Promise((resolve) => {
     let settled = false;

package/dist/adapters/mobile/run.js

@@ -2,7 +2,6 @@ import { EXIT, isRecord } from "@farmslot/recipe-cli/harness";
 import { spawnSync } from "node:child_process";
 import path from "node:path";
 import { IOS_SIMULATOR_RECORDING_TARGET_PREFIX } from "@farmslot/adapter-rn";
-import { runnerDir } from "../../paths.js";
 import { devicePlatformFromEnv } from "../performance/device-platform.js";
 import {
   resolveAndroidDeviceSerial,
@@ -10,6 +9,7 @@ import {
 } from "./recording-target.js";
 import { emitProofFailure } from "../proof-failure.js";
 import { mobileAppIdentityEnv } from "./app-identity.js";
+import { mobileBridgeScript } from "./bridge-script.js";
 import { requireCurrentMobileReleaseArtifactState } from "./release-artifact-state.js";
 const EXPLICIT_DEVICE_KEYS = [
   "PLATFORM",
@@ -158,7 +158,7 @@ const mobileObservation = {
   }
 };
 function runMobileIssueCommand(projectRoot, command) {
-  const bridge = process.env.METAMASK_RECIPE_MOBILE_BRIDGE_SCRIPT || path.join(runnerDir, "adapters", "mobile", "bridge-runtime", "cdp-bridge.cjs");
+  const bridge = mobileBridgeScript();
   const result = spawnSync(process.execPath, [bridge, command], {
     cwd: projectRoot,
     env: { ...process.env, APP_ROOT: projectRoot, CDP_TIMEOUT: "5000" },

package/dist/adapters/mobile/ui.js

@@ -10,6 +10,7 @@ import { trustedMutationContextExtras } from "../../funding-execution-context.js
 import { LIBRARY_ACTION_NAMESPACE } from "../../paths.js";
 import { liveTsxCandidates } from "../../live-tsx.js";
 import { mobileAppIdentityEnv } from "./app-identity.js";
+import { mobileBridgeScriptOverride } from "./bridge-script.js";
 const execFileAsync = promisify(execFile);
 function sleep(ms) {
   return new Promise((resolve) => setTimeout(resolve, ms));
@@ -58,7 +59,7 @@ function mobileProbeOutput(status, input, projectRoot) {
   };
 }
 function mobileBridgePath(_projectRoot) {
-  return process.env.METAMASK_RECIPE_MOBILE_BRIDGE_SCRIPT || "runner:adapters/mobile/bridge-runtime/cdp-bridge.cjs";
+  return mobileBridgeScriptOverride() ?? "runner:adapters/mobile/bridge-runtime/cdp-bridge.cjs";
 }
 function resolveMobileWaitTarget(payload) {
   const testId = optionalScalarText(

package/dist/commands/status-probe.js

@@ -1,13 +1,9 @@
 import { spawn } from "node:child_process";
 import fs from "node:fs";
-import path from "node:path";
 import { fixtureSummary } from "../doctor.js";
 import { normalizeFeatureFlagRecord } from "../feature-flags.js";
-import { runnerDir } from "../paths.js";
+import { mobileBridgeScript } from "../adapters/mobile/bridge-script.js";
 const PROBE_TIMEOUT_MS = 2e3;
-function bridgeScriptPath() {
-  return process.env.METAMASK_RECIPE_MOBILE_BRIDGE_SCRIPT ?? path.join(runnerDir, "adapters", "mobile", "bridge-runtime", "cdp-bridge.cjs");
-}
 function truncateAddress(address) {
   if (!address || address.length <= 10) return address;
   return `${address.slice(0, 6)}\u2026${address.slice(-4)}`;
@@ -77,7 +73,7 @@ function matchBridgeEntry(device, entries, devices) {
   return null;
 }
 function probeMobileBridge(target) {
-  const script = bridgeScriptPath();
+  const script = mobileBridgeScript();
   if (!fs.existsSync(script)) {
     return Promise.resolve({ ok: false, liveState: "no-bridge" });
   }

package/library/actions/extension/perps/close_visible_position.mjs

@@ -208,10 +208,11 @@ async function prepareCloseModal(page, partialAmount) {
   return confirmation;
 }
 
-async function proveGlobalCleanup(page, balanceBeforeBaseUnits, toleranceBaseUnits, timeoutMs = 20_000) {
+async function proveGlobalCleanup(page, balanceBeforeBaseUnits, releaseBaseUnits, toleranceBaseUnits, timeoutMs = 20_000) {
   await page.navigateHash('#/perps-home');
   const state = await waitForStableGlobalPerpsHome(page, { timeoutMs, requireZero: true });
-  const balanceDeltaBaseUnits = absoluteDelta(state.balanceBaseUnits, balanceBeforeBaseUnits);
+  const expectedBalanceAfterBaseUnits = `${BigInt(balanceBeforeBaseUnits) + BigInt(releaseBaseUnits ?? '0')}`;
+  const balanceDeltaBaseUnits = absoluteDelta(state.balanceBaseUnits, expectedBalanceAfterBaseUnits);
   if (BigInt(balanceDeltaBaseUnits) > BigInt(toleranceBaseUnits)) {
     throw new Error('Final visible Perps balance exceeds the authorized reconciliation tolerance.');
   }
@@ -219,6 +220,8 @@ async function proveGlobalCleanup(page, balanceBeforeBaseUnits, toleranceBaseUni
     positionCount: 0,
     orderCount: 0,
     balanceBeforeBaseUnits,
+    releaseBaseUnits: releaseBaseUnits ?? null,
+    expectedBalanceAfterBaseUnits,
     balanceAfterBaseUnits: state.balanceBaseUnits,
     balanceDeltaBaseUnits,
     toleranceBaseUnits,
@@ -327,9 +330,14 @@ export async function closeVisiblePosition(input) {
                 if (!/^(?:0|[1-9][0-9]{0,29})$/u.test(balanceBeforeBaseUnits)) {
                   throw new Error('Resumed close receipt has no valid pre-order balance.');
                 }
+                const releaseBaseUnits = existingReceipt.record?.facts?.closeReleaseBaseUnits ?? null;
+                if (releaseBaseUnits != null && !/^-?(?:0|[1-9][0-9]{0,29})$/u.test(String(releaseBaseUnits))) {
+                  throw new Error('Resumed close receipt has an invalid close release amount.');
+                }
                 const cleanup = await proveGlobalCleanup(
                   page,
                   balanceBeforeBaseUnits,
+                  releaseBaseUnits,
                   balanceToleranceBaseUnits,
                 );
                 return {
@@ -413,6 +421,11 @@ export async function closeVisiblePosition(input) {
   if (partialAmount == null && (!confirmation.fullSizeSelected || !confirmation.marketOrder)) {
     throw new Error('Receipt-bound full close requires the visible 100% market-close form.');
   }
+  // Without a placement receipt the baseline is the in-position balance, which excludes the released margin.
+  const closeReleaseBaseUnits = placement ? null : parseUsdBaseUnits(confirmation.receive);
+  if (!placement && closeReleaseBaseUnits == null) {
+    throw new Error('Close without a placement receipt requires the visible close receive amount.');
+  }
   const closeSizing = partialAmount == null ? { size: sizeMatch[1], side: fundingSide === 'long' ? 'short' : 'long' } : null;
   let submissionObserver = null;
   let mutation;
@@ -427,6 +440,7 @@ export async function closeVisiblePosition(input) {
       cleanupOnly,
       fundingBalance,
       tradingContext,
+      ...(closeReleaseBaseUnits != null ? { closeReleaseBaseUnits } : {}),
       ...(acceptedFill ? { acceptedFill } : {}),
       ...(closeSizing ? { closeSizing } : {}),
     },
@@ -507,6 +521,7 @@ export async function closeVisiblePosition(input) {
             const cleanup = await proveGlobalCleanup(
               page,
               balanceBeforeBaseUnits,
+              closeReleaseBaseUnits,
               balanceToleranceBaseUnits,
             );
             return {

package/library/actions/mobile/platform/bridge.mjs

@@ -107,6 +107,8 @@ export async function runAdapter(callback) {
   }
 }
 
+// Same rule as src/adapters/mobile/bridge-script.ts (unset or empty means the
+// bundled bridge); the library cannot import src/.
 function bridgeScript(input) {
   if (process.env.METAMASK_RECIPE_MOBILE_BRIDGE_SCRIPT) {
     return process.env.METAMASK_RECIPE_MOBILE_BRIDGE_SCRIPT;

package/library/actions/mobile/platform/observe-ui.mjs

@@ -16,6 +16,41 @@ import { mobileToolRecovery, resolveMobileToolPath } from '@farmslot/adapter-rn'
 const execFileAsync = promisify(execFile);
 const VISIBLE_LIMIT = 200;
 const HIDDEN_LIMIT = 100;
+// iOS accessibility exposes React Native Text as StaticText without its testID.
+// Read each mounted Perps Text's testID, string and size (synchronous on Fabric)
+// so the visible native element with the same label and size can carry that
+// testID. Only perps- Texts leave the app: other Text, such as a revealed
+// Secret Recovery Phrase word, never reaches the harness or a trace.
+const TEXT_TEST_ID_LIMIT = 500;
+const IOS_TEXT_TEST_IDS = `(() => {
+  const ui = globalThis.nativeFabricUIManager;
+  const hook = globalThis.__REACT_DEVTOOLS_GLOBAL_HOOK__;
+  if (!ui?.measureInWindow || !hook?.getFiberRoots) return { texts: [], total: 0 };
+  const texts = [];
+  const content = (fiber) => {
+    let value = '';
+    for (let child = fiber.child; child; child = child.sibling) {
+      value += typeof child.memoizedProps === 'string' || typeof child.memoizedProps === 'number'
+        ? String(child.memoizedProps) : content(child);
+    }
+    return value;
+  };
+  const visit = (fiber) => {
+    for (; fiber; fiber = fiber.sibling) {
+      const testId = fiber.memoizedProps?.testID;
+      if (fiber.type === 'RCTText' && typeof testId === 'string' && testId.startsWith('perps-') && fiber.stateNode?.node) {
+        let bounds;
+        ui.measureInWindow(fiber.stateNode.node, (x, y, width, height) => { bounds = { x, y, width, height }; });
+        if (bounds) texts.push({ testId, label: content(fiber), bounds });
+      }
+      visit(fiber.child);
+    }
+  };
+  const roots = new Set();
+  for (const id of hook.renderers.keys()) hook.getFiberRoots(id)?.forEach((root) => roots.add(root));
+  roots.forEach((root) => visit(root.current));
+  return { texts: texts.slice(0, ${TEXT_TEST_ID_LIMIT}), total: texts.length };
+})()`;
 
 export async function observeNativeUi(payload, context) {
   await hideAccessibilityMaskingHud(payload, context);
@@ -39,7 +74,26 @@ export async function observeNativeUi(payload, context) {
         warnings.push({ ref: 'ui.screen', message: `Navigation route unavailable: ${error.message}` });
       }
     }
-    const hierarchy = await readNativeHierarchy(payload, context);
+    let textTestIds = [];
+    if (
+      supported.includes('ui.visible') &&
+      resolvePlatform(record(payload?.node), env) === 'ios' &&
+      !isOpaqueRuntime(env) && (env.METRO_PORT || env.WATCHER_PORT)
+    ) {
+      try {
+        const read = await bridgeCommand(routeInput, ['eval', IOS_TEXT_TEST_IDS]);
+        textTestIds = Array.isArray(read?.texts) ? read.texts : [];
+        if (read?.total > textTestIds.length) {
+          warnings.push({
+            ref: 'ui.visible',
+            message: `Text test IDs truncated: read ${textTestIds.length} of ${read.total}.`,
+          });
+        }
+      } catch (error) {
+        warnings.push({ ref: 'ui.visible', message: `Text test IDs unavailable: ${error.message}` });
+      }
+    }
+    const hierarchy = await readNativeHierarchy(payload, context, textTestIds);
     if (routeBefore?.name) {
       const routeAfter = await bridgeCommand(routeInput, ['get-route']);
       if (routeAfter?.name !== routeBefore.name || routeAfter?.key !== routeBefore.key) {
@@ -85,7 +139,7 @@ export async function hideAccessibilityMaskingHud(payload, context) {
   }
 }
 
-async function readNativeHierarchy(payload, context) {
+async function readNativeHierarchy(payload, context, textTestIds) {
   const node = record(payload?.node);
   const env = {
     ...process.env,
@@ -98,13 +152,13 @@ async function readNativeHierarchy(payload, context) {
   const appLabel = nativeAppLabel(env);
   const hierarchy = platform === 'android'
     ? await readAndroidHierarchy(node, env)
-    : await readIosHierarchy(node, env);
+    : await readIosHierarchy(node, env, textTestIds);
   // No screen name and no labelled item: name the screen after the app.
   hierarchy.screen.name ??= appLabel;
   return hierarchy;
 }
 
-async function readIosHierarchy(node, env) {
+async function readIosHierarchy(node, env, textTestIds) {
   const idbPath = resolveMobileToolPath('idb');
   if (!idbPath) {
     throw new Error(
@@ -123,7 +177,7 @@ async function readIosHierarchy(node, env) {
     },
   );
   const parsed = parseJsonOutput(stdout);
-  const hierarchy = flattenIosHierarchy(parsed);
+  const hierarchy = flattenIosHierarchy(parsed, textTestIds);
   if (hierarchy.nodeCount === 0) {
     throw new Error('idb returned an empty accessibility hierarchy.');
   }
@@ -364,7 +418,12 @@ function parseJsonOutput(output) {
   }
 }
 
-function flattenIosHierarchy(value) {
+function flattenIosHierarchy(value, textTestIds = []) {
+  const texts = (Array.isArray(textTestIds) ? textTestIds : []).map((entry) => ({
+    testId: text(entry?.testId),
+    label: text(entry?.label),
+    bounds: normalizeBounds(entry?.bounds),
+  })).filter((entry) => entry.testId && entry.label && entry.bounds);
   const visible = [];
   const hidden = [];
   let nodeCount = 0;
@@ -382,9 +441,10 @@ function flattenIosHierarchy(value) {
       text(item.role_description) ?? text(item.className);
     const label = text(item.label) ?? text(item.AXLabel) ?? text(item.name) ??
       text(item.title);
-    const testId = text(item.identifier) ?? text(item.accessibilityIdentifier) ??
-      text(item.AXUniqueId) ?? text(item.id);
     const bounds = normalizeBounds(item.frame ?? item.AXFrame ?? item.bounds);
+    const testId = text(item.identifier) ?? text(item.accessibilityIdentifier) ??
+      text(item.AXUniqueId) ?? text(item.id) ??
+      (label && hasVisibleBounds(bounds, screenBounds) ? textTestId(texts, label, bounds) : undefined);
     if (isApplicationRole(role)) {
       screenName ??= label;
       screenBounds ??= bounds;
@@ -466,6 +526,17 @@ function parseAndroidHierarchy(output) {
   return { visible, hidden, nodeCount, screenName };
 }
 
+// Bind an exact label and size to one testID. Origins are not compared: Fabric
+// frames omit native screen offsets such as a modal card. A same-text twin with
+// another size (the collapsed header price) or another testID stays unbound.
+function textTestId(texts, label, bounds) {
+  const testIds = new Set(texts
+    .filter((entry) => entry.label === label &&
+      ['width', 'height'].every((key) => Math.abs(entry.bounds[key] - bounds[key]) <= 1))
+    .map((entry) => entry.testId));
+  return testIds.size === 1 ? [...testIds][0] : undefined;
+}
+
 function isApplicationRole(role) {
   return role?.toLowerCase().includes('application') ?? false;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.86.0",
+  "version": "0.86.1",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"