@deeeed/metamask-harness 0.79.0 → 0.80.0

package/library/actions/core/wallet/_fixture-accounts.mjs

@@ -0,0 +1,69 @@
+// The checkout's wallet fixture expanded into accounts: a mnemonic entry with
+// count N yields N accounts at address indexes 0..N-1, named dev1..devN from the
+// entry's name. list_accounts shows them; Core Perps actions select from them.
+
+import { readFile } from 'node:fs/promises';
+import { mnemonicToAccount, privateKeyToAccount } from 'viem/accounts';
+
+import { walletFixturePath } from '../../harness-exports.mjs';
+
+function fixtureAccountName(base, index, count) {
+  if (count === 1) return base || 'account1';
+  const match = /^(.*?)(\d+)$/u.exec(base || 'account1');
+  return match
+    ? `${match[1]}${Number(match[2]) + index}`
+    : `${base || 'account'}${index + 1}`;
+}
+
+function mnemonicCount(entry, fixturePath, index) {
+  const count = Number(entry.count ?? entry.numberOfAccounts ?? 1);
+  if (!Number.isInteger(count) || count < 1 || count > 100) {
+    throw new Error(`${fixturePath} accounts[${index}] mnemonic count must be an integer from 1 through 100.`);
+  }
+  return count;
+}
+
+/**
+ * Expand fixture entries into `{ name, address, signer }`. `signer` is the viem
+ * account holding the key: use it to sign, never serialize it.
+ */
+export function deriveFixtureAccounts(fixture, fixturePath) {
+  if (!Array.isArray(fixture.accounts) || fixture.accounts.length === 0) {
+    throw new Error(`wallet fixture at ${fixturePath} has no accounts array.`);
+  }
+  return fixture.accounts.flatMap((entry, fixtureIndex) => {
+    if (!entry || typeof entry !== 'object' || typeof entry.value !== 'string' || !entry.value.trim()) {
+      throw new Error(`${fixturePath} accounts[${fixtureIndex}] must contain a non-empty value.`);
+    }
+    if (entry.type === 'mnemonic') {
+      const count = mnemonicCount(entry, fixturePath, fixtureIndex);
+      return Array.from({ length: count }, (_, addressIndex) => {
+        const signer = mnemonicToAccount(entry.value.trim(), { addressIndex });
+        return { name: fixtureAccountName(entry.name, addressIndex, count), address: signer.address, signer };
+      });
+    }
+    if (entry.type === 'privateKey') {
+      const raw = entry.value.trim();
+      const normalized = raw.startsWith('0x') ? raw : `0x${raw}`;
+      if (!/^0x[0-9a-fA-F]{64}$/u.test(normalized)) {
+        throw new Error(`${fixturePath} accounts[${fixtureIndex}] privateKey is not a 32-byte hex key.`);
+      }
+      const signer = privateKeyToAccount(normalized);
+      return [{ name: entry.name || `account${fixtureIndex + 1}`, address: signer.address, signer }];
+    }
+    throw new Error(`${fixturePath} accounts[${fixtureIndex}].type must be mnemonic or privateKey.`);
+  });
+}
+
+/** The checkout's fixture accounts, or null when it has no wallet fixture. */
+export async function readFixtureAccounts(projectRoot) {
+  const fixturePath = walletFixturePath(projectRoot);
+  let raw;
+  try {
+    raw = await readFile(fixturePath, 'utf8');
+  } catch (error) {
+    if (error?.code === 'ENOENT') return null;
+    throw error;
+  }
+  return { fixturePath, accounts: deriveFixtureAccounts(JSON.parse(raw), fixturePath) };
+}

package/library/actions/core/wallet/list_accounts.mjs

@@ -3,72 +3,29 @@
 
 import { readFile, writeFile } from 'node:fs/promises';
 import { pathToFileURL } from 'node:url';
-import { mnemonicToAccount, privateKeyToAccount } from 'viem/accounts';
 
 import { walletFixturePath } from '../../harness-exports.mjs';
-
-function fixtureAccountName(base, index, count) {
-  if (count === 1) return base || 'account1';
-  const match = /^(.*?)(\d+)$/u.exec(base || 'account1');
-  return match
-    ? `${match[1]}${Number(match[2]) + index}`
-    : `${base || 'account'}${index + 1}`;
-}
-
-function mnemonicCount(entry, fixturePath, index) {
-  const count = Number(entry.count ?? entry.numberOfAccounts ?? 1);
-  if (!Number.isInteger(count) || count < 1 || count > 100) {
-    throw new Error(`${fixturePath} accounts[${index}] mnemonic count must be an integer from 1 through 100.`);
-  }
-  return count;
-}
-
-function deriveFixtureAccounts(fixture, fixturePath) {
-  if (!Array.isArray(fixture.accounts) || fixture.accounts.length === 0) {
-    throw new Error(`wallet fixture at ${fixturePath} has no accounts array.`);
-  }
-  return fixture.accounts.flatMap((entry, fixtureIndex) => {
-    if (!entry || typeof entry !== 'object' || typeof entry.value !== 'string' || !entry.value.trim()) {
-      throw new Error(`${fixturePath} accounts[${fixtureIndex}] must contain a non-empty value.`);
-    }
-    if (entry.type === 'mnemonic') {
-      const count = mnemonicCount(entry, fixturePath, fixtureIndex);
-      return Array.from({ length: count }, (_, addressIndex) => {
-        const account = mnemonicToAccount(entry.value.trim(), { addressIndex });
-        return {
-          id: `fixture:${fixtureAccountName(entry.name, addressIndex, count)}`,
-          address: account.address,
-          name: fixtureAccountName(entry.name, addressIndex, count),
-          type: 'eip155:eoa',
-        };
-      });
-    }
-    if (entry.type === 'privateKey') {
-      const raw = entry.value.trim();
-      const normalized = raw.startsWith('0x') ? raw : `0x${raw}`;
-      if (!/^0x[0-9a-fA-F]{64}$/u.test(normalized)) {
-        throw new Error(`${fixturePath} accounts[${fixtureIndex}] privateKey is not a 32-byte hex key.`);
-      }
-      const account = privateKeyToAccount(normalized);
-      const name = entry.name || `account${fixtureIndex + 1}`;
-      return [{ id: `fixture:${name}`, address: account.address, name, type: 'eip155:eoa' }];
-    }
-    throw new Error(`${fixturePath} accounts[${fixtureIndex}].type must be mnemonic or privateKey.`);
-  });
-}
+import { readFixtureAccounts } from './_fixture-accounts.mjs';
 
 async function listAccounts(input) {
   const scope = input.node?.scope == null ? 'named' : String(input.node.scope);
   if (scope !== 'selected' && scope !== 'named' && scope !== 'evm' && scope !== 'all') {
     throw new Error('metamask.wallet.list_accounts scope must be selected, named, evm, or all.');
   }
-  const fixturePath = walletFixturePath(input.context.projectRoot);
-  const fixture = JSON.parse(await readFile(fixturePath, 'utf8'));
+  const loaded = await readFixtureAccounts(input.context.projectRoot);
+  if (!loaded) {
+    throw new Error(
+      `no wallet fixture at ${walletFixturePath(input.context.projectRoot)}.\nNext: run mm-harness fixtures set`,
+    );
+  }
   const selectedName = String(input.node?.account_name ?? input.node?.account ?? 'dev1');
-  const accounts = deriveFixtureAccounts(fixture, fixturePath)
-    .map((account) => ({
-      ...account,
-      selected: account.name === selectedName,
+  const accounts = loaded.accounts
+    .map(({ name, address }) => ({
+      id: `fixture:${name}`,
+      address,
+      name,
+      type: 'eip155:eoa',
+      selected: name === selectedName,
     }))
     .filter((account) => {
       if (scope === 'selected') return account.selected;

package/library/actions/extension/feature_flags/state.mjs

@@ -15,7 +15,7 @@
 import fs from 'node:fs';
 import path from 'node:path';
 
-import { recipeRuntimeDir } from '../../harness-exports.mjs';
+import { recipeRuntimeDir } from '@farmslot/recipe-cli/harness';
 
 export const EXTENSION_SET_UNSUPPORTED_REASON =
   'The extension exposes no runtime remote feature-flag override RPC: RemoteFeatureFlagController.setFlagOverride is never registered in metamask-controller.js getApi(), so stateHooks.submitRequestToBackground cannot reach it. Overrides are pinned into the per-run dist snapshot manifest at launch.';

package/library/actions/extension/platform/cdp.mjs

@@ -20,14 +20,8 @@ import { spawn } from 'node:child_process';
 import { createRequire } from 'node:module';
 import path from 'node:path';
 
-import {
-  importRecipeHarnessRuntimeBrowserExtension,
-  importRecipeHarnessRuntimeCdp,
-  extensionIdPath,
-  recipeHarnessPath,
-  walletFixturePath,
-  captureActiveRecipeRecordingSnapshot,
-} from '../../harness-exports.mjs';
+import { captureActiveRecipeRecordingSnapshot, recipeHarnessPath } from '@farmslot/recipe-cli/harness';
+import { importRecipeHarnessRuntimeBrowserExtension, importRecipeHarnessRuntimeCdp, extensionIdPath, walletFixturePath } from '../../harness-exports.mjs';
 
 // Resolve the Farmslot harness through normal package dependencies by default.
 // Local Farmslot source is only a dev override handled by the harness paths module.

package/library/actions/harness-exports.mjs

@@ -1,4 +1,4 @@
-// Bridge from library actions to the harness path/recording helpers. Published
+// Bridge from library actions to the harness path helpers. Published
 // installs load the compiled dist (node cannot type-strip .ts under
 // node_modules); source checkouts without dist fall back to src. Deliberately
 // narrow — importing the package entry here would close an import cycle
@@ -14,20 +14,15 @@ async function load(distRelative, srcRelative) {
 }
 
 const paths = await load('dist/paths.js', 'src/paths.ts');
-const recording = await load('dist/run-recording.js', 'src/run-recording.ts');
 const featureFlags = await load('dist/feature-flags.js', 'src/feature-flags.ts');
 
 export const {
   importRecipeHarnessRuntimeBrowserExtension,
   importRecipeHarnessRuntimeCdp,
   extensionIdPath,
-  recipeHarnessPath,
-  recipeRuntimeDir,
   walletFixturePath,
 } = paths;
 
-export const { captureActiveRecipeRecordingSnapshot } = recording;
-
 // One normalisation for --remote-flag specs, fixture objects, and the
 // doctor/status summary line. See src/feature-flags.ts.
 export const {

package/library/actions/mobile/app/network-control.mjs

@@ -3,7 +3,9 @@
 import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 
-import { resolveMobileToolPath } from '../platform/tool-paths.mjs';
+import { resolveMobileToolPath } from '@farmslot/adapter-rn';
+
+import { nativeAppId } from '../platform/native-session-name.mjs';
 
 const execFileAsync = promisify(execFile);
 
@@ -31,13 +33,9 @@ function selectedAndroidSerial(input) {
 }
 
 function selectedAndroidPackage(input) {
-  return String(
-    input.node?.package_id ??
-      input.node?.app_id ??
-      input.context?.env?.ANDROID_PACKAGE_ID ??
-      process.env.ANDROID_PACKAGE_ID ??
-      'io.metamask',
-  ).trim();
+  const explicit = input.node?.package_id ?? input.node?.app_id;
+  if (explicit != null) return String(explicit).trim();
+  return nativeAppId({ ...process.env, ...(input.context?.env ?? {}) }, 'android');
 }
 
 async function defaultRun(file, args) {

package/library/actions/mobile/perps/prepare_local_snapshot_endpoint.mjs

@@ -4,7 +4,7 @@ import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 
 import { runAdapter } from '../platform/bridge.mjs';
-import { resolveMobileToolPath } from '../platform/tool-paths.mjs';
+import { resolveMobileToolPath } from '@farmslot/adapter-rn';
 
 const execFileAsync = promisify(execFile);
 

package/library/actions/mobile/platform/bridge.mjs

@@ -8,10 +8,10 @@ import { promisify } from 'node:util';
 import os from 'node:os';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
-import bridgeErrors from '../../../../adapters/mobile/bridge-runtime/lib/bridge-errors.cjs';
-import brokerModule from '../../../../adapters/mobile/bridge-runtime/lib/cdp-broker.cjs';
-import configModule from '../../../../adapters/mobile/bridge-runtime/lib/config.cjs';
-import { resolveMobileToolPath } from './tool-paths.mjs';
+import bridgeErrors from '@farmslot/adapter-rn/bridge-runtime/lib/bridge-errors.cjs';
+import brokerModule from '@farmslot/recipe-runner/cdp-broker';
+import configModule from '@farmslot/adapter-rn/bridge-runtime/lib/config.cjs';
+import { resolveMobileToolPath } from '@farmslot/adapter-rn';
 
 const {
   BRIDGE_ERROR_CODES,
@@ -155,8 +155,8 @@ export async function bridgeEnv(input) {
     ...(input.context?.env || {}),
     CDP_TIMEOUT: String(input.node?.cdp_timeout_ms ?? process.env.CDP_TIMEOUT ?? '10000'),
   };
-  if (adbPath) env.MM_HARNESS_ADB_PATH = adbPath;
-  if (idbPath) env.MM_HARNESS_IDB_PATH = idbPath;
+  if (adbPath) env.RECIPE_RN_ADB_PATH = adbPath;
+  if (idbPath) env.RECIPE_RN_IDB_PATH = idbPath;
   const target = resolveMobileTarget(input);
   const requestedPlatform = target.requestedPlatform;
   const watcherPort = target.watcherPort;
@@ -238,8 +238,8 @@ export function resolveMobileTarget(input) {
     input.node?.sim_udid ?? contextEnv.SIM_UDID ?? process.env.SIM_UDID;
   const configuredPlatform = String(
     input.node?.platform ??
-      contextEnv.MM_HARNESS_EXPLICIT_PLATFORM ??
-      process.env.MM_HARNESS_EXPLICIT_PLATFORM ??
+      contextEnv.RECIPE_RN_EXPLICIT_PLATFORM ??
+      process.env.RECIPE_RN_EXPLICIT_PLATFORM ??
       contextEnv.PLATFORM ??
       process.env.PLATFORM ??
       '',

package/library/actions/mobile/platform/native-session-name.mjs

@@ -1,7 +1,27 @@
 // Derive native session names and device-specific state directories, honoring configured overrides.
 import path from 'node:path';
 
-export function nativeSessionName(env, device, app = 'io.metamask') {
+// The host adapter supplies the app under test in the action env
+// (ANDROID_PACKAGE_ID / IOS_BUNDLE_ID, display name in
+// METAMASK_RECIPE_MOBILE_APP_LABEL); the library has no default app.
+export function nativeAppId(env, platform) {
+  const key = platform === 'android' ? 'ANDROID_PACKAGE_ID' : 'IOS_BUNDLE_ID';
+  const app = String(env[key] ?? '').trim();
+  if (!app) {
+    throw new Error(`Mobile native UI needs the app identity in ${key}. Next: run through mm-harness run or call, or set ${key}.`);
+  }
+  return app;
+}
+
+export function nativeAppLabel(env) {
+  const label = String(env.METAMASK_RECIPE_MOBILE_APP_LABEL ?? '').trim();
+  if (!label) {
+    throw new Error('Mobile native UI needs the app display name in METAMASK_RECIPE_MOBILE_APP_LABEL. Next: run through mm-harness run or call, or set METAMASK_RECIPE_MOBILE_APP_LABEL.');
+  }
+  return label;
+}
+
+export function nativeSessionName(env, device, app) {
   const configured = String(env.METAMASK_RECIPE_MOBILE_SESSION ?? '').trim();
   const source = configured || `mm-harness-${app}-${device}`;
   return source.replace(/[^A-Za-z0-9._-]/gu, '-').slice(0, 120);

package/library/actions/mobile/platform/native-session.mjs

@@ -1,6 +1,6 @@
 // Create device-targeted native UI sessions for actions and accessibility snapshots.
 // Opening an instrumented iOS session hides the accessibility-masking HUD.
-import { createAgentDeviceUiTransport } from '@farmslot/expo-recipe';
+import { createAgentDeviceUiTransport } from '@farmslot/adapter-rn';
 import { createAgentDeviceClient } from 'agent-device';
 
 import { resolveMobileTarget } from './bridge.mjs';
@@ -8,6 +8,7 @@ import { hideAccessibilityMaskingHud } from './observe-ui.mjs';
 
 import {
   nativeAgentDeviceStateDir,
+  nativeAppId,
   nativeSessionName,
 } from './native-session-name.mjs';
 
@@ -19,9 +20,7 @@ export function createNativeSession(input, domain, sessionSuffix = '') {
     ? target.adbSerial ?? ''
     : input.node?.sim_udid ?? env.SIM_UDID ?? target.iosSimulator ?? '').trim();
   if (!device) throw new Error(`Mobile ${domain} native actions require one explicit ${platform} device. Next: pass --device <device>.`);
-  const app = String(platform === 'android'
-    ? env.ANDROID_PACKAGE_ID ?? 'io.metamask'
-    : env.IOS_BUNDLE_ID ?? 'io.metamask.MetaMask');
+  const app = nativeAppId(env, platform);
   const baseSession = nativeSessionName(env, device, app);
   const session = sessionSuffix
     ? `${baseSession}-${String(sessionSuffix).replace(/[^A-Za-z0-9._-]/gu, '-')}`.slice(0, 120)

package/library/actions/mobile/platform/observe-ui.mjs

@@ -7,9 +7,11 @@ import { createAgentDeviceClient } from 'agent-device';
 import { bridgeCommand } from './bridge.mjs';
 import {
   nativeAgentDeviceStateDir,
+  nativeAppId,
+  nativeAppLabel,
   nativeSessionName,
 } from './native-session-name.mjs';
-import { mobileToolRecovery, resolveMobileToolPath } from './tool-paths.mjs';
+import { mobileToolRecovery, resolveMobileToolPath } from '@farmslot/adapter-rn';
 
 const execFileAsync = promisify(execFile);
 const VISIBLE_LIMIT = 200;
@@ -93,8 +95,13 @@ async function readNativeHierarchy(payload, context) {
     env.METAMASK_RECIPE_PROJECT_ROOT = String(context.projectRoot);
   }
   const platform = resolvePlatform(node, env);
-  if (platform === 'android') return readAndroidHierarchy(node, env);
-  return readIosHierarchy(node, env);
+  const appLabel = nativeAppLabel(env);
+  const hierarchy = platform === 'android'
+    ? await readAndroidHierarchy(node, env)
+    : await readIosHierarchy(node, env);
+  // No screen name and no labelled item: name the screen after the app.
+  hierarchy.screen.name ??= appLabel;
+  return hierarchy;
 }
 
 async function readIosHierarchy(node, env) {
@@ -166,7 +173,7 @@ async function readAndroidHierarchy(node, env) {
 }
 
 async function readAndroidAgentDeviceHierarchy(serial, env) {
-  const app = text(env.ANDROID_PACKAGE_ID) ?? 'io.metamask';
+  const app = nativeAppId(env, 'android');
   const session = nativeSessionName(env, serial, app);
   const stateDir = nativeAgentDeviceStateDir(env, env.METAMASK_RECIPE_PROJECT_ROOT ?? process.cwd(), serial);
   const client = createAgentDeviceClient({
@@ -257,8 +264,7 @@ function normalizedHierarchy(
   const items = nodes.slice(0, VISIBLE_LIMIT);
   const hiddenOrOffscreen = hiddenNodes.slice(0, HIDDEN_LIMIT);
   const name = metadata.screenName ??
-    items.find((item) => item.label)?.label ??
-    'MetaMask';
+    items.find((item) => item.label)?.label;
   return {
     screen: {
       provider,

package/library/actions/mobile/ui/native-navigation.mjs

@@ -1,9 +1,10 @@
 // Navigate Android Home, Swap, and Perps through native controls and verify visible destinations.
 // Switch Perps Lite or Pro mode through visible controls on Android and iOS.
-import { createAgentDeviceUiTransport } from '@farmslot/expo-recipe';
+import { createAgentDeviceUiTransport } from '@farmslot/adapter-rn';
 import { createAgentDeviceClient } from 'agent-device';
 import {
   nativeAgentDeviceStateDir,
+  nativeAppId,
   nativeSessionName,
 } from '../platform/native-session-name.mjs';
 import { bridgeCommand } from '../platform/bridge.mjs';
@@ -51,7 +52,7 @@ export async function navigateOpaqueMobile(input, destination) {
   if (!device) {
     throw new Error('Opaque Mobile navigation requires one explicit Android device serial.');
   }
-  const app = String(env.ANDROID_PACKAGE_ID ?? 'io.metamask');
+  const app = nativeAppId(env, 'android');
   const session = nativeSessionName(env, device, app);
   const stateDir = nativeAgentDeviceStateDir(env, input.context.projectRoot, device);
   const client = createAgentDeviceClient({
@@ -184,7 +185,7 @@ export async function ensureVisibleAndroidPerpsMode(input, perpsMode) {
       'Android Perps mode requires one explicit device serial.',
     );
   }
-  const app = String(env.ANDROID_PACKAGE_ID ?? 'io.metamask');
+  const app = nativeAppId(env, 'android');
   const session = nativeSessionName(env, device, app);
   const stateDir = nativeAgentDeviceStateDir(env, input.context.projectRoot, device);
   const client = createAgentDeviceClient({

package/library/actions/mobile/wallet/native-ui.mjs

@@ -1,9 +1,10 @@
 // Drive Android wallet onboarding, lock, unlock, and reset through native accessibility.
 // Wallet observations can navigate home and open the address list to verify the selected account.
-import { createAgentDeviceUiTransport } from '@farmslot/expo-recipe';
+import { createAgentDeviceUiTransport } from '@farmslot/adapter-rn';
 import { createAgentDeviceClient } from 'agent-device';
 import {
   nativeAgentDeviceStateDir,
+  nativeAppId,
   nativeSessionName,
 } from '../platform/native-session-name.mjs';
 
@@ -249,7 +250,7 @@ function nativeSession(input) {
   const env = { ...process.env, ...(input.context?.env ?? {}) };
   const device = String(env.ADB_SERIAL ?? env.ANDROID_SERIAL ?? '').trim();
   if (!device) throw new Error('Opaque Mobile UI execution requires one explicit Android device serial.');
-  const app = String(env.ANDROID_PACKAGE_ID ?? 'io.metamask');
+  const app = nativeAppId(env, 'android');
   const session = nativeSessionName(env, device, app);
   const stateDir = nativeAgentDeviceStateDir(env, input.context.projectRoot, device);
   const client = createAgentDeviceClient({

package/library/actions/shared/analytics/_adapter.mjs

@@ -1,6 +1,6 @@
 // Minimal adapter IO for the shared analytics actions.
 //
-// Mirrors the live-adapter contract in src/live-adapter-contract.ts. Neither
+// Mirrors the live-adapter contract in @farmslot/recipe-cli/harness. Neither
 // existing runAdapter fits: extension's lives under actions/extension/platform
 // and core's carries PerpsController teardown and expect_error handling. A
 // `shared/` action importing either would couple every platform to one of them,

package/library/actions/shared/console-findings.mjs

@@ -1,6 +1,6 @@
 // The one console matcher: classify application console events and apply a
 // recipe-library allowlist of known noise. Used by run diagnostics
-// (src/run-diagnostics.ts), the assert_no_console_errors action, the
+// (src/console-classifier.ts), the assert_no_console_errors action, the
 // allowlist generator, and the recipe library's checks/console-guard.mjs
 // (which imports this file), so every caller judges an event the same way.
 //

package/library/actions/terminal/platform/runtime.mjs

@@ -9,7 +9,8 @@ import { pathToFileURL } from 'node:url';
 
 import { mnemonicToAccount, privateKeyToAccount } from 'viem/accounts';
 
-import { recipeRuntimeDir, walletFixturePath } from '../../harness-exports.mjs';
+import { recipeRuntimeDir } from '@farmslot/recipe-cli/harness';
+import { walletFixturePath } from '../../harness-exports.mjs';
 
 export const SIGNER_MODES = Object.freeze(['extension', 'injected']);
 export const DEFAULT_ACCOUNT = 'dev1';