@deeeed/metamask-harness 0.76.0 → 0.78.0

package/dist/commands/manifest.js

@@ -17,6 +17,15 @@ import {
 } from "@farmslot/protocol";
 import { metaMaskActionExecutionCapabilities } from "../recipe-security.js";
 import { closest } from "../command-contract.js";
+import {
+  actionCapabilityMatrix,
+  actionCategory,
+  findRelatedActions,
+  fuzzyResolveActions,
+  resolveActionCapabilityRefusal,
+  searchActions,
+  summarizeActionCategories
+} from "@farmslot/recipe-cli";
 const OFFICIAL_ACTIONS = new Set(OFFICIAL_RECIPE_ACTIONS);
 const ACTION_MATRIX_ADAPTERS = ["mobile", "extension", "core", "terminal"];
 function actionLibraryContextArgs(librarySources) {
@@ -178,51 +187,7 @@ async function resolveActionCapabilityMatrix(librarySources) {
       return { adapter, actions: describeManifestActions(manifest, actionSources) };
     })
   );
-  const actions = /* @__PURE__ */ new Map();
-  for (const catalog of catalogs) {
-    for (const action of catalog.actions) {
-      const entry = actions.get(action.name) ?? { entries: [], adapters: /* @__PURE__ */ new Set() };
-      entry.entries.push(action);
-      entry.adapters.add(catalog.adapter);
-      actions.set(action.name, entry);
-    }
-  }
-  return [...actions.entries()].map(([name, entry]) => {
-    const representative = entry.entries[0];
-    const satisfyingAdapters = ACTION_MATRIX_ADAPTERS.filter(
-      (adapter) => entry.adapters.has(adapter)
-    );
-    return {
-      name,
-      category: representative.category,
-      description: entry.entries.map((action) => action.description).find(Boolean) ?? "",
-      fields: [...new Set(entry.entries.flatMap((action) => action.fields))].sort(),
-      support: Object.fromEntries(
-        ACTION_MATRIX_ADAPTERS.map((adapter) => [
-          adapter,
-          entry.adapters.has(adapter) ? "available" : "unavailable"
-        ])
-      ),
-      satisfyingAdapters
-    };
-  }).sort((left, right) => left.name.localeCompare(right.name));
-}
-function resolveActionCapabilityRefusal(action, adapter, matrix) {
-  const matches = fuzzyResolveActions(matrix, action);
-  if (matches.length !== 1 || matches[0].satisfyingAdapters.includes(adapter)) {
-    return void 0;
-  }
-  return {
-    capability: matches[0].name,
-    satisfyingAdapters: matches[0].satisfyingAdapters
-  };
-}
-function missingActionCapabilities(adapter, actionNames, matrix) {
-  return [...new Set(actionNames)].flatMap((action) => {
-    const row = matrix.find((entry) => entry.name === action);
-    if (!row || row.satisfyingAdapters.includes(adapter)) return [];
-    return [{ capability: row.name, satisfyingAdapters: row.satisfyingAdapters }];
-  });
+  return actionCapabilityMatrix(catalogs);
 }
 function handleActionMatrixError(json, code, message, userAction, details = {}) {
   if (json) {
@@ -315,32 +280,6 @@ function renderHumanActionMatrix(actions) {
     )
   ].join("\n");
 }
-function fuzzyResolveActions(entries, query) {
-  const exactFull = entries.filter((e) => e.name === query);
-  if (exactFull.length > 0) return exactFull;
-  const finalSegment2 = (name) => name.split(".").pop() ?? name;
-  const exactSegment = entries.filter((e) => finalSegment2(e.name) === query);
-  if (exactSegment.length > 0) return exactSegment;
-  return entries.filter((e) => finalSegment2(e.name).includes(query));
-}
-function searchActions(entries, query) {
-  const terms = searchTerms(query);
-  if (terms.length === 0) return [];
-  return entries.map((entry) => {
-    const scores = terms.map((term) => actionSearchScore(entry, term));
-    return { entry, scores, score: scores.reduce((total, value) => total + value, 0) };
-  }).filter(({ score, scores }) => score > 0 && scores.every((value) => value > 0)).sort((left, right) => right.score - left.score || left.entry.name.localeCompare(right.entry.name)).map(({ entry }) => entry);
-}
-function findRelatedActions(entries, selected, limit = 5) {
-  const selectedNameTerms = searchTerms(finalSegment(selected.name).replaceAll("_", " "));
-  return entries.filter((entry) => entry.name !== selected.name).map((entry) => {
-    const nameTerms = new Set(searchTerms(finalSegment(entry.name).replaceAll("_", " ")));
-    const sharedScore = selectedNameTerms.filter((term) => nameTerms.has(term)).reduce((score2, term) => score2 + (GENERIC_OPERATION_TERMS.has(term) ? 5 : 30), 0);
-    const score = (entry.category === selected.category ? 100 : 0) + sharedScore;
-    return { name: entry.name, score };
-  }).filter(({ score }) => score > 0).sort((left, right) => right.score - left.score || left.name.localeCompare(right.name)).slice(0, limit).map(({ name }) => name);
-}
-const GENERIC_OPERATION_TERMS = /* @__PURE__ */ new Set(["assert", "call", "close", "ensure", "place", "read", "start", "teardown"]);
 function summarizeDescribedAction(entry) {
   const { schema: _schema, examples: _examples, ...summary } = entry;
   return summary;
@@ -496,11 +435,6 @@ function actionDomainGroup(entry) {
   const match = /^metamask[.]([^.]+)[.]/u.exec(entry.name);
   return match ? `metamask \xB7 ${match[1]}` : "custom";
 }
-function summarizeActionCategories(actions) {
-  const counts = /* @__PURE__ */ new Map();
-  for (const action of actions) counts.set(action.category, (counts.get(action.category) ?? 0) + 1);
-  return [...counts.entries()].map(([name, count]) => ({ name, count })).sort((left, right) => left.name.localeCompare(right.name));
-}
 function describeManifestActions(manifest, actionSources = /* @__PURE__ */ new Map()) {
   const manifestRecord = isRecord(manifest) ? manifest : {};
   const actions = isRecord(manifestRecord.actions) ? manifestRecord.actions : {};
@@ -521,7 +455,7 @@ function describeManifestAction(name, kind, metadata, source) {
   return {
     name,
     kind,
-    category: actionCategory(name),
+    category: actionCategory(name, ["metamask"]),
     description: typeof record.description === "string" ? record.description : "",
     fields: properties,
     schema,
@@ -539,72 +473,16 @@ function describeManifestAction(name, kind, metadata, source) {
     ])]
   };
 }
-function actionCategory(name) {
-  const segments = name.split(".");
-  if (segments[0] === "metamask" && segments.length > 2) return segments[1] ?? "metamask";
-  if (segments[0] === "app" || segments[0] === "cdp") return "runtime";
-  if (segments[0] === "ui") return "ui";
-  if (name.startsWith("assert_")) return "assertion";
-  if (name === "watch_logs" || name === "index_artifacts") return "evidence";
-  if (name === "command" || name === "wait" || name === "call" || name === "end") return "control";
-  return segments.length > 1 ? segments[0] || "utility" : "utility";
-}
-function actionSearchScore(entry, term) {
-  const name = entry.name.toLowerCase();
-  const segment = finalSegment(name);
-  const nameTerms = searchTerms(name.replaceAll(".", " ").replaceAll("_", " "));
-  const fields = entry.fields.map((field) => field.toLowerCase());
-  const description = entry.description.toLowerCase();
-  if (name === term) return 120;
-  if (segment === term) return 110;
-  if (entry.category === term) return 100;
-  if (fields.includes(term)) return 90;
-  if (nameTerms.includes(term)) return 80;
-  if (name.includes(term)) return 70;
-  if (fields.some((field) => field.includes(term))) return 60;
-  if (description.includes(term)) return 50;
-  if ([...nameTerms, ...fields].some((candidate) => fuzzyTermMatch(term, candidate))) return 40;
-  return 0;
-}
-function fuzzyTermMatch(term, candidate) {
-  if (term.length < 4 || candidate.length < 4) return false;
-  const threshold = Math.max(1, Math.floor(Math.max(term.length, candidate.length) / 4));
-  return levenshtein(term, candidate) <= threshold;
-}
-function searchTerms(value) {
-  return value.toLowerCase().match(/[a-z0-9]+/gu) ?? [];
-}
-function finalSegment(name) {
-  return name.split(".").pop() ?? name;
-}
-function levenshtein(left, right) {
-  const prior = Array.from({ length: right.length + 1 }, (_, index) => index);
-  for (let leftIndex = 1; leftIndex <= left.length; leftIndex += 1) {
-    const current = [leftIndex];
-    for (let rightIndex = 1; rightIndex <= right.length; rightIndex += 1) {
-      const substitution = (prior[rightIndex - 1] ?? 0) + (left[leftIndex - 1] === right[rightIndex - 1] ? 0 : 1);
-      current[rightIndex] = Math.min((current[rightIndex - 1] ?? 0) + 1, (prior[rightIndex] ?? 0) + 1, substitution);
-    }
-    for (let index = 0; index < current.length; index += 1) prior[index] = current[index] ?? 0;
-  }
-  return prior[right.length] ?? right.length;
-}
 export {
   ACTION_MATRIX_ADAPTERS,
   actionDomain,
   actionExampleCommand,
   actionLibraryContextArgs,
   describeManifestActions,
-  findRelatedActions,
-  fuzzyResolveActions,
   handleActions,
-  missingActionCapabilities,
   renderHumanActionCatalog,
   renderHumanActionExample,
   renderHumanActionMatrix,
   resolveActionCapabilityMatrix,
-  resolveActionCapabilityRefusal,
-  searchActions,
-  summarizeActionCategories,
   summarizeDescribedAction
 };

package/dist/commands/run.js

@@ -38,11 +38,8 @@ import { formatRunDiagnosticsForHuman, readRunDiagnosticsDocument } from "../run
 import { recipeTrustFailure } from "../recipe-security.js";
 import { ProvenanceDriftError } from "../execution-provenance.js";
 import { recordCommandEvidence } from "../command-journal.js";
-import {
-  actionLibraryContextArgs,
-  missingActionCapabilities,
-  resolveActionCapabilityMatrix
-} from "./manifest.js";
+import { actionLibraryContextArgs, resolveActionCapabilityMatrix } from "./manifest.js";
+import { missingActionCapabilities } from "@farmslot/recipe-cli";
 import {
   startRunNetworkObservation
 } from "../network-observation.js";

package/docs/cli-contract.md

@@ -90,22 +90,11 @@ These are real farm bugs. The goldens freeze the current rejections, so fixing e
 | Mobile templates `dev.md`, `dev-interactive.md`, `fix-bug.md`, `review-pr.md` | `mark complete --status blocked --outcome partial --reason …` exits 2 | `mark blocked --reason "<why>"` | `task/mark-invalid-status-outcome`, `task/mark-blocked` |
 | Docs | `launch --build-lavamoat` (only `runtime-launch` has it); `run --target <recipe-file>` | `runtime-launch --build-lavamoat`; `run <recipe-file> --target <repo>` | — |
 
-## Terminal adapter: TODO
-
-#298 merged the `terminal` adapter (`fd1c77e`). Discovery already reflects it (`discovery/actions-matrix`, the adapter hint in `help`). **Follow-up, not in this PR:** freeze its farm hooks once a stub browser replaces the LaunchServices launch of a visible Chrome for Testing (the goldens must never start a real browser). Add `tests/contract/goldens-terminal.test.sh` covering the `va-mmcx-terminal-farm` hooks:
-
-- [ ] `run <recipe> --adapter terminal --artifacts-dir <d> --target <repo> --slot <s> --cdp-port <p> --watcher-port <p> --json`
-- [ ] `actions --raw --adapter terminal --json`
-- [ ] `doctor --adapter terminal --target <repo> --cdp-port <p> --watcher-port <p> --json`
-- [ ] `install --adapter terminal --target <repo>`
-- [ ] `verify --adapter terminal --target <repo> -- --cdp-port <p> --watcher-port <p> --account <a>`
-- [ ] `cleanup --adapter terminal --target <repo> -- --cdp-port <p>`
-- [ ] `launch --adapter terminal --target <repo> --cdp-port <p> --watcher-port <p> --signer extension --account <a>` (use the stub browser from #298's `tests/fixtures/terminal-stub-browser.mjs`)
-- [ ] `stop --adapter terminal --target <repo>` with `RECIPE_CDP_PORT`
-- [ ] `run terminal.perps.<name> k=v… --adapter terminal --target <t> --cdp-port <p> --watcher-port <p> --plan` (recipe-terminal `checks/plan-recipes.mjs`)
-- [ ] runtime layout of `temp/recipe/runtime/terminal/` (`browser.pid` is watched by the farm)
-- [ ] discovery: add `terminal` to the per-adapter loop in `goldens-discovery.test.sh` (`actions --raw`, `actions`, `run --list`, `call --list`)
-- [ ] recipe-terminal `console-guard.mjs` imports the harness's `library/actions/shared/console-findings.mjs` and `tests/fixtures/console-allowlist-vectors.json`: freeze both paths and the exported surface
+## Terminal adapter
+
+`goldens-terminal` freezes the `va-mmcx-terminal-farm` hooks with their exact argv (`recipe_action_manifest`, `recipe_doctor`, `recipe_harness_{install,verify,cleanup}`, `recipe_run`, the browser `boot`/`shutdown` resources and `teardown`), against a fresh fixture slot: no slot dev server, no Extension dist, and the farm's wallet fixture outside the slot, so `install` copies it in. `launch` is frozen on its cold path: it refuses at the missing dist before any browser starts. The slot's CDP port is the one port no port holder reserves: a farm slot with no browser has it free, and the Terminal's port checks probe it. `goldens-discovery` covers `terminal` in its per-adapter loop, so `terminal/actions-raw` and `discovery/actions-raw-terminal` freeze the same manifest and change together.
+
+Outside this boundary: a successful `launch` and the `temp/recipe/runtime/terminal/` layout (`browser.pid`), recipes and actions from the farm's `RECIPE_LIBRARY_PATH` libraries, `run terminal.perps.<name> --plan`, and the recipe-terminal `console-guard.mjs` import paths.
 
 ## Running the goldens
 
@@ -152,7 +141,7 @@ The goldens need the harness to be a git checkout: `execution-provenance.json` `
 1. Absolute paths: the sandbox becomes `<SANDBOX>`, the repo `<REPO>`, the real `$HOME` `<HOME>`, the node binary and its prefix `<NODE>`/`<NODE_PREFIX>`, and `os.tmpdir()` `<TMP>`. Both `/var` and `/private/var` spellings are covered. Ports from `gd_reserve_ports` become `<PORT:NAME>` in port positions only: numbers under `*port` keys, and in text after `:`, `port `, `port=` or `PORT=`, or a string that is exactly the port (`^<port>$`; `60000 ms` is left alone).
 2. UUIDs become `<UUID>`. Git object ids (40 hex, or a short hex value under a `*head`/`*gitRef`/`*commit` key) become `<GIT_REF>`. ISO-8601 timestamps become `<TIMESTAMP>`, and compact stamps in names `<STAMP>`. Path-derived slot ids `local-<adapter>-<8 hex>` become `local-<adapter>-<HASH>`.
 3. The package version becomes `<HARNESS_VERSION>`. Any other `x.y.z` under a key ending in `version` becomes `<VERSION>`.
-4. Numbers under volatile keys: `*pid` becomes `<PID>`, `*port` `<PORT>`, `*At`/`*Time`/`*timestamp`/`mtime*` `<TIMESTAMP>`, and `*Ms`/`duration*`/`elapsed*` `<DURATION>`. Values inside `schema` and `examples` subtrees (static manifest content) are never rewritten.
+4. Numbers under volatile keys: `*pid` becomes `<PID>`, `inode` `<INODE>`, `*port` `<PORT>`, `*At`/`*Time`/`*timestamp`/`mtime*` `<TIMESTAMP>`, and `*Ms`/`duration*`/`elapsed*` `<DURATION>`. Values inside `schema` and `examples` subtrees (static manifest content) are never rewritten.
 5. `invocationDigest` becomes `<DIGEST>`: it hashes `recipe-invocation.json`, which carries sandbox paths and timestamps and is frozen itself in normalised form. `runner.sourceFingerprint` becomes `<FINGERPRINT>`: it hashes the harness source tree, so any harness edit changes it. A `status` holding `git status --porcelain` output (provenance `runner.status` and `libraries[].status`, empty when clean) becomes `<GIT_STATUS>`. Content-only digests (recipe and dependency digests) stay frozen.
 6. Durations in text (`0.3s`, `123ms`) become `<DURATION>`.
 

package/library/actions/extension/platform/cdp.mjs

@@ -19,7 +19,6 @@ import { closeSync, openSync } from 'node:fs';
 import { spawn } from 'node:child_process';
 import { createRequire } from 'node:module';
 import path from 'node:path';
-import { fileURLToPath } from 'node:url';
 
 import {
   importRecipeHarnessRuntimeBrowserExtension,
@@ -370,11 +369,10 @@ function autolaunchEnabled(input) {
 }
 
 const runnerRequire = createRequire(import.meta.url);
-const runnerRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '../../../..');
-const browserResolver = runnerRequire(path.join(runnerRoot, 'adapters/shared/browser-resolver.cjs'));
-const { stopProfileProcessesSync } = runnerRequire(path.join(runnerRoot, 'adapters/extension/lib/validation-process-ownership.cjs'));
-const browserCdp = runnerRequire(path.join(runnerRoot, 'adapters/shared/browser-cdp.cjs'));
-const macosFocus = runnerRequire(path.join(runnerRoot, 'adapters/extension/lib/macos-focus.cjs'));
+const browserResolver = runnerRequire('@farmslot/adapter-web/browser-resolver');
+const { stopProfileProcessesSync } = runnerRequire('@farmslot/adapter-web/validation-process-ownership');
+const browserCdp = runnerRequire('@farmslot/adapter-web/browser-cdp');
+const macosFocus = runnerRequire('@farmslot/adapter-web/macos-focus');
 
 // On macOS a browser that opens a window at startup activates itself, so the
 // autolaunched browser starts without one and gets its pages over CDP in the
@@ -382,7 +380,7 @@ const macosFocus = runnerRequire(path.join(runnerRoot, 'adapters/extension/lib/m
 const startsWithoutWindow = () => process.platform === 'darwin';
 
 // One bounded browser-level CDP operation (the shared helpers in
-// browser-cdp.cjs never take the operator's focus).
+// @farmslot/adapter-web/browser-cdp never take the operator's focus).
 async function withBrowserCdp(port, fn) {
   const deadline = Date.now() + 15000;
   const remaining = () => Math.max(1, deadline - Date.now());

package/library/actions/terminal/platform/page.mjs

@@ -1,7 +1,7 @@
 // Select the CDP page a terminal UI action drives: the app tab (default) or the
 // MetaMask wallet surface (side panel / notification / popup) that shows the
 // pending dapp request. Pages are never brought to front unless
-// MM_HARNESS_FOCUS_BROWSER=1, as in the Extension adapter: Page.bringToFront
+// FARMSLOT_FOCUS_BROWSER=1, as in the Extension adapter: Page.bringToFront
 // activates the browser on macOS and takes the operator's keyboard focus. The
 // app tab is the only tab of its window (the wallet host closes the others),
 // so it stays the window's active tab and keeps painting without it.
@@ -199,7 +199,7 @@ export function slowMoFor(browserState, env = process.env) {
 }
 
 export function focusBrowserRequested(env = process.env) {
-  return env.MM_HARNESS_FOCUS_BROWSER === '1';
+  return env.FARMSLOT_FOCUS_BROWSER === '1';
 }
 
 // Defence in depth before a wallet confirmation: the app port is still served

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.76.0",
+  "version": "0.78.0",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"
@@ -21,11 +21,12 @@
     "check:syntax": "find . -name '*.mjs' -print0 | xargs -0 -n1 node --check"
   },
   "dependencies": {
+    "@farmslot/adapter-web": "0.1.0",
     "@farmslot/agent-runtime": "0.16.0",
     "@farmslot/expo-recipe": "0.13.1",
     "@farmslot/handoff": "^0.3.1",
     "@farmslot/protocol": "0.34.0",
-    "@farmslot/recipe-cli": "0.1.1",
+    "@farmslot/recipe-cli": "0.1.2",
     "@farmslot/recipe-harness": "0.22.1",
     "agent-device": "0.19.3",
     "commander": "^12.0.0",