@deeeed/metamask-harness 0.74.0 → 0.76.0

package/dist/live-adapter-contract.js

@@ -10,7 +10,8 @@ import { pathToFileURL } from "node:url";
 import { build } from "esbuild";
 import { init, parse } from "es-module-lexer";
 import { resolveRequiredLocalProtocolRoot, runnerDir } from "./paths.js";
-import { corePnpNodeOptions } from "./commands/core-readiness.js";
+import { adapterRegistry } from "./adapters/registry.js";
+import { getAdapterSurface } from "./adapters/surface.js";
 import { serializeTrustedMutationContext } from "./funding-execution-context.js";
 function actionFileStem(action) {
   return String(action).replace(/[^a-zA-Z0-9._-]/g, "_");
@@ -213,8 +214,11 @@ function bindImportMetaUrls() {
     }
   };
 }
+function tsxLiveScripts(platform) {
+  return platform && adapterRegistry.has(platform) ? getAdapterSurface(platform).actions.tsxLiveScripts : void 0;
+}
 function commandFor(file, projectRoot, platform) {
-  const needsTsx = platform === "core" || importsSourceTypescript(file);
+  const needsTsx = Boolean(tsxLiveScripts(platform)) || importsSourceTypescript(file);
   if (!needsTsx) {
     return { command: process.execPath, args: [file] };
   }
@@ -268,36 +272,6 @@ function importsSourceTypescriptFrom(file, visited) {
 async function resolveLiveAdapter(platform, action, runtimeEnv) {
   return firstExecutablePath(candidatePaths(platform, action, runtimeEnv));
 }
-const CORE_WORKSPACE_PACKAGES = [
-  "@metamask/base-controller",
-  "@metamask/messenger",
-  "@metamask/controller-utils",
-  "@metamask/keyring-controller"
-];
-async function platformAdapterEnv(platform, projectRoot, tempDir) {
-  if (platform !== "core") return {};
-  const paths = {};
-  for (const pkg of CORE_WORKSPACE_PACKAGES) {
-    const packageDir = path.join(projectRoot, "packages", pkg.replace("@metamask/", ""));
-    const distEntry = path.join(packageDir, "dist/index.cjs");
-    if (existsSync(distEntry)) continue;
-    const srcDir = path.join(packageDir, "src");
-    if (!existsSync(path.join(srcDir, "index.ts"))) continue;
-    paths[pkg] = [path.join(srcDir, "index.ts")];
-    paths[`${pkg}/*`] = [path.join(srcDir, "*")];
-  }
-  if (Object.keys(paths).length === 0) return {};
-  const tsconfigPath = path.join(tempDir, "core-adapter.tsconfig.json");
-  await writeFile(
-    tsconfigPath,
-    `${JSON.stringify({ compilerOptions: { baseUrl: projectRoot, paths } }, null, 2)}
-`
-  );
-  return {
-    TSX_TSCONFIG_PATH: tsconfigPath,
-    NODE_OPTIONS: corePnpNodeOptions(projectRoot, process.env.NODE_OPTIONS)
-  };
-}
 async function runLiveAdapterScript({ platform, action, node, context, prepared }) {
   const script = prepared?.entryPath ?? await resolveLiveAdapter(platform, action, context?.env);
   if (!script) return null;
@@ -320,7 +294,7 @@ async function runLiveAdapterScript({ platform, action, node, context, prepared
   await writeFile(inputPath, `${JSON.stringify(input, null, 2)}
 `);
   const command = prepared ? commandForPrepared(context.projectRoot, platform) : commandFor(script, context.projectRoot, platform);
-  const platformEnv = await platformAdapterEnv(platform, context.projectRoot, tempDir);
+  const platformEnv = await tsxLiveScripts(platform)?.env(context.projectRoot, tempDir) ?? {};
   const processTimeoutMs = liveAdapterProcessTimeoutMs(node);
   const result = await runProcess(command.command, [...command.args, inputPath], {
     cwd: context.projectRoot,
@@ -380,7 +354,7 @@ function liveAdapterProcessTimeoutMs(node) {
   return 6e4 + settleAllowance;
 }
 function commandForPrepared(projectRoot, platform) {
-  if (platform !== "core") {
+  if (!tsxLiveScripts(platform)) {
     return { command: process.execPath, args: ["--input-type=module", "-"] };
   }
   const tsxBin = resolveTsxBin(projectRoot);

package/dist/manifest.js

@@ -1,6 +1,7 @@
 import fs from "node:fs";
 import path from "node:path";
 import { OFFICIAL_RECIPE_ACTIONS } from "@farmslot/protocol";
+import { getAdapterSurface } from "./adapters/surface.js";
 import { manifestPath, readJson, importRecipeProtocol } from "./paths.js";
 function loadMetaMaskMobileActionManifest() {
   return asActionManifest(readJson(manifestPath("mobile")));
@@ -16,10 +17,7 @@ function loadMetaMaskTerminalActionManifest() {
 }
 function loadActionManifest(adapter, overridePath) {
   if (overridePath) return asActionManifest(readJson(path.resolve(overridePath)));
-  if (adapter === "mobile") return loadMetaMaskMobileActionManifest();
-  if (adapter === "core") return loadMetaMaskCoreActionManifest();
-  if (adapter === "terminal") return loadMetaMaskTerminalActionManifest();
-  return loadMetaMaskExtensionActionManifest();
+  return asActionManifest(readJson(getAdapterSurface(adapter).actions.manifestPath()));
 }
 async function resolveActionManifest(adapter, overridePath, librarySources, taskActionRoot) {
   if (overridePath) {
@@ -40,7 +38,7 @@ async function resolveActionManifest(adapter, overridePath, librarySources, task
       })
     };
   }
-  const canonicalPath = path.resolve(manifestPath(adapter));
+  const canonicalPath = path.resolve(getAdapterSurface(adapter).actions.manifestPath());
   const canonicalRoot = path.dirname(path.dirname(canonicalPath));
   const sources = librarySources?.length ? librarySources : [{ name: "metamask", root: canonicalRoot }];
   const manifests = [];

package/dist/metamask-action-validation.js

@@ -1,3 +1,5 @@
+import { adapterRegistry } from "./adapters/registry.js";
+import { getAdapterSurface } from "./adapters/surface.js";
 function isRecord(value) {
   return Boolean(value) && typeof value === "object" && !Array.isArray(value);
 }
@@ -22,208 +24,15 @@ function validateMetaMaskActionInputs(recipe, adapter, params) {
   if (!isRecord(recipe) || !isRecord(recipe.workflow)) return [];
   const nodes = isRecord(recipe.workflow.nodes) ? recipe.workflow.nodes : void 0;
   if (!nodes) return [];
+  const surface = adapter && adapterRegistry.has(adapter) ? getAdapterSurface(adapter) : void 0;
   const findings = [];
   for (const [nodeId, rawNode] of Object.entries(nodes)) {
     const node = params ? resolveMetaMaskParameterValue(rawNode, params) : rawNode;
     if (!isRecord(node)) continue;
     const action = node.action;
-    const maximum = (name, limit) => {
-      if (typeof node[name] !== "number" || node[name] <= limit) return;
-      findings.push({
-        severity: "error",
-        code: "recipe.invalid_param",
-        path: `workflow.nodes.${nodeId}.${name}`,
-        message: `${action} ${name} must not exceed ${limit}`
-      });
-    };
-    if (action === "metamask.perps.read_snapshot" && adapter === "extension") {
-      if (node.market !== void 0 && node.markets !== void 0) {
-        findings.push({
-          severity: "error",
-          code: "recipe.invalid_param",
-          path: `workflow.nodes.${nodeId}.markets`,
-          message: `${action} accepts market or markets, not both`
-        });
-      }
-      if (isRecord(node.history)) {
-        const start = node.history.start_time_ms;
-        const end = node.history.end_time_ms;
-        if (typeof start === "number" && typeof end === "number" && start > end) {
-          findings.push({
-            severity: "error",
-            code: "recipe.invalid_param",
-            path: `workflow.nodes.${nodeId}.history.start_time_ms`,
-            message: `${action} history.start_time_ms must not exceed history.end_time_ms`
-          });
-        }
-        if (typeof node.history.limit === "number" && node.history.limit > 500) {
-          findings.push({
-            severity: "error",
-            code: "recipe.invalid_param",
-            path: `workflow.nodes.${nodeId}.history.limit`,
-            message: `${action} history.limit must not exceed 500`
-          });
-        }
-      }
-      if (typeof node.max_items_per_section === "number" && node.max_items_per_section > 500) {
-        findings.push({
-          severity: "error",
-          code: "recipe.invalid_param",
-          path: `workflow.nodes.${nodeId}.max_items_per_section`,
-          message: `${action} max_items_per_section must not exceed 500`
-        });
-      }
-      if (typeof node.timeout_ms === "number" && node.timeout_ms > 6e4) {
-        findings.push({
-          severity: "error",
-          code: "recipe.invalid_param",
-          path: `workflow.nodes.${nodeId}.timeout_ms`,
-          message: `${action} timeout_ms must not exceed 60000`
-        });
-      }
-      if (isRecord(node.sampling)) {
-        if (typeof node.sampling.count === "number" && node.sampling.count > 10) {
-          findings.push({
-            severity: "error",
-            code: "recipe.invalid_param",
-            path: `workflow.nodes.${nodeId}.sampling.count`,
-            message: `${action} sampling.count must not exceed 10`
-          });
-        }
-        if (typeof node.sampling.interval_ms === "number" && node.sampling.interval_ms > 3e4) {
-          findings.push({
-            severity: "error",
-            code: "recipe.invalid_param",
-            path: `workflow.nodes.${nodeId}.sampling.interval_ms`,
-            message: `${action} sampling.interval_ms must not exceed 30000`
-          });
-        }
-      }
-      if (isRecord(node.expect)) {
-        if (typeof node.expect.minimum_changed_market_count === "number" && node.expect.minimum_changed_market_count > 100) {
-          findings.push({
-            severity: "error",
-            code: "recipe.invalid_param",
-            path: `workflow.nodes.${nodeId}.expect.minimum_changed_market_count`,
-            message: `${action} expect.minimum_changed_market_count must not exceed 100`
-          });
-        }
-        if (typeof node.expect.minimum_history_count === "number" && node.expect.minimum_history_count > 500) {
-          findings.push({
-            severity: "error",
-            code: "recipe.invalid_param",
-            path: `workflow.nodes.${nodeId}.expect.minimum_history_count`,
-            message: `${action} expect.minimum_history_count must not exceed 500`
-          });
-        }
-      }
-    }
-    if (action === "metamask.perps.assert_visible_consistency" && adapter === "extension") {
-      maximum("sample_count", 10);
-      maximum("sample_interval_ms", 3e4);
-      maximum("minimum_changed_count", 200);
-      maximum("minimum_recent_activity_count", 50);
-      maximum("timeout_ms", 12e4);
-      maximum("max_items", 200);
-    }
-    const fundedVisibleMutation = adapter === "extension" && (action === "metamask.perps.close_visible_position" || action === "metamask.perps.close_orders" || action === "metamask.perps.edit_margin" || action === "metamask.perps.update_position_tpsl" || action === "metamask.perps.place_order" && node.confirm_live === true);
-    if (fundedVisibleMutation) {
-      const required = (name, pattern, message) => {
-        if (typeof node[name] === "string" && pattern.test(node[name])) return;
-        findings.push({
-          severity: "error",
-          code: "recipe.invalid_param",
-          path: `workflow.nodes.${nodeId}.${name}`,
-          message
-        });
-      };
-      const decimal = action === "metamask.perps.close_visible_position" || action === "metamask.perps.update_position_tpsl" ? node.funding_amount : node.amount ?? node.notional;
-      const decimalText = String(decimal ?? "");
-      const match = /^([1-9][0-9]*)(?:\.([0-9]{1,6}))?$/u.exec(decimalText);
-      if (!match) {
-        findings.push({
-          severity: "error",
-          code: "recipe.invalid_param",
-          path: `workflow.nodes.${nodeId}.${action === "metamask.perps.close_visible_position" || action === "metamask.perps.update_position_tpsl" ? "funding_amount" : "amount"}`,
-          message: `${action} funded decimal amount must be positive plain decimal text with at most six places`
-        });
-      }
-      if (action === "metamask.perps.place_order" && node.submit_attempts !== void 0 && node.submit_attempts !== 1) {
-        findings.push({
-          severity: "error",
-          code: "recipe.invalid_param",
-          path: `workflow.nodes.${nodeId}.submit_attempts`,
-          message: `${action} funded visible submission requires submit_attempts=1`
-        });
-      }
-      if (action === "metamask.perps.close_visible_position" || action === "metamask.perps.edit_margin" || action === "metamask.perps.update_position_tpsl") {
-        required("funding_side", /^(?:long|short)$/u, `${action} requires the authorized position side`);
-      }
-      if (action === "metamask.perps.edit_margin" || action === "metamask.perps.update_position_tpsl") {
-        required(
-          "funding_position_size",
-          /^(?=[0-9.]*[1-9])[0-9]+(?:\.[0-9]+)? [A-Z0-9:_-]{2,20}$/u,
-          `${action} requires the exact visible position size`
-        );
-      }
-      if (action === "metamask.perps.close_visible_position" && node.cleanup_only === true) {
-        required(
-          "funding_position_size",
-          /^(?=[0-9.]*[1-9])[0-9]+(?:\.[0-9]+)? [A-Z0-9:_-]{2,20}$/u,
-          `${action} cleanup requires the exact visible position size`
-        );
-        if (node.amount != null) {
-          findings.push({
-            severity: "error",
-            code: "recipe.invalid_param",
-            path: `workflow.nodes.${nodeId}.amount`,
-            message: `${action} cleanup must close the full exact position`
-          });
-        }
-      }
-      if (action === "metamask.perps.edit_margin" && !/^[1-9][0-9]*(?:\.[0-9]{1,6})?$/u.test(String(node.funding_amount ?? ""))) {
-        findings.push({
-          severity: "error",
-          code: "recipe.invalid_param",
-          path: `workflow.nodes.${nodeId}.funding_amount`,
-          message: `${action} requires the authorized position amount`
-        });
-      }
-      if (action === "metamask.perps.close_orders") {
-        required("side", /^(?:long|short)$/u, `${action} requires the exact order side`);
-        const outputPrice = /^\{\{outputs\.[A-Za-z0-9_.-]+\}\}$/u.test(String(node.limit_price ?? ""));
-        if (!outputPrice && (!/^(?:0|[1-9][0-9]*)(?:\.[0-9]{1,6})?$/u.test(String(node.limit_price ?? "")) || !(Number(node.limit_price) > 0))) {
-          findings.push({
-            severity: "error",
-            code: "recipe.invalid_param",
-            path: `workflow.nodes.${nodeId}.limit_price`,
-            message: `${action} requires an explicit positive limit_price for resumable cancellation`
-          });
-        }
-      }
-      if (action === "metamask.perps.place_order" && String(node.order_type ?? "market") === "limit" && (!/^(?:0|[1-9][0-9]*)(?:\.[0-9]{1,6})?$/u.test(String(node.limit_price ?? "")) || !(Number(node.limit_price) > 0))) {
-        findings.push({
-          severity: "error",
-          code: "recipe.invalid_param",
-          path: `workflow.nodes.${nodeId}.limit_price`,
-          message: `${action} funded limit submission requires explicit limit_price; offset-only pricing is not resumable`
-        });
-      }
-      for (const name of ["identity_rounding_tolerance_base_units", "balance_reconciliation_tolerance_base_units"]) {
-        if (node[name] === void 0) continue;
-        const value = String(node[name]);
-        if (!/^(?:0|[1-9][0-9]{0,6})$/u.test(value) || BigInt(value) > 1000000n) {
-          findings.push({
-            severity: "error",
-            code: "recipe.invalid_param",
-            path: `workflow.nodes.${nodeId}.${name}`,
-            message: `${action} ${name} must be an integer string from 0 through 1000000`
-          });
-        }
-      }
-    }
+    findings.push(...surface?.actions.inputFindings?.(nodeId, node) ?? []);
     const state = typeof node.state === "string" ? node.state.toLowerCase() : void 0;
-    const createsOrder = action === "metamask.perps.place_order" || adapter !== "extension" && (action === "metamask.perps.ensure_positions" || action === "metamask.perps.ensure_orders") && (state === "open" || state === "present");
+    const createsOrder = action === "metamask.perps.place_order" || !surface?.actions.ensureChecksOnly && (action === "metamask.perps.ensure_positions" || action === "metamask.perps.ensure_orders") && (state === "open" || state === "present");
     if (!createsOrder) continue;
     const requireOneOf = (names, message) => {
       const present = names.some((name) => {

package/dist/mm-harness-cli.js

@@ -7,6 +7,7 @@ import { color } from "./cli-color.js";
 import { withCommandJournal } from "./command-journal.js";
 import { JsonStreamWriter } from "./json-stream.js";
 import { handleUpdate, maybeNudge } from "./commands/update.js";
+import { handlePin } from "./commands/pin.js";
 import { handleCallHelp } from "./commands/call.js";
 import { handleHelp } from "./commands/help.js";
 import { handleTutorial } from "./commands/tutorial.js";
@@ -834,6 +835,27 @@ Example:
 Example:
   mm-harness reload`
   },
+  {
+    name: "pin",
+    summary: "Copy this installed mm-harness into an immutable, versioned store and print the copy for a task to run, so a later global upgrade cannot change a running task.",
+    example: "mm-harness pin",
+    helpText: `mm-harness pin [flags]
+
+  Copies the installed mm-harness running this command into an immutable,
+  versioned store (~/.local/share/mm-harness/pins/<version>-<hash>/; APFS clone
+  where available) and prints the copy's executable. A task records that path,
+  so \`npm i -g\` upgrading the global install never changes the harness a running
+  task runs. Idempotent: the same install returns the same pin. A source checkout
+  (MM_HARNESS_BIN) or an existing pin is printed as is.
+
+  --json                             Machine-readable { version, source, executable, pinned, created }
+
+  MM_HARNESS_PIN_ROOT overrides the store location.
+
+Example:
+  mm-harness pin
+  mm-harness pin --json`
+  },
   {
     name: "update",
     summary: "Update the installed mm-harness to the published latest (--check reports only; --json = {current, latest, updateAvailable}).",
@@ -980,7 +1002,7 @@ const HELP_GROUPS = [
   {
     title: "MAINTAIN",
     blurb: "keep the installed harness current with the npm registry",
-    commands: ["setup-base", "update"]
+    commands: ["setup-base", "update", "pin"]
   }
 ];
 function commandMeta(name) {
@@ -1010,8 +1032,9 @@ function detectedSlotLine(out) {
     if (ctx.slotId) parts.push(`slot ${out("ok", String(ctx.slotId))}`);
     if (ctx.simulator) parts.push(`device ${out("ok", String(ctx.simulator))}`);
     const devServerPort = ctx.watcherPort ?? ctx.devServerPort ?? ctx.metroPort;
-    if (adapter && adapter !== "core" && devServerPort) {
-      parts.push(`${getAdapterSurface(adapter).devServer.label} :${out("ok", String(devServerPort))}`);
+    const surface = adapter ? getAdapterSurface(adapter) : void 0;
+    if (surface && !surface.headless && devServerPort) {
+      parts.push(`${surface.devServer.label} :${out("ok", String(devServerPort))}`);
     }
     if (ctx.gitBranch) parts.push(`branch ${out("info", String(ctx.gitBranch))}`);
     if (parts.length === 0) return null;
@@ -1088,6 +1111,9 @@ for (const command of REAL) {
     if (command.name === "update") {
       process.exit(await handleUpdate(rawArgv.slice(1)));
     }
+    if (command.name === "pin") {
+      process.exit(handlePin(rawArgv.slice(1)));
+    }
     if (command.name === "help") {
       process.exitCode = handleHelp(rawArgv.slice(1), { packageRoot, harnessVersion: pkgVersion });
       return;
@@ -1116,7 +1142,7 @@ program.command("completions").description("Install/print bundled shell tab-comp
   const result = spawnSync("bash", [script, ...rawArgv.slice(1)], { stdio: "inherit" });
   process.exit(result.status ?? 1);
 });
-const NUDGE_SKIP = ["help", "tutorial", "setup-base", "update", "completions", "completion-candidates"];
+const NUDGE_SKIP = ["help", "tutorial", "setup-base", "update", "pin", "completions", "completion-candidates"];
 if (rawArgv.length > 0 && !NUDGE_SKIP.includes(rawArgv[0])) {
   maybeNudge();
 }

package/dist/network-observation.js

@@ -4,6 +4,7 @@ import configModule from "../adapters/mobile/bridge-runtime/lib/config.cjs";
 import {
   createExtensionNetworkObserver
 } from "./adapters/extension/network-observer.js";
+import { getAdapterSurface } from "./adapters/surface.js";
 import {
   indexArtifactManifest,
   writeContainedArtifact
@@ -14,7 +15,8 @@ const { brokerSocketPath, createBrokerClient } = brokerModule;
 const { resolvePort } = configModule;
 const sessions = /* @__PURE__ */ new Map();
 async function startRunNetworkObservation(adapter, target, artifactsDir, env, ports = {}) {
-  if (adapter === "core") return void 0;
+  const network = getAdapterSurface(adapter).observation?.network;
+  if (!network) return void 0;
   const runtimeEnv = {
     ...env,
     ...ports.cdpPort ? { CDP_PORT: ports.cdpPort, RECIPE_CDP_PORT: ports.cdpPort } : {},
@@ -29,7 +31,7 @@ async function startRunNetworkObservation(adapter, target, artifactsDir, env, po
   };
   sessions.set(key, session);
   try {
-    session.backend = adapter === "mobile" ? await createMobileNetworkBackend(target, runtimeEnv) : await createExtensionNetworkObserver(extensionCdpPort(runtimeEnv), key);
+    session.backend = await network.backend(target, runtimeEnv, key);
   } catch (error) {
     session.setupError = boundedError(error);
   }
@@ -76,7 +78,7 @@ async function startRunNetworkObservation(adapter, target, artifactsDir, env, po
   };
 }
 async function handleRunNetworkAction(platform, action, node, context) {
-  if (platform !== "extension") return null;
+  if (!getAdapterSurface(platform).observation?.network?.actions) return null;
   if (action === "app.network_assert") {
     const assertion = await import("../library/actions/shared/app/network-assert.mjs");
     return {
@@ -261,6 +263,9 @@ async function indexArtifact(artifactManifestPath, relativePath, label) {
     ]
   );
 }
+async function createExtensionNetworkBackend(env, artifactsDir) {
+  return createExtensionNetworkObserver(extensionCdpPort(env), artifactsDir);
+}
 function extensionCdpPort(env) {
   const port = Number(
     env.CDP_PORT ?? env.RECIPE_CDP_PORT ?? process.env.CDP_PORT
@@ -278,6 +283,8 @@ function asRecord(value) {
 }
 export {
   connectMobileBroker,
+  createExtensionNetworkBackend,
+  createMobileNetworkBackend,
   handleRunNetworkAction,
   startRunNetworkObservation
 };

package/dist/paths.js

@@ -1,6 +1,7 @@
 import fs from "node:fs";
 import path from "node:path";
 import { fileURLToPath, pathToFileURL } from "node:url";
+import { adapterRegistry } from "./adapters/registry.js";
 const runnerDir = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
 const pathDefaults = readPathDefaults();
 const DEFAULT_RECIPE_RUNTIME_DIR = pathDefaults.recipeRuntimeDir;
@@ -88,8 +89,13 @@ function isProtocolRoot(candidate) {
   return fs.existsSync(path.join(candidate, "packages/recipe-harness/package.json")) && fs.existsSync(path.join(candidate, "packages/protocol/package.json"));
 }
 function assertAdapter(adapter) {
-  if (adapter !== "mobile" && adapter !== "extension" && adapter !== "core" && adapter !== "terminal") {
-    throw new Error("Adapter must be mobile, extension, core, or terminal.");
+  const ids = adapterRegistry.list();
+  if (ids.length === 0) {
+    throw new Error("internal: no adapters are registered yet; import src/adapters/surface.ts before validating an adapter");
+  }
+  if (typeof adapter !== "string" || !adapterRegistry.has(adapter)) {
+    const choices = ids.length > 1 ? `${ids.slice(0, -1).join(", ")}, or ${ids.at(-1)}` : ids.join("");
+    throw new Error(`Adapter must be ${choices}.`);
   }
 }
 function manifestPath(adapter) {

package/dist/performance-observation.js

@@ -1,10 +1,9 @@
 import path from "node:path";
 import { promisify } from "node:util";
 import { gzip } from "node:zlib";
-import {
-  createMobilePerformanceBackend
-} from "./adapters/mobile/performance-observer.js";
+import { getAdapterSurface } from "./adapters/surface.js";
 import { createExtensionPerformanceBackend } from "./adapters/extension/performance-observer.js";
+import { TRACE_KINDS } from "./adapters/performance/cdp-trace.js";
 import { summarizeFrames } from "./adapters/mobile/frame-metrics.js";
 import { summarizeJavaScriptTasks } from "./adapters/performance/js-task-metrics.js";
 import {
@@ -17,10 +16,11 @@ const DEFAULT_MAX_DURATION_MS = 5 * 60 * 1e3;
 const MAX_DURATION_MS = 60 * 60 * 1e3;
 const gzipAsync = promisify(gzip);
 function startRunPerformanceObservation(adapter, target, artifactsDir, env, ports = {}) {
-  if (adapter === "core") return void 0;
+  const observer = getAdapterSurface(adapter).observation?.performance;
+  if (!observer) return void 0;
   const key = path.resolve(artifactsDir);
   const session = {
-    adapter,
+    observer,
     artifactsDir: key,
     env: {
       ...env,
@@ -84,7 +84,7 @@ function startRunPerformanceObservation(adapter, target, artifactsDir, env, port
   };
 }
 async function handleRunPerformanceAction(platform, action, node, context) {
-  if (platform === "core") return null;
+  if (!getAdapterSurface(platform).observation?.performance) return null;
   if (action === "app.performance_assert") {
     return { output: await assertPerformance(node, context) };
   }
@@ -154,10 +154,7 @@ async function performanceBackend(session) {
   if (session.backend) return session.backend;
   if (session.backendError) throw new Error(session.backendError);
   try {
-    session.backend = session.adapter === "mobile" ? await createMobilePerformanceBackend(session.target, session.env) : await createExtensionPerformanceBackend(
-      extensionCdpPort(session),
-      session.target
-    );
+    session.backend = await session.observer.backend(session.target, session.env, session.ports);
     return session.backend;
   } catch (error) {
     session.backendError = errorMessage(error);
@@ -182,7 +179,7 @@ function finishCaptureWindow(session, window) {
   return window.result;
 }
 function buildPerformanceArtifact(window, endedAtEpochMs, result, allEvents) {
-  const javascriptTasksApplicable = result.platform === "extension";
+  const javascriptTasksApplicable = TRACE_KINDS[result.platform].javascriptTasks;
   const javascript = javascriptTasksApplicable ? result.javascript : {
     ...result.javascript,
     applicability: "not_applicable",
@@ -436,7 +433,7 @@ function chromeTracePath(jsonPath) {
   return jsonPath.endsWith(".json") ? `${jsonPath.slice(0, -".json".length)}-trace.json.gz` : `${jsonPath}-trace.json.gz`;
 }
 function renderPerformanceHtml(artifact) {
-  const javascriptTasksApplicable = artifact.platform === "extension";
+  const javascriptTasksApplicable = TRACE_KINDS[artifact.platform].javascriptTasks;
   const iosCadence = artifact.platform === "ios";
   const maxNodeDurationMs = Math.max(
     1,
@@ -503,7 +500,7 @@ function unavailableCapture(session, window, reason) {
     window,
     Date.now(),
     {
-      platform: resolveSessionPlatform(session),
+      platform: session.observer.platform(session.env),
       javascript: unavailableJavaScript,
       nativeUi: unavailableNativeUi,
       trace: {
@@ -520,17 +517,12 @@ function unavailableCapture(session, window, reason) {
     session.nodeEvents
   );
 }
-function resolveSessionPlatform(session) {
-  if (session.adapter === "extension") return "extension";
-  const explicit = String(
-    session.env.MM_HARNESS_EXPLICIT_PLATFORM ?? session.env.RECIPE_HARNESS_PLATFORM ?? ""
-  ).toLowerCase();
-  if (explicit === "android" || explicit === "ios") return explicit;
-  return session.env.ADB_SERIAL || session.env.ANDROID_SERIAL || session.env.ANDROID_DEVICE ? "android" : "ios";
+async function createExtensionPerformanceObserver(target, env, ports) {
+  return createExtensionPerformanceBackend(extensionCdpPort(ports, env), target);
 }
-function extensionCdpPort(session) {
+function extensionCdpPort(ports, env) {
   const port = Number(
-    session.ports.cdpPort ?? session.env.CDP_PORT ?? session.env.RECIPE_CDP_PORT
+    ports.cdpPort ?? env.CDP_PORT ?? env.RECIPE_CDP_PORT
   );
   if (!Number.isInteger(port) || port <= 0) {
     throw new Error("Extension performance observation requires CDP_PORT.");
@@ -572,6 +564,7 @@ function errorMessage(error) {
 }
 export {
   buildPerformanceArtifact,
+  createExtensionPerformanceObserver,
   handleRunPerformanceAction,
   renderPerformanceHtml,
   startRunPerformanceObservation

package/dist/pr-body/render.js

@@ -37,6 +37,8 @@ function countRecipeNodes(recipe) {
   if (Array.isArray(record.steps)) return record.steps.length;
   const workflow = record.workflow;
   if (!workflow || typeof workflow !== "object") return 0;
+  const graph = workflow.nodes;
+  if (graph && typeof graph === "object" && !Array.isArray(graph)) return Object.keys(graph).length;
   return Object.values(workflow).reduce(
     (total, value) => total + (Array.isArray(value) ? value.length : 0),
     0
@@ -47,7 +49,7 @@ function recipeSection(file) {
   const nodes = countRecipeNodes(recipe);
   const record = recipe && typeof recipe === "object" ? recipe : {};
   const title = typeof record.title === "string" ? record.title : typeof record.description === "string" ? record.description : "";
-  const summary = escapeHtml(`recipe.json (${nodes} steps${title ? ` \u2014 ${title.slice(0, 120)}` : ""})`);
+  const summary = escapeHtml(`recipe.json (${nodes} nodes${title ? ` \u2014 ${title.slice(0, 120)}` : ""})`);
   return {
     nodes,
     body: [`<details><summary>${summary}</summary>`, "", fenced(JSON.stringify(recipe, null, 2), "json"), "</details>"].join("\n")

package/dist/recording-target.js

@@ -6,45 +6,10 @@ const IOS_SIMULATOR_RECORDING_TARGET_PREFIX = "ios-simulator:";
 function createMetaMaskRecordingTargetProvider(adapter) {
   return {
     async resolveRecordingTarget(context) {
-      if (adapter === "extension") {
-        const pid = resolveExtensionBrowserPid(
-          context.projectRoot,
-          context.artifactsDir,
-          context.env.CDP_PORT ?? context.env.RECIPE_CDP_PORT ?? process.env.CDP_PORT ?? process.env.RECIPE_CDP_PORT
-        );
-        if (!pid) {
-          throw new Error(
-            "Could not resolve the extension browser PID for --record-video. Ensure the slot browser is running and CDP_PORT is set."
-          );
-        }
-        return { kind: "pid", pid };
-      }
-      if (adapter === "mobile") {
-        const platform = (context.env.PLATFORM ?? process.env.PLATFORM ?? "ios").trim().toLowerCase();
-        const androidSerial = resolveAndroidDeviceSerial(context.env);
-        if (platform === "android" || androidSerial) {
-          if (!androidSerial) {
-            throw new Error(
-              "Could not resolve an Android device for --record-video. Set ADB_SERIAL or pass --device to mm-harness run."
-            );
-          }
-          return {
-            kind: "android-device",
-            serial: androidSerial
-          };
-        }
-        const simulator = resolveMobileIosSimulatorName(context.env);
-        if (!simulator) {
-          throw new Error(
-            "Could not resolve an iOS simulator name for --record-video. Set IOS_SIMULATOR or pass --simulator to the recipe hook."
-          );
-        }
-        return {
-          kind: "window-id",
-          windowId: `${IOS_SIMULATOR_RECORDING_TARGET_PREFIX}${simulator}`
-        };
-      }
-      throw new Error(`--record-video is not implemented for the ${adapter} adapter.`);
+      const { getAdapterSurface } = await import("./adapters/surface.js");
+      const recording = getAdapterSurface(adapter).recording;
+      if (!recording) throw new Error(`--record-video is not implemented for the ${adapter} adapter.`);
+      return recording.target(context);
     }
   };
 }