@deeeed/metamask-harness 0.73.0 → 0.74.0

package/dist/commands/launch/mobile.js

@@ -1,3 +1,4 @@
+import fs from "node:fs";
 import { prepareMobile } from "../../adapters/mobile/prepare.js";
 import {
   mobileSourceCheck,
@@ -7,7 +8,11 @@ import { ensureHarnessFresh } from "../../adapters/harness-freshness.js";
 import { pinMobileFeatureFlags } from "../../adapters/mobile/feature-flags.js";
 import { toRemoteFlagSpec } from "../../feature-flags.js";
 import { clearMobileReleaseArtifactState } from "../../adapters/mobile/release-artifact-state.js";
-import { EXIT } from "../shared.js";
+import { EXIT, str, writeInteractiveProgress } from "../shared.js";
+import { applyDeviceTargeting } from "../device-target.js";
+import { RECOVERY_CODE } from "../../heal-bounds.js";
+import { recipeRuntimePath } from "../../paths.js";
+import { shellQuote } from "./device.js";
 async function launchMobile(target, mobileTarget, tier, json, restartApp = false, clearMetro = false, remoteFlags) {
   clearMobileReleaseArtifactState(target);
   await ensureHarnessFresh(target, "mobile");
@@ -54,6 +59,189 @@ async function launchMobile(target, mobileTarget, tier, json, restartApp = false
   }
   return { ...result, remoteFeatureFlags: provenFlags };
 }
+function mobileProvisioningBlocked(output) {
+  return /open-device: configured iOS simulator '.+' does not exist|open-device: no MetaMask bundle found|fast mode requires an installed (?:iOS dev client|Android dev client)/u.test(output);
+}
+function missingConfiguredIosSimulator(output) {
+  return /open-device: configured iOS simulator '([^']+)' does not exist/u.exec(output)?.[1];
+}
+function ambiguousConfiguredIosSimulator(output) {
+  return /open-device: iOS simulator target ("[^"]+") is ambiguous/u.exec(output)?.[1];
+}
+function mobileBridgeTargetMissing(output) {
+  return /no bridge target matched|wait-for-bridge: readiness deadline expired/iu.test(output);
+}
+function mobileProvisionCommand(target, mobileTarget) {
+  const platform = mobileTarget === "android" ? "android" : "ios";
+  const device = platform === "ios" ? process.env.SIM_UDID || process.env.IOS_SIMULATOR : process.env.ADB_SERIAL || process.env.ANDROID_SERIAL || process.env.ANDROID_DEVICE;
+  const parts = ["mm-harness", "provision", "runway", platform, "--adapter", "mobile", "--target", shellQuote(target)];
+  if (device) parts.push("--device", shellQuote(device));
+  return parts.join(" ");
+}
+function isIosSimulatorUdid(value) {
+  return /^[0-9A-Fa-f-]{36}$/u.test(value);
+}
+function launchDeviceLabel(mobileTarget) {
+  if (mobileTarget === "android") {
+    return process.env.ANDROID_TARGET_DEVICE_NAME || process.env.ADB_SERIAL || process.env.ANDROID_SERIAL || process.env.ANDROID_DEVICE || "android device";
+  }
+  if (mobileTarget === "ios") {
+    return process.env.IOS_SIMULATOR || process.env.SIM_UDID || "iOS simulator";
+  }
+  return process.env.IOS_SIMULATOR || process.env.ADB_SERIAL || "booted device";
+}
+function metroLaunchEvidence(target) {
+  const evidencePath = recipeRuntimePath(target, "metro-generation.json");
+  let descriptor;
+  try {
+    descriptor = fs.openSync(evidencePath, fs.constants.O_RDONLY | fs.constants.O_NOFOLLOW);
+    const stat = fs.fstatSync(descriptor);
+    if (!stat.isFile() || stat.size > 256 * 1024) return void 0;
+    return JSON.parse(fs.readFileSync(descriptor, "utf8"));
+  } catch {
+    return void 0;
+  } finally {
+    if (descriptor !== void 0) fs.closeSync(descriptor);
+  }
+}
+const mobileLaunchProfile = {
+  refuseFlags({ mobileTarget }) {
+    if (!mobileTarget) {
+      return { message: "target is required for mobile.", userAction: "mm-harness launch ios   or   mm-harness launch android" };
+    }
+    return void 0;
+  },
+  applyEnv({ adapter, options, mobileTarget, target }) {
+    const device = str(options, "device");
+    if (!device && mobileTarget !== "ios" && mobileTarget !== "android") return void 0;
+    const targetingOptions = {
+      ...options,
+      ...mobileTarget ? { platform: mobileTarget } : {}
+    };
+    const result = applyDeviceTargeting("launch", adapter, targetingOptions, { gate: false, rerun: "" });
+    if ("code" in result) {
+      if (mobileTarget === "ios" && result.code === "DEVICE_NOT_FOUND") {
+        process.env.IOS_SIMULATOR = device;
+        process.env.SIM_UDID = isIosSimulatorUdid(device) ? device : "";
+        process.env.ADB_SERIAL = "";
+        process.env.ANDROID_SERIAL = "";
+        process.env.ANDROID_DEVICE = "";
+        process.env.ANDROID_TARGET_DEVICE_NAME = "";
+      } else {
+        return result;
+      }
+    }
+    if (mobileTarget === "android" && device && !process.env.ADB_SERIAL && !process.env.ANDROID_SERIAL) {
+      return {
+        ok: false,
+        code: "DEVICE_WRONG_PLATFORM",
+        message: `--device ${device} did not resolve to an Android device for launch android.`,
+        userAction: `mm-harness status --target ${shellQuote(target)} --all-devices --json`
+      };
+    }
+    if (mobileTarget === "ios" && device && !process.env.IOS_SIMULATOR) {
+      return {
+        ok: false,
+        code: "DEVICE_WRONG_PLATFORM",
+        message: `--device ${device} did not resolve to an iOS simulator for launch ios.`,
+        userAction: `mm-harness status --target ${shellQuote(target)} --all-devices --json`
+      };
+    }
+    return void 0;
+  },
+  start({ options, mobileTarget, machine, tier, wantClearMetro }) {
+    const device = str(options, "device") ?? (mobileTarget === "android" ? process.env.ADB_SERIAL ?? process.env.ANDROID_SERIAL : process.env.IOS_SIMULATOR ?? process.env.SIM_UDID) ?? "configured device";
+    const watcherPort = str(options, "watcherPort") ?? process.env.WATCHER_PORT ?? "auto";
+    writeInteractiveProgress(
+      machine,
+      `\u2192 mobile launch \u2014 ${mobileTarget} \xB7 ${tier === "build" ? "native build" : "quick readiness"} \xB7 ${device} \xB7 Metro ${watcherPort === "auto" ? "auto" : `:${watcherPort}`}${wantClearMetro ? " \xB7 clear cache" : ""}`
+    );
+  },
+  nativeInputs: ["ios", "android", "package.json", "yarn.lock"],
+  rebuildCommand: ({ mobileTarget }) => `mm-harness launch ${mobileTarget} --build`,
+  compose: ({ target, mobileTarget, machine, remoteFlagRequest }, tier, restartApp, clearMetro) => launchMobile(target, mobileTarget, tier, machine, restartApp, clearMetro, remoteFlagRequest?.flags),
+  classify(_launch, output) {
+    if (output.includes("open-device: Android device is locked.")) {
+      return {
+        code: "MOBILE_DEVICE_LOCKED",
+        message: "the selected Android device is locked.",
+        recoverable: false,
+        userAction: "Unlock the selected Android device, then retry the launch.",
+        exitCode: EXIT.runtime,
+        originalError: output.trim()
+      };
+    }
+    if (/open-device: Android (?:lock state unavailable|display preparation failed)\./u.test(output)) {
+      return {
+        code: "MOBILE_DEVICE_UI_UNAVAILABLE",
+        message: "the selected Android display could not be prepared.",
+        recoverable: false,
+        userAction: "Check adb access and the selected device screen, then retry the launch.",
+        exitCode: EXIT.runtime,
+        originalError: output.trim()
+      };
+    }
+    return void 0;
+  },
+  async beforeHeal(launch, attempt, state) {
+    const { target, mobileTarget, tier } = launch;
+    const output = attempt.output;
+    const missingIosSimulator = missingConfiguredIosSimulator(output);
+    const ambiguousIosSimulator = ambiguousConfiguredIosSimulator(output);
+    if (ambiguousIosSimulator) {
+      return launch.fail(state, {
+        code: "MOBILE_DEVICE_AMBIGUOUS",
+        message: `more than one iOS simulator matches ${ambiguousIosSimulator}.`,
+        recoverable: false,
+        userAction: `mm-harness status --adapter mobile --target ${shellQuote(target)} --all-devices --json`,
+        exitCode: EXIT.runtime,
+        originalError: output.trim() || void 0
+      });
+    }
+    if (missingIosSimulator && isIosSimulatorUdid(missingIosSimulator)) {
+      return launch.fail(state, {
+        code: "MOBILE_DEVICE_NOT_FOUND",
+        message: `the configured iOS simulator ${missingIosSimulator} no longer exists.`,
+        recoverable: false,
+        userAction: `mm-harness status --adapter mobile --target ${shellQuote(target)} --all-devices --json`,
+        exitCode: EXIT.runtime,
+        originalError: output.trim() || void 0
+      });
+    }
+    if (mobileProvisioningBlocked(output)) {
+      return launch.fail(state, {
+        code: "MOBILE_PROVISION_REQUIRED",
+        message: `mobile ${mobileTarget ?? "runtime"} is not provisioned for this slot.`,
+        recoverable: false,
+        userAction: mobileProvisionCommand(target, mobileTarget),
+        exitCode: EXIT.runtime,
+        originalError: output.trim() || void 0
+      });
+    }
+    if (tier === "build" && /open-device: (?:Android|iOS) native build failed/u.test(output)) {
+      return launch.fail(state, {
+        code: "MOBILE_NATIVE_BUILD_FAILED",
+        message: "the selected Mobile native build failed; refusing to repeat the expensive build as a Metro recovery.",
+        recoverable: false,
+        exitCode: EXIT.runtime,
+        originalError: output.trim() || void 0
+      });
+    }
+    return void 0;
+  },
+  recovery(_launch, output) {
+    const restartApp = mobileBridgeTargetMissing(output);
+    return { code: restartApp ? "mobile.app-restarted" : RECOVERY_CODE.mobile, restartApp };
+  },
+  // Mobile proved its set inside launchMobile (null: nothing requested and no
+  // runtime answered).
+  provenFlags: (_launch, requested, proven) => ({ flags: proven === void 0 ? requested : proven }),
+  verifyArgs: ({ mobileTarget }) => mobileTarget ? ["--platform", mobileTarget] : [],
+  platformLabel: ({ mobileTarget }) => mobileTarget ?? null,
+  deviceLabel: ({ mobileTarget }) => launchDeviceLabel(mobileTarget),
+  evidence: metroLaunchEvidence
+};
 export {
-  launchMobile
+  launchMobile,
+  mobileLaunchProfile
 };

package/dist/commands/review.js

@@ -8,6 +8,7 @@ import {
   parityAdapter,
   readConfig,
   referenceHint,
+  REVIEW_ADAPTERS,
   renderReviewChecklist,
   renderReviewHelp,
   resolveLibrary,
@@ -30,7 +31,8 @@ function adapterFromOptions(options, target) {
     if (raw !== "mobile" && raw !== "extension" && raw !== "core" && raw !== "terminal") throw usageError(`--adapter must be mobile, extension, core, or terminal (got ${raw}).`);
     return raw;
   }
-  return detectAdapter(target) ?? "unscoped";
+  const detected = detectAdapter(target);
+  return REVIEW_ADAPTERS.find((adapter) => adapter === detected) ?? "unscoped";
 }
 function resolveReviewContext(options, { fetch = true } = {}) {
   const target = targetPath(options);

package/dist/commands/shared.js

@@ -7,6 +7,7 @@ import path from "node:path";
 import { detectAdapter } from "../harness.js";
 import { colorHumanMessage } from "../cli-color.js";
 import { resolveLeafInvoke, shellLeafMissing } from "../leaf-invoke.js";
+import { adapterRegistry } from "../adapters/registry.js";
 const EXIT = { ok: 0, runtime: 1, usage: 2, infra: 3, bounded: 4, validation: 5 };
 function writeInteractiveProgress(json, message, {
   stdoutIsTTY = Boolean(process.stdout.isTTY),
@@ -59,11 +60,10 @@ function flag(options, key) {
 function targetOf(options) {
   return path.resolve(str(options, "target") ?? process.cwd());
 }
-const ADAPTER_TOKENS = ["mobile", "extension", "core", "terminal"];
 function resolveAdapter(options, target, hint) {
   const platform = str(options, "platform");
   const explicit = str(options, "adapter") ?? (platform === "ios" || platform === "android" ? "mobile" : platform);
-  if (explicit && ADAPTER_TOKENS.includes(explicit)) return explicit;
+  if (explicit && adapterRegistry.has(explicit)) return explicit;
   if (hint) return hint;
   return detectAdapter(target);
 }

package/docs/CONTRIBUTING.md

@@ -61,9 +61,14 @@ exits.
 ## Adapter surface
 
 Commands resolve shared platform behavior through
-`src/adapters/surface.ts`. Extend `AdapterSurface` only when all platforms need
-the concept, implement all three adapters, and let Core report headless/N/A
-explicitly. Do not add command-local platform ladders for surface-owned behavior.
+`src/adapters/surface.ts`. Each platform's surface registers itself in
+`src/adapters/registry.ts` when its module loads; a new platform registers the
+same way and needs no edit to shared code. Extend `AdapterSurface` only when all
+platforms need the concept, implement it in every adapter, and let Core report
+headless/N/A explicitly. Do not add command-local platform ladders for
+surface-owned behavior: `launch` already dispatches through
+`AdapterSurface.launch`, and the device platforms supply a `DeviceLaunchProfile`
+(`src/commands/launch/device.ts`).
 
 Each checkout owns:
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.73.0",
+  "version": "0.74.0",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"