@deeeed/metamask-harness 0.7.4 → 0.7.5

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 0.7.5 - 2026-07-07
+
+### Fixed
+- **`launch --verify` converges duplicate extension home tabs instead of failing prepare forever.** A second bare `home.html` tab can appear beside the operator's slot-titled one outside the harness's control (the extension opens its own tab after the build-freeze reload), and the live verify health gate requires exactly one home tab — but nothing in launch/verify ever collapsed duplicates (`ensureExtensionReady` was only reachable via the retired `ensure-ready` verb), so every preflight retry recounted two tabs and failed. `launch --verify` (extension, with a CDP port) now runs the convergence before the live verify phase.
+- **Convergence keeps the operator's tab.** With multiple home tabs, `ensureExtensionReady` now prunes the extras keeping the preferred tab — attached (another client is driving it) over custom slot title (`<slot-id> — MetaMask`, how operators tell which agent owns a browser) over first listed — instead of closing all and reopening fresh, which discarded the slot title. The deterministic close-all + fresh-open remains as a one-shot fallback when the kept tab fails the health check, and a failed re-listing during the fallback reports `cdp-unreachable` instead of a stale tab count.
+
+### Changed
+- **`EnsureReadyAction` gains `pruned`** — extras were closed keeping the preferred tab; `reopened` now specifically means the pruned keeper failed the health check and one fresh tab was reopened.
+
 ## 0.7.4 - 2026-07-07
 
 ### Added

package/dist/adapters/extension/ensure-ready.js

@@ -47,6 +47,12 @@ function homePages(targets, extensionId) {
     (t) => t.type === "page" && typeof t.url === "string" && t.url.startsWith(prefix) && t.url.includes("/home.html") && t.id
   );
 }
+function pickHomeKeeper(homes) {
+  const attached = homes.filter((t) => typeof t.webSocketDebuggerUrl !== "string");
+  const pool = attached.length > 0 ? attached : homes;
+  const marked = pool.find((t) => typeof t.title === "string" && t.title.trim() !== "" && t.title.trim() !== "MetaMask");
+  return marked ?? pool[0];
+}
 async function ensureExtensionReady(target, options) {
   const resolved = path.resolve(target);
   const { cdpPort } = options;
@@ -91,14 +97,14 @@ async function ensureExtensionReady(target, options) {
       opened = await openHome(cdpPort, extensionId) || opened;
       await sleep(1500);
     } else {
-      action = "reopened";
+      action = "pruned";
+      const keeper = pickHomeKeeper(homes);
       for (const h of homes) {
+        if (h === keeper) continue;
         await closeTab(cdpPort, String(h.id));
         closed += 1;
       }
       await sleep(500);
-      opened = await openHome(cdpPort, extensionId) || opened;
-      await sleep(1500);
     }
     const next = await jsonList(cdpPort);
     if (!next.ok) {
@@ -125,14 +131,35 @@ async function ensureExtensionReady(target, options) {
   if (!finalListing.ok) {
     return base({ extensionId, opened, action, homeTabs: { before, closed, after: homesNow.length }, reasonCode: "cdp-unreachable" });
   }
-  const after = homePages(finalListing.targets, extensionId).length;
-  let health = { status: "unknown", findings: [] };
-  try {
-    const { checkExtensionRuntimeHealth } = await import("./runtime.js");
-    const report = await checkExtensionRuntimeHealth(resolved, cdpPort);
-    health = { status: report.status, findings: report.findings };
-  } catch (error) {
-    health = { status: "FAIL", findings: [error instanceof Error ? error.message : String(error)] };
+  let after = homePages(finalListing.targets, extensionId).length;
+  const checkHealth = async () => {
+    try {
+      const { checkExtensionRuntimeHealth } = await import("./runtime.js");
+      const report = await checkExtensionRuntimeHealth(resolved, cdpPort);
+      return { status: report.status, findings: report.findings };
+    } catch (error) {
+      return { status: "FAIL", findings: [error instanceof Error ? error.message : String(error)] };
+    }
+  };
+  let health = await checkHealth();
+  if (action === "pruned" && (health.status !== "PASS" || after !== 1)) {
+    const listing = await jsonList(cdpPort);
+    if (listing.ok) {
+      action = "reopened";
+      for (const h of homePages(listing.targets, extensionId)) {
+        await closeTab(cdpPort, String(h.id));
+        closed += 1;
+      }
+      await sleep(500);
+      opened = await openHome(cdpPort, extensionId) || opened;
+      await sleep(1500);
+      const relisted = await jsonList(cdpPort);
+      if (!relisted.ok) {
+        return base({ extensionId, opened, action, homeTabs: { before, closed, after }, reasonCode: "cdp-unreachable" });
+      }
+      after = homePages(relisted.targets, extensionId).length;
+      health = await checkHealth();
+    }
   }
   const ready = health.status === "PASS" && after === 1;
   return base({

package/dist/commands/launch/index.js

@@ -104,6 +104,14 @@ async function handleLaunch(argv) {
     });
   }
   if (tier === "verify") {
+    const verifyCdpPort = Number(process.env.CDP_PORT ?? "");
+    if (adapter === "extension" && Number.isInteger(verifyCdpPort) && verifyCdpPort > 0) {
+      const { ensureExtensionReady } = await import("../../adapters/extension/ensure-ready.js");
+      const convergence = await ensureExtensionReady(target, { cdpPort: verifyCdpPort });
+      console.error(
+        `[launch] home-tab convergence: ${convergence.action} (${convergence.homeTabs.before}\u2192${convergence.homeTabs.after} tabs, closed ${convergence.homeTabs.closed})${convergence.ready ? "" : ` \u2014 ${convergence.reasonCode}`}`
+      );
+    }
     const liveArgs = ["live", "--adapter", adapter, "--target", target];
     if (adapter === "mobile" && mobileTarget) liveArgs.push("--platform", mobileTarget);
     if (json) liveArgs.push("--json");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.7.4",
+  "version": "0.7.5",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"
@@ -69,4 +69,4 @@
     "url": "https://github.com/MetaMask/experimental-metamask-harness/issues"
   },
   "homepage": "https://github.com/MetaMask/experimental-metamask-harness#readme"
-}
+}