@deeeed/metamask-harness 0.7.2 → 0.7.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.7.3
+
+### Fixed
+- **`provision runway` gates its install-skip on artifact identity.** The baseline now records the installed artifact identity (run id, branch, digest) at install time and a skip preserves it; provisioning skips ONLY when the recorded identity matches the requested (or probe-resolved) run — a different or unknown installed app is reinstalled from the cache instead of being silently kept. Previously any installed MetaMask.app suppressed the install, so a stale binary could be served against a newer JS bundle.
+- **Provision decisions are machine-readable**: the --json envelope carries `reason` (`identity-match` | `identity-mismatch` | `unknown-identity` | `fresh-install` | `forced`) and a skip envelope includes the matched artifact identity.
+
 ## 0.7.2
 
 ### Added

package/dist/adapters/mobile/provision.js

@@ -71,25 +71,43 @@ async function provisionRunwayMobile(target, options) {
       };
     }
     const sim = ensureSimulator(simulator, runtime, deviceType);
+    let resolved;
+    let reason = options.force ? "forced" : "fresh-install";
     if (!options.force && appInstalled(sim.udid ?? sim.name)) {
-      const baselinePath2 = writeRunwayBaseline(resolvedTarget, slot, platform, void 0, void 0, sim, true, options.runtimeDir);
-      return {
-        schemaVersion: 1,
-        command: "provision",
-        adapter: "mobile",
-        target: resolvedTarget,
-        platform,
-        status: "pass",
-        exitCode: 0,
-        slot,
-        simulator: sim,
-        skipped: true,
-        installed: false,
-        baselinePath: baselinePath2
-      };
+      const installed = readInstalledBaselineArtifact(resolvedTarget, sim, options.runtimeDir);
+      let requestedRunId = options.run;
+      if (installed && !requestedRunId) {
+        log(options, `runway: resolving Runway artifact for ${branch} (default ${defaultBranch})`);
+        resolved = resolveArtifactRun(repo, branch, defaultBranch, void 0);
+        requestedRunId = resolved.runId;
+      }
+      if (installed && installed.runId === requestedRunId) {
+        const baselinePath2 = writeRunwayBaseline(resolvedTarget, slot, platform, void 0, void 0, sim, true, options.runtimeDir, installed.record);
+        return {
+          schemaVersion: 1,
+          command: "provision",
+          adapter: "mobile",
+          target: resolvedTarget,
+          platform,
+          status: "pass",
+          exitCode: 0,
+          slot,
+          // State WHAT matched: the recorded artifact identity the skip trusted.
+          artifact: installed.record,
+          simulator: sim,
+          skipped: true,
+          installed: false,
+          baselinePath: baselinePath2,
+          reason: "identity-match"
+        };
+      }
+      reason = installed ? "identity-mismatch" : "unknown-identity";
+      log(options, installed ? `runway: installed app is run ${installed.runId} but run ${requestedRunId} is requested; reinstalling` : "runway: installed app has no recorded Runway identity; installing the requested artifact");
+    }
+    if (!resolved) {
+      log(options, `runway: resolving Runway artifact for ${branch} (default ${defaultBranch})`);
+      resolved = resolveArtifactRun(repo, branch, defaultBranch, options.run);
     }
-    log(options, `runway: resolving Runway artifact for ${branch} (default ${defaultBranch})`);
-    const resolved = resolveArtifactRun(repo, branch, defaultBranch, options.run);
     const cacheRoot = options.cacheRoot ?? defaultRunwayCacheRoot();
     const cache = ensureCachedArtifact(repo, resolved.branch, resolved.runId, cacheRoot, options);
     log(options, `runway: installing ${cache.artifact.appPath} on ${sim.name}`);
@@ -111,7 +129,8 @@ async function provisionRunwayMobile(target, options) {
       simulator: sim,
       installed: true,
       skipped: false,
-      baselinePath
+      baselinePath,
+      reason
     };
   } catch (error) {
     return fail(resolvedTarget, platform, "PROVISION_FAILED", errorMessage(error), command, slot);
@@ -465,6 +484,22 @@ function baselineSimulatorCandidates(data, current) {
   }
   return [...new Set(candidates)];
 }
+function readInstalledBaselineArtifact(target, sim, runtimeDir) {
+  let data;
+  try {
+    data = JSON.parse(fs.readFileSync(runwayBaselinePath(target, runtimeDir), "utf8"));
+  } catch {
+    return void 0;
+  }
+  if (data.appInstalled !== true) return void 0;
+  const record = data.artifact;
+  if (!record || typeof record !== "object" || Array.isArray(record)) return void 0;
+  const runId = record.runId;
+  if (typeof runId !== "string" || !runId) return void 0;
+  const recordedSims = baselineSimulatorCandidates(data, {});
+  if (!recordedSims.includes(sim.name) && (!sim.udid || !recordedSims.includes(sim.udid))) return void 0;
+  return { runId, record };
+}
 function appInstalled(device) {
   try {
     execFileSync("xcrun", ["simctl", "get_app_container", device, RUNWAY_IOS_METADATA.bundleId, "app"], { stdio: ["ignore", "ignore", "ignore"] });
@@ -473,7 +508,7 @@ function appInstalled(device) {
     return false;
   }
 }
-function writeRunwayBaseline(target, slot, platform, resolved, artifact, simulator, alreadyInstalled, runtimeDir) {
+function writeRunwayBaseline(target, slot, platform, resolved, artifact, simulator, alreadyInstalled, runtimeDir, preservedArtifact) {
   const file = runwayBaselinePath(target, runtimeDir);
   fs.mkdirSync(path.dirname(file), { recursive: true });
   fs.writeFileSync(file, `${JSON.stringify({
@@ -484,7 +519,7 @@ function writeRunwayBaseline(target, slot, platform, resolved, artifact, simulat
     slotId: slot.slotId ?? null,
     watcherPort: slot.watcherPort ?? null,
     simulator,
-    artifact: resolved && artifact ? { ...resolved, path: artifact.appPath, sizeBytes: artifact.sizeBytes, sha256: artifact.sha256 } : null,
+    artifact: resolved && artifact ? { ...resolved, path: artifact.appPath, sizeBytes: artifact.sizeBytes, sha256: artifact.sha256 } : preservedArtifact ?? null,
     alreadyInstalled,
     recordedAt: (/* @__PURE__ */ new Date()).toISOString()
   }, null, 2)}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.7.2",
+  "version": "0.7.3",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"