@deeeed/metamask-harness 0.7.1 → 0.7.3

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 0.7.3
+
+### Fixed
+- **`provision runway` gates its install-skip on artifact identity.** The baseline now records the installed artifact identity (run id, branch, digest) at install time and a skip preserves it; provisioning skips ONLY when the recorded identity matches the requested (or probe-resolved) run — a different or unknown installed app is reinstalled from the cache instead of being silently kept. Previously any installed MetaMask.app suppressed the install, so a stale binary could be served against a newer JS bundle.
+- **Provision decisions are machine-readable**: the --json envelope carries `reason` (`identity-match` | `identity-mismatch` | `unknown-identity` | `fresh-install` | `forced`) and a skip envelope includes the matched artifact identity.
+
+## 0.7.2
+
+### Added
+- **`recipe-quality build`** — the single worker surface for producing `recipe-quality.json`: fronts @farmslot/agent-runtime's canonical builder (no reimplementation), validates against @farmslot/protocol `RecipeQualityArtifact` before writing (invalid input writes nothing, exit 5 with a teaching escape naming the invalid field). New production dependency: `@farmslot/agent-runtime`.
+
+### Changed
+- `@farmslot/protocol` dependency raised to `^0.7.3` so one protocol version serves both the harness and the builder.
+- The packed-install contract test now executes `recipe-quality build` from the published layout, guarding the new dependency's packaging path.
+
 ## 0.7.1
 
 ### Added

package/dist/adapters/mobile/provision.js

@@ -71,25 +71,43 @@ async function provisionRunwayMobile(target, options) {
       };
     }
     const sim = ensureSimulator(simulator, runtime, deviceType);
+    let resolved;
+    let reason = options.force ? "forced" : "fresh-install";
     if (!options.force && appInstalled(sim.udid ?? sim.name)) {
-      const baselinePath2 = writeRunwayBaseline(resolvedTarget, slot, platform, void 0, void 0, sim, true, options.runtimeDir);
-      return {
-        schemaVersion: 1,
-        command: "provision",
-        adapter: "mobile",
-        target: resolvedTarget,
-        platform,
-        status: "pass",
-        exitCode: 0,
-        slot,
-        simulator: sim,
-        skipped: true,
-        installed: false,
-        baselinePath: baselinePath2
-      };
+      const installed = readInstalledBaselineArtifact(resolvedTarget, sim, options.runtimeDir);
+      let requestedRunId = options.run;
+      if (installed && !requestedRunId) {
+        log(options, `runway: resolving Runway artifact for ${branch} (default ${defaultBranch})`);
+        resolved = resolveArtifactRun(repo, branch, defaultBranch, void 0);
+        requestedRunId = resolved.runId;
+      }
+      if (installed && installed.runId === requestedRunId) {
+        const baselinePath2 = writeRunwayBaseline(resolvedTarget, slot, platform, void 0, void 0, sim, true, options.runtimeDir, installed.record);
+        return {
+          schemaVersion: 1,
+          command: "provision",
+          adapter: "mobile",
+          target: resolvedTarget,
+          platform,
+          status: "pass",
+          exitCode: 0,
+          slot,
+          // State WHAT matched: the recorded artifact identity the skip trusted.
+          artifact: installed.record,
+          simulator: sim,
+          skipped: true,
+          installed: false,
+          baselinePath: baselinePath2,
+          reason: "identity-match"
+        };
+      }
+      reason = installed ? "identity-mismatch" : "unknown-identity";
+      log(options, installed ? `runway: installed app is run ${installed.runId} but run ${requestedRunId} is requested; reinstalling` : "runway: installed app has no recorded Runway identity; installing the requested artifact");
+    }
+    if (!resolved) {
+      log(options, `runway: resolving Runway artifact for ${branch} (default ${defaultBranch})`);
+      resolved = resolveArtifactRun(repo, branch, defaultBranch, options.run);
     }
-    log(options, `runway: resolving Runway artifact for ${branch} (default ${defaultBranch})`);
-    const resolved = resolveArtifactRun(repo, branch, defaultBranch, options.run);
     const cacheRoot = options.cacheRoot ?? defaultRunwayCacheRoot();
     const cache = ensureCachedArtifact(repo, resolved.branch, resolved.runId, cacheRoot, options);
     log(options, `runway: installing ${cache.artifact.appPath} on ${sim.name}`);
@@ -111,7 +129,8 @@ async function provisionRunwayMobile(target, options) {
       simulator: sim,
       installed: true,
       skipped: false,
-      baselinePath
+      baselinePath,
+      reason
     };
   } catch (error) {
     return fail(resolvedTarget, platform, "PROVISION_FAILED", errorMessage(error), command, slot);
@@ -465,6 +484,22 @@ function baselineSimulatorCandidates(data, current) {
   }
   return [...new Set(candidates)];
 }
+function readInstalledBaselineArtifact(target, sim, runtimeDir) {
+  let data;
+  try {
+    data = JSON.parse(fs.readFileSync(runwayBaselinePath(target, runtimeDir), "utf8"));
+  } catch {
+    return void 0;
+  }
+  if (data.appInstalled !== true) return void 0;
+  const record = data.artifact;
+  if (!record || typeof record !== "object" || Array.isArray(record)) return void 0;
+  const runId = record.runId;
+  if (typeof runId !== "string" || !runId) return void 0;
+  const recordedSims = baselineSimulatorCandidates(data, {});
+  if (!recordedSims.includes(sim.name) && (!sim.udid || !recordedSims.includes(sim.udid))) return void 0;
+  return { runId, record };
+}
 function appInstalled(device) {
   try {
     execFileSync("xcrun", ["simctl", "get_app_container", device, RUNWAY_IOS_METADATA.bundleId, "app"], { stdio: ["ignore", "ignore", "ignore"] });
@@ -473,7 +508,7 @@ function appInstalled(device) {
     return false;
   }
 }
-function writeRunwayBaseline(target, slot, platform, resolved, artifact, simulator, alreadyInstalled, runtimeDir) {
+function writeRunwayBaseline(target, slot, platform, resolved, artifact, simulator, alreadyInstalled, runtimeDir, preservedArtifact) {
   const file = runwayBaselinePath(target, runtimeDir);
   fs.mkdirSync(path.dirname(file), { recursive: true });
   fs.writeFileSync(file, `${JSON.stringify({
@@ -484,7 +519,7 @@ function writeRunwayBaseline(target, slot, platform, resolved, artifact, simulat
     slotId: slot.slotId ?? null,
     watcherPort: slot.watcherPort ?? null,
     simulator,
-    artifact: resolved && artifact ? { ...resolved, path: artifact.appPath, sizeBytes: artifact.sizeBytes, sha256: artifact.sha256 } : null,
+    artifact: resolved && artifact ? { ...resolved, path: artifact.appPath, sizeBytes: artifact.sizeBytes, sha256: artifact.sha256 } : preservedArtifact ?? null,
     alreadyInstalled,
     recordedAt: (/* @__PURE__ */ new Date()).toISOString()
   }, null, 2)}

package/dist/cli-commands.js

@@ -16,6 +16,7 @@ const SPEC = {
     { name: "actions", desc: "List runnable recipe actions", flags: ["--json"] },
     { name: "doctor", desc: "Check harness/orchestration health", flags: ["--json", "--target", "--adapter", "--runtime-dir", "--expect-live", "--cdp-port"] },
     { name: "run", desc: "Execute a proof recipe", args: ["recipe.json"], flags: ["--list"] },
+    { name: "recipe-quality", desc: "Build the recipe-quality artifact from compact JSON", args: ["build"], flags: ["--input", "--output", "--json"] },
     { name: "interactive", aliases: ["menu"], desc: "Interactive command menu" },
     { name: "prepare", desc: "Install harness (+ optional validate)", flags: ["--target", "--runtime-dir", "--json"] },
     { name: "runtime-status", desc: "Structured runtime status JSON", flags: ["--json", "--target", "--cdp-port", "--runtime-dir"] }

package/dist/cli.js

@@ -17,6 +17,7 @@ import { handleLaunch } from "./commands/launch/index.js";
 import { handleLogs } from "./commands/logs.js";
 import { handleDebug } from "./commands/debug.js";
 import { handleFixtures } from "./commands/fixtures.js";
+import { handleRecipeQuality } from "./commands/recipe-quality.js";
 import { parseArgs, targetPath } from "./commands/parse-args.js";
 import { runOneNode } from "./commands/run-engine.js";
 const COMMANDS = {
@@ -121,6 +122,7 @@ async function main(argv) {
   if (command === "logs") return handleLogs(argv.slice(1));
   if (command === "debug") return handleDebug(argv.slice(1));
   if (command === "fixtures") return handleFixtures(argv.slice(1), { runOneNode });
+  if (command === "recipe-quality") return handleRecipeQuality(argv.slice(1));
   const handler = COMMANDS[command];
   if (!handler) throw new Error(`Unknown command: ${command}`);
   return handler(parseArgs(argv.slice(1), command));

package/dist/commands/recipe-quality.js

@@ -0,0 +1,93 @@
+import fs from "node:fs";
+import path from "node:path";
+import {
+  buildRecipeQualityArtifact
+} from "@farmslot/agent-runtime";
+import { EXIT, usageOut } from "./shared.js";
+import { optionFlag, optionString, parseArgs } from "./parse-args.js";
+const BUILD_USAGE = "mm-harness recipe-quality build --input <compact.json> --output <path> [--json]";
+function errorMessage(error) {
+  return error instanceof Error ? error.message : String(error);
+}
+function invalidOut(json, message, source) {
+  const userAction = `fix ${source} (${message}), then re-run: ${BUILD_USAGE}`;
+  if (json) {
+    console.log(
+      JSON.stringify(
+        {
+          schemaVersion: 1,
+          command: "recipe-quality",
+          action: "build",
+          status: "fail",
+          exitCode: EXIT.validation,
+          error: { code: "RECIPE_QUALITY_INVALID", message, userAction }
+        },
+        null,
+        2
+      )
+    );
+  } else {
+    console.error(`\u2717 mm-harness recipe-quality: ${message}
+  Next: ${userAction}`);
+  }
+  return EXIT.validation;
+}
+async function handleRecipeQuality(argv) {
+  const { positional, options } = parseArgs(argv, "recipe-quality");
+  const json = optionFlag(options, "json");
+  const action = positional[0];
+  if (action !== "build") {
+    const message = action ? `unknown action '${action}'` : "missing action";
+    return usageOut(json, "recipe-quality", message, BUILD_USAGE);
+  }
+  return buildArtifact(options, json);
+}
+function buildArtifact(options, json) {
+  const input = optionString(options, "input");
+  const output = optionString(options, "output");
+  if (!input) return usageOut(json, "recipe-quality", "missing --input <compact.json>", BUILD_USAGE);
+  if (!output) return usageOut(json, "recipe-quality", "missing --output <path>", BUILD_USAGE);
+  const inputPath = path.resolve(input);
+  let raw;
+  try {
+    raw = fs.readFileSync(inputPath, "utf8");
+  } catch (error) {
+    return usageOut(
+      json,
+      "recipe-quality",
+      `cannot read --input ${input}: ${errorMessage(error)}`,
+      `write the compact recipe-quality JSON to that path, then: ${BUILD_USAGE}`
+    );
+  }
+  let parsed;
+  try {
+    parsed = JSON.parse(raw);
+  } catch (error) {
+    return invalidOut(json, `--input ${input} is not valid JSON: ${errorMessage(error)}`, `--input ${input}`);
+  }
+  let artifact;
+  try {
+    artifact = buildRecipeQualityArtifact(parsed);
+  } catch (error) {
+    return invalidOut(json, errorMessage(error), `--input ${input}`);
+  }
+  const outputPath = path.resolve(output);
+  fs.mkdirSync(path.dirname(outputPath), { recursive: true });
+  fs.writeFileSync(outputPath, `${JSON.stringify(artifact, null, 2)}
+`);
+  if (json) {
+    console.log(
+      JSON.stringify(
+        { schemaVersion: 1, command: "recipe-quality", action: "build", status: "ok", outputPath: output, artifact },
+        null,
+        2
+      )
+    );
+  } else {
+    console.log(`\u2713 recipe-quality build \u2192 ${output} (verdict: ${artifact.verdict})`);
+  }
+  return EXIT.ok;
+}
+export {
+  handleRecipeQuality
+};

package/dist/mm-harness-cli.js

@@ -139,6 +139,28 @@ Example:
   mm-harness doctor --adapter extension --target /path/to/checkout --cdp-port 6662 --expect-live
   mm-harness doctor --adapter mobile --target /path/to/checkout`
   },
+  {
+    name: "recipe-quality",
+    summary: "Build the recipe-quality artifact from a compact verdict JSON (validates before writing).",
+    example: "mm-harness recipe-quality build --input compact.json --output artifacts/recipe-quality.json",
+    helpText: `mm-harness recipe-quality build [flags]
+
+  Build artifacts/recipe-quality.json from the compact fields a recipe-quality pass
+  produces (verdict + reasons + optional guidance/dimensions/findings/delta/training).
+  The artifact is validated against the RecipeQualityArtifact schema before it is
+  written \u2014 an invalid input never reaches disk.
+
+  --input <compact.json>   Compact verdict JSON: { "verdict": "pass|warn|fail", "reasons": [..],
+                             "betterVersionGuidance"?: [..], "dimensions"?: {..}, "trainingFields"?: {..}, \u2026 }
+  --output <path>          Where to write the built artifact (parent dirs created)
+  --json                   Machine-readable envelope { status, outputPath, artifact }
+
+  Exit: 0 built \xB7 2 missing/unreadable args \xB7 5 invalid input (teaching escape names the invalid field).
+
+Example:
+  mm-harness recipe-quality build --input compact.json --output artifacts/recipe-quality.json
+  mm-harness recipe-quality build --input compact.json --output artifacts/recipe-quality.json --json`
+  },
   {
     name: "provision",
     summary: "Install the cached Runway iOS dev client on a prepared mobile slot (no deps, no Metro).",
@@ -393,7 +415,7 @@ const HELP_GROUPS = [
   {
     title: "PROVE",
     blurb: "run recipes and inspect readiness",
-    commands: ["run", "doctor"]
+    commands: ["run", "doctor", "recipe-quality"]
   },
   {
     title: "RUNTIME OVERLAY",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.7.1",
+  "version": "0.7.3",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"
@@ -16,7 +16,8 @@
     "check:syntax": "find . -name '*.mjs' -print0 | xargs -0 -n1 node --check"
   },
   "dependencies": {
-    "@farmslot/protocol": "^0.7.2",
+    "@farmslot/agent-runtime": "^0.1.0",
+    "@farmslot/protocol": "^0.7.3",
     "@farmslot/recipe-harness": "^0.3.3",
     "commander": "^12.0.0",
     "viem": "^2.54.3"