@deeeed/metamask-harness 0.68.0 → 0.70.0

package/docs/RECIPES.md

@@ -542,12 +542,19 @@ selected deterministically from `recipes/<adapter>/<domain>/`. Identical
 cross-adapter graphs live once in `recipes/shared/<domain>/`; an adapter-specific
 variant takes precedence. Both resolve as `<domain>.<recipe>`, without a platform
 or `shared` prefix. Keep domains below `core`, `extension`, `mobile`, or `shared`.
-Legacy
-`*.<adapter>.recipe.json` paths remain readable during migration, but new and
-migrated libraries use the adapter-first layout. A file cannot declare its
+
+Legacy `*.<adapter>.recipe.json` paths remain readable during migration, but new
+and migrated libraries use the adapter-first layout. A file cannot declare its
 adapter through both forms. Every run records the root recipe, exact resolved
 dependency documents, their digests, call edges, selected sources, and shadows.
 
+`mm-harness run --list` and `mm-harness call --list` group recipes/actions by domain
+and show their library origins separately.
+Use `--domain swap-bridge` or `--source perps` to filter, and `--sort name|domain|library`
+to change the order. These options also apply to `--json` output, which keeps name
+ordering unless `--sort` is supplied. Domain filters accept hyphens or underscores,
+so `--domain swap-bridge` includes `metamask.swap_bridge.*` actions.
+
 ## Direct product access
 
 The bundled library is intentionally small. A task may use a verified controller

package/library/actions/extension/platform/cdp.mjs

@@ -19,6 +19,7 @@ import { closeSync, openSync } from 'node:fs';
 import { spawn } from 'node:child_process';
 import { createRequire } from 'node:module';
 import path from 'node:path';
+import { fileURLToPath } from 'node:url';
 
 import {
   importRecipeHarnessRuntimeBrowserExtension,
@@ -368,24 +369,26 @@ function autolaunchEnabled(input) {
     process.env.METAMASK_RECIPE_EXTENSION_LAUNCH_EXISTING_DIST === '1';
 }
 
-function projectRequire(projectRoot) {
-  return createRequire(path.join(projectRoot, 'package.json'));
-}
+const runnerRequire = createRequire(import.meta.url);
+const runnerRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '../../../..');
+const browserResolver = runnerRequire(path.join(runnerRoot, 'adapters/shared/browser-resolver.cjs'));
+const { stopProfileProcessesSync } = runnerRequire(path.join(runnerRoot, 'adapters/extension/lib/validation-process-ownership.cjs'));
 
-function resolveChromeBinary(projectRoot) {
-  if (process.env.RECIPE_HARNESS_CHROME_BIN) return process.env.RECIPE_HARNESS_CHROME_BIN;
-  const requireFromProject = projectRequire(projectRoot);
-  for (const packageName of ['@playwright/test', 'playwright']) {
-    try {
-      const { chromium } = requireFromProject(packageName);
-      const executable = chromium.executablePath();
-      if (executable) return executable;
-    } catch (error) {
-      if (error?.code === 'MODULE_NOT_FOUND') continue;
-      throw error;
-    }
+// Same browser choice as the live launcher (RECIPE_HARNESS_BROWSER /
+// RECIPE_HARNESS_CHROME_BIN); branded Chrome loads the dist over CDP. This
+// launcher spawns a headful browser directly, so the probe does too, and a
+// reused profile keeps its recorded browser.
+async function resolveChromeBinary(projectRoot, recorded) {
+  try {
+    return await browserResolver.resolveBrowser({
+      cft: () => browserResolver.playwrightChromiumExecutable(projectRoot),
+      launchMethod: browserResolver.SPAWN,
+      display: browserResolver.HEADFUL,
+      recorded,
+    });
+  } catch (error) {
+    throw new Error(`Extension autolaunch could not select a browser: ${error.message}`);
   }
-  throw new Error('Extension autolaunch requires RECIPE_HARNESS_CHROME_BIN or Playwright installed in the target checkout.');
 }
 
 async function execNodeScript(script, args, options) {
@@ -446,7 +449,7 @@ async function findWalletFixture(projectRoot) {
   return null;
 }
 
-async function launchExistingDistRuntime(input, port) {
+export async function launchExistingDistRuntime(input, port) {
   const projectRoot = input.context.projectRoot;
   const artifactsDir = input.context.artifactsDir;
   const distDir = path.resolve(projectRoot, input.node?.dist_dir || process.env.METAMASK_RECIPE_EXTENSION_DIST_DIR || 'dist/chrome');
@@ -476,12 +479,23 @@ async function launchExistingDistRuntime(input, port) {
     fixtureSeeded = true;
   }
 
-  const chrome = resolveChromeBinary(projectRoot);
+  // Never start a second browser on a port something else holds: whatever
+  // answers there afterwards would not be ours to load or seed.
+  const holders = browserResolver.cdpListenerPids(port);
+  if (holders.length > 0) {
+    throw new Error(`Extension autolaunch refused: CDP port ${port} is already held by pid ${holders.join(', ')}. Next: stop that browser or choose a free --cdp-port.`);
+  }
+  // Next to the profile, so a reused profile (METAMASK_RECIPE_EXTENSION_PROFILE_DIR)
+  // finds the browser it was created with.
+  const browserRecord = `${profileDir}.browser.json`;
+  const profileExisted = await canAccess(path.join(profileDir, 'Local State'));
+  const browser = await resolveChromeBinary(projectRoot, profileExisted ? browserRecord : null);
+  const loadsOverCdp = browser.extensionLoading === browserResolver.CDP_LOAD_UNPACKED;
   const stdoutFd = openSync(path.join(logsDir, 'chrome.log'), 'a');
   const stderrFd = openSync(path.join(logsDir, 'chrome.log'), 'a');
   let child;
   try {
-    child = spawn(chrome, [
+    child = spawn(browser.bin, [
       `--user-data-dir=${profileDir}`,
       ...(process.platform === 'darwin' ? ['--use-mock-keychain'] : []),
       '--remote-debugging-address=127.0.0.1',
@@ -493,8 +507,7 @@ async function launchExistingDistRuntime(input, port) {
       '--disable-extensions-file-access-check',
       '--disable-extensions-content-verification',
       '--disable-features=ExtensionContentVerification,DisableLoadExtensionCommandLineSwitch',
-      `--disable-extensions-except=${runtimeDist}`,
-      `--load-extension=${runtimeDist}`,
+      ...browserResolver.extensionLaunchArgs(runtimeDist, browser.extensionLoading),
       'chrome://extensions/',
     ], {
       cwd: projectRoot,
@@ -516,32 +529,58 @@ async function launchExistingDistRuntime(input, port) {
   }
   child.unref();
   await writeFile(path.join(logsDir, 'chrome.pid'), `${child.pid}\n`);
-  await retryJsonGet(`http://127.0.0.1:${port}/json/version`, 45000);
-
   let fixtureValidation = null;
-  if (fixtureSeeded) {
-    fixtureValidation = path.join(logsDir, 'fixture-account-parity.json');
-    await execNodeScript(
-      fixtureScript,
-      [
-        'seed-cdp',
-        '--target',
-        projectRoot,
-        '--fixture',
-        fixture,
-        '--state',
-        fixtureState,
-        '--cdp-port',
-        String(port),
-        '--extension-dir',
-        runtimeDist,
-        '--extension-id-file',
-        extensionIdFile,
-        '--out',
-        fixtureValidation,
-      ],
-      { cwd: projectRoot },
-    );
+  let launchedBrowser = null;
+  try {
+    await retryJsonGet(`http://127.0.0.1:${port}/json/version`, 45000);
+    const owner = browserResolver.waitForCdpOwner(port, profileDir);
+    const cdpLoad = loadsOverCdp ? await browserResolver.loadUnpackedOverPort(port, runtimeDist, { profile: profileDir }) : null;
+    launchedBrowser = {
+      ...browser,
+      launch: {
+        pid: owner.pid,
+        cdpPort: port,
+        startedAt: new Date().toISOString(),
+        profile: owner.profile,
+        processStartedAt: owner.startedAt,
+        ...(cdpLoad ? { extensionId: cdpLoad.id, otherExtensions: cdpLoad.otherExtensions } : {}),
+      },
+    };
+    await writeFile(browserRecord, `${JSON.stringify(launchedBrowser, null, 2)}\n`);
+    if (fixtureSeeded) {
+      fixtureValidation = path.join(logsDir, 'fixture-account-parity.json');
+      await execNodeScript(
+        fixtureScript,
+        [
+          'seed-cdp',
+          '--target',
+          projectRoot,
+          '--fixture',
+          fixture,
+          '--state',
+          fixtureState,
+          '--cdp-port',
+          String(port),
+          '--extension-dir',
+          runtimeDist,
+          '--extension-id-file',
+          extensionIdFile,
+          '--out',
+          fixtureValidation,
+        ],
+        { cwd: projectRoot },
+      );
+    }
+  } catch (error) {
+    // The launch failed after the browser started: stop it before reporting,
+    // so no detached browser outlives this action. A failed stop is reported
+    // with the original failure, never swallowed.
+    try {
+      stopProfileProcessesSync(profileDir, { extraPids: [child.pid] });
+    } catch (stopError) {
+      throw new Error(`${error.message}\nStopping the autolaunched browser (pid ${child.pid}, profile ${profileDir}) also failed: ${stopError.message}`, { cause: error });
+    }
+    throw error;
   }
 
   await writeFile(path.join(runtimeRoot, 'runtime.json'), `${JSON.stringify({
@@ -553,6 +592,8 @@ async function launchExistingDistRuntime(input, port) {
     profileDir,
     fixtureSeeded,
     fixtureValidation,
+    browser: launchedBrowser,
+    browserRecord,
     launchedAt: new Date().toISOString(),
   }, null, 2)}\n`);
   return { launched: true, pid: child.pid, runtimeRoot, fixtureSeeded };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.68.0",
+  "version": "0.70.0",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"

package/scripts/completions.sh

@@ -44,8 +44,8 @@ _mmh_flags_for() {
     execution-template) printf '%s' "--dir --domain-dir --project-worker --project-name --package-templates --package-id --flow --run-mode --platform --domain --id --provenance --include-shadowed --no-include-shadowed --title --force --json" ;;
     recipe-quality) printf '%s' "--input --output --recipe --task --evidence --params --adapter --library --advisor --advisor-model --advisor-stages --json" ;;
     actions)  printf '%s' "--adapter --action --kind --raw --action-manifest --target --json" ;;
-    call)     printf '%s' "--list --arg --adapter --target --artifacts-dir --action-manifest --heal --json" ;;
-    run)      printf '%s' "--list --describe --plan --adapter --artifacts-dir --target --library --cdp-port --heal --record-video --json" ;;
+    call)     printf '%s' "--list --domain --source --sort --arg --adapter --target --artifacts-dir --action-manifest --heal --json" ;;
+    run)      printf '%s' "--list --domain --source --sort --describe --plan --adapter --artifacts-dir --target --library --cdp-port --heal --record-video --json" ;;
     doctor)   printf '%s' "--adapter --target --fix --json" ;;
     install|verify|cleanup) printf '%s' "--adapter --target --json" ;;
     *)        printf '%s' "" ;;

package/scripts/site-contrast.mjs

@@ -449,8 +449,12 @@ async function checkBehavior(browserEndpoint, port, pages) {
         return checked;
       })()
     `);
-    if (!previews.includes('review-pr/static-perps.mobile') || !previews.includes('qa/default')) {
-      throw new Error('Static review and QA previews must both be available');
+    if (!['fix-bug/extension', 'fix-bug/mobile', 'qa/default'].every(id => previews.includes(id))) {
+      throw new Error('Runtime workflow previews must be available');
+    }
+    const reviewSource = await page.evaluate("document.querySelector('[data-static-review-source]')?.href");
+    if (!reviewSource?.endsWith('/domains/perps/skills/perps-review-pr/skill.md')) {
+      throw new Error('Static review must link to its owning skill');
     }
     const progress = await page.evaluate(String.raw`
       (() => {
@@ -514,7 +518,16 @@ async function checkBehavior(browserEndpoint, port, pages) {
                 await new Promise((resolve) => setTimeout(resolve, 100));
               }
             }
-            if (!response?.ok) failures.push(url.pathname + ' (' + (response?.status ?? 'network') + ')');
+            if (!response?.ok) {
+              failures.push(url.pathname + ' (' + (response?.status ?? 'network') + ')');
+            } else if (url.hash) {
+              const target = url.pathname === location.pathname
+                ? document
+                : new DOMParser().parseFromString(await response.text(), 'text/html');
+              if (!target.getElementById(decodeURIComponent(url.hash.slice(1)))) {
+                failures.push(url.pathname + url.hash + ' (missing anchor)');
+              }
+            }
           }
           return failures;
         })()