@deeeed/metamask-harness 0.57.0 → 0.59.0

package/CHANGELOG.md

@@ -2,6 +2,25 @@
 
 ## Unreleased
 
+## 0.59.0 - 2026-09-18
+
+### Changed
+
+- Extension `verify` is runner-owned TypeScript: `adapters/extension/verify.sh` (572 lines, with node heredocs assembling `summary.json`, the fixture status and the CDP holder probe) is now `src/adapters/extension/verify.ts`, run in-process by `mm-harness verify --adapter extension`. Same flags, env, exit codes, check names and artifacts (`summary.json`, `artifact-manifest.json`, `logs/`, `runner-smoke/`); a live run against the same checkout produced a byte-identical normalised summary. Deliberate differences: `install` no longer copies a `scripts/verify.sh` into the checkout and dispatch no longer prefers one, so an older overlay cannot shadow the current runner's verify; the two shell-lib preflights (`harness-path.sh`, `json-field.sh`) are gone because the typed helpers cannot be missing; usage now names `mm-harness verify --adapter extension`; a `--target` that does not exist is a named exit-1 refusal instead of a bare `cd` failure; and `live.sh` reaches verify through the checkout's runner delegate, refusing early when that delegate is absent. Three more deliberate differences: `--artifacts-dir` is resolved to an absolute path once (the shell resolved a relative value against the cwd for its own files and against the target for the smoke run); `readiness.mjs` runs under the harness's own node instead of `PATH` `node`; and `live.sh`, having just installed the overlay, tells verify to skip the overlay re-ensure (`MM_HARNESS_SKIP_OVERLAY_ENSURE=1`) instead of reinstalling it between launch and the live probe.
+
+### Fixed
+
+- Slot identity resolves against this machine's pool first. Every farm node keeps the same checkout paths, so a repo path matched a slot in every `pool/*.json` and the alphabetically first pool won: `doctor --fix` on macwork stamped `metamask-extension-2` as `macpro-mme-2` on CDP 7662 instead of `macwork-mmedev-2` on 6662. Pools whose `machine` or `host` is this host are consulted first; other machines' pools only when none of ours names the repo. A malformed pool file is skipped like the port resolver already did, and `*.bak` files never count.
+- An invalid `RECIPE_RUNTIME_DIR` no longer crashes every command at startup with a stack trace. The extension runtime decision read it while loading; it reads it when a build-log check needs it, so `--help` still works and the command that needs the value reports it.
+
+## 0.58.0 - 2026-09-18
+
+### Changed
+
+- Pins `@farmslot/agent-runtime` 0.12.0, whose `mark` records step names through the protocol's `checklistStepName`, so SIGNAL.json events and `status --watch` name a step identically.
+- Mobile `verify` is runner-owned TypeScript: `adapters/mobile/verify.sh` (557 lines, with node heredocs assembling `summary.json`) is now `src/adapters/mobile/verify.ts`, run in-process by `mm-harness verify --adapter mobile`. Same flags, env, exit codes, check names and artifacts (`summary.json`, `artifact-manifest.json`, `logs/`, smoke recipes, `runner-live-smoke/`); a live run against the same checkout produced a byte-identical normalised summary. `install` no longer copies a `scripts/verify.sh` into the checkout and dispatch no longer prefers one, so an older overlay cannot shadow the current runner's verify; the mobile overlay's `scripts/` tree is gone and its manifest advertises `runtimeHelpers: {}`, like Core. Extension verify is unchanged.
+- The execution-provenance record is indexed into `artifact-manifest.json` through the same hardened manifest writer every other artifact uses (`indexArtifactManifest`), instead of a private copy that skipped a missing or unreadable manifest without a word. A manifest the run said it wrote but cannot be read is now the error it is.
+
 ## 0.57.0 - 2026-09-18
 
 ### Changed

package/adapters/extension/inject.mjs

@@ -114,7 +114,6 @@ copyFile(path.join(runnerDir, 'adapters/extension/sidepanel-toggle.sh'), path.jo
 copyFile(path.join(runnerDir, 'adapters/extension/reattach.sh'), path.join(harnessDir, 'scripts/reattach.sh'));
 copyFile(path.join(runnerDir, 'adapters/extension/readiness.mjs'), path.join(harnessDir, 'scripts/readiness.mjs'));
 copyFile(path.join(runnerDir, 'adapters/extension/wallet-fixture-state.cjs'), path.join(harnessDir, 'scripts/wallet-fixture-state.cjs'));
-copyFile(path.join(runnerDir, 'adapters/extension/verify.sh'), path.join(harnessDir, 'scripts/verify.sh'));
 copyFile(path.join(runnerDir, 'adapters/extension/refresh-build.sh'), path.join(harnessDir, 'scripts/refresh-build.sh'));
 copyFile(path.join(runnerDir, 'adapters/extension/ensure-browser.sh'), path.join(harnessDir, 'scripts/reopen-browser.sh'));
 copyFile(path.join(runnerDir, 'adapters/shared/harness-path.sh'), path.join(harnessDir, 'scripts/lib/harness-path.sh'));

package/adapters/extension/live.sh

@@ -6,8 +6,8 @@
 # Purpose:
 #   Builds the per-run prepare command from the named feature scripts
 #   (watch, dist snapshot, fixture seed, detached chrome, CDP poll), then
-#   runs launch.sh and, unless --launch-only is set, verify.sh under a
-#   timestamped artifact dir.
+#   runs launch.sh and, unless --launch-only is set, `mm-harness verify` under
+#   a timestamped artifact dir.
 #
 # Inputs (flags / env):
 #   --target <metamask-extension> (default $PWD)
@@ -128,17 +128,6 @@ case "$CDP_PORT" in
   *[!0-9]*) echo "Invalid --cdp-port (must be numeric): $CDP_PORT" >&2; exit 2 ;;
 esac
 
-# verify.sh is a recipe-tree feature: co-located in installed copies, under
-# adapters/extension in a repo checkout.
-VERIFY_SH=""
-for _v in "$SCRIPT_DIR/verify.sh" "$SCRIPT_DIR/../../adapters/extension/verify.sh"; do
-  [ -f "$_v" ] && { VERIFY_SH="$_v"; break; }
-done
-unset _v
-if [ -z "$VERIFY_SH" ]; then
-  echo "mm-harness: extension verify.sh not found next to $SCRIPT_DIR; reinstall the runner." >&2
-  exit 1
-fi
 RUNTIME_DIR="$(recipe_runtime_dir)"
 RUNTIME_DIST_DIR="${RECIPE_RUNTIME_DIST_DIR:-runtime-dist}"
 case "$RUNTIME_DIST_DIR" in
@@ -152,6 +141,12 @@ CHROME_PROFILE_NAME="${RECIPE_CHROME_PROFILE_NAME:-chrome-profile}"
 # to defer the cache-clear DECISION to `runtime-decision` (single source) and to
 # record the deps/cache baseline after a confirmed-good build.
 RUNNER_BIN="$(harness_dir "$TARGET" extension)/runner/bin/mm-harness"
+# Verify is runner-owned typed code reached through the runner delegate, not a
+# shipped leaf this sequencer could resolve next to itself.
+if $RUN_VERIFY && [ ! -x "$RUNNER_BIN" ]; then
+  echo "mm-harness: runner delegate missing at $RUNNER_BIN; run mm-harness install --adapter extension --target $TARGET." >&2
+  exit 1
+fi
 OUT="${OUT:-$(harness_root)/extension/runner/recipes}"
 ARTIFACTS="${ARTIFACTS:-$(harness_dir "$TARGET" extension)/live/$(date -u +%Y%m%dT%H%M%SZ)}"
 mkdir -p "$ARTIFACTS/logs"
@@ -390,7 +385,9 @@ verify_status=0
 if [ "$launch_status" -eq 0 ] && $RUN_VERIFY; then
   echo "[recipe-harness] phase 2/2: live verify (readiness + smoke recipe)" >&2
   set +e
-  "$VERIFY_SH" --target "$TARGET" --out "$OUT" --cdp-port "$CDP_PORT" --artifacts-dir "$ARTIFACTS/verify"
+  # The overlay was installed by this sequencer moments ago; verify must not
+  # reinstall it between launch and the live probe.
+  MM_HARNESS_SKIP_OVERLAY_ENSURE=1 "$RUNNER_BIN" verify --adapter extension --target "$TARGET" -- --out "$OUT" --cdp-port "$CDP_PORT" --artifacts-dir "$ARTIFACTS/verify"
   verify_status=$?
   set -e
 elif [ "$launch_status" -ne 0 ]; then

package/adapters/manifest.json

@@ -140,9 +140,9 @@
     },
     {
       "id": "mobile/verify",
-      "entry": "adapters/mobile/verify.sh",
-      "kind": "bash",
-      "purpose": "Verify the mobile harness/runtime is present and healthy (no app launch).",
+      "entry": "src/adapters/mobile/verify.ts",
+      "kind": "module",
+      "purpose": "Verify the mobile harness/runtime is present and healthy (no app launch). Runner-owned: mm-harness verify runs it in-process.",
       "inputs": "--target --artifacts-dir --static-only --platform ios|android --preflight-mode --no-auto-start",
       "outputs": "verify report + evidence; exit 0/1/2"
     },
@@ -164,10 +164,10 @@
     },
     {
       "id": "extension/verify",
-      "entry": "adapters/extension/verify.sh",
-      "kind": "bash",
-      "purpose": "Verify the extension harness/runtime is present and healthy (no app launch).",
-      "inputs": "--target --out --cdp-port --static-only",
+      "entry": "src/adapters/extension/verify.ts",
+      "kind": "module",
+      "purpose": "Verify the extension harness/runtime is present and healthy (no app launch). Runner-owned: mm-harness verify runs it in-process.",
+      "inputs": "--target --out --cdp-port --static-only --artifacts-dir",
       "outputs": "verify report + evidence; exit 0/1/2"
     },
     {

package/adapters/mobile/inject.sh

@@ -34,7 +34,7 @@ fi
 HARNESS_ROOT="$(harness_root)"
 HARNESS_REL="$HARNESS_ROOT/mobile"
 HARNESS_DIR="$(harness_dir "$TARGET" mobile)"
-for rel in "$HARNESS_REL" "$HARNESS_REL/runner" "$HARNESS_REL/scripts"; do
+for rel in "$HARNESS_REL" "$HARNESS_REL/runner"; do
   current="$TARGET"
   IFS='/' read -r -a parts <<< "$rel"
   for part in "${parts[@]}"; do
@@ -45,7 +45,7 @@ for rel in "$HARNESS_REL" "$HARNESS_REL/runner" "$HARNESS_REL/scripts"; do
 done
 
 rm -rf "$HARNESS_DIR/runner" "$HARNESS_DIR/scripts" "$HARNESS_DIR/bridge-runtime"
-mkdir -p "$HARNESS_DIR/runner/bin" "$HARNESS_DIR/runner/manifests" "$HARNESS_DIR/runner/recipes" "$HARNESS_DIR/scripts/lib"
+mkdir -p "$HARNESS_DIR/runner/bin" "$HARNESS_DIR/runner/manifests" "$HARNESS_DIR/runner/recipes"
 
 RUNNER_EXEC_Q="$(printf '%q' "$RUNNER_DIR/bin/mm-harness")"
 TARGET_Q="$(printf '%q' "$TARGET")"
@@ -76,10 +76,7 @@ cp "$RUNNER_DIR/library/manifests/extension.action-manifest.json" "$HARNESS_DIR/
 rsync -a --delete "$RUNNER_DIR/library/recipes/" "$HARNESS_DIR/runner/recipes/"
 rm -rf "$HARNESS_DIR/runner/flows"
 rm -f "$HARNESS_DIR/runner/library.json"
-cp "$RUNNER_DIR/adapters/mobile/verify.sh" "$HARNESS_DIR/scripts/verify.sh"
 cp -R "$RUNNER_DIR/adapters/mobile/bridge-runtime" "$HARNESS_DIR/bridge-runtime"
-cp "$RUNNER_DIR/adapters/shared/harness-path.sh" "$HARNESS_DIR/scripts/lib/harness-path.sh"
-cp "$RUNNER_DIR/adapters/shared/path-defaults.json" "$HARNESS_DIR/scripts/lib/path-defaults.json"
 chmod -R u+rwX,go+rX "$HARNESS_DIR"
 
 add_git_exclude() {
@@ -114,8 +111,8 @@ fs.writeFileSync(manifestPath, JSON.stringify({
   protocolVersion: 'v1',
   actionManifestPath: `${harnessRel}/action-manifest.json`,
   runnerEntrypoint: `${harnessRel}/runner/bin/mm-harness`,
-  runtimeHelpers: { verify: `${harnessRel}/scripts/verify.sh` },
-  harnessInstalledPaths: [`${harnessRel}/runner`, `${harnessRel}/scripts`, `${harnessRel}/bridge-runtime`, `${harnessRel}/action-manifest.json`],
+  runtimeHelpers: {},
+  harnessInstalledPaths: [`${harnessRel}/runner`, `${harnessRel}/bridge-runtime`, `${harnessRel}/action-manifest.json`],
   productOwnedPaths: ['app/dev-tools/AgenticService', 'app/core/NavigationService/NavigationService.ts'],
   cleanupCommand,
   productDiffExcludes: [`:(exclude)${harnessRoot}`],

package/adapters/shared/resolve-slot-ports-core.mjs

@@ -73,6 +73,35 @@ function scoreSlot(slot, slotSuffix) {
   return [score, cdp, port, slotId, simulator, adbSerial, androidDevice];
 }
 
+// Pool files that describe this machine, then the rest. Every farm node keeps
+// the same checkout paths, so a repo path alone matches a slot in every pool;
+// the pool whose `machine`/`host` is this host is the one that owns the slot.
+export function poolFilesForHost(poolDir, hostname = os.hostname()) {
+  // macOS may report a capitalised or FQDN hostname; pools carry lowercase names.
+  const canonical = (value) => String(value ?? '').toLowerCase().replace(/\.$/u, '');
+  const full = canonical(hostname);
+  const short = full.split('.')[0];
+  const names = (value) => {
+    const name = canonical(value);
+    return name ? [name, name.split('.')[0]] : [];
+  };
+  const local = [];
+  const other = [];
+  for (const name of fs.readdirSync(poolDir).sort()) {
+    // Backups (`*.json.bak.<ts>`, `*.bak`) never define a live slot.
+    if (!name.endsWith('.json') || name.includes('.bak')) continue;
+    let data;
+    try {
+      data = JSON.parse(fs.readFileSync(path.join(poolDir, name), 'utf8'));
+    } catch {
+      continue;
+    }
+    const isLocal = [...names(data.machine), ...names(data.host)].some((name) => name === full || name === short);
+    (isLocal ? local : other).push({ name, data });
+  }
+  return { local, other };
+}
+
 export function resolveSlotPortsByRepo(repo) {
   const realRepo = realRepoPath(repo);
   if (!realRepo) return null;
@@ -91,29 +120,28 @@ export function resolveSlotPortsByRepo(repo) {
   for (const root of roots) {
     if (!root || !fs.existsSync(path.join(root, 'pool'))) continue;
     const poolDir = path.join(root, 'pool');
+    const pools = poolFilesForHost(poolDir);
     let best = null;
 
-    for (const name of fs.readdirSync(poolDir).sort()) {
-      if (!name.endsWith('.json') || name.includes('.bak.')) continue;
-      let data;
-      try {
-        data = JSON.parse(fs.readFileSync(path.join(poolDir, name), 'utf8'));
-      } catch {
-        continue;
-      }
-      for (const slot of data.slots ?? []) {
-        const slotRepo = slot.repo ?? '';
-        if (!slotRepo) continue;
-        let slotReal;
-        try {
-          slotReal = fs.realpathSync(slotRepo);
-        } catch {
-          continue;
+    // This host's pools decide first; other machines' pools only when none of
+    // ours names the repo (single-node and demo setups).
+    for (const group of [pools.local, pools.other]) {
+      for (const { data } of group) {
+        for (const slot of data.slots ?? []) {
+          const slotRepo = slot.repo ?? '';
+          if (!slotRepo) continue;
+          let slotReal;
+          try {
+            slotReal = fs.realpathSync(slotRepo);
+          } catch {
+            continue;
+          }
+          if (slotReal !== realRepo) continue;
+          const scored = scoreSlot(slot, slotSuffix);
+          if (!best || scored[0] > best[0]) best = scored;
         }
-        if (slotReal !== realRepo) continue;
-        const scored = scoreSlot(slot, slotSuffix);
-        if (!best || scored[0] > best[0]) best = scored;
       }
+      if (best) break;
     }
 
     if (best) {

package/dist/adapters/extension/runtime-decision.js

@@ -11,7 +11,6 @@ import { recipeHarnessPath, recipeRuntimeDir, recipeWatchLogCandidates } from ".
 const WEBPACK_DIRECT_INPUTS = ["package.json", "yarn.lock", ".yarnrc.yml", ".tool-versions"];
 const WEBPACK_RECURSIVE_INPUTS = ["development/webpack"];
 const WEBPACK_CACHE_DIR = "node_modules/.cache/webpack";
-const WATCH_LOG_CANDIDATES = recipeWatchLogCandidates();
 function git(target, args) {
   try {
     return execFileSync("git", ["-C", target, ...args], {
@@ -95,7 +94,7 @@ function webpackCacheCheck(target) {
   return { cachePresent: true, status, hasBaseline: true };
 }
 function buildLogCheck(target, watchLog) {
-  const candidates = (watchLog ? [path.isAbsolute(watchLog) ? watchLog : path.join(target, watchLog)] : WATCH_LOG_CANDIDATES.map((rel) => path.join(target, rel))).filter((file) => fs.existsSync(file));
+  const candidates = (watchLog ? [path.isAbsolute(watchLog) ? watchLog : path.join(target, watchLog)] : recipeWatchLogCandidates().map((rel) => path.join(target, rel))).filter((file) => fs.existsSync(file));
   if (!candidates.length) return { status: "no-watch" };
   const newestFirst = [...candidates].sort((a, b) => fs.statSync(b).mtimeMs - fs.statSync(a).mtimeMs);
   const lines = fs.readFileSync(newestFirst[0], "utf8").split("\n");

package/dist/adapters/extension/runtime.js

@@ -3,6 +3,7 @@ import fs from "node:fs";
 import { createRequire } from "node:module";
 import path from "node:path";
 import { importRecipeHarnessRuntimeBrowserExtension, importRecipeHarnessRuntimeCdp, recipeHarnessPath, recipeRuntimeDir, resolveLocalProtocolRoot, runnerDir } from "../../paths.js";
+import { poolFilesForHost } from "../resolve-slot-ports.js";
 import { profileProcessPids } from "./validation-process-ownership.js";
 const require2 = createRequire(import.meta.url);
 const { detachedLaunchUnprovenPath, hasDetachedLaunchUnproven, shellQuote } = require2(
@@ -543,9 +544,9 @@ function resolveExtensionSlot(projectRoot, requestedSlot) {
   }
   const poolsDir = path.join(protocolRoot, "pool");
   if (!fs.existsSync(poolsDir)) return null;
-  for (const file of fs.readdirSync(poolsDir)) {
-    if (!file.endsWith(".json") || file.includes(".bak")) continue;
-    const pool = JSON.parse(fs.readFileSync(path.join(poolsDir, file), "utf8"));
+  const pools = poolFilesForHost(poolsDir);
+  for (const { data } of [...pools.local, ...pools.other]) {
+    const pool = data;
     for (const rawSlot of pool.slots ?? []) {
       if (!rawSlot || typeof rawSlot !== "object") continue;
       const slot = rawSlot;