@deeeed/metamask-harness 0.51.7 → 0.51.8

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## Unreleased
+
+## 0.51.8 - 2026-09-15
+
+### Fixed
+
+- Mobile launch replaces a Metro process that Metro itself reported unusable (delta-graph corruption after a commit failed mid-way, or its "Detected a change in babel.config.js. Restart the server" advisory) by stopping it before `start-metro`, keeping the transform cache. Previously every "restart Metro" verdict and the `metro.restarted` recovery reused the live listener, so a Metro that outlived a bundler-config change failed every bundle until someone killed it by hand. Plain bundle errors still never restart Metro, and `--clear` stays explicit. `start-metro` now records the content hashes of the bundler config files so an advisory raised by an mtime-only touch is ignored; a Metro started before this release has no record, so its first advisory restarts it once.
+
 ## 0.51.7 - 2026-09-14
 
 ### Added

package/adapters/mobile/start-metro.sh

@@ -257,6 +257,27 @@ printf '(Full log: %s — mm-harness logs | mm-harness logs --full)\n' "$LOG_FIL
 ROTATION_REASON="metro-start"
 [ "$CLEAR" = true ] && ROTATION_REASON="clear-cache-restart"
 node "$METRO_LOG_GENERATION" "$LOG_DIR" "$PORT" "$ROTATION_REASON" >/dev/null || exit 1
+# Record what this process loads from the files Expo's FileNotifier watches, so
+# the readiness decision can tell a real config change from an mtime-only touch
+# when Metro later prints its "Detected a change in <file>" advisory.
+record_metro_config_hashes() {
+  local file hash hashes=""
+  for file in babel.config.js metro.config.js metro.transform.js app.json app.config.js; do
+    [ -f "$TARGET/$file" ] || continue
+    if command -v shasum >/dev/null 2>&1; then
+      hash="$(shasum -a 256 "$TARGET/$file" | cut -d' ' -f1)"
+    else
+      hash="$(sha256sum "$TARGET/$file" | cut -d' ' -f1)"
+    fi
+    # An entry without a hash could never match and would force a restart on
+    # every advisory; leave the file out so the decision fails closed to
+    # "changed" for that file only, visibly.
+    [ -n "$hash" ] || continue
+    hashes+="$hash  $file"$'\n'
+  done
+  printf '%s' "$hashes" > "$LOG_DIR/metro-config.sha256"
+}
+record_metro_config_hashes
 
 write_metro_build_env || {
   printf 'start-metro: could not stage the scoped Metro environment\n' >&2

package/adapters/mobile/stop-metro.sh

@@ -6,7 +6,8 @@
 set -euo pipefail
 
 TARGET="."
-PORT="${WATCHER_PORT:-}"
+# Same fallback order as start-metro so stop and start always agree on the port.
+PORT="${WATCHER_PORT:-${METRO_PORT:-}}"
 while [ $# -gt 0 ]; do
   case "$1" in
     --target) TARGET="$2"; shift 2 ;;
@@ -14,7 +15,7 @@ while [ $# -gt 0 ]; do
     -h|--help)
       printf 'Usage: stop-metro.sh [--target <dir>] [--port <port>]\n'
       printf '  --target  MetaMask Mobile checkout directory\n'
-      printf '  --port    Metro port (default: WATCHER_PORT env, else the slot context, else 8081)\n'
+      printf '  --port    Metro port (default: WATCHER_PORT env, else METRO_PORT, else the slot context, else 8081)\n'
       exit 0
       ;;
     *) printf 'stop-metro: unknown arg: %s\n' "$1" >&2; exit 2 ;;
@@ -63,6 +64,7 @@ set +e
 rm -f "$PID_FILE"
 rm -f "$LOG_DIR/metro-launch.json"
 rm -f "$LOG_DIR/metro-build-env.sh"
+rm -f "$LOG_DIR/metro-config.sha256"
 
 # start-metro runs a per-checkout console-forwarder holding the device debugger
 # slot; Metro going down must take it too, or the orphan keeps polling and later

package/dist/adapters/mobile/prepare.js

@@ -386,6 +386,11 @@ async function dispatchAction(action, target, platform, json, preflightMode = "f
       const leaf = path.join(runnerDir, "adapters/mobile/yarn-setup.sh");
       return spawnScriptStreaming(leaf, ["--target", cwd], target, POD_PROBE_ENV);
     }
+    case "stop-metro": {
+      const leaf = path.join(runnerDir, "adapters/mobile/stop-metro.sh");
+      const port = watcherPort ?? Number(process.env.WATCHER_PORT || process.env.METRO_PORT || 8081);
+      return spawnScriptStreaming(leaf, ["--target", cwd, "--port", String(port)], target);
+    }
     case "start-metro": {
       const leaf = path.join(runnerDir, "adapters/mobile/start-metro.sh");
       const extra = action.argv ?? [];

package/dist/adapters/mobile/runtime-decision.js

@@ -1,4 +1,5 @@
 import { execFileSync } from "node:child_process";
+import { createHash } from "node:crypto";
 import fs from "node:fs";
 import path from "node:path";
 import {
@@ -16,6 +17,12 @@ import { mobileProductMarkers } from "./deps-markers.js";
 import { mobileMetroEnvCheck } from "./metro-env.js";
 const BUNDLE_ERR = /Bundling failed|Unable to resolve /u;
 const BUNDLE_OK = /Bundled \d+ms|iOS Bundled|Android Bundled|Finished bundling/u;
+const METRO_GRAPH_ROLLBACK = /attempted to roll back a graph commit but there were still changes/u;
+const METRO_GRAPH_COMMIT_THROW = /Got unexpected undefined/u;
+const METRO_GRAPH_FRAME = /DeltaBundler\/Graph\.js/u;
+const METRO_RESTART_ADVISORY = /Detected a change in ([\w.-]+)\. Restart the server/u;
+const METRO_REASON_MAX = 200;
+const METRO_CONFIG_HASHES_FILE = "metro-config.sha256";
 const NATIVE_MODULE_STALE = /\[runtime not ready\].*HybridObject "([^"]+)" - It has not yet been registered in the Nitro Modules HybridObjectRegistry/u;
 function resolveMetroLog(target, metroLog) {
   const abs = metroLog ? path.isAbsolute(metroLog) ? metroLog : path.join(target, metroLog) : recipeRuntimePath(target, "metro.log");
@@ -87,6 +94,46 @@ function appRunningOnDevice(platform) {
     return false;
   }
 }
+function metroConfigUnchangedSinceStart(target, relative) {
+  let recorded;
+  try {
+    recorded = fs.readFileSync(recipeRuntimePath(target, METRO_CONFIG_HASHES_FILE), "utf8");
+  } catch {
+    return false;
+  }
+  const entry = recorded.split("\n").find((line) => line.endsWith(`  ${relative}`));
+  if (!entry) return false;
+  try {
+    const current = createHash("sha256").update(fs.readFileSync(path.join(target, relative))).digest("hex");
+    return entry.startsWith(current);
+  } catch {
+    return false;
+  }
+}
+function metroProcessUnusable(target, logText) {
+  const lines = logText.split("\n");
+  let lastOk = -1;
+  for (let i = lines.length - 1; i >= 0; i -= 1) {
+    if (BUNDLE_OK.test(lines[i])) {
+      lastOk = i;
+      break;
+    }
+  }
+  for (let i = lines.length - 1; i > lastOk; i -= 1) {
+    if (METRO_GRAPH_ROLLBACK.test(lines[i])) return lines[i].trim().slice(0, METRO_REASON_MAX);
+    if (METRO_GRAPH_COMMIT_THROW.test(lines[i]) && lines.slice(i + 1, i + 4).some((frame) => METRO_GRAPH_FRAME.test(frame))) {
+      return lines[i].trim().slice(0, METRO_REASON_MAX);
+    }
+  }
+  const advised = /* @__PURE__ */ new Set();
+  for (const line of lines) {
+    const advisory = METRO_RESTART_ADVISORY.exec(line);
+    if (!advisory || advised.has(advisory[1])) continue;
+    advised.add(advisory[1]);
+    if (!metroConfigUnchangedSinceStart(target, advisory[1])) return advisory[0];
+  }
+  return null;
+}
 const launchActions = (target, clearMetro = false) => {
   const actions = [];
   actions.push({
@@ -218,6 +265,21 @@ async function computeMobileReadiness(resolved, options, fast) {
       ]
     };
   }
+  const unusable = metro.status !== "down" && metroLog.reason !== "unresolved-module" ? metroProcessUnusable(resolved, metroLogText) : null;
+  if (unusable) {
+    return {
+      schemaVersion: 1,
+      adapter: "mobile",
+      target: resolved,
+      decision: "launch",
+      reasonCode: "metro-restart-required",
+      reasons: [
+        `Metro reported its process unusable ("${unusable}"); restarting Metro and keeping its transform cache. Pass --clear-metro only if the same failure returns in the new process.`
+      ],
+      checks,
+      actions: [{ id: "stop-metro", cwd: resolved }, ...launchActions(resolved)]
+    };
+  }
   if (metroLog.status === "errors") {
     const depsSatisfied = deps.status === "current";
     if (depsSatisfied && (metroLog.reason === "stale-bundle-error" || metroLog.reason === "bundle-error")) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.51.7",
+  "version": "0.51.8",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"