@deeeed/metamask-harness 0.51.0 → 0.51.2

package/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 ## Unreleased
 
+## 0.51.2 - 2026-09-14
+
+### Fixed
+
+- Mobile native builds no longer pass `--no-bundler` to Expo: a Debug configuration starts the bundler regardless, so 0.51.1 left Expo attached to a stray Metro on 8081 and the launch never returned. Instead the build env answers Expo's one `lsof` lookup for the Metro listener from the harness's `metro.pid`; Expo's 350 ms lsof budget is what a busy Mac missed. A reused Metro listener now records its pid too.
+
+## 0.51.1 - 2026-09-13
+
+### Fixed
+
+- Mobile native builds run `expo run:ios` / `run:android` with `--no-bundler` (and without `--port`, which Expo refuses next to it): the harness owns Metro on the watcher port, and Expo's post-build port re-check (lsof under a 350 ms budget) aborted a successful 45-minute build on a loaded machine with "Port became busy running another process while the app was compiling".
+- Mobile `verify` waits for the React Native bridge to settle (bounded, best effort) before its live smoke, so a checkout is no longer reported not ready when the app is still hydrating right after a launch or a fixture unlock. `mm-harness prepare` on a fresh full slot build had failed at the final `verify` step this way while a retry a minute later passed.
 ## 0.51.0 - 2026-09-13
 
 ### Added

package/adapters/mobile/open-device.sh

@@ -81,6 +81,46 @@ for _rb in "$SCRIPT_DIR/../shared/activate-repo-ruby.sh" "$SCRIPT_DIR/lib/activa
   [ -f "$_rb" ] && { . "$_rb"; break; }
 done
 unset _rb
+# shellcheck disable=SC1091
+for _hp in "$SCRIPT_DIR/../shared/harness-path.sh" "$SCRIPT_DIR/lib/harness-path.sh"; do
+  [ -f "$_hp" ] && { . "$_hp"; break; }
+done
+unset _hp
+
+# Expo's run:ios / run:android bookkeeping asks lsof which process listens on
+# the Metro port, before and after the native build, under a 350 ms budget.
+# lsof scans every process on the machine, so a busy Mac misses that budget
+# and Expo aborts a finished build with "Port became busy running another
+# process while the app was compiling". The harness started that listener and
+# recorded it in metro.pid: answer that one query from the record and hand
+# every other lsof call to the real binary.
+write_lsof_shim() {
+  local dir="$1" real_lsof
+  real_lsof="$(command -v lsof 2>/dev/null || true)"
+  [ -n "$real_lsof" ] || return 0
+  {
+    printf '#!/usr/bin/env bash\n'
+    printf 'REAL_LSOF=%q\n' "$real_lsof"
+    cat <<'SHIM'
+# Exactly Expo's listener query and nothing else. A recycled pid after a Metro
+# death is the only way this can lie, and a dead Metro fails the build anyway.
+if [ $# -eq 4 ] && [ "$1" = "-i:${MM_HARNESS_BUILD_WATCHER_PORT:-}" ] && [ "$2" = "-P" ] && [ "$3" = "-t" ] && [ "$4" = "-sTCP:LISTEN" ] \
+  && [ -f "${MM_HARNESS_METRO_PID_FILE:-/nonexistent}" ]; then
+  pid="$(cat "$MM_HARNESS_METRO_PID_FILE" 2>/dev/null)"
+  if [ -n "$pid" ] && kill -0 "$pid" 2>/dev/null; then printf '%s\n' "$pid"; exit 0; fi
+fi
+exec "$REAL_LSOF" "$@"
+SHIM
+  } > "$dir/lsof"
+  chmod +x "$dir/lsof"
+}
+
+metro_pid_file() {
+  command -v recipe_runtime_dir >/dev/null 2>&1 || return 1
+  local runtime
+  runtime="$(recipe_runtime_dir)" || return 1
+  printf '%s/%s/metro.pid' "$TARGET" "$runtime"
+}
 
 # --- iOS helpers --------------------------------------------------------------
 
@@ -90,7 +130,7 @@ ios_app_installed() {
 }
 
 run_ios_native_build() (
-  local sim_target="$1" bundle_id="$2" reason="$3" build_env="" build_script="" build_type=""
+  local sim_target="$1" bundle_id="$2" reason="$3" build_env="" build_script="" build_type="" shim_dir=""
   case "$bundle_id" in
     io.metamask.MetaMask|io.metamask) build_script="start:ios"; build_type="main" ;;
     io.metamask.MetaMask-Flask) build_script="start:ios:flask"; build_type="flask" ;;
@@ -102,11 +142,15 @@ run_ios_native_build() (
   printf '%s; installing with yarn %s (WATCHER_PORT=%s)\n' "$reason" "$build_script" "$PORT" >&2
   build_env="$(mktemp "${TMPDIR:-/tmp}/mm-harness-ios-build-env.XXXXXX")" || return 1
   chmod 600 "$build_env" || { rm -f "$build_env"; return 1; }
-  trap 'rm -f "$build_env"' EXIT HUP INT TERM
+  shim_dir="$(mktemp -d "${TMPDIR:-/tmp}/mm-harness-build-shim.XXXXXX")" || { rm -f "$build_env"; return 1; }
+  trap 'rm -rf "$build_env" "$shim_dir"' EXIT HUP INT TERM
+  write_lsof_shim "$shim_dir"
   {
     printf 'export MM_HARNESS_BUILD_WATCHER_PORT=%q\n' "$PORT"
     printf 'export MM_HARNESS_BUILD_IOS_SIMULATOR=%q\n' "$sim_target"
     printf 'export MM_HARNESS_BUILD_TYPE=%q\n' "$build_type"
+    printf 'export MM_HARNESS_METRO_PID_FILE=%q\n' "$(metro_pid_file || true)"
+    printf 'export PATH=%q:"$PATH"\n' "$shim_dir"
     cat <<'BUILD_ENV'
 mm_harness_restore_build_target() {
   export WATCHER_PORT="$MM_HARNESS_BUILD_WATCHER_PORT"
@@ -281,7 +325,7 @@ android_app_installed() {
 }
 
 run_android_native_build() (
-  local serial="$1" expo_device="$2" pkg="$3" reason="$4" build_env="" build_script=""
+  local serial="$1" expo_device="$2" pkg="$3" reason="$4" build_env="" build_script="" shim_dir=""
   case "$pkg" in
     io.metamask) build_script="start:android" ;;
     io.metamask.flask) build_script="start:android:flask" ;;
@@ -293,11 +337,15 @@ run_android_native_build() (
   printf '%s; installing with yarn %s (WATCHER_PORT=%s)\n' "$reason" "$build_script" "$PORT" >&2
   build_env="$(mktemp "${TMPDIR:-/tmp}/mm-harness-android-build-env.XXXXXX")" || return 1
   chmod 600 "$build_env" || { rm -f "$build_env"; return 1; }
-  trap 'rm -f "$build_env"' EXIT HUP INT TERM
+  shim_dir="$(mktemp -d "${TMPDIR:-/tmp}/mm-harness-build-shim.XXXXXX")" || { rm -f "$build_env"; return 1; }
+  trap 'rm -rf "$build_env" "$shim_dir"' EXIT HUP INT TERM
+  write_lsof_shim "$shim_dir"
   {
     printf 'export MM_HARNESS_BUILD_ANDROID_SERIAL=%q\n' "$serial"
     printf 'export MM_HARNESS_BUILD_ANDROID_EXPO_DEVICE=%q\n' "$expo_device"
     printf 'export MM_HARNESS_BUILD_WATCHER_PORT=%q\n' "$PORT"
+    printf 'export MM_HARNESS_METRO_PID_FILE=%q\n' "$(metro_pid_file || true)"
+    printf 'export PATH=%q:"$PATH"\n' "$shim_dir"
     cat <<'BUILD_ENV'
 mm_harness_restore_android_build_target() {
   export WATCHER_PORT="$MM_HARNESS_BUILD_WATCHER_PORT"

package/adapters/mobile/start-metro.sh

@@ -218,6 +218,12 @@ if metro_ready; then
     rm -f "$PID_FILE"
   elif metro_listener_valid; then
     printf 'Metro already running and valid on port %s\n' "$PORT" >&2
+    # A reused listener still needs its record: the native build answers
+    # Expo's port lookup from metro.pid.
+    if [ ! -f "$PID_FILE" ]; then
+      lsof -nP -iTCP:"$PORT" -sTCP:LISTEN -t 2>/dev/null | head -1 > "$PID_FILE" || true
+      [ -s "$PID_FILE" ] || rm -f "$PID_FILE"
+    fi
     exit 0
   else
     stop_metro_listener || exit 1

package/adapters/mobile/verify.sh

@@ -414,6 +414,30 @@ if [ "$STATIC_ONLY" = false ]; then
 
   port_holder_json "$port" > "$ARTIFACTS/logs/port-holder.json"
 
+  # Right after a launch or a fixture unlock the app's JS thread can stay busy
+  # for a while (account hydration); a single CDP probe then times out although
+  # the runtime is healthy. When Metro holds the port, let wait-for-bridge
+  # absorb that settle before the smoke. Best effort and bounded: the smoke
+  # below is the check that counts. The installed overlay carries only this
+  # script, so the waiter is resolved from the runner source it was installed
+  # from.
+  if [ "$status" != "fail" ] && node -e 'process.exit(JSON.parse(require("fs").readFileSync(process.argv[1], "utf8")).listening ? 0 : 1)' "$ARTIFACTS/logs/port-holder.json" 2>/dev/null; then
+    wait_sh=""
+    for candidate in "$SCRIPT_DIR/wait-for-bridge.sh" "$(cat "$HARNESS_DIR/runner/.runner-source" 2>/dev/null || true)/adapters/mobile/wait-for-bridge.sh"; do
+      [ -f "$candidate" ] && { wait_sh="$candidate"; break; }
+    done
+    if [ -z "$wait_sh" ]; then
+      add_note "Mobile bridge settle skipped: wait-for-bridge.sh not found beside verify.sh or under runner/.runner-source; reinstall the runner."
+    elif MOBILE_BRIDGE_READY_TIMEOUT_MS="${MOBILE_BRIDGE_READY_TIMEOUT_MS:-90000}" \
+      MOBILE_BRIDGE_UNRESPONSIVE_GRACE_MS="${MOBILE_BRIDGE_UNRESPONSIVE_GRACE_MS:-90000}" \
+      bash "$wait_sh" --target "$TARGET" --port "$port" --platform "$PLATFORM" \
+      > "$ARTIFACTS/logs/wait-for-bridge.log" 2>&1; then
+      add_note "Mobile bridge settled before the live smoke (logs/wait-for-bridge.log)."
+    else
+      add_note "Mobile bridge settle did not complete (waiter exit $?); running the live smoke anyway (logs/wait-for-bridge.log)."
+    fi
+  fi
+
   cat > "$ARTIFACTS/mobile-v1-live-smoke.recipe.json" <<'JSON'
 {
   "$schema": "https://farmslot.io/schemas/recipe-v1.schema.json",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.51.0",
+  "version": "0.51.2",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"