@deeeed/metamask-harness 0.47.4 → 0.48.0

package/library/actions/extension/performance/_navigation-memory.mjs

@@ -1,9 +1,38 @@
+import { mkdtemp, writeFile } from 'node:fs/promises';
+import path from 'node:path';
+
 const DEFAULT_SCREEN_TIMEOUT_MS = 15_000;
 const DEFAULT_SETTLE_MS = 1_500;
 const DEFAULT_GC_SETTLE_MS = 300;
 const DEFAULT_ACTION_TIMEOUT_MS = 400_000;
 const DEFAULT_ROUND_DURATION_MS = 10_000;
 
+export async function withMemoryFailureReport(input, measure) {
+  try {
+    return await measure();
+  } catch (error) {
+    if (!error?.memoryMeasurement) throw error;
+    const directory = await mkdtemp(path.join(input.context.artifactsDir, 'navigation-memory-'));
+    const report = path.join(directory, 'measurement.json');
+    await writeFile(report, `${JSON.stringify({
+      nodeId: input.context.nodeId,
+      action: input.action,
+      ...error.memoryMeasurement,
+    }, null, 2)}\n`, { mode: 0o600 });
+    await writeFile(input.outputPath, `${JSON.stringify({ artifacts: [{
+      path: path.relative(input.context.artifactsDir, report),
+      type: 'report',
+      nodeId: input.context.nodeId,
+      label: 'Failed memory measurement',
+      category: 'diagnostic',
+      mimeType: 'application/json',
+    }] })}\n`, { mode: 0o600 });
+    delete error.memoryMeasurement;
+    error.message += `\nNext: jq . ${JSON.stringify(report)}`;
+    throw error;
+  }
+}
+
 function finiteNumber(value, fallback, label) {
   const parsed = value ?? fallback;
   if (!Number.isFinite(parsed)) throw new Error(`${label} must be a finite number.`);
@@ -217,9 +246,9 @@ export async function measureNavigationSlope(page, options, bounds) {
     passed,
   };
   if (!passed.nodes || !passed.listeners) {
-    throw new Error(
+    throw Object.assign(new Error(
       `Navigation memory bounds exceeded: nodes ${slopes.nodes.toFixed(2)}/${bounds.maxNodesPerCycle} per cycle; listeners ${slopes.listeners.toFixed(2)}/${bounds.maxListenersPerCycle} per cycle.`,
-    );
+    ), { memoryMeasurement: result });
   }
   return result;
 }
@@ -282,9 +311,9 @@ export async function measureDetachedDom(page, options, maxDetachedGrowth) {
     passed: after - before <= maxDetachedGrowth,
   };
   if (!result.passed) {
-    throw new Error(
+    throw Object.assign(new Error(
       `Detached DOM bound exceeded: growth ${result.growth}/${maxDetachedGrowth} nodes.`,
-    );
+    ), { memoryMeasurement: result });
   }
   return result;
 }
@@ -333,9 +362,9 @@ export async function compareIdleNavigation(page, options, maxAttributableListen
     passed: attributableListenersPerCycle <= maxAttributableListenersPerCycle,
   };
   if (!result.passed) {
-    throw new Error(
+    throw Object.assign(new Error(
       `Idle-control bound exceeded: attributable listeners ${attributableListenersPerCycle.toFixed(2)}/${maxAttributableListenersPerCycle} per cycle (navigation ${navigation.slopes.listeners.toFixed(2)}, idle ${idleListenersPerCycle.toFixed(2)}).`,
-    );
+    ), { memoryMeasurement: result });
   }
   return result;
 }

package/library/actions/extension/performance/compare_idle_navigation_memory.mjs

@@ -3,10 +3,11 @@ import {
   compareIdleNavigation,
   idleControlBound,
   navigationMemoryOptions,
+  withMemoryFailureReport,
 } from './_navigation-memory.mjs';
 
 runAdapter((input) =>
-  withExtensionPage(input, async (page) => ({
+  withMemoryFailureReport(input, () => withExtensionPage(input, async (page) => ({
     action: input.action,
     status: 'pass',
     ...(await compareIdleNavigation(
@@ -14,5 +15,5 @@ runAdapter((input) =>
       navigationMemoryOptions(input.node, 'rounds', 8),
       idleControlBound(input.node),
     )),
-  })),
+  }))),
 );

package/library/actions/extension/performance/measure_detached_dom.mjs

@@ -3,10 +3,11 @@ import {
   detachedDomBound,
   measureDetachedDom,
   navigationMemoryOptions,
+  withMemoryFailureReport,
 } from './_navigation-memory.mjs';
 
 runAdapter((input) =>
-  withExtensionPage(input, async (page) => ({
+  withMemoryFailureReport(input, () => withExtensionPage(input, async (page) => ({
     action: input.action,
     status: 'pass',
     ...(await measureDetachedDom(
@@ -14,5 +15,5 @@ runAdapter((input) =>
       navigationMemoryOptions(input.node, 'cycles', 5),
       detachedDomBound(input.node),
     )),
-  })),
+  }))),
 );

package/library/actions/extension/performance/measure_navigation_memory.mjs

@@ -3,10 +3,11 @@ import {
   measureNavigationSlope,
   navigationMemoryOptions,
   navigationSlopeBounds,
+  withMemoryFailureReport,
 } from './_navigation-memory.mjs';
 
 runAdapter((input) =>
-  withExtensionPage(input, async (page) => ({
+  withMemoryFailureReport(input, () => withExtensionPage(input, async (page) => ({
     action: input.action,
     status: 'pass',
     ...(await measureNavigationSlope(
@@ -14,5 +15,5 @@ runAdapter((input) =>
       navigationMemoryOptions(input.node),
       navigationSlopeBounds(input.node),
     )),
-  })),
+  }))),
 );

package/library/actions/extension/perps/assert_visible_consistency.mjs

@@ -86,7 +86,8 @@ async function visiblePrice(page, surface, market) {
       if (!element) return false;
       const style = getComputedStyle(element);
       const rect = element.getBoundingClientRect();
-      return style.display !== 'none' && style.visibility !== 'hidden' && rect.width > 0 && rect.height > 0;
+      return style.display !== 'none' && style.visibility !== 'hidden' && rect.width > 0 && rect.height > 0
+        && rect.bottom > 0 && rect.right > 0 && rect.top < innerHeight && rect.left < innerWidth;
     };
     const root = document.querySelector('[data-testid=${JSON.stringify(rootTestId)}]');
     const price = ${priceTestId
@@ -111,7 +112,8 @@ async function marketRows(page, maxItems) {
     if (testId.startsWith('market-row-ticker-') || /-(?:token-logo|asset-label)$/u.test(testId)) return false;
     const style = getComputedStyle(element);
     const rect = element.getBoundingClientRect();
-    return style.display !== 'none' && style.visibility !== 'hidden' && rect.width > 0 && rect.height > 0;
+    return style.display !== 'none' && style.visibility !== 'hidden' && rect.width > 0 && rect.height > 0
+        && rect.bottom > 0 && rect.right > 0 && rect.top < innerHeight && rect.left < innerWidth;
   }).slice(0, ${JSON.stringify(maxItems)}).map((element) => ({
     testId: String(element.getAttribute('data-testid') || '').slice(0, 500),
     label: String(element.innerText || '').replace(/\\s+/gu, ' ').trim().slice(0, 500),
@@ -124,7 +126,8 @@ async function watchlistRows(page, maxItems) {
   ].filter((element) => {
     const style = getComputedStyle(element);
     const rect = element.getBoundingClientRect();
-    return style.display !== 'none' && style.visibility !== 'hidden' && rect.width > 0 && rect.height > 0;
+    return style.display !== 'none' && style.visibility !== 'hidden' && rect.width > 0 && rect.height > 0
+        && rect.bottom > 0 && rect.right > 0 && rect.top < innerHeight && rect.left < innerWidth;
   }).slice(0, ${JSON.stringify(maxItems)}).map((element) => ({
     testId: String(element.getAttribute('data-testid') || '').slice(0, 500),
     label: String(element.innerText || '').replace(/\\s+/gu, ' ').trim().slice(0, 500),
@@ -138,6 +141,7 @@ function changedRows(first, last) {
     .map((entry) => entry.testId);
 }
 
+// Containment checks loaded full-list rows, including rows below the viewport.
 async function activityIds(page, maxItems) {
   const selector = '[data-testid^="transaction-card-"]';
   return page.evaluate(`[
@@ -155,7 +159,8 @@ async function recentActivityState(page, maxItems) {
       if (!element) return false;
       const style = getComputedStyle(element);
       const rect = element.getBoundingClientRect();
-      return style.display !== 'none' && style.visibility !== 'hidden' && rect.width > 0 && rect.height > 0;
+      return style.display !== 'none' && style.visibility !== 'hidden' && rect.width > 0 && rect.height > 0
+        && rect.bottom > 0 && rect.right > 0 && rect.top < innerHeight && rect.left < innerWidth;
     };
     return {
       ids: [...document.querySelectorAll('[data-testid^="transaction-card-"]')]

package/library/actions/extension/perps/close_visible_position.mjs

@@ -10,7 +10,7 @@ import {
   trustedExternalMutationPlanIsExact,
   withExternalMutationRecovery,
 } from './mutation-receipt.mjs';
-import { requireCurrentVisibleFundingBalance, requirePerpsTradingContext } from './perps.mjs';
+import { placementReceiptSelection, requireCurrentVisibleFundingBalance, requirePerpsTradingContext } from './perps.mjs';
 import {
   absoluteDelta,
   parsePositionDetail,
@@ -281,7 +281,7 @@ export async function closeVisiblePosition(input) {
     throw new Error('Visible Perps position notional is unavailable or exceeds the authorized close cap.');
   }
   if (!cleanupOnly) {
-    await readPriorMutationReceipt(input, identity, 'metamask.perps.place_order');
+    await readPriorMutationReceipt(input, identity, 'metamask.perps.place_order', placementReceiptSelection(input));
   }
   const balanceBeforeBaseUnits = fundingBalance.observedBaseUnits;
   if (!/^(?:0|[1-9][0-9]{0,29})$/u.test(balanceBeforeBaseUnits)) {
@@ -303,7 +303,6 @@ export async function closeVisiblePosition(input) {
       let dispatchTarget;
       try {
         await requireCurrentVisibleFundingBalance(input, page, timeoutMs, fundingBalance.observedBaseUnits);
-        await requirePerpsTradingContext(input, page);
         assertTrustedExternalMutationTarget(input, page, identity);
         const current = await readVisibleClosePosition(page, market);
         const currentPosition = parsePositionDetail({ pair: `${market}-USD`, ...current });
@@ -322,6 +321,7 @@ export async function closeVisiblePosition(input) {
           const rect = element.getBoundingClientRect();
           return { x: rect.left + rect.width / 2, y: rect.top + rect.height / 2 };
         })()`);
+        await requirePerpsTradingContext(input, page);
         assertTrustedExternalMutationTarget(input, page, identity);
       } catch (error) {
         throw externalMutationNotDispatched(error instanceof Error ? error.message : String(error));

package/library/actions/extension/perps/edit_margin.mjs

@@ -266,7 +266,6 @@ export async function editMargin(input) {
       let dispatchTarget;
       try {
         await requireCurrentVisibleFundingBalance(input, page, timeoutMs, fundingBalance.observedBaseUnits);
-        await requirePerpsTradingContext(input, page);
         assertTrustedExternalMutationTarget(input, page, identity);
         const current = await readPosition(page, market);
         if (current.marginBaseUnits !== before.marginBaseUnits || current.size !== before.size
@@ -284,6 +283,7 @@ export async function editMargin(input) {
           const rect = element.getBoundingClientRect();
           return { x: rect.left + rect.width / 2, y: rect.top + rect.height / 2 };
         })()`);
+        await requirePerpsTradingContext(input, page);
         assertTrustedExternalMutationTarget(input, page, identity);
       } catch (error) {
         throw externalMutationNotDispatched(error instanceof Error ? error.message : String(error));

package/library/actions/extension/perps/open_balance_action.mjs

@@ -11,13 +11,22 @@ runAdapter(async (input) => withExtensionPage(input, async (page) => {
   if (!actionTestId) {
     throw new Error(`metamask.perps.open_balance_action received unsupported balance_action ${JSON.stringify(balanceAction)}.`);
   }
-  await page.click(dataTestId('perps-balance-dropdown-balance'));
-  const actionSelector = dataTestId(actionTestId);
-  await page.waitForSelector(actionSelector, { timeoutMs: 10_000 });
+  const directSelector = dataTestId(`perps-balance-actions-${balanceAction}`);
+  const directVisible = await page.evaluate(`(() => {
+    const element = document.querySelector(${JSON.stringify(directSelector)});
+    if (!element) return false;
+    const style = getComputedStyle(element), rect = element.getBoundingClientRect();
+    return style.display !== 'none' && style.visibility !== 'hidden' && rect.width > 0 && rect.height > 0;
+  })()`);
+  const actionSelector = directVisible ? directSelector : dataTestId(actionTestId);
+  if (!directVisible) {
+    await page.click(dataTestId('perps-balance-dropdown-balance'));
+    await page.waitForSelector(actionSelector, { timeoutMs: 10_000 });
+  }
   await page.click(actionSelector);
   const expected = balanceAction === 'withdraw'
-    ? ['perps-withdraw-page', 'perps-withdraw-container', 'perps-withdraw-view']
-    : ['confirm-page-container-content', 'confirm-page-container', 'transaction-confirmation'];
+    ? ['parent-selector-perps-withdraw', 'parent-selector-confirmation-page', 'perps-withdraw-page', 'perps-withdraw-container', 'perps-withdraw-view']
+    : ['parent-selector-confirmation-page', 'confirm-page-container-content', 'confirm-page-container', 'transaction-confirmation'];
   const resultDeadline = Date.now() + 15_000;
   let observed;
   while (Date.now() <= resultDeadline) {
@@ -38,10 +47,10 @@ runAdapter(async (input) => withExtensionPage(input, async (page) => {
         text: String(document.body?.innerText || '').replace(/\\s+/gu, ' ').trim().slice(0, 10_000),
       };
     })()`);
-    if (observed.matched.length > 0 || observed.route !== '#/perps-home') break;
+    if (observed.matched.length > 0) break;
     await new Promise((resolve) => setTimeout(resolve, 100));
   }
-  if (!observed || (observed.matched.length === 0 && observed.route === '#/perps-home')) {
+  if (!observed || observed.matched.length === 0) {
     throw new Error(`Perps ${balanceAction} did not open: ${JSON.stringify(observed)}.`);
   }
   return {