@deeeed/metamask-harness 0.40.0 → 0.40.1

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## Unreleased
 
+## 0.40.1 - 2026-08-16
+
+### Fixed
+
+- Read durable funding claims and mutation receipts through one non-symlink file descriptor, and keep filter polling delays out of page-evaluated code.
+
 ## 0.40.0 - 2026-08-16
 
 - Remove Extension's public `metamask.perps.close_positions` and `metamask.perps.start_state` surfaces and its mutating `runner.action-validation` recipe; retain only state assertions it can prove without implicit readiness or unreceipted convergence.

package/dist/funding-execution-context.js

@@ -324,11 +324,12 @@ async function readFundingDocuments(requestPath, preflightPath, releaseProofPath
   };
 }
 async function readRegularFile(file, option) {
-  const linkInfo = await lstat(file);
-  if (linkInfo.isSymbolicLink() || !linkInfo.isFile()) {
+  let handle;
+  try {
+    handle = await open(file, fsConstants.O_RDONLY | fsConstants.O_NOFOLLOW);
+  } catch {
     throw new Error(`${option} must name a regular non-symlink file.`);
   }
-  const handle = await open(file, fsConstants.O_RDONLY | fsConstants.O_NOFOLLOW);
   try {
     const info = await handle.stat();
     if (!info.isFile() || info.size <= 0 || info.size > MAX_DOCUMENT_BYTES) {
@@ -339,6 +340,24 @@ async function readRegularFile(file, option) {
     await handle.close();
   }
 }
+async function readOptionalRegularFile(file, label) {
+  let handle;
+  try {
+    handle = await open(file, fsConstants.O_RDONLY | fsConstants.O_NOFOLLOW);
+  } catch (error) {
+    if (error.code === "ENOENT") return void 0;
+    throw new Error(`${label} is unsafe.`);
+  }
+  try {
+    const info = await handle.stat();
+    if (!info.isFile() || info.size <= 0 || info.size > MAX_DOCUMENT_BYTES) {
+      throw new Error(`${label} is unsafe.`);
+    }
+    return await handle.readFile();
+  } finally {
+    await handle.close();
+  }
+}
 async function directoryIdentity(directory) {
   const resolved = path.resolve(directory);
   const info = await lstat(resolved);
@@ -365,14 +384,7 @@ async function publishExecutionClaim(base, claim, artifactsDir, plan, directory)
   const stateRoot = path.dirname(directory);
   const claimPath = path.join(directory, `${identityKey}.json`);
   const bytes = canonical(claim);
-  let currentClaimExists = true;
-  try {
-    await lstat(claimPath);
-  } catch (error) {
-    if (error.code !== "ENOENT") throw error;
-    currentClaimExists = false;
-  }
-  if (!currentClaimExists) {
+  if (!await readOptionalRegularFile(claimPath, "Funding execution claim")) {
     const legacyRecovery = await recoverLegacyExecutionClaim(
       path.join(directory, `${releaseIdentityKey}.json`),
       bytes,
@@ -394,9 +406,9 @@ async function publishExecutionClaim(base, claim, artifactsDir, plan, directory)
     await syncDirectory(stateRoot);
   } catch (error) {
     if (error.code !== "EEXIST") throw error;
-    const info = await lstat(claimPath);
-    if (!info.isFile() || info.isSymbolicLink()) throw new Error("Funding execution claim is unsafe.");
-    const existing = await readFile(claimPath, "utf8");
+    const existingBytes = await readOptionalRegularFile(claimPath, "Funding execution claim");
+    if (!existingBytes) throw new Error("Funding execution claim disappeared during inspection.");
+    const existing = existingBytes.toString("utf8");
     if (existing !== bytes) {
       const comparison = compareExecutionClaims(existing, bytes);
       if (comparison.differences.length === 2 && comparison.differences.includes("runId") && comparison.differences.includes("executionPlanSha256")) {
@@ -417,15 +429,9 @@ async function publishExecutionClaim(base, claim, artifactsDir, plan, directory)
   return void 0;
 }
 async function recoverLegacyExecutionClaim(claimPath, currentBytes, artifactsDir, base, plan) {
-  let info;
-  try {
-    info = await lstat(claimPath);
-  } catch (error) {
-    if (error.code === "ENOENT") return void 0;
-    throw error;
-  }
-  if (!info.isFile() || info.isSymbolicLink()) throw new Error("Funding execution claim is unsafe.");
-  const existingBytes = await readFile(claimPath, "utf8");
+  const existing = await readOptionalRegularFile(claimPath, "Legacy funding execution claim");
+  if (!existing) return void 0;
+  const existingBytes = existing.toString("utf8");
   const comparison = compareExecutionClaims(existingBytes, currentBytes);
   const sameFundingDocuments = comparison.existing.fundingRequestSha256 === comparison.current.fundingRequestSha256 && comparison.existing.fundingPreflightSha256 === comparison.current.fundingPreflightSha256 && comparison.existing.fundingReleaseProofSha256 === comparison.current.fundingReleaseProofSha256 && comparison.existing.fundingBalanceProofSha256 === comparison.current.fundingBalanceProofSha256;
   if (!sameFundingDocuments) return void 0;
@@ -519,16 +525,17 @@ async function requireSafeRecoveryReceiptChain(artifactsDir, claim, base, plan)
   let runtimeIdentity;
   for (const entry of entries) {
     const receiptPath = path.join(receiptDirectory, entry.name);
-    const receiptInfo = await lstat(receiptPath);
-    if (!receiptInfo.isFile() || receiptInfo.isSymbolicLink() || receiptInfo.size <= 0 || receiptInfo.size > MAX_DOCUMENT_BYTES) {
+    let handle;
+    try {
+      handle = await open(receiptPath, fsConstants.O_RDONLY | fsConstants.O_NOFOLLOW);
+    } catch {
       throw new Error("Funding recovery mutation receipt is unsafe.");
     }
-    const handle = await open(receiptPath, fsConstants.O_RDONLY | fsConstants.O_NOFOLLOW);
     let bytes;
     try {
       const openedInfo = await handle.stat();
-      if (!openedInfo.isFile() || openedInfo.size !== receiptInfo.size) {
-        throw new Error("Funding recovery mutation receipt changed during inspection.");
+      if (!openedInfo.isFile() || openedInfo.size <= 0 || openedInfo.size > MAX_DOCUMENT_BYTES) {
+        throw new Error("Funding recovery mutation receipt is unsafe.");
       }
       bytes = await handle.readFile();
     } finally {

package/library/actions/extension/perps/mutation-receipt.mjs

@@ -1,4 +1,5 @@
 import { createHash } from 'node:crypto';
+import { constants as fsConstants } from 'node:fs';
 import {
   chmod,
   link,
@@ -6,7 +7,6 @@ import {
   mkdir,
   mkdtemp,
   open,
-  readFile,
   readdir,
   realpath,
   rename,
@@ -353,21 +353,25 @@ function unreadableReceiptError(detail) {
 }
 
 async function readPublished(destination) {
-  let entry;
+  let handle;
   try {
-    entry = await lstat(destination.absolute);
+    handle = await open(destination.absolute, fsConstants.O_RDONLY | fsConstants.O_NOFOLLOW);
   } catch (error) {
     if (error?.code === 'ENOENT') return null;
     throw unreadableReceiptError('the persisted receipt could not be inspected');
   }
-  if (!entry.isFile() || entry.isSymbolicLink()) {
-    throw unreadableReceiptError('the persisted receipt is unsafe');
-  }
   let bytes;
   try {
-    bytes = await readFile(destination.absolute, 'utf8');
-  } catch {
+    const entry = await handle.stat();
+    if (!entry.isFile()) {
+      throw unreadableReceiptError('the persisted receipt is unsafe');
+    }
+    bytes = await handle.readFile({ encoding: 'utf8' });
+  } catch (error) {
+    if (error instanceof Error && error.message.includes('the persisted receipt is unsafe')) throw error;
     throw unreadableReceiptError('the persisted receipt could not be read');
+  } finally {
+    await handle.close();
   }
   let record;
   try {

package/library/actions/extension/perps/select_activity_filter.mjs

@@ -85,7 +85,7 @@ export async function selectActivityFilter(page, input, options = {}) {
         `label=${JSON.stringify(observed.selected)}, visible=${observed.selectedVisible === true}.`,
       );
     }
-    await page.evaluate(`new Promise((resolve) => setTimeout(resolve, ${JSON.stringify(pollIntervalMs)}))`);
+    await new Promise((resolve) => setTimeout(resolve, pollIntervalMs));
   }
   return {
     action: input.action,

package/library/actions/extension/perps/select_market_filter.mjs

@@ -74,7 +74,7 @@ export async function selectMarketFilter(page, input, pollOptions = {}) {
         `(visible=${selectedState.visible === true}).`,
       );
     }
-    await page.evaluate(`new Promise((resolve) => setTimeout(resolve, ${JSON.stringify(pollIntervalMs)}))`);
+    await new Promise((resolve) => setTimeout(resolve, pollIntervalMs));
   }
   const raw = await page.evaluate(`(() => {
     const maximum = ${JSON.stringify(options.maxItems)};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.40.0",
+  "version": "0.40.1",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"