@deeeed/metamask-harness 0.38.1 → 0.40.0

package/library/actions/mobile/wallet/native-ui.mjs

@@ -1,6 +1,9 @@
 import { createAgentDeviceUiTransport } from '@farmslot/expo-recipe';
 import { createAgentDeviceClient } from 'agent-device';
-import { nativeSessionName } from '../platform/native-session-name.mjs';
+import {
+  nativeAgentDeviceStateDir,
+  nativeSessionName,
+} from '../platform/native-session-name.mjs';
 
 const TEST_IDS = {
   existingWallet: 'wallet-setup-screen-have-an-existing-wallet-button-id',
@@ -30,6 +33,8 @@ const TEST_IDS = {
   perpsHomeBack: 'perps-home-back-button',
   perpsMarket: 'perps-market-details-view',
   perpsMarketBack: 'perps-market-header-back-button',
+  perpsProMarket: 'perps-pro-market-scroll-view',
+  perpsProMarketBack: 'perps-pro-market-header-back-button',
   hamburger: 'navbar-hamburger-menu-button',
   lock: 'lock-menu-item',
   confirmLock: 'android:id/button1',
@@ -85,6 +90,10 @@ function isWalletScreen(nodes) {
   return nodes.some((node) => WALLET_SCREEN_IDS.includes(String(node.identifier ?? '')));
 }
 
+function visibleSnapshotNodes(nodes) {
+  return nodes.filter((node) => node.visibleToUser !== false);
+}
+
 function hasBlockingSystemUi(nodes) {
   return nodes.some((node) =>
     (node.bundleId === 'com.android.systemui' || PERMISSION_CONTROLLER_PACKAGES.has(node.bundleId)) &&
@@ -101,7 +110,7 @@ export async function importWalletThroughNativeUi(input, credentials, options) {
   const native = nativeSession(input);
   try {
     const initial = await native.normalizeWalletSurface(options.timeoutMs);
-    if (initial.wallet) {
+    if (initial.wallet && !initial.visible.has(TEST_IDS.walletTourSkip)) {
       if (options.requireFresh) {
         throw new Error('metamask.wallet.import method=ui requires a fresh Mobile onboarding state.');
       }
@@ -183,6 +192,27 @@ export async function unlockWalletThroughNativeUi(input, password, timeoutMs) {
   }
 }
 
+export async function lockWalletThroughNativeUi(input) {
+  const native = nativeSession(input);
+  const timeoutMs = Number(input.node?.timeout_ms ?? 30_000);
+  try {
+    const state = await native.normalizeWalletSurface(timeoutMs);
+    if (state.visible.has(TEST_IDS.login)) {
+      return { alreadyLocked: true, provider: 'android-native-accessibility' };
+    }
+    if (!state.wallet) throw new Error('Opaque Mobile wallet lock could not reach wallet home.');
+    await native.press(TEST_IDS.hamburger, timeoutMs);
+    await native.press(TEST_IDS.lock, timeoutMs);
+    if (await native.exists(TEST_IDS.confirmLock, 3000)) {
+      await native.press(TEST_IDS.confirmLock, timeoutMs);
+    }
+    await native.wait(TEST_IDS.login, timeoutMs);
+    return { alreadyLocked: false, provider: 'android-native-accessibility' };
+  } finally {
+    await native.close();
+  }
+}
+
 export async function resetWalletThroughNativeUi(input) {
   const native = nativeSession(input);
   const timeoutMs = Number(input.node?.timeout_ms ?? 60_000);
@@ -219,8 +249,10 @@ function nativeSession(input) {
   if (!device) throw new Error('Opaque Mobile UI execution requires one explicit Android device serial.');
   const app = String(env.ANDROID_PACKAGE_ID ?? 'io.metamask');
   const session = nativeSessionName(env, device, app);
+  const stateDir = nativeAgentDeviceStateDir(env, input.context.projectRoot, device);
   const client = createAgentDeviceClient({
     session,
+    stateDir,
     lockPolicy: 'reject',
     lockPlatform: 'android',
   });
@@ -230,6 +262,7 @@ function nativeSession(input) {
     device,
     app,
     session,
+    stateDir,
     client,
   });
   const context = {
@@ -240,7 +273,11 @@ function nativeSession(input) {
   };
   const execute = (action, node) => transport.execute(action, node, context);
   return {
-    press: (testId, timeoutMs) => execute('ui.press', { test_id: testId, timeout_ms: timeoutMs }),
+    press: (testId, timeoutMs) => execute('ui.press', {
+      test_id: testId,
+      timeout_ms: timeoutMs,
+      settle: false,
+    }),
     fill: (testId, value, timeoutMs) => execute('ui.set_input', {
       test_id: testId,
       value,
@@ -259,7 +296,7 @@ function nativeSession(input) {
         interactiveOnly: false,
         forceFull: true,
       });
-      const actual = new Map(snapshot.nodes
+      const actual = new Map(visibleSnapshotNodes(snapshot.nodes)
         .filter((node) => /^phrase-input-id_\d+$/u.test(String(node.identifier ?? '')))
         .map((node) => [
           Number(String(node.identifier).split('_').at(-1)),
@@ -288,11 +325,12 @@ function nativeSession(input) {
         interactiveOnly: false,
         forceFull: true,
       });
+      const nodes = visibleSnapshotNodes(snapshot.nodes);
       return {
-        nodes: snapshot.nodes,
-        visible: new Set(snapshot.nodes.map((node) => String(node.identifier ?? ''))),
-        wallet: isWalletScreen(snapshot.nodes),
-        postPassword: isPostPasswordScreen(snapshot.nodes) || isMetaMaskBiometricPrompt(snapshot.nodes),
+        nodes,
+        visible: new Set(nodes.map((node) => String(node.identifier ?? ''))),
+        wallet: isWalletScreen(nodes),
+        postPassword: isPostPasswordScreen(nodes) || isMetaMaskBiometricPrompt(nodes),
       };
     },
     async normalizeWalletSurface(timeoutMs) {
@@ -307,7 +345,12 @@ function nativeSession(input) {
         ) {
           return state;
         }
-        if (state.visible.has(TEST_IDS.perpsMarketBack)) {
+        if (
+          state.visible.has(TEST_IDS.perpsProMarket) &&
+          state.visible.has(TEST_IDS.perpsProMarketBack)
+        ) {
+          await this.press(TEST_IDS.perpsProMarketBack, timeoutMs);
+        } else if (state.visible.has(TEST_IDS.perpsMarketBack)) {
           await this.press(TEST_IDS.perpsMarketBack, timeoutMs);
         } else if (state.visible.has(TEST_IDS.perpsHomeBack)) {
           await this.press(TEST_IDS.perpsHomeBack, timeoutMs);
@@ -333,13 +376,15 @@ function nativeSession(input) {
       let walletTourSkipped = false;
       let interestsHandled = false;
       let awaitingNotificationPermission = false;
+      let stableWalletCaptures = 0;
       while (Date.now() <= deadline) {
         const snapshot = await client.capture.snapshot({
           ...selection,
           interactiveOnly: false,
           forceFull: true,
         });
-        if (isMetaMaskBiometricPrompt(snapshot.nodes)) {
+        const nodes = visibleSnapshotNodes(snapshot.nodes);
+        if (isMetaMaskBiometricPrompt(nodes)) {
           if (options.biometricsEnabled) {
             throw new Error('Mobile biometrics=true requires manual device authentication and is not supported by an unattended recipe.');
           }
@@ -351,7 +396,7 @@ function nativeSession(input) {
           biometricPromptDismissed = true;
           continue;
         }
-        if (isMetaMaskNotificationPermissionPrompt(snapshot.nodes) && awaitingNotificationPermission) {
+        if (isMetaMaskNotificationPermissionPrompt(nodes) && awaitingNotificationPermission) {
           await client.command.alert({
             ...selection,
             action: 'accept',
@@ -362,12 +407,21 @@ function nativeSession(input) {
           notificationsEnabled = true;
           continue;
         }
-        if (hasBlockingSystemUi(snapshot.nodes)) {
+        if (hasBlockingSystemUi(nodes)) {
           throw new Error('Unexpected Android system UI blocked Mobile wallet creation; refusing to dismiss it as biometric authentication.');
         }
-        const visible = new Set(snapshot.nodes.map((node) => String(node.identifier ?? '')));
+        const visible = new Set(nodes.map((node) => String(node.identifier ?? '')));
+        const walletVisible = WALLET_SCREEN_IDS.some((testId) => visible.has(testId));
+        if (!walletVisible) stableWalletCaptures = 0;
         if (visible.has(TEST_IDS.metricsContinue)) {
           if (!options.metametricsEnabled) {
+            if (!visible.has(TEST_IDS.metricsCheckbox)) {
+              await this.scroll('down', options.timeoutMs);
+              const afterScroll = await this.screenState();
+              if (!afterScroll.visible.has(TEST_IDS.metricsCheckbox)) {
+                throw new Error('Mobile MetaMetrics opt-out checkbox remained unavailable after one bounded onboarding scroll.');
+              }
+            }
             await this.press(TEST_IDS.metricsCheckbox, options.timeoutMs);
           }
           await this.press(TEST_IDS.metricsContinue, options.timeoutMs);
@@ -402,6 +456,7 @@ function nativeSession(input) {
           continue;
         }
         if (visible.has(TEST_IDS.walletTourSkip)) {
+          stableWalletCaptures = 0;
           if (options.skipWalletTour) {
             await this.press(TEST_IDS.walletTourSkip, options.timeoutMs);
             walletTourSkipped = true;
@@ -409,10 +464,15 @@ function nativeSession(input) {
           }
           throw new Error('Mobile wallet-home tour remains visible because skip_wallet_tour=false; wallet readiness cannot be proven.');
         }
-        if (WALLET_SCREEN_IDS.some((testId) => visible.has(testId))) {
+        if (walletVisible) {
           if (options.interests.length > 0 && !interestsHandled) {
             throw new Error('Mobile onboarding interests were requested, but the questionnaire is not enabled for this build.');
           }
+          stableWalletCaptures += 1;
+          if (stableWalletCaptures < 2) {
+            await new Promise((resolve) => setTimeout(resolve, 500));
+            continue;
+          }
           return {
             biometricsEnabled: options.biometricsEnabled,
             biometricPromptDismissed,
@@ -431,10 +491,23 @@ function nativeSession(input) {
       timeout_ms: timeoutMs,
       settle: false,
     }),
+    scroll: (direction, timeoutMs) => execute('ui.scroll', {
+      direction,
+      amount: 0.75,
+      timeout_ms: timeoutMs,
+      settle: false,
+    }),
     async waitForWallet(timeoutMs) {
       const deadline = Date.now() + timeoutMs;
+      let stableCaptures = 0;
       while (Date.now() <= deadline) {
-        if ((await this.screenState()).wallet) return;
+        const state = await this.screenState();
+        if (state.wallet && state.visible.has(TEST_IDS.walletAddress)) {
+          stableCaptures += 1;
+          if (stableCaptures >= 2) return;
+        } else {
+          stableCaptures = 0;
+        }
         await new Promise((resolve) => setTimeout(resolve, 250));
       }
       throw new Error('Mobile wallet home did not become visible before the readiness timeout.');

package/library/actions/shared/perps/visible-state.mjs

@@ -87,6 +87,7 @@ export function resolveVisibleStateOptions(node = {}) {
     maximumOrderCount: boundedInteger(node.maximum_order_count, 200, 0, 200, 'maximum_order_count'),
     minimumActivityCount: boundedInteger(node.minimum_activity_count, 0, 0, 200, 'minimum_activity_count'),
     requireNoHorizontalOverflow: node.require_no_horizontal_overflow === true,
+    requireNoControlOverlap: node.require_no_control_overlap === true,
     requireFeatures: stringList(node.require_features, 'require_features').map((feature) => {
       if (!FEATURES.has(feature)) {
         throw new Error(
@@ -132,6 +133,7 @@ function marketFromTestId(testId) {
   for (const prefix of ['perps-watchlist-', 'explore-markets-', 'perps-market-row-item-', 'market-row-']) {
     if (!testId.startsWith(prefix)) continue;
     const raw = testId.slice(prefix.length);
+    if (/(?:-token-logo|-asset-label)$/u.test(raw)) return undefined;
     if ((prefix === 'explore-markets-' || prefix === 'market-row-') && raw.startsWith('xyz-')) {
       return `XYZ:${raw.slice(4).toUpperCase()}`;
     }
@@ -142,6 +144,9 @@ function marketFromTestId(testId) {
 
 function classifySurface(route, testIds) {
   const joined = [...testIds].join('\n');
+  if (/confirm-transaction\/.*[?&]goBackTo=%2Fperps-home(?:&|$)/u.test(route)) {
+    return 'funds';
+  }
   if (/\/perps\/trade\//u.test(route)) {
     return 'order-entry';
   }
@@ -173,18 +178,19 @@ function compactEntries(items, maximum) {
 function visibleFeatures(items) {
   const ids = new Set(items.map((item) => item.testId));
   const has = (pattern) => [...ids].some((testId) => pattern.test(testId));
-  const long = has(/(?:long-cta-button|direction-long)$/u);
-  const short = has(/(?:short-cta-button|direction-short)$/u);
+  const long = has(/(?:long-cta-button|direction-long|market-details-long-button)$/u);
+  const short = has(/(?:short-cta-button|direction-short|market-details-short-button)$/u);
   return {
     activity: has(/^(?:transaction-card-|perps-(?:recent-activity|activity))/u),
-    balance: has(/^perps-balance-dropdown/u),
-    chart: has(/perps-(?:candlestick-chart|market-detail-chart|pro-market-chart)/u),
+    balance: has(/^(?:perps-balance-dropdown|perps-market-(?:balance-value|available-balance-text))/u),
+    chart: has(/^(?:chart_surface|tv_chart_container)$/u) ||
+      has(/perps-(?:candlestick-chart|market-detail-chart|market-details-fullscreen-chart|pro-market-chart)/u),
     'long-short': long && short,
     'market-list': has(/^(?:market-list-view|perps-market-list|perps-watchlist-|explore-markets-|market-row-)/u),
     'order-entry': has(/perps-(?:order-entry|pro-order-form)/u),
-    price: has(/perps-(?:market-detail-price|pro-market-price)$/u),
-    'price-change': has(/perps-(?:market-detail-change|pro-market-price-change)$/u),
-    stats: has(/perps-(?:stats-section|market-detail-oracle-price|pro-market-stats)/u),
+    price: has(/perps-(?:market-detail-price|market-header-price|pro-market-price)$/u),
+    'price-change': has(/perps-(?:market-detail-change|market-header-price-change|pro-market-price-change)$/u),
+    stats: has(/perps-(?:stats-section|market-details-market-summary|market-detail-oracle-price|pro-market-stats)/u),
   };
 }
 
@@ -213,20 +219,20 @@ export function normalizeVisiblePerpsState(raw, options, platform) {
     ...(route ? { route } : {}),
     ...(text(raw.title) ? { title: text(raw.title) } : {}),
     balance: compactEntries(
-      selected(unique, (item) => item.testId.startsWith('perps-balance-dropdown'), 1),
+      selected(unique, (item) => /^(?:perps-balance-dropdown|perps-market-balance-value)$/u.test(item.testId), 1),
       1,
     )[0] ?? null,
     markets: marketItems,
     positions: compactEntries(
-      selected(unique, (item) => /^(?:position-card-|perps-position-row-|perps-position-size-value$|perps-pro-market-position-row-)/u.test(item.testId), options.maxItems),
+      selected(unique, (item) => /^(?:position-card-(?!roe-)|perps-position-row-|perps-position-size-value$|perps-pro-market-position-row-|perps-home-position-card-)/u.test(item.testId), options.maxItems),
       options.maxItems,
     ),
     orders: compactEntries(
-      selected(unique, (item) => /^(?:order-card-|perps-order-row-)/u.test(item.testId), options.maxItems),
+      selected(unique, (item) => /^(?:order-card-|perps-order-row-|perps-home-order-card-)/u.test(item.testId), options.maxItems),
       options.maxItems,
     ),
     activity: compactEntries(
-      selected(unique, (item) => /^(?:transaction-card-|perps-activity-row-)/u.test(item.testId), options.maxItems),
+      selected(unique, (item) => /^(?:transaction-card-|transaction-item(?:-|$)|perps-activity-row-)/u.test(item.testId), options.maxItems),
       options.maxItems,
     ),
     orderEntry: raw.orderEntry && typeof raw.orderEntry === 'object' ? {
@@ -267,6 +273,16 @@ export function normalizeVisiblePerpsState(raw, options, platform) {
       clippedTestIds: Array.isArray(raw.layout.clippedTestIds)
         ? raw.layout.clippedTestIds.map(text).filter(Boolean).slice(0, 100)
         : [],
+      obscuredControlTestIds: Array.isArray(raw.layout.obscuredControlTestIds)
+        ? raw.layout.obscuredControlTestIds.map(text).filter(Boolean).slice(0, 100)
+        : [],
+      overlappingControlPairs: Array.isArray(raw.layout.overlappingControlPairs)
+        ? raw.layout.overlappingControlPairs
+          .filter((pair) => Array.isArray(pair) && pair.length === 2)
+          .map((pair) => pair.map(text))
+          .filter((pair) => pair.every(Boolean))
+          .slice(0, 100)
+        : [],
     } : null,
   };
   assertVisibleState(state, options);
@@ -279,6 +295,12 @@ function assertVisibleState(state, options) {
   )) {
     throw new Error(`Visible Perps layout overflows horizontally: ${JSON.stringify(state.layout)}.`);
   }
+  if (options.requireNoControlOverlap && (
+    !state.layout || state.layout.obscuredControlTestIds.length > 0 ||
+    state.layout.overlappingControlPairs.length > 0
+  )) {
+    throw new Error(`Visible Perps controls overlap: ${JSON.stringify(state.layout)}.`);
+  }
   if (options.surface !== 'auto' && state.surface !== options.surface) {
     throw new Error(
       `Expected visible Perps surface ${options.surface}, but observed ${state.surface}.`,

package/library/actions/shared/swap-bridge/visible-state.mjs

@@ -17,6 +17,8 @@ export function resolveVisibleSwapBridgeOptions(node = {}) {
     destinationSymbol: symbol(node.destination_symbol),
     requireAmountInputs: node.require_amount_inputs !== false,
     requireSettings: node.require_settings === true,
+    requireQuote: node.require_quote === true,
+    expectedSlippage: node.expected_slippage == null ? null : Number(node.expected_slippage),
   };
 }
 
@@ -42,6 +44,11 @@ function matchesSymbol(value, expected) {
     .test(String(value ?? '').toUpperCase());
 }
 
+function slippagePercent(value) {
+  const match = String(value ?? '').match(/(\d+(?:\.\d+)?)\s*%/u);
+  return match ? Number(match[1]) : Number.NaN;
+}
+
 export function normalizeVisibleSwapBridgeState(raw, options, platform) {
   const items = [...(raw.items ?? []), ...(raw.offscreenItems ?? [])]
     .map(normalizedItem)
@@ -55,6 +62,7 @@ export function normalizeVisibleSwapBridgeState(raw, options, platform) {
   const settings = byId.get(platform === 'extension' ? 'bridge__header-settings-button' : 'bridge-slippage-settings-button');
   const noQuotes = byId.get(platform === 'extension' ? 'prepare-swap-page-error' : 'bridge-no-quotes');
   const missingPrice = byId.get(platform === 'extension' ? 'bridge-missing-price-banner' : 'bridge-missing-price-banner');
+  const slippage = byId.get(platform === 'extension' ? 'slippage-edit-button' : 'edit-slippage-button');
   const state = {
     source: 'visible-ui',
     platform,
@@ -65,6 +73,7 @@ export function normalizeVisibleSwapBridgeState(raw, options, platform) {
     destinationAsset,
     sourceAmount: text(sourceInput?.value ?? sourceInput?.label) ?? null,
     destinationAmount: text(destinationInput?.value ?? destinationInput?.label) ?? null,
+    slippage: text(raw.slippage ?? raw.quote?.slippage ?? slippage?.value ?? slippage?.label) ?? null,
     controls: unique.slice(0, 100),
     features: {
       'amount-inputs': Boolean(sourceInput && destinationInput),
@@ -88,6 +97,12 @@ function assertVisibleSwapBridgeState(state, options) {
   if (options.requireSettings && !state.features.settings) {
     throw new Error('Visible Swap settings control was not observed.');
   }
+  if (options.requireQuote && !(Number(state.destinationAmount) > 0)) {
+    throw new Error('Visible Swap quote did not contain a positive destination amount.');
+  }
+  if (options.expectedSlippage !== null && slippagePercent(state.slippage) !== options.expectedSlippage) {
+    throw new Error(`Expected visible Swap slippage ${options.expectedSlippage}%, but observed ${JSON.stringify(state.slippage)}.`);
+  }
   if (!matchesSymbol(state.sourceAsset, options.sourceSymbol)) {
     throw new Error(`Expected visible Swap source ${options.sourceSymbol}, but observed ${JSON.stringify(state.sourceAsset)}.`);
   }