@deeeed/metamask-harness 0.38.0 → 0.39.0

package/library/recipes/swap-bridge/release-custom-slippage.recipe.json

@@ -7,14 +7,14 @@
     "additionalProperties": false,
     "properties": {
       "source_symbol": { "type": "string", "default": "ETH" },
-      "destination_symbol": { "type": "string", "default": "WETH" },
-      "source_chain": { "type": "string", "default": "eip155:1" },
-      "destination_chain": { "type": "string", "default": "eip155:1" },
+      "destination_symbol": { "type": "string", "default": "USDC" },
+      "source_chain": { "type": "string", "default": "eip155:42161" },
+      "destination_chain": { "type": "string", "default": "eip155:42161" },
       "source_query": { "type": "string", "default": "ETH" },
-      "destination_query": { "type": "string", "default": "WETH" },
+      "destination_query": { "type": "string", "default": "USDC" },
       "source_asset_id": { "type": "string", "default": "" },
       "destination_asset_id": { "type": "string", "default": "" },
-      "amount": { "type": "number", "minimum": 0.00000001, "default": 0.0001 },
+      "amount": { "type": "number", "minimum": 0.00000001, "default": 0.002 },
       "slippage": { "type": "number", "minimum": 0.01, "default": 3 },
       "timeout_ms": { "type": "integer", "minimum": 1000, "default": 60000 }
     }
@@ -67,14 +67,6 @@
         "require_quote": true,
         "expected_slippage": "{{params.slippage}}",
         "intent": "Prove the live quote retains the custom slippage value",
-        "next": "wait-for-quote-display"
-      },
-      "wait-for-quote-display": {
-        "action": "ui.wait_for",
-        "test_id": "minimum-received",
-        "expected": "visible",
-        "timeout_ms": "{{params.timeout_ms}}",
-        "intent": "Confirm the refreshed quote is visible",
         "next": "capture-quote"
       },
       "capture-quote": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.38.0",
+  "version": "0.39.0",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"

package/scripts/validate-release-report.mjs

@@ -106,23 +106,20 @@ for (const entry of verdictCases) {
       ];
       for (const required of requiredDocuments) {
         const requiredPath = path.join(resolved, required);
-        if (!fs.existsSync(requiredPath)) {
+        const requiredDocument = readRegularJsonFile(requiredPath);
+        if (requiredDocument.status === 'missing') {
           errors.push(`${entry.id ?? '<missing-id>'} evidence directory is missing ${required}: ${resolved}`);
           continue;
         }
-        const requiredStat = fs.lstatSync(requiredPath);
-        if (requiredStat.isSymbolicLink() || !requiredStat.isFile()) {
+        if (requiredDocument.status === 'unsafe') {
           errors.push(`${entry.id ?? '<missing-id>'} evidence directory ${required} must be a regular file: ${resolved}`);
           continue;
         }
-        let document;
-        try {
-          document = JSON.parse(fs.readFileSync(requiredPath, 'utf8'));
-        } catch {
+        if (requiredDocument.status === 'invalid') {
           errors.push(`${entry.id ?? '<missing-id>'} evidence directory ${required} must contain valid JSON: ${resolved}`);
           continue;
         }
-        documents[required] = document;
+        documents[required] = requiredDocument.value;
       }
       if (documents['summary.json'] && entry.status === 'PASS' && documents['summary.json'].status !== 'pass') {
         errors.push(`${entry.id ?? '<missing-id>'} PASS evidence summary.json must have status pass: ${resolved}`);
@@ -216,6 +213,24 @@ function readJson(file, label) {
   }
 }
 
+function readRegularJsonFile(file) {
+  let descriptor;
+  try {
+    descriptor = fs.openSync(file, fs.constants.O_RDONLY | (fs.constants.O_NOFOLLOW ?? 0));
+    if (!fs.fstatSync(descriptor).isFile()) return { status: 'unsafe' };
+    const contents = fs.readFileSync(descriptor, 'utf8');
+    try {
+      return { status: 'ok', value: JSON.parse(contents) };
+    } catch {
+      return { status: 'invalid' };
+    }
+  } catch (error) {
+    return { status: error?.code === 'ENOENT' ? 'missing' : 'unsafe' };
+  } finally {
+    if (descriptor !== undefined) fs.closeSync(descriptor);
+  }
+}
+
 function duplicates(values) {
   const seen = new Set();
   const repeated = new Set();
@@ -259,11 +274,10 @@ function readResolvedRecipes(root, resolution, caseId, validationErrors) {
     if (!fs.existsSync(artifactPath)) continue;
     const canonicalArtifact = fs.realpathSync(artifactPath);
     if (!canonicalArtifact.startsWith(`${canonicalRoot}${path.sep}`)) continue;
-    const stat = fs.lstatSync(artifactPath);
-    if (stat.isSymbolicLink() || !stat.isFile()) continue;
-    try {
-      recipes[digest] = JSON.parse(fs.readFileSync(artifactPath, 'utf8'));
-    } catch {
+    const recipe = readRegularJsonFile(artifactPath);
+    if (recipe.status === 'ok') {
+      recipes[digest] = recipe.value;
+    } else if (recipe.status === 'invalid') {
       validationErrors.push(`${caseId} evidence directory resolved recipe must contain valid JSON: ${artifactPath}`);
     }
   }
@@ -294,7 +308,7 @@ function renderMarkdown(verdicts, inventoryCases, counts, releaseStatus) {
 }
 
 function escapeTable(value) {
-  return String(value).replace(/\|/gu, '\\|').replace(/\s+/gu, ' ').trim();
+  return String(value).replace(/\\/gu, '\\\\').replace(/\|/gu, '\\|').replace(/\s+/gu, ' ').trim();
 }
 
 function parseArgs(argv) {