@deeeed/metamask-harness 0.3.6 → 0.3.8

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # Changelog
 
+## 0.3.8 - 2026-07-04
+
+### Fixed
+- **Mobile launch streams progress in  mode** — mobile prepare leaves now run through , which tees the child's stdout+stderr to the parent's stderr live while stdout stays reserved for the JSON envelope. A multi-minute {
+  "schemaVersion": 1,
+  "command": "launch",
+  "status": "fail",
+  "exitCode": 2,
+  "error": {
+    "code": "USAGE",
+    "message": "could not detect the MetaMask repo type for /private/tmp/claude-501/-Users-deeeed-dev-metamask-principal-pitch-2025/4645d206-3e7f-482d-a5c1-2274f26a7411/scratchpad/emh-review",
+    "userAction": "cd into a MetaMask checkout or pass --target <path>, or force it with --adapter <mobile|extension|core>"
+  }
+} is no longer silent (previously  buffered leaf output and suppressed it entirely under ). Contract test asserts leaf progress reaches stderr, the envelope stays clean, and the streaming conversion preserves the exit-code contract.
+
+## 0.3.7 - 2026-07-04
+
+### Fixed
+- **Overlay install manifest no longer advertises the retired `launch.sh`/`live.sh`** — mobile launch/live orchestration is in-process now (`mm-harness launch`), and `install_v1_runner_assets` deletes `scripts/launch.sh` and `scripts/live.sh` on both install paths. The product-owned/metadata-only manifest already advertised `verify` only, but the overlay manifest's `runtimeHelpers` still listed `launch: scripts/launch.sh` and `live: scripts/live.sh` — paths the same install had just removed, a manifest that pointed at nonexistent files. The overlay manifest now advertises `verify` only, matching the product-owned path. A new manifest-honesty contract check in `tests/contract/mobile-inject.test.sh` asserts every advertised `runtimeHelpers` path exists on disk and that `launch`/`live` are not advertised, for both the product-owned and a full overlay install, so this cannot recur in either mode.
+
 ## 0.3.6 - 2026-07-04
 
 ### Fixed

package/adapters/mobile/inject.sh

@@ -669,9 +669,12 @@ node -e '
     protocolVersion: "v1",
     actionManifestPath: harnessRel + "/action-manifest.json",
     runnerEntrypoint: harnessRel + "/runner/bin/mm-harness",
+    // launch/live orchestration is in-process (mm-harness launch); only verify
+    // remains a shell helper. install_v1_runner_assets deletes scripts/launch.sh
+    // and scripts/live.sh, so advertising them here would be a manifest that
+    // points at files this same install removed. Keep this in sync with the
+    // product-owned block above (verify only).
     runtimeHelpers: {
-      launch: harnessRel + "/scripts/launch.sh",
-      live: harnessRel + "/scripts/live.sh",
       verify: harnessRel + "/scripts/verify.sh"
     },
     installedPaths: [harnessRel + "/runner", harnessRel + "/scripts", harnessRel + "/action-manifest.json", "app/dev-tools/AgenticService"],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.3.6",
+  "version": "0.3.8",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"

package/src/adapters/mobile/prepare.ts

@@ -7,7 +7,7 @@
 
 import path from 'node:path';
 
-import { EXIT, spawnScript } from '../../commands/shared.ts';
+import { EXIT, spawnScriptStreaming } from '../../commands/shared.ts';
 import type { ScriptResult } from '../../commands/shared.ts';
 import { runnerDir } from '../../paths.ts';
 import {
@@ -27,7 +27,11 @@ export { type MobileRuntimeDecisionReport };
 const POD_PROBE_ENV: Record<string, string> = { FORCE_COLOR: '0', NO_COLOR: '1' };
 
 export interface PrepareMobileOptions extends MobileRuntimeDecisionOptions {
-  /** Pass through to leaf-script spawnScript calls so output is suppressed in --json mode. */
+  /**
+   * Whether the caller emits a --json envelope on stdout. Leaf progress always
+   * streams to stderr (see dispatchAction/spawnScriptStreaming); this only gates
+   * the in-process teaching messages so they never pollute the stdout envelope.
+   */
   json?: boolean;
   /**
    * Passed to open-device.sh --preflight-mode.
@@ -106,7 +110,7 @@ export async function prepareMobile(
       )
     : report.actions;
   for (const action of actions) {
-    const result = dispatchAction(action, target, platform, json, preflightMode);
+    const result = await dispatchAction(action, target, platform, json, preflightMode);
     if (result.status !== 0) return result;
   }
 
@@ -132,13 +136,13 @@ export async function prepareMobile(
       }
       case 'ready': {
         // Deps resolved and runtime appears ready — still confirm bridge is live.
-        const bridge = dispatchAction({ id: 'wait-for-bridge', cwd: target }, target, platform, json, preflightMode);
+        const bridge = await dispatchAction({ id: 'wait-for-bridge', cwd: target }, target, platform, json, preflightMode);
         if (bridge.status !== 0) return bridge;
         break;
       }
       case 'launch': {
         for (const action of postInstall.actions) {
-          const result = dispatchAction(action, target, platform, json, preflightMode);
+          const result = await dispatchAction(action, target, platform, json, preflightMode);
           if (result.status !== 0) return result;
         }
         break;
@@ -157,51 +161,53 @@ export async function prepareMobile(
   return { status: 0, output: '' };
 }
 
-function dispatchAction(
+// Long-running leaves stream their output to stderr live (spawnScriptStreaming),
+// so the multi-minute prepare phase is not silent; stdout stays reserved for the
+// caller's --json envelope. Async so the parent can await each leaf in sequence.
+async function dispatchAction(
   action: { id: string; argv?: string[]; cwd?: string },
   target: string,
   platform: string,
   json: boolean,
   preflightMode = 'fast',
-): ScriptResult {
+): Promise<ScriptResult> {
   const cwd = action.cwd ?? target;
   switch (action.id) {
     case 'yarn-setup': {
       // Leaf: install node_modules (deps missing or stale); `yarn setup` runs pods.
       const leaf = path.join(runnerDir, 'adapters/mobile/yarn-setup.sh');
-      return spawnScript(leaf, ['--target', cwd], target, json, POD_PROBE_ENV);
+      return spawnScriptStreaming(leaf, ['--target', cwd], target, POD_PROBE_ENV);
     }
     case 'start-metro': {
       // Leaf: ensure Metro is running; argv may carry --clear for cache reset.
       const leaf = path.join(runnerDir, 'adapters/mobile/start-metro.sh');
       const extra: string[] = action.argv ?? [];
-      return spawnScript(leaf, ['--target', cwd, ...extra], target, json);
+      return spawnScriptStreaming(leaf, ['--target', cwd, ...extra], target);
     }
     case 'prewarm-bundle': {
       // Leaf: curl the bundle URL before opening the dev client.
       const leaf = path.join(runnerDir, 'adapters/mobile/prewarm-bundle.sh');
-      return spawnScript(leaf, ['--platform', platform, '--target', cwd], target, json);
+      return spawnScriptStreaming(leaf, ['--platform', platform, '--target', cwd], target);
     }
     case 'wait-for-bridge': {
       // Leaf: poll CDP bridge until a route target registers.
       const leaf = path.join(runnerDir, 'adapters/mobile/wait-for-bridge.sh');
-      return spawnScript(leaf, ['--target', cwd], target, json);
+      return spawnScriptStreaming(leaf, ['--target', cwd], target);
     }
     case 'clear-metro-cache': {
       // Legacy alias for start-metro --clear (kept for backward compat).
       const leaf = path.join(runnerDir, 'adapters/mobile/start-metro.sh');
-      return spawnScript(leaf, ['--target', cwd, '--clear'], target, json);
+      return spawnScriptStreaming(leaf, ['--target', cwd, '--clear'], target);
     }
     case 'launch-mobile-runtime': {
       // Leaf: open the MetaMask Mobile dev client on the simulator/device. In
       // auto/rebuild modes this runs the native build (`yarn start:*`), which
       // triggers pod install — pass the pod-probe env so it stays FORCE_COLOR-safe.
       const leaf = path.join(runnerDir, 'adapters/mobile/open-device.sh');
-      return spawnScript(
+      return spawnScriptStreaming(
         leaf,
         ['--platform', platform, '--target', cwd, '--preflight-mode', preflightMode],
         target,
-        json,
         POD_PROBE_ENV,
       );
     }

package/src/commands/shared.ts

@@ -7,7 +7,7 @@
 //   For node invocations (bin === process.execPath) the stem is derived from the
 //   script path in args[0], e.g. MM_HARNESS_SCRIPT_BIN_OPEN_DEBUG_MJS.
 
-import { spawnSync } from 'node:child_process';
+import { spawn, spawnSync } from 'node:child_process';
 import path from 'node:path';
 
 import { detectAdapter } from '../harness.ts';
@@ -151,6 +151,67 @@ export function spawnScript(
   return { status: result.status ?? 1, output };
 }
 
+// Streaming variant of spawnScript for long-running leaves (mobile prepare:
+// native build + Metro + health-bridge poll, minutes long). spawnScript buffers
+// via spawnSync and, in --json mode, suppresses output entirely — so those leaves
+// run with zero feedback until exit. This tees the child's stdout+stderr to the
+// parent's STDERR live (so the --json envelope on stdout stays clean) while still
+// capturing the combined output for heal classification. Same seam, leaf-invoke
+// resolution, missing-leaf pre-check, and spawn-error contract as spawnScript.
+export function spawnScriptStreaming(
+  script: string,
+  args: string[],
+  cwd: string,
+  env?: Record<string, string>,
+): Promise<ScriptResult> {
+  const isNodeScript = script === process.execPath && args.length > 0;
+  const stem = isNodeScript
+    ? path.basename(args[0]).replace(/[^A-Za-z0-9]/gu, '_').toUpperCase()
+    : path.basename(script).replace(/[^A-Za-z0-9]/gu, '_').toUpperCase();
+  const override = process.env[`MM_HARNESS_SCRIPT_BIN_${stem}`];
+  const bin = override ?? script;
+  const directArgs = override !== undefined && isNodeScript ? args.slice(1) : args;
+
+  if (shellLeafMissing(bin)) {
+    const message =
+      `leaf could not start: ${path.basename(bin)} (ENOENT)\n` +
+      `  Next: reinstall mm-harness (npm i -g @deeeed/metamask-harness) — the shell leaf is missing or not executable`;
+    process.stderr.write(`${message}\n`);
+    return Promise.resolve({ status: 1, output: message });
+  }
+
+  const { bin: invokeBin, args: spawnArgs } = resolveLeafInvoke(bin, directArgs);
+  return new Promise<ScriptResult>((resolve) => {
+    const child = spawn(invokeBin, spawnArgs, {
+      cwd,
+      env: env ? { ...process.env, ...env } : process.env,
+      stdio: ['ignore', 'pipe', 'pipe'],
+    });
+    let output = '';
+    // Route BOTH child streams to the parent's stderr, live: stdout is reserved
+    // for the harness --json envelope, so all human/leaf progress goes to stderr.
+    const tee = (chunk: Buffer): void => {
+      const text = chunk.toString('utf8');
+      output += text;
+      process.stderr.write(text);
+    };
+    child.stdout?.on('data', tee);
+    child.stderr?.on('data', tee);
+    child.on('error', (error: NodeJS.ErrnoException) => {
+      const leaf = isNodeScript ? path.basename(args[0]) : path.basename(script);
+      const code = error.code ?? 'ESPAWN';
+      const message =
+        `leaf could not start: ${leaf} (${code})\n` +
+        `  Next: reinstall mm-harness (npm i -g @deeeed/metamask-harness) — the shell leaf is missing or not executable`;
+      process.stderr.write(`${message}\n`);
+      resolve({ status: 1, output: message });
+    });
+    child.on('close', (status) => {
+      resolve({ status: status ?? 1, output });
+    });
+  });
+}
+
 // Both escapes from a failed repo-type detection (defined at the detection source
 // in harness.ts): where to run it (checkout/target) and how to force it (adapter).
 export { ADAPTER_DETECT_NEXT } from '../harness.ts';