@deeeed/metamask-harness 0.3.5 → 0.3.7

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.3.7 - 2026-07-04
+
+### Fixed
+- **Overlay install manifest no longer advertises the retired `launch.sh`/`live.sh`** — mobile launch/live orchestration is in-process now (`mm-harness launch`), and `install_v1_runner_assets` deletes `scripts/launch.sh` and `scripts/live.sh` on both install paths. The product-owned/metadata-only manifest already advertised `verify` only, but the overlay manifest's `runtimeHelpers` still listed `launch: scripts/launch.sh` and `live: scripts/live.sh` — paths the same install had just removed, a manifest that pointed at nonexistent files. The overlay manifest now advertises `verify` only, matching the product-owned path. A new manifest-honesty contract check in `tests/contract/mobile-inject.test.sh` asserts every advertised `runtimeHelpers` path exists on disk and that `launch`/`live` are not advertised, for both the product-owned and a full overlay install, so this cannot recur in either mode.
+
+## 0.3.6 - 2026-07-04
+
+### Fixed
+- **Install manifest carries target checkout identity (`targetRevision`)** — `adapters/mobile/inject.sh` stamps the target repo's `HEAD` (resolved once, up front, via `git rev-parse --verify HEAD`) and an explicit `installMode` into the mobile install manifest on both install paths (product-owned/metadata-only and overlay). Consumers (the farm recipe hook) can now gate their fast path on manifest identity matching the current checkout instead of manifest existence, closing the stale-manifest hole where a gitignored manifest survives a branch switch to a bridge-less checkout. Install now fails with teaching guidance when the target `HEAD` cannot be resolved (not-a-repo, unborn branch), instead of stamping an unusable `targetRevision`. Contract tests cover the identity stamp on both paths and the unborn-HEAD refusal.
+
 ## 0.3.5 - 2026-07-04
 
 ### Fixed

package/adapters/mobile/inject.sh

@@ -60,6 +60,19 @@ if ! command -v harness_root >/dev/null 2>&1; then
   exit 1
 fi
 TARGET="$(cd "$TARGET" && pwd)"
+# The install stamps this checkout's HEAD into the manifest as its identity. If we
+# cannot resolve it (not a git repo, unborn HEAD, git unavailable) we must not
+# install with an unidentifiable target: a downstream consumer could not tell a
+# stale manifest (left behind by a previous branch/tag) from a current one. Fail
+# loud with escape guidance rather than stamping an "unknown" revision.
+# --verify fails cleanly (no stdout) on an unborn HEAD, where plain `rev-parse
+# HEAD` would echo the literal "HEAD" and slip past the emptiness check below.
+TARGET_REV="$(git -C "$TARGET" rev-parse --verify HEAD 2>/dev/null || true)"
+if [ -z "$TARGET_REV" ]; then
+  echo "Refusing mobile recipe harness install: cannot resolve the target checkout HEAD in $TARGET." >&2
+  echo "Next: ensure the target is a git checkout with at least one commit (git -C \"$TARGET\" rev-parse HEAD succeeds), then retry the install." >&2
+  exit 1
+fi
 METAMASK_RUNNER_DIR="$RUNNER_DIR"
 METAMASK_RUNNER_SOURCE_KIND="runner-self"
 METAMASK_RUNNER_REVISION="$(git -C "$RUNNER_DIR" rev-parse HEAD 2>/dev/null || echo unknown)"
@@ -272,10 +285,11 @@ if [ "$FORCE_OVERLAY" = false ] && has_product_owned_mobile_harness; then
   fi
   node -e '
     const fs = require("fs");
-    const [runnerOwnerDir, runnerOwnerRevision, runnerDir, runnerRevision, runnerSourceKind, adapterRuntime, target, scriptDir, manifestPath, harnessRoot, harnessRel, cleanupCommand] = process.argv.slice(1);
+    const [runnerOwnerDir, runnerOwnerRevision, runnerDir, runnerRevision, runnerSourceKind, adapterRuntime, target, scriptDir, manifestPath, harnessRoot, harnessRel, cleanupCommand, targetRevision] = process.argv.slice(1);
     const m = {
       adapter: "mobile",
       installMode: "product-owned",
+      targetRevision,
       installedAt: new Date().toISOString(),
       source: {
         runnerOwnerDir,
@@ -308,7 +322,7 @@ if [ "$FORCE_OVERLAY" = false ] && has_product_owned_mobile_harness; then
       note: "This checkout already contains the Mobile in-app bridge. Runner install only writes recipe-harness metadata and must not overwrite tracked in-app bridge files."
     };
     fs.writeFileSync(manifestPath, JSON.stringify(m, null, 2) + "\n");
-  ' "$RUNNER_DIR" "$SOURCE_REV" "$METAMASK_RUNNER_DIR" "$METAMASK_RUNNER_REVISION" "$METAMASK_RUNNER_SOURCE_KIND" "$ADAPTER_DIR" "$TARGET" "$SCRIPT_DIR" "$HARNESS_DIR/manifest.json" "$HARNESS_ROOT" "$HARNESS_REL" "$CLEANUP_COMMAND"
+  ' "$RUNNER_DIR" "$SOURCE_REV" "$METAMASK_RUNNER_DIR" "$METAMASK_RUNNER_REVISION" "$METAMASK_RUNNER_SOURCE_KIND" "$ADAPTER_DIR" "$TARGET" "$SCRIPT_DIR" "$HARNESS_DIR/manifest.json" "$HARNESS_ROOT" "$HARNESS_REL" "$CLEANUP_COMMAND" "$TARGET_REV"
   echo "Installed mobile recipe harness metadata only (in-app bridge detected): $HARNESS_DIR/manifest.json"
   exit 0
 fi
@@ -637,9 +651,11 @@ SOURCE_REV="$(git -C "$RUNNER_DIR" rev-parse HEAD 2>/dev/null || echo unknown)"
 CLEANUP_COMMAND="RECIPE_HARNESS_ROOT=$HARNESS_ROOT $(printf '%q' "$CLEANUP_SH") --target $(printf '%q' "$TARGET")"
 node -e '
   const fs = require("fs");
-  const [runnerOwnerDir, runnerOwnerRevision, runnerDir, runnerRevision, runnerSourceKind, adapterRuntime, target, backupDir, scriptDir, manifestPath, mobileAgenticSource, harnessRoot, harnessRel, cleanupCommand] = process.argv.slice(1);
+  const [runnerOwnerDir, runnerOwnerRevision, runnerDir, runnerRevision, runnerSourceKind, adapterRuntime, target, backupDir, scriptDir, manifestPath, mobileAgenticSource, harnessRoot, harnessRel, cleanupCommand, targetRevision] = process.argv.slice(1);
   const m = {
     adapter: "mobile",
+    installMode: "overlay",
+    targetRevision,
     installedAt: new Date().toISOString(),
     source: {
       runnerOwnerDir,
@@ -653,9 +669,12 @@ node -e '
     protocolVersion: "v1",
     actionManifestPath: harnessRel + "/action-manifest.json",
     runnerEntrypoint: harnessRel + "/runner/bin/mm-harness",
+    // launch/live orchestration is in-process (mm-harness launch); only verify
+    // remains a shell helper. install_v1_runner_assets deletes scripts/launch.sh
+    // and scripts/live.sh, so advertising them here would be a manifest that
+    // points at files this same install removed. Keep this in sync with the
+    // product-owned block above (verify only).
     runtimeHelpers: {
-      launch: harnessRel + "/scripts/launch.sh",
-      live: harnessRel + "/scripts/live.sh",
       verify: harnessRel + "/scripts/verify.sh"
     },
     installedPaths: [harnessRel + "/runner", harnessRel + "/scripts", harnessRel + "/action-manifest.json", "app/dev-tools/AgenticService"],
@@ -669,7 +688,7 @@ node -e '
     ]
   };
   fs.writeFileSync(manifestPath, JSON.stringify(m, null, 2) + "\n");
-' "$RUNNER_DIR" "$SOURCE_REV" "$METAMASK_RUNNER_DIR" "$METAMASK_RUNNER_REVISION" "$METAMASK_RUNNER_SOURCE_KIND" "$ADAPTER_DIR" "$TARGET" "$BACKUP_DIR" "$SCRIPT_DIR" "$HARNESS_DIR/manifest.json" "${MOBILE_AGENTIC_SOURCE:-}" "$HARNESS_ROOT" "$HARNESS_REL" "$CLEANUP_COMMAND"
+' "$RUNNER_DIR" "$SOURCE_REV" "$METAMASK_RUNNER_DIR" "$METAMASK_RUNNER_REVISION" "$METAMASK_RUNNER_SOURCE_KIND" "$ADAPTER_DIR" "$TARGET" "$BACKUP_DIR" "$SCRIPT_DIR" "$HARNESS_DIR/manifest.json" "${MOBILE_AGENTIC_SOURCE:-}" "$HARNESS_ROOT" "$HARNESS_REL" "$CLEANUP_COMMAND" "$TARGET_REV"
 
 ENSURE_DEPS="$SCRIPT_DIR/../shared/ensure-runner-deps.sh"
 if [ -f "$ENSURE_DEPS" ]; then

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.3.5",
+  "version": "0.3.7",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"