@deeeed/metamask-harness 0.3.3 → 0.3.4

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.3.4 - 2026-07-04
+
+### Fixed
+- **IMP-24: published tarball stripped exec bits from shell leaves** — the harness execs `adapters/**/*.sh` leaves directly, but six shipped leaves (`adapters/mobile/lib/metro-listener.sh`, `adapters/shared/activate-repo-node.sh`, `cli-ux.sh`, `harness-path.sh`, `hash-helpers.sh`, `resolve-farmslot-ports.sh`) were committed without the git exec bit (mode `100644`), so npm packed them `644`. A fresh `npm i -g` then hit `EACCES` on the first leaf. All shipped `*.sh` are now stored `100755` in git, so the published tarball packs them executable. Added contract test `tests/contract/packaging-exec-bits.test.sh` — it runs `npm pack` to produce the actual `.tgz`, then asserts via `tar tzvf` that every shipped `*.sh` entry has owner-execute set; fails with the offending path(s) if any is `644`, so this cannot silently regress.
+- **IMP-24: spawn failures are surfaced, not swallowed** — `spawnScript` returned on `result.error` (a leaf that is missing/`ENOENT` or not executable/`EACCES`) before its human-mode stderr forward, so a leaf that could not start produced a silent exit-1 (surfaced upstream as `MOBILE_PREPARE_FAILED`). The `result.error` branch now always writes a teaching diagnostic (`leaf could not start: <leaf> (<errno>)` + a `Next: reinstall mm-harness` hint) to stderr before returning. Covered by `tests/contract/spawn-error-surfaced.test.sh`.
+
 ## 0.3.3 - 2026-07-04
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.3.3",
+  "version": "0.3.4",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"

package/src/commands/shared.ts

@@ -120,7 +120,17 @@ export function spawnScript(
     maxBuffer: 64 * 1024 * 1024,
   });
   if (result.error) {
-    return { status: 1, output: `script could not start (${path.basename(script)}): ${result.error.message}` };
+    // A spawn failure (EACCES on a non-executable leaf, ENOENT on a missing one)
+    // is otherwise silent because the human-mode stderr forward below is skipped
+    // on early return. Always emit the diagnostic so a leaf that can't start is
+    // never a mystery exit-1. For node invocations the leaf is args[0], not node.
+    const leaf = isNodeScript ? path.basename(args[0]) : path.basename(script);
+    const code = (result.error as NodeJS.ErrnoException).code ?? 'ESPAWN';
+    const message =
+      `leaf could not start: ${leaf} (${code})\n` +
+      `  Next: reinstall mm-harness (npm i -g @deeeed/metamask-harness) — the shell leaf is missing or not executable`;
+    process.stderr.write(`${message}\n`);
+    return { status: 1, output: message };
   }
   const output = `${result.stdout ?? ''}${result.stderr ?? ''}`;
   if (!json && output) process.stderr.write(output);