@deeeed/metamask-harness 0.26.2 → 0.26.4

package/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 ## Unreleased
 
+## 0.26.4 - 2026-07-31
+
+### Fixed
+
+- Forward Mobile verify's resolved Metro port into nested recipe runs so an older runtime context cannot redirect live bridge checks to another slot.
+
+## 0.26.3 - 2026-07-31
+
+### Fixed
+
+- Stop the verified detached analytics collector with its owning harness runtime instead of leaving an idle process behind.
+
 ## 0.26.2 - 2026-07-31
 
 ### Fixed

package/adapters/mobile/verify.sh

@@ -321,7 +321,7 @@ JSON
     cd "$TARGET"
     device_args=()
     [ -n "$device_target" ] && device_args=(--device "$device_target")
-    "$RUNNER_BIN" run "$ARTIFACTS/mobile-status-smoke.recipe.json" --adapter mobile --target "$TARGET" "${device_args[@]}" --artifacts-dir "$ARTIFACTS/runner-status-smoke" --json
+    "$RUNNER_BIN" run "$ARTIFACTS/mobile-status-smoke.recipe.json" --adapter mobile --target "$TARGET" "${device_args[@]}" --watcher-port "$port" --artifacts-dir "$ARTIFACTS/runner-status-smoke" --json
   ) > "$log_path" 2>&1
 }
 
@@ -351,6 +351,13 @@ EOF
 }
 
 if [ "$STATIC_ONLY" = false ]; then
+  port="$(watcher_port)"
+  # Reject a non-numeric port before it reaches runner arguments or the
+  # port-holder shell probe.
+  case "$port" in
+    ""|*[!0-9]*) echo "Refusing mobile verify: resolved watcher port is not numeric: '$port' (check WATCHER_PORT)" >&2; exit 2 ;;
+  esac
+
   device_target="$(mobile_device_target)"
   if [ -z "$device_target" ]; then
     if [ "$PLATFORM" = "android" ]; then
@@ -376,13 +383,6 @@ if [ "$STATIC_ONLY" = false ]; then
   add_note "$fixture_message"
   checks+=("$fixture_check_json")
 
-  port="$(watcher_port)"
-  # Reject a non-numeric port before it is interpolated into a shell command
-  # (port_holder_json runs `lsof -iTCP:${port}`). The .env path is regex-guarded,
-  # but the WATCHER_PORT env path is not, so validate here.
-  case "$port" in
-    ""|*[!0-9]*) echo "Refusing mobile verify: resolved watcher port is not numeric: '$port' (check WATCHER_PORT)" >&2; exit 2 ;;
-  esac
   port_holder_json "$port" > "$ARTIFACTS/logs/port-holder.json"
 
   cat > "$ARTIFACTS/mobile-v1-live-smoke.recipe.json" <<'JSON'
@@ -411,7 +411,7 @@ JSON
     IOS_SIMULATOR="${IOS_SIMULATOR:-$ios_simulator_resolved}" \
     ADB_SERIAL="${ADB_SERIAL:-$adb_serial_resolved}" \
     ANDROID_SERIAL="${ANDROID_SERIAL:-$adb_serial_resolved}" \
-    "$RUNNER_BIN" run "$ARTIFACTS/mobile-v1-live-smoke.recipe.json" --adapter mobile --target "$TARGET" "${device_args[@]}" --artifacts-dir "$ARTIFACTS/runner-live-smoke" --json
+    "$RUNNER_BIN" run "$ARTIFACTS/mobile-v1-live-smoke.recipe.json" --adapter mobile --target "$TARGET" "${device_args[@]}" --watcher-port "$port" --artifacts-dir "$ARTIFACTS/runner-live-smoke" --json
   ) > "$ARTIFACTS/logs/runner-live-smoke.log" 2>&1; then
     checks+=("{\"name\":\"runner v1 live bridge smoke\",\"status\":\"pass\"}")
   else

package/dist/commands/stop.js

@@ -1,6 +1,7 @@
 import { color } from "../cli-color.js";
 import { getAdapterSurface } from "../adapters/surface.js";
 import { usageOut } from "./shared.js";
+import { stopProjectCollector } from "../../library/actions/shared/analytics/collector.mjs";
 import {
   parseArgs,
   optionFlag,
@@ -23,6 +24,9 @@ async function handleStop(argv) {
   if (stop.kind === "headless") {
     return usageOut(json, "stop", stop.message, stop.userAction);
   }
+  const collector = await stopProjectCollector(target);
+  const signalled = (stop.signalled ?? 0) + (collector.stopped ? 1 : 0);
+  const summary = collector.stopped ? `${stop.summary}; stopped analytics collector ${collector.pid}` : stop.summary;
   const next = adapter === "extension" ? `${surface.hints.launch} --target ${shellQuote(target)}` : void 0;
   const userAction = `mm-harness status --target ${shellQuote(target)} --json`;
   if (json) {
@@ -34,10 +38,10 @@ async function handleStop(argv) {
           adapter,
           target,
           status: stop.status === 0 ? "pass" : "fail",
-          ...stop.signalled !== void 0 ? { signalled: stop.signalled } : {},
+          ...stop.signalled !== void 0 || collector.stopped ? { signalled } : {},
           exitCode: stop.status,
           ...stop.output ? { output: stop.output } : {},
-          ...stop.status === 0 ? next ? { next } : {} : { error: { code: "DEV_SERVER_STOP_FAILED", message: stop.summary, userAction } }
+          ...stop.status === 0 ? next ? { next } : {} : { error: { code: "DEV_SERVER_STOP_FAILED", message: summary, userAction } }
         },
         null,
         2
@@ -46,7 +50,7 @@ async function handleStop(argv) {
   } else {
     if (stop.output) process.stderr.write(`${stop.output}
 `);
-    console.error(`${color(stop.status === 0 ? "ok" : "err", stop.status === 0 ? "\u2713" : "\u2717")} ${stop.summary}`);
+    console.error(`${color(stop.status === 0 ? "ok" : "err", stop.status === 0 ? "\u2713" : "\u2717")} ${summary}`);
     if (stop.status !== 0 || next) console.error(`  Next: ${stop.status === 0 ? next : userAction}`);
   }
   return stop.status;

package/library/actions/shared/analytics/collector.mjs

@@ -268,6 +268,22 @@ async function stopCollector(state) {
   return true;
 }
 
+export async function stopProjectCollector(projectRoot) {
+  const { stateFile } = collectorPaths(projectRoot);
+  const state = await readState(stateFile);
+  if (!state) return { stopped: false, pid: null };
+
+  const stopped = await stopCollector(state);
+  if (stopped || !pidAlive(state.pid)) {
+    try {
+      await unlink(stateFile);
+    } catch (error) {
+      if (error?.code !== 'ENOENT') throw error;
+    }
+  }
+  return { stopped, pid: stopped ? state.pid : null };
+}
+
 async function stopSpawnedCollector(pid) {
   if (!pidAlive(pid)) return;
   try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deeeed/metamask-harness",
-  "version": "0.26.2",
+  "version": "0.26.4",
   "type": "module",
   "bin": {
     "mm-harness": "bin/mm-harness"