@deeeed/metamask-harness 0.18.0 → 0.19.0

package/library/actions/core/perps/_controller.mjs

@@ -246,6 +246,14 @@ export function resolveNetwork(input) {
   return raw;
 }
 
+export function requireRuntimeExport(moduleNamespace, exportName, sourceLabel) {
+  const value = moduleNamespace?.[exportName] ?? moduleNamespace?.default?.[exportName];
+  if (value === undefined) {
+    throw new Error(`${sourceLabel} does not export ${exportName}.`);
+  }
+  return value;
+}
+
 /**
  * Instantiate the PerpsController headlessly against the resolved core checkout.
  * Returns the controller plus the resolved read account address. Cached per
@@ -261,10 +269,25 @@ export async function getCoreController(input) {
     return { ...cached, accountAddress };
   }
 
-  const [{ PerpsController }, { Messenger, MOCK_ANY_NAMESPACE }] = await Promise.all([
+  const [controllerModule, messengerModule] = await Promise.all([
     import(controllerEntry(projectRoot)),
     import(messengerEntry(projectRoot)),
   ]);
+  const PerpsController = requireRuntimeExport(
+    controllerModule,
+    'PerpsController',
+    'Core perps-controller entrypoint',
+  );
+  const Messenger = requireRuntimeExport(
+    messengerModule,
+    'Messenger',
+    'Core messenger entrypoint',
+  );
+  const MOCK_ANY_NAMESPACE = requireRuntimeExport(
+    messengerModule,
+    'MOCK_ANY_NAMESPACE',
+    'Core messenger entrypoint',
+  );
 
   const stubbed = new Set();
   const infrastructure = buildInfrastructure(stubbed);
@@ -558,6 +581,15 @@ export function configuredSymbols(input, items) {
   return single ? [normalizeMarketSymbol(single)] : [];
 }
 
+export function requireExplicitSelection(input) {
+  const selector =
+    input.node?.selector && typeof input.node.selector === 'object' ? input.node.selector : {};
+  const mode = String(input.node?.mode ?? selector.mode ?? '').toLowerCase();
+  if (configuredSymbols(input, []).length === 0 && mode !== 'all') {
+    throw new Error(`${input.action} requires market=<symbol> or mode=all.`);
+  }
+}
+
 /**
  * Filter live items to the recipe-selected subset using the same market/side
  * vocabulary as the extension perps adapter. With no selector and no

package/library/actions/core/perps/assert_orders.mjs

@@ -2,6 +2,7 @@ import {
   getCoreController,
   isDirectRun,
   redactOrder,
+  requireExplicitSelection,
   runAdapter,
   selectedItems,
 } from './_controller.mjs';
@@ -12,13 +13,15 @@ import {
 // assert_positions.mjs.
 
 export function expectedOpen(input) {
-  const state = String(input.node?.state ?? input.node?.order ?? 'open').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.assert_orders requires state=open or state=none.');
+  const state = String(input.node.state).toLowerCase();
   if (state === 'open' || state === 'present') return true;
   if (state === 'none' || state === 'closed' || state === 'absent') return false;
   throw new Error(`metamask.perps.assert_orders received unsupported state: ${state}`);
 }
 
 export async function assertOrders(input, expectOpen = expectedOpen(input)) {
+  requireExplicitSelection(input);
   const { controller, accountAddress, network } = await getCoreController(input);
   const orders = await controller.getOpenOrders({
     standalone: true,
@@ -28,14 +31,10 @@ export async function assertOrders(input, expectOpen = expectedOpen(input)) {
   const hasOrder = matching.length > 0;
 
   if (expectOpen && !hasOrder) {
-    throw new Error(
-      `Expected selected Perps open order(s), but none matched ${JSON.stringify(input.node)}.`,
-    );
+    throw new Error('Expected at least one matching open Perps order, but found none.');
   }
   if (!expectOpen && hasOrder) {
-    throw new Error(
-      `Expected no selected Perps open orders, but ${matching.length} matched ${JSON.stringify(input.node)}.`,
-    );
+    throw new Error(`Expected no matching open Perps orders, but found ${matching.length}.`);
   }
 
   return {

package/library/actions/core/perps/assert_positions.mjs

@@ -2,6 +2,7 @@ import {
   getCoreController,
   isDirectRun,
   redactPosition,
+  requireExplicitSelection,
   runAdapter,
   selectedItems,
 } from './_controller.mjs';
@@ -11,13 +12,15 @@ import {
 // throws on mismatch so the recipe fails loudly.
 
 export function expectedOpen(input) {
-  const state = String(input.node?.state ?? input.node?.position ?? 'open').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.assert_positions requires state=open or state=none.');
+  const state = String(input.node.state).toLowerCase();
   if (state === 'open' || state === 'present') return true;
   if (state === 'none' || state === 'closed' || state === 'absent') return false;
   throw new Error(`metamask.perps.assert_positions received unsupported state: ${state}`);
 }
 
 export async function assertPositions(input, expectOpen = expectedOpen(input)) {
+  requireExplicitSelection(input);
   const { controller, accountAddress, network } = await getCoreController(input);
   const positions = await controller.getPositions({
     standalone: true,
@@ -27,14 +30,10 @@ export async function assertPositions(input, expectOpen = expectedOpen(input)) {
   const hasPosition = matching.length > 0;
 
   if (expectOpen && !hasPosition) {
-    throw new Error(
-      `Expected selected Perps position(s), but none matched ${JSON.stringify(input.node)}.`,
-    );
+    throw new Error('Expected at least one matching open Perps position, but found none.');
   }
   if (!expectOpen && hasPosition) {
-    throw new Error(
-      `Expected no selected Perps positions, but ${matching.length} matched ${JSON.stringify(input.node)}.`,
-    );
+    throw new Error(`Expected no matching open Perps positions, but found ${matching.length}.`);
   }
 
   return {

package/library/actions/core/perps/close_orders.mjs

@@ -2,6 +2,7 @@ import {
   getCoreControllerWithSigner,
   isDirectRun,
   redactOrder,
+  requireExplicitSelection,
   runAdapter,
   selectedItems,
   symbolForItem,
@@ -37,6 +38,7 @@ async function waitForOrdersAbsent(controller, accountAddress, symbols, timeoutM
 }
 
 export async function closeOrders(input) {
+  requireExplicitSelection(input);
   const { controller, accountAddress, network } = await getCoreControllerWithSigner(input);
   const timeoutMs = Number(input.node?.timeout_ms ?? 30000);
 

package/library/actions/core/perps/close_positions.mjs

@@ -3,6 +3,7 @@ import {
   getCoreControllerWithSigner,
   isDirectRun,
   redactPosition,
+  requireExplicitSelection,
   runAdapter,
   selectedItems,
   symbolForItem,
@@ -36,6 +37,7 @@ async function waitForPositionsAbsent(controller, accountAddress, symbols, timeo
 }
 
 export async function closePositions(input) {
+  requireExplicitSelection(input);
   const { controller, accountAddress, network } = await getCoreControllerWithSigner(input);
   const timeoutMs = Number(input.node?.timeout_ms ?? 30000);
   const maxSlippageBps = Number(

package/library/actions/core/perps/ensure_orders.mjs

@@ -1,4 +1,4 @@
-import { getCoreController, isDirectRun, runAdapter, selectedItems } from './_controller.mjs';
+import { getCoreController, isDirectRun, requireExplicitSelection, runAdapter, selectedItems } from './_controller.mjs';
 import { assertOrders } from './assert_orders.mjs';
 import { closeOrders } from './close_orders.mjs';
 import { placeOrder } from './place_order.mjs';
@@ -8,7 +8,9 @@ import { placeOrder } from './place_order.mjs';
 // order state. Mirrors ensure_positions.mjs.
 
 export async function ensureOrders(input) {
-  const state = String(input.node?.state ?? input.node?.order ?? 'none').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.ensure_orders requires state=open or state=none.');
+  requireExplicitSelection(input);
+  const state = String(input.node.state).toLowerCase();
 
   if (state === 'none' || state === 'closed' || state === 'absent') {
     const close = await closeOrders(input);

package/library/actions/core/perps/ensure_positions.mjs

@@ -1,4 +1,4 @@
-import { getCoreController, isDirectRun, runAdapter, selectedItems } from './_controller.mjs';
+import { getCoreController, isDirectRun, requireExplicitSelection, runAdapter, selectedItems } from './_controller.mjs';
 import { assertPositions } from './assert_positions.mjs';
 import { closePositions } from './close_positions.mjs';
 import { placeOrder } from './place_order.mjs';
@@ -8,7 +8,9 @@ import { placeOrder } from './place_order.mjs';
 // state. Mirrors the extension ensure_positions semantics.
 
 export async function ensurePositions(input) {
-  const state = String(input.node?.state ?? input.node?.position ?? 'none').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.ensure_positions requires state=open or state=none.');
+  requireExplicitSelection(input);
+  const state = String(input.node.state).toLowerCase();
 
   if (state === 'none' || state === 'closed' || state === 'absent') {
     const close = await closePositions(input);

package/library/actions/core/perps/place_order.mjs

@@ -81,12 +81,16 @@ function resolveLimitPrice(input, isBuy, mid) {
 }
 
 export async function placeOrder(input) {
-  const { controller, accountAddress, network } = await getCoreControllerWithSigner(input);
   const symbol = resolveSymbol(input);
-  const side = String(input.node?.side ?? 'long').toLowerCase();
+  if (input.node?.side == null) throw new Error('metamask.perps.place_order requires side=long or side=short.');
+  if (input.node?.amount == null && input.node?.notional == null) {
+    throw new Error('metamask.perps.place_order requires amount=<usd> or notional=<usd>.');
+  }
+  const { controller, accountAddress, network } = await getCoreControllerWithSigner(input);
+  const side = String(input.node.side).toLowerCase();
   const isBuy = side !== 'short';
   const orderType = resolveOrderType(input);
-  const usdAmount = String(input.node?.amount ?? input.node?.notional ?? '11');
+  const usdAmount = String(input.node.amount ?? input.node.notional);
   const leverage = Number(input.node?.leverage ?? 3);
   const maxSlippageBps = Number(
     input.node?.max_slippage_bps ?? input.node?.maxSlippageBps ?? 300,

package/library/actions/extension/perps/assert_orders.mjs

@@ -2,7 +2,8 @@ import { runAdapter } from '../platform/cdp.mjs';
 import { assertOrders } from './perps.mjs';
 
 function expectedOpen(input) {
-  const state = String(input.node?.state ?? input.node?.orders ?? 'open').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.assert_orders requires state=open or state=none.');
+  const state = String(input.node.state).toLowerCase();
   if (state === 'open' || state === 'present') return true;
   if (state === 'none' || state === 'closed' || state === 'absent') return false;
   throw new Error(`metamask.perps.assert_orders received unsupported state: ${state}`);

package/library/actions/extension/perps/assert_positions.mjs

@@ -2,7 +2,8 @@ import { runAdapter } from '../platform/cdp.mjs';
 import { assertPositions } from './perps.mjs';
 
 function expectedOpen(input) {
-  const state = String(input.node?.state ?? input.node?.position ?? 'open').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.assert_positions requires state=open or state=none.');
+  const state = String(input.node.state).toLowerCase();
   if (state === 'open' || state === 'present') return true;
   if (state === 'none' || state === 'closed' || state === 'absent') return false;
   throw new Error(`metamask.perps.assert_positions received unsupported state: ${state}`);

package/library/actions/extension/perps/perps.mjs

@@ -24,20 +24,39 @@ function configuredSymbols(input, items) {
   const explicit = input.node?.markets ?? input.node?.symbols ?? selector.markets ?? selector.symbols;
   if (Array.isArray(explicit) && explicit.length > 0) return uniqueSymbols(explicit.map(normalizeMarketSymbol));
   if (typeof explicit === 'string' && explicit.length > 0) return uniqueSymbols(explicit.split(',').map((part) => normalizeMarketSymbol(part.trim())).filter(Boolean));
-  return [marketSymbol(input)];
+  const single = input.node?.market ?? input.node?.symbol ?? selector.market ?? selector.symbol;
+  return single ? [normalizeMarketSymbol(single)] : [];
 }
 
-function selectedItems(input, items) {
-  const symbols = new Set(configuredSymbols(input, items));
+export function selectedItems(input, items) {
+  const requested = configuredSymbols(input, items);
+  const symbols = requested.length > 0 ? new Set(requested) : null;
   const selector = input.node?.selector && typeof input.node.selector === 'object' ? input.node.selector : {};
   const side = input.node?.side ?? selector.side;
   return items.filter((item) => {
-    if (!symbols.has(symbolForItem(item))) return false;
+    if (symbols && !symbols.has(symbolForItem(item))) return false;
     if (side && sideForItem(item) && sideForItem(item) !== String(side).toLowerCase()) return false;
     return true;
   });
 }
 
+function requireExplicitSelection(input) {
+  const node = input.node ?? {};
+  const selector = node.selector && typeof node.selector === 'object' ? node.selector : {};
+  const values = [node.market, node.symbol, node.markets, node.symbols, selector.market, selector.symbol, selector.markets, selector.symbols];
+  const selected = values.some((value) => Array.isArray(value) ? value.length > 0 : value != null && String(value).trim() !== '');
+  if (!selected && node.mode !== 'all' && selector.mode !== 'all') {
+    throw new Error(`${input.action} requires market=<symbol> or mode=all.`);
+  }
+}
+
+function requirePlaceOrderInputs(input) {
+  const node = input.node ?? {};
+  if (node.market == null && node.symbol == null) throw new Error(`${input.action} requires market=<symbol>.`);
+  if (node.side == null) throw new Error(`${input.action} requires side=long or side=short.`);
+  if (node.amount == null && node.notional == null) throw new Error(`${input.action} requires amount=<usd> or notional=<usd>.`);
+}
+
 export function positionSelectionState(input, positions) {
   return { hasMatching: selectedItems(input, positions).length > 0 };
 }
@@ -85,33 +104,37 @@ export async function readOrders(input) {
 }
 
 export async function assertPositions(input, expectedOpen) {
+  requireExplicitSelection(input);
   return withExtensionPage(input, async (page) => {
     const timeoutMs = Number(input.node?.timeout_ms ?? 0);
-    if (expectedOpen && timeoutMs > 0) {
-      await waitForPositionPresent(page, marketSymbol(input), timeoutMs);
+    const requested = configuredSymbols(input, []);
+    if (expectedOpen && timeoutMs > 0 && requested.length === 1) {
+      await waitForPositionPresent(page, requested[0], timeoutMs);
     }
     const state = await page.readPositions();
     if (!state.available) throw new Error('stateHooks.submitRequestToBackground is unavailable; cannot assert live Perps positions.');
     const matching = selectedItems(input, state.positions);
     const hasPosition = matching.length > 0;
-    if (expectedOpen && !hasPosition) throw new Error(`Expected selected Perps position(s), but none matched ${JSON.stringify(input.node)}.`);
-    if (!expectedOpen && hasPosition) throw new Error(`Expected no selected Perps positions, but ${matching.length} matched ${JSON.stringify(input.node)}.`);
+    if (expectedOpen && !hasPosition) throw new Error('Expected at least one matching open Perps position, but found none.');
+    if (!expectedOpen && hasPosition) throw new Error(`Expected no matching open Perps positions, but found ${matching.length}.`);
     return { action: input.action, expectedOpen, matchingCount: matching.length, positions: matching.map(redactPosition), source: state.source ?? 'perps-stream-manager-cache' };
   });
 }
 
 export async function assertOrders(input, expectedOpen) {
+  requireExplicitSelection(input);
   return withExtensionPage(input, async (page) => {
     const orders = await readOpenOrders(page);
     const matching = selectedItems(input, orders);
     const hasOrders = matching.length > 0;
-    if (expectedOpen && !hasOrders) throw new Error(`Expected selected Perps order(s), but none matched ${JSON.stringify(input.node)}.`);
-    if (!expectedOpen && hasOrders) throw new Error(`Expected no selected Perps orders, but ${matching.length} matched ${JSON.stringify(input.node)}.`);
+    if (expectedOpen && !hasOrders) throw new Error('Expected at least one matching open Perps order, but found none.');
+    if (!expectedOpen && hasOrders) throw new Error(`Expected no matching open Perps orders, but found ${matching.length}.`);
     return { action: input.action, expectedOpen, matchingCount: matching.length, orders: matching.map(redactOrder), source: 'perps-stream-manager-cache' };
   });
 }
 
 export async function closePositions(input) {
+  requireExplicitSelection(input);
   return withExtensionPage(input, async (page) => {
     const timeoutMs = Number(input.node?.timeout_ms ?? 30000);
     const state = await page.readPositions();
@@ -147,6 +170,7 @@ export async function closePositions(input) {
 }
 
 export async function closeOrders(input) {
+  requireExplicitSelection(input);
   return withExtensionPage(input, async (page) => {
     const timeoutMs = Number(input.node?.timeout_ms ?? 30000);
     const before = await readOpenOrders(page);
@@ -370,9 +394,10 @@ async function waitForPositionPresent(page, symbol, timeoutMs) {
 }
 
 export async function placeOrder(input) {
+  requirePlaceOrderInputs(input);
   const symbol = marketSymbol(input);
-  const side = String(input.node?.side ?? 'long').toLowerCase();
-  const amount = String(input.node?.amount ?? input.node?.notional ?? '11');
+  const side = String(input.node.side).toLowerCase();
+  const amount = String(input.node.amount ?? input.node.notional);
   const leverage = Number(input.node?.leverage ?? 3);
   return withExtensionPage(input, async (page) => {
     await page.navigateHash(`#/perps/market/${encodeURIComponent(symbol)}`);
@@ -427,7 +452,9 @@ export async function placeOrder(input) {
 }
 
 export async function ensurePositions(input) {
-  const state = String(input.node?.state ?? input.node?.position ?? 'none').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.ensure_positions requires state=open or state=none.');
+  requireExplicitSelection(input);
+  const state = String(input.node.state).toLowerCase();
   if (state === 'none' || state === 'closed' || state === 'absent') {
     const close = await closePositions(input);
     return { ...(await assertPositions(input, false)), close };
@@ -445,7 +472,9 @@ export async function ensurePositions(input) {
 }
 
 export async function ensureOrders(input) {
-  const state = String(input.node?.state ?? input.node?.orders ?? 'none').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.ensure_orders requires state=open or state=none.');
+  requireExplicitSelection(input);
+  const state = String(input.node.state).toLowerCase();
   if (state === 'none' || state === 'closed' || state === 'absent') {
     const close = await closeOrders(input);
     return { ...(await assertOrders(input, false)), close };

package/library/actions/mobile/perps/assert_orders.mjs

@@ -2,7 +2,8 @@ import { runAdapter } from '../platform/bridge.mjs';
 import { assertOrders } from './perps.mjs';
 
 function expectedOpen(input) {
-  const state = String(input.node?.state ?? input.node?.orders ?? 'open').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.assert_orders requires state=open or state=none.');
+  const state = String(input.node.state).toLowerCase();
   if (state === 'open' || state === 'present') return true;
   if (state === 'none' || state === 'closed' || state === 'absent') return false;
   throw new Error(`metamask.perps.assert_orders received unsupported state: ${state}`);

package/library/actions/mobile/perps/assert_positions.mjs

@@ -2,7 +2,8 @@ import { runAdapter } from '../platform/bridge.mjs';
 import { assertPositions } from './perps.mjs';
 
 function expectedOpen(input) {
-  const state = String(input.node?.state ?? input.node?.position ?? 'open').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.assert_positions requires state=open or state=none.');
+  const state = String(input.node.state).toLowerCase();
   if (state === 'open' || state === 'present') return true;
   if (state === 'none' || state === 'closed' || state === 'absent') return false;
   throw new Error(`metamask.perps.assert_positions received unsupported state: ${state}`);

package/library/actions/mobile/perps/perps.mjs

@@ -34,20 +34,39 @@ function configuredSymbols(input, items) {
   const explicit = input.node?.markets ?? input.node?.symbols ?? selector.markets ?? selector.symbols;
   if (Array.isArray(explicit) && explicit.length > 0) return uniqueSymbols(explicit.map(normalizeMarketSymbol));
   if (typeof explicit === 'string' && explicit.length > 0) return uniqueSymbols(explicit.split(',').map((part) => normalizeMarketSymbol(part.trim())).filter(Boolean));
-  return [marketSymbol(input)];
+  const single = input.node?.market ?? input.node?.symbol ?? selector.market ?? selector.symbol;
+  return single ? [normalizeMarketSymbol(single)] : [];
 }
 
-function selectedItems(input, items) {
-  const symbols = new Set(configuredSymbols(input, items));
+export function selectedItems(input, items) {
+  const requested = configuredSymbols(input, items);
+  const symbols = requested.length > 0 ? new Set(requested) : null;
   const selector = input.node?.selector && typeof input.node.selector === 'object' ? input.node.selector : {};
   const side = input.node?.side ?? selector.side;
   return items.filter((item) => {
-    if (!symbols.has(symbolForItem(item))) return false;
+    if (symbols && !symbols.has(symbolForItem(item))) return false;
     if (side && sideForItem(item) && sideForItem(item) !== String(side).toLowerCase()) return false;
     return true;
   });
 }
 
+function requireExplicitSelection(input) {
+  const node = input.node ?? {};
+  const selector = node.selector && typeof node.selector === 'object' ? node.selector : {};
+  const values = [node.market, node.symbol, node.markets, node.symbols, selector.market, selector.symbol, selector.markets, selector.symbols];
+  const selected = values.some((value) => Array.isArray(value) ? value.length > 0 : value != null && String(value).trim() !== '');
+  if (!selected && node.mode !== 'all' && selector.mode !== 'all') {
+    throw new Error(`${input.action} requires market=<symbol> or mode=all.`);
+  }
+}
+
+function requirePlaceOrderInputs(input) {
+  const node = input.node ?? {};
+  if (node.market == null && node.symbol == null) throw new Error(`${input.action} requires market=<symbol>.`);
+  if (node.side == null) throw new Error(`${input.action} requires side=long or side=short.`);
+  if (node.amount == null && node.notional == null) throw new Error(`${input.action} requires amount=<usd> or notional=<usd>.`);
+}
+
 function uniqueSymbols(symbols) {
   return Array.from(new Set(symbols.filter(Boolean)));
 }
@@ -250,20 +269,22 @@ export async function readOrders(input) {
 }
 
 export async function assertPositions(input, expectedOpen) {
+  requireExplicitSelection(input);
   const positions = await readPositions(input);
   const matching = selectedItems(input, positions);
   const hasPosition = matching.length > 0;
-  if (expectedOpen && !hasPosition) throw new Error(`Expected selected Perps position(s), but none matched ${JSON.stringify(input.node)}.`);
-  if (!expectedOpen && hasPosition) throw new Error(`Expected no selected Perps positions, but ${matching.length} matched ${JSON.stringify(input.node)}.`);
+  if (expectedOpen && !hasPosition) throw new Error('Expected at least one matching open Perps position, but found none.');
+  if (!expectedOpen && hasPosition) throw new Error(`Expected no matching open Perps positions, but found ${matching.length}.`);
   return { action: input.action, expectedOpen, matchingCount: matching.length, positions: matching.map(redactPosition), source: 'mobile-perps-controller' };
 }
 
 export async function assertOrders(input, expectedOpen) {
+  requireExplicitSelection(input);
   const orders = await readOpenOrders(input);
   const matching = selectedItems(input, orders);
   const hasOrders = matching.length > 0;
-  if (expectedOpen && !hasOrders) throw new Error(`Expected selected Perps order(s), but none matched ${JSON.stringify(input.node)}.`);
-  if (!expectedOpen && hasOrders) throw new Error(`Expected no selected Perps orders, but ${matching.length} matched ${JSON.stringify(input.node)}.`);
+  if (expectedOpen && !hasOrders) throw new Error('Expected at least one matching open Perps order, but found none.');
+  if (!expectedOpen && hasOrders) throw new Error(`Expected no matching open Perps orders, but found ${matching.length}.`);
   return { action: input.action, expectedOpen, matchingCount: matching.length, orders: matching.map(redactOrder), source: 'mobile-perps-controller-open-orders' };
 }
 
@@ -315,6 +336,7 @@ async function closePositionItem(input, position) {
 }
 
 export async function closePositions(input) {
+  requireExplicitSelection(input);
   const before = await readPositions(input);
   const matching = selectedItems(input, before);
   const symbols = uniqueSymbols(matching.map(symbolForItem));
@@ -336,6 +358,7 @@ export async function closePositions(input) {
 }
 
 export async function closeOrders(input) {
+  requireExplicitSelection(input);
   const before = await readOpenOrders(input);
   const matching = selectedItems(input, before);
   const symbols = uniqueSymbols(matching.map(symbolForItem));
@@ -380,9 +403,10 @@ export async function closeOrders(input) {
 }
 
 export async function placeOrder(input) {
+  requirePlaceOrderInputs(input);
   const symbol = marketSymbol(input);
-  const side = String(input.node?.side ?? 'long').toLowerCase();
-  const amount = String(input.node?.amount ?? input.node?.notional ?? '11');
+  const side = String(input.node.side).toLowerCase();
+  const amount = String(input.node.amount ?? input.node.notional);
   const size = String(input.node?.size ?? '0.0001');
   const leverage = Number(input.node?.leverage ?? 3);
   const maxSlippageBps = Number(input.node?.max_slippage_bps ?? input.node?.maxSlippageBps ?? 300);
@@ -401,7 +425,9 @@ export async function placeOrder(input) {
 }
 
 export async function ensurePositions(input) {
-  const state = String(input.node?.state ?? input.node?.position ?? 'none').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.ensure_positions requires state=open or state=none.');
+  requireExplicitSelection(input);
+  const state = String(input.node.state).toLowerCase();
   if (state === 'none' || state === 'closed' || state === 'absent') {
     const close = await closePositions(input);
     return { ...(await assertPositions(input, false)), close };
@@ -415,7 +441,9 @@ export async function ensurePositions(input) {
 }
 
 export async function ensureOrders(input) {
-  const state = String(input.node?.state ?? input.node?.orders ?? 'none').toLowerCase();
+  if (input.node?.state == null) throw new Error('metamask.perps.ensure_orders requires state=open or state=none.');
+  requireExplicitSelection(input);
+  const state = String(input.node.state).toLowerCase();
   if (state === 'none' || state === 'closed' || state === 'absent') {
     const close = await closeOrders(input);
     return { ...(await assertOrders(input, false)), close };

package/library/library.json

@@ -3,5 +3,5 @@
   "schema_version": 1,
   "name": "metamask",
   "owner": "mm-harness-runner",
-  "description": "Canonical MetaMask recipe library: minimal, stable flows every recipe can compose. Team and personal libraries layer on top and win resolution by default."
+  "description": "Canonical MetaMask library of reusable, parameterized recipes. Team and personal libraries layer on top and win resolution by default."
 }