@deeeed/metamask-harness 0.17.5 → 0.18.0

package/adapters/manifest.json

@@ -18,6 +18,22 @@
       "inputs": "--target --port --clear; env WATCHER_PORT, METRO_PORT, MOBILE_METRO_REQUIRED_ENV, METRO_MAX_WORKERS",
       "outputs": "Metro PID file + log; exit 0 ready / 1 timeout / 2 bad args"
     },
+    {
+      "id": "mobile/start-console-forwarder",
+      "entry": "adapters/mobile/start-console-forwarder.sh",
+      "kind": "bash",
+      "purpose": "Ensure one runner-owned Mobile application console collector is alive after bridge readiness.",
+      "inputs": "--target --port --quiet; env WATCHER_PORT, METRO_PORT, METAMASK_RECIPE_CONSOLE_FORWARD",
+      "outputs": "app-console.log + collector PID file; exit 0 ready / 1 startup failed / 2 bad args"
+    },
+    {
+      "id": "mobile/launch-console-forwarder",
+      "entry": "adapters/mobile/launch-console-forwarder.cjs",
+      "kind": "node",
+      "purpose": "Detach the Mobile application console collector from command-runner process-group cleanup.",
+      "inputs": "--port --out --err",
+      "outputs": "collector PID on stdout; exit 0 launched / 1 spawn failed / 2 bad args"
+    },
     {
       "id": "mobile/launch-metro",
       "entry": "adapters/mobile/launch-metro.cjs",
@@ -62,17 +78,17 @@
       "id": "mobile/inject",
       "entry": "adapters/mobile/inject.sh",
       "kind": "bash",
-      "purpose": "Install the mobile harness overlay (delegate + snapshots; full mode adds the app bridge with backups).",
-      "inputs": "--target --allow-dirty-harness-paths --force-overlay --no-git-exclude; env RECIPE_HARNESS_ROOT, METAMASK_RUNNER_PROTOCOL_ROOT>FARMSLOT_ROOT",
-      "outputs": "<harness>/manifest.json + runner/ + scripts/ + backup store; exit 0/1/2"
+      "purpose": "Install Mobile runner metadata, delegates, and snapshots without modifying product source.",
+      "inputs": "--target --no-git-exclude; env RECIPE_HARNESS_ROOT, METAMASK_RUNNER_PROTOCOL_ROOT",
+      "outputs": "<harness>/manifest.json + runner/ + scripts/; exit 0/1/2"
     },
     {
       "id": "mobile/cleanup",
       "entry": "adapters/mobile/cleanup.sh",
       "kind": "bash",
-      "purpose": "Remove the mobile overlay; restore backed-up product files; remove recorded git excludes.",
-      "inputs": "--target --allow-managed-changes; env RECIPE_HARNESS_ROOT",
-      "outputs": "removes <harness>/ + backups; exit 0/1/2"
+      "purpose": "Remove Mobile harness metadata and recorded git excludes without touching product source.",
+      "inputs": "--target; env RECIPE_HARNESS_ROOT",
+      "outputs": "removes <harness>/; exit 0/1/2"
     },
     {
       "id": "mobile/verify",
@@ -114,6 +130,30 @@
       "inputs": "--target --runtime-dir --runner-bin --summary",
       "outputs": "<runtime-dir>/recipe-harness-webpack.{pid,log}; optional summary; exit 0/1/2"
     },
+    {
+      "id": "extension/launch-webpack",
+      "entry": "adapters/extension/launch-webpack.cjs",
+      "kind": "node",
+      "purpose": "Detach the normal yarn start watcher from the launching CLI process while preserving its target, environment, and log.",
+      "inputs": "--target --log --pid-file --sync-script --sync-pid-file --sync-log --dist --runtime-dist; optional --port --path-prefix",
+      "outputs": "watcher and runtime-sync pids; webpack and sync logs; exit 0/1"
+    },
+    {
+      "id": "extension/sync-webpack-dist",
+      "entry": "adapters/extension/sync-webpack-dist.cjs",
+      "kind": "node",
+      "purpose": "After each successful webpack compile, update the loaded isolated runtime in place so an ordinary browser refresh sees the edit.",
+      "inputs": "--watcher-pid --watch-log --target --dist --runtime-dist --pid-file",
+      "outputs": "runtime-dist updated in place after successful compile markers; exits with its watcher"
+    },
+    {
+      "id": "extension/stamp-runtime-title",
+      "entry": "adapters/extension/stamp-runtime-title.cjs",
+      "kind": "node",
+      "purpose": "Stamp the slot id into isolated Extension page titles so window identity survives browser refreshes.",
+      "inputs": "--target --runtime-dist; optional --runtime-dir",
+      "outputs": "home.html and sidepanel.html titles updated in the isolated runtime only; exit 0/1"
+    },
     {
       "id": "extension/stop-viewers",
       "entry": "adapters/extension/stop-viewers.sh",
@@ -378,22 +418,6 @@
       "inputs": "ESM import from resolve-slot-ports.mjs or resolve-slot-ports.ts",
       "outputs": "resolveSlotPortsByRepo and related functions"
     },
-    {
-      "id": "lib/resolve-farmslot-ports",
-      "entry": "adapters/shared/resolve-farmslot-ports.mjs",
-      "kind": "node",
-      "purpose": "Back-compat shim (one release): delegates to resolve-slot-ports.mjs.",
-      "inputs": "resolve-farmslot-ports.mjs <fn> <repo>",
-      "outputs": "same as resolve-slot-ports.mjs"
-    },
-    {
-      "id": "lib/resolve-farmslot-ports-core",
-      "entry": "adapters/shared/resolve-farmslot-ports-core.mjs",
-      "kind": "lib",
-      "purpose": "Back-compat shim (one release): re-exports resolve-slot-ports-core.mjs.",
-      "inputs": "ESM import of the old path",
-      "outputs": "re-exports resolveSlotPortsByRepo (and the resolveFarmslotPortsByRepo alias)"
-    },
     {
       "id": "lib/recipe-harness-root",
       "entry": "adapters/shared/recipe-harness-root.mjs",
@@ -406,18 +430,10 @@
       "id": "lib/resolve-slot-ports-sh",
       "entry": "adapters/shared/resolve-slot-ports.sh",
       "kind": "lib",
-      "purpose": "Bash-compat sourced wrapper over resolve-slot-ports.mjs for stop-metro and legacy callers.",
+      "purpose": "Sourced wrapper over resolve-slot-ports.mjs for shell runtime leaves.",
       "inputs": "source + resolve_* / apply_resolved_* function calls",
       "outputs": "KEY=VALUE lines on stdout; env vars via apply_resolved_*"
     },
-    {
-      "id": "lib/resolve-farmslot-ports-sh",
-      "entry": "adapters/shared/resolve-farmslot-ports.sh",
-      "kind": "lib",
-      "purpose": "Back-compat shim (one release): sources resolve-slot-ports.sh (keeps the resolve_farmslot_ports_by_repo alias).",
-      "inputs": "source",
-      "outputs": "same sourced functions as resolve-slot-ports.sh"
-    },
     {
       "id": "lib/reap-checkout-metros",
       "entry": "adapters/shared/reap-checkout-metros.sh",
@@ -480,12 +496,12 @@
       "outputs": "stable SHA-256 fingerprint"
     },
     {
-      "id": "compat-overlays/mobile",
-      "entry": "adapters/mobile/overlay/compat",
-      "kind": "compat-overlay",
-      "purpose": "Historical-commit replay support: reversible source overlays (e.g. rn81-message-event-source.patch) applied manually/via the recipe-harness skill so pre-RN-0.81 mobile checkouts boot and bridge under the current toolchain.",
-      "inputs": "manual `git apply` in the historical product checkout (no in-repo apply logic)",
-      "outputs": "patched historical checkout (reversible via git apply -R); overlay path recorded in eval evidence"
+      "id": "lib/update-check-worker",
+      "entry": "adapters/shared/update-check-worker.mjs",
+      "kind": "node",
+      "purpose": "Detached, silent registry probe used by the daily passive update notice.",
+      "inputs": "<cache-file> <timeout-ms> [registry-endpoint]",
+      "outputs": "atomic update-cache refresh; always silent and best-effort"
     }
   ]
 }

package/adapters/mobile/bridge-runtime/cdp-bridge.cjs

@@ -254,6 +254,21 @@ const COMMANDS = {
     return { ...result, testId, deviceName };
   },
 
+  async 'press-text'(client, args, { deviceName } = {}) {
+    const text = args[0];
+    if (!text) {
+      throw new Error('Usage: press-text <text>');
+    }
+    const expr = `(function() {
+      if (typeof globalThis.__AGENTIC__?.pressText !== 'function') {
+        return { ok: false, error: 'The app bridge does not expose pressText' };
+      }
+      return globalThis.__AGENTIC__.pressText(${JSON.stringify(text)});
+    })()`;
+    const result = await cdpEval(client, expr);
+    return { ...result, text, deviceName };
+  },
+
   async 'scroll-view'(client, args, { deviceName } = {}) {
     let testId;
     let offset = 300;
@@ -678,6 +693,7 @@ Commands:
   get-selected-account                 Get the currently selected account
   switch-account <address>             Switch to account by address
   press-test-id <testId>               Press a component by its testID prop
+  press-text <text>                     Press a component containing visible text
   scroll-view [--test-id <id>] [--offset <n>] [--animated]
                                        Scroll a ScrollView/FlatList
   set-input <testId> <value>           Set text input value by testID (calls onChangeText)

package/adapters/mobile/bridge-runtime/console-forwarder.cjs

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 // console-forwarder — stream device console lines into metro.log.
 //
-// React Native (Bridgeless) gates its legacy console→Metro forwarding on
+// React Native (Bridgeless) gates its built-in console→Metro forwarding on
 // `console._isPolyfilled` (setUpDeveloperTools.js, T214991636); with the Hermes
 // native console that gate is false, so app logs (incl. DevLogger) never reach
 // Metro's log. The supported contract for log consumption in modern RN is CDP —

package/adapters/mobile/bridge-runtime/lib/match-bridge-target.cjs

@@ -50,7 +50,9 @@ function matchesBridgeTarget(target, env) {
 // (an in-app agentic bridge is live), not merely a registered debug target.
 function hasMatchingRoute(value, env) {
   const targets = Array.isArray(value) ? value : [value];
-  return targets.some((t) => matchesBridgeTarget(t, env) && t && t.route);
+  return targets.some(
+    (t) => matchesBridgeTarget(t, env) && t && t.agenticPresent === true && Boolean(t.route),
+  );
 }
 
 // Human summary of the targets that answered (platform / deviceName), for teaching on

package/adapters/mobile/bridge-runtime/lib/target-discovery.cjs

@@ -136,7 +136,7 @@ async function discoverTarget(port) {
   //   ANDROID_TARGET_DEVICE_NAME — Metro-compatible model prefix resolved by bridge.mjs
   //     from the adb serial via `adb -s <serial> shell getprop ro.product.model`.
   //     Example: "Pixel 6" matches Metro deviceName "Pixel 6 - 16 - API 36".
-  //   ANDROID_DEVICE — exact Metro deviceName (backward compat / user-specified).
+  //   ANDROID_DEVICE — exact user-specified Metro deviceName.
   const androidTargetName = loadAndroidTargetDeviceName();
   const androidDevice = loadAndroidDevice();
   const adbSerial = process.env.ADB_SERIAL || process.env.ANDROID_SERIAL || '';
@@ -205,8 +205,7 @@ async function discoverTarget(port) {
       }
       candidates = androidFiltered;
     } else if (androidDevice) {
-      // Exact Metro deviceName match (user set ANDROID_DEVICE to the Metro name, or
-      // legacy path where ANDROID_DEVICE was not resolved from serial).
+      // Exact Metro deviceName match when the user set ANDROID_DEVICE directly.
       androidFiltered = candidates.filter((t) => t.deviceName === androidDevice);
       if (androidFiltered.length === 0) {
         // Pinned by exact Metro name but no candidate matched — fail fast.

package/adapters/mobile/cleanup.sh

@@ -1,196 +1,36 @@
 #!/usr/bin/env bash
-# cleanup.sh — remove the mobile harness overlay from a checkout
-#
-# Purpose:
-#   Restores backed-up product files (full installs), removes exactly the
-#   .git/info/exclude entries the install recorded, then deletes the harness
-#   dir and backup store. Metadata-only installs remove metadata alone.
-#
-# Inputs (flags / env):
-#   --target <metamask-mobile> (default $PWD)
-#   --allow-managed-changes   skip the managed-hash refusal
-#   env RECIPE_HARNESS_ROOT
-#
-# Outputs:
-#   Removes <harness>/ and backup dir; restores managed product paths.
-#   Exit 0 — cleaned; 1 — no backup state / changed managed paths refusal /
-#   missing backup; 2 — bad args.
-#
-# Never touches: product files other than the recorded managed paths;
-# .git/info/exclude lines it did not record; product-local cache dirs.
+# Remove checkout-local Mobile harness metadata without touching product source.
 set -euo pipefail
 
 TARGET="$PWD"
-ALLOW_MANAGED_CHANGES=false
 while [ "$#" -gt 0 ]; do
   case "$1" in
-    --target) TARGET="$2"; shift 2 ;;
-    --allow-managed-changes) ALLOW_MANAGED_CHANGES=true; shift ;;
-    -h|--help) echo "Usage: cleanup.sh [--target <metamask-mobile>] [--allow-managed-changes]"; exit 0 ;;
+    --target) [ "$#" -ge 2 ] || { echo "Missing value for --target" >&2; exit 2; }; TARGET="$2"; shift 2 ;;
+    -h|--help) echo "Usage: cleanup.sh [--target <metamask-mobile>]"; exit 0 ;;
     *) echo "Unknown arg: $1" >&2; exit 2 ;;
   esac
 done
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-TARGET="$(cd "$TARGET" && pwd)"
-# shellcheck disable=SC1091
-. "$SCRIPT_DIR/../shared/hash-helpers.sh"
-# shellcheck disable=SC1091
-for _hp in "$SCRIPT_DIR/../shared/harness-path.sh"; do
-  [ -f "$_hp" ] && { . "$_hp"; break; }
-done
-unset _hp
-if ! command -v harness_root >/dev/null 2>&1; then
-  echo "mm-harness: shared lib adapters/shared/harness-path.sh not found; reinstall the runner." >&2
-  exit 1
-fi
+. "$SCRIPT_DIR/../shared/harness-path.sh"
+TARGET="$(cd "$TARGET" && pwd -P)"
 HARNESS_DIR="$(harness_dir "$TARGET" mobile)"
 
-# A console-forwarder left running would keep polling for this checkout's Metro
-# after cleanup orphans it; stop any forwarder scoped to this checkout first.
 pkill -f "console-forwarder.cjs --port .* --out $TARGET/" 2>/dev/null || true
-if GIT_BACKUP_PATH="$(git -C "$TARGET" rev-parse --git-path recipe-harness/mobile/backup 2>/dev/null)"; then
-  case "$GIT_BACKUP_PATH" in
-    /*) BACKUP_DIR="$GIT_BACKUP_PATH" ;;
-    *) BACKUP_DIR="$TARGET/$GIT_BACKUP_PATH" ;;
-  esac
-else
-  BACKUP_DIR="$HARNESS_DIR/backup-store"
-fi
-if [ ! -f "$BACKUP_DIR/state.env" ] && [ -f "$HARNESS_DIR/backup/state.env" ]; then
-  BACKUP_DIR="$HARNESS_DIR/backup"
-fi
-STATE_FILE="$BACKUP_DIR/state.env"
-
-remove_recorded_git_exclude_entries() {
-  local tracking_file="$1"
-  [ -s "$tracking_file" ] || return 0
-  local git_dir exclude_file tmp_file
-  if ! git_dir="$(git -C "$TARGET" rev-parse --git-dir 2>/dev/null)"; then
-    return 0
-  fi
-  case "$git_dir" in
-    /*) ;;
-    *) git_dir="$TARGET/$git_dir" ;;
-  esac
-  exclude_file="$git_dir/info/exclude"
-  [ -f "$exclude_file" ] || return 0
-  # Remove only the lines THIS install recorded, one occurrence per distinct
-  # ledger entry (the appended copy is the last match), so a pre-existing
-  # duplicate copy or a stale/duplicate ledger entry never drops a line we did
-  # not add this run.
-  tmp_file="$(mktemp)"
-  awk '
-    NR==FNR { if (length($0)) want[$0]=1; next }
-    { lines[++n]=$0; if ($0 in want) last[$0]=n }
-    END { for (k in last) drop[last[k]]=1; for (i=1;i<=n;i++) if (!(i in drop)) print lines[i] }
-  ' "$tracking_file" "$exclude_file" > "$tmp_file"
-  mv "$tmp_file" "$exclude_file"
-}
-
-if [ -f "$HARNESS_DIR/manifest.json" ] && node -e '
-    const fs = require("fs");
-    const manifest = JSON.parse(fs.readFileSync(process.argv[1], "utf8"));
-    process.exit(manifest.installMode === "product-owned" ? 0 : 1);
-  ' "$HARNESS_DIR/manifest.json" 2>/dev/null; then
-  remove_recorded_git_exclude_entries "$HARNESS_DIR/added-git-exclude"
-  rm -rf "$HARNESS_DIR"
-  echo "Cleaned mobile recipe harness metadata from $TARGET (product-owned in-app bridge files left untouched)"
-  exit 0
-fi
-
-if [ ! -f "$STATE_FILE" ]; then
-  if [ -f "$HARNESS_DIR/manifest.json" ] && node -e '
-    const fs = require("fs");
-    const manifest = JSON.parse(fs.readFileSync(process.argv[1], "utf8"));
-    process.exit(manifest.installMode === "product-owned" ? 0 : 1);
-  ' "$HARNESS_DIR/manifest.json" 2>/dev/null; then
-    remove_recorded_git_exclude_entries "$HARNESS_DIR/added-git-exclude"
-    rm -rf "$HARNESS_DIR"
-    echo "Cleaned mobile recipe harness metadata from $TARGET (product-owned in-app bridge files left untouched)"
-    exit 0
-  fi
-  echo "No mobile harness backup found at $STATE_FILE" >&2
-  exit 1
-fi
-
-while IFS= read -r _line || [ -n "$_line" ]; do
-  [[ "$_line" =~ ^[[:space:]]*(#|$) ]] && continue
-  _key="${_line%%=*}"
-  _val="${_line#*=}"
-  case "$_key" in
-    AGENTIC_SERVICE_EXISTED|PACKAGE_JSON_EXISTED|NAVIGATION_SERVICE_EXISTED|APP_TSX_EXISTED) ;;
-    *) continue ;;
-  esac
-  export "$_key=$_val"
-done < "$STATE_FILE"
-unset _line _key _val
-
-HASH_FILE="$BACKUP_DIR/managed-hashes.tsv"
-
-verify_managed_paths_unchanged() {
-  if [ ! -f "$HASH_FILE" ]; then
-    cat >&2 <<EOF
-Refusing cleanup: no managed hash file found at $HASH_FILE.
-Re-run mobile harness install from the current runner to refresh safety metadata, or restore manually.
-EOF
-    exit 1
-  fi
-  local rel expected actual conflicts=0
-  while IFS=$'\t' read -r rel expected; do
-    [ -n "$rel" ] || continue
-    actual="$(hash_path "$rel")"
-    if [ "$actual" != "$expected" ]; then
-      echo "Refusing cleanup: managed harness path changed after install: $rel" >&2
-      echo "  expected: $expected" >&2
-      echo "  actual:   $actual" >&2
-      conflicts=1
-    fi
-  done < "$HASH_FILE"
-  if [ "$conflicts" != "0" ]; then
-    cat >&2 <<EOF
-Cleanup would restore backups over files that changed after harness install.
-Save/stash those changes, rerun harness install to refresh managed hashes, or restore manually.
-EOF
-    exit 1
-  fi
-}
-
-if [ "$ALLOW_MANAGED_CHANGES" != "true" ]; then
-  verify_managed_paths_unchanged
-else
-  echo "Allowing cleanup over changed managed harness paths."
-fi
 
-restore_path() {
-  local rel="$1"
-  local existed="$2"
-  local target_path="$TARGET/$rel"
-  local backup_path="$BACKUP_DIR/$rel"
-  if [ "$existed" = "1" ]; then
-    if [ ! -e "$backup_path" ]; then
-      echo "Missing backup for $rel at $backup_path" >&2
-      exit 1
+tracking_file="$HARNESS_DIR/added-git-exclude"
+if [ -s "$tracking_file" ]; then
+  git_dir="$(git -C "$TARGET" rev-parse --git-dir 2>/dev/null || true)"
+  if [ -n "$git_dir" ]; then
+    case "$git_dir" in /*) ;; *) git_dir="$TARGET/$git_dir" ;; esac
+    exclude_file="$git_dir/info/exclude"
+    if [ -f "$exclude_file" ]; then
+      tmp_file="$(mktemp)"
+      awk 'NR==FNR { if (length($0)) drop[$0]=1; next } !($0 in drop)' "$tracking_file" "$exclude_file" > "$tmp_file"
+      mv "$tmp_file" "$exclude_file"
     fi
-    rm -rf "$target_path"
-    mkdir -p "$(dirname "$target_path")"
-    cp -a "$backup_path" "$target_path"
-  else
-    rm -rf "$target_path"
   fi
-}
-
-restore_path "app/dev-tools/AgenticService" "${AGENTIC_SERVICE_EXISTED:-0}"
-if [ "${PACKAGE_JSON_EXISTED+x}" = "x" ]; then
-  restore_path "package.json" "$PACKAGE_JSON_EXISTED"
 fi
-restore_path "app/core/NavigationService/NavigationService.ts" "${NAVIGATION_SERVICE_EXISTED:-0}"
-restore_path "app/components/Nav/App/App.tsx" "${APP_TSX_EXISTED:-0}"
-
-remove_recorded_git_exclude_entries "$BACKUP_DIR/added-git-exclude"
 
-# Leave any product-local cache dirs alone: they are owned by the product
-# checkout, not the harness.
 rm -rf "$HARNESS_DIR"
-rm -rf "$BACKUP_DIR"
-echo "Cleaned mobile recipe harness from $TARGET"
+echo "Cleaned mobile harness metadata from $TARGET; product files were not touched"