@deeeed/metamask-harness 0.17.4 → 0.17.5

package/adapters/mobile/overlay/compat/README.md

@@ -0,0 +1,28 @@
+# Compatibility overlays (historical-commit replay)
+
+NOT dead code. These overlays exist for replay/eval runs against OLD product
+commits — e.g. re-running a historical task on a fixed baseline to validate
+prompt or harness changes. A "zero current references" scan will always come
+up empty here by design: the feature's purpose is non-current checkouts.
+
+- Purpose: make historical product checkouts bootable/bridgeable under the
+  current local toolchain so Recipe v1 evals can replay against them.
+- When it applies: mobile checkouts predating React Native 0.81 polyfill fixes.
+- How it is applied: MANUALLY (no automatic apply logic in this repo).
+  The operator or the `/recipe-harness` skill applies the patch reversibly
+  before a historical rebuild (`git apply <patch>` in the product checkout,
+  `git apply -R` to remove) and records the overlay path in validation
+  evidence. `adapters/mobile/inject.sh` does NOT apply these.
+
+Kept in the external runner repository, not Farmslot root scripts, so a
+`/recipe-harness` skill can apply the same reversible overlay before a
+historical rebuild and record the overlay path in validation evidence.
+
+Listed in adapters/manifest.json (kind: compat-overlay) so the doctor
+verifies the surface and this directory is never flagged as unused again.
+
+## Patches
+
+- `rn81-message-event-source.patch`: adds a read-only `MessageEvent.prototype.source`
+  getter for React Native 0.81 historical checkouts whose bundled polyfill omits
+  it while CDP websocket clients expect browser-compatible `MessageEvent` shape.

package/adapters/mobile/overlay/compat/rn81-message-event-source.patch

@@ -0,0 +1,42 @@
+compat-overlay: rn81-message-event-source (historical-checkout replay support)
+
+What: patches metamask-mobile shim.js to add a read-only
+MessageEvent.prototype.source getter.
+Why: the harness CDP bridge expects browser-compatible MessageEvent shape;
+pre-RN-0.81 checkouts ship a polyfill that omits .source, so the bridge
+cannot attach when replaying tasks on those historical commits.
+When: only when replaying/evaluating against mobile checkouts older than the
+RN 0.81 upgrade (pre-RN-0.81 checkouts). Never needed on current main.
+How: applied MANUALLY in the historical product checkout —
+  git apply <this file>     (and `git apply -R` to remove)
+No automatic apply logic exists in this repo. See ../README.md.
+
+diff --git a/shim.js b/shim.js
+--- a/shim.js
++++ b/shim.js
+@@
+ if (typeof global.MessageEvent === 'undefined') {
+   global.MessageEvent =
+     require('react-native/src/private/webapis/html/events/MessageEvent').default;
+ }
+ 
++// Historical runner compatibility: React Native 0.81's MessageEvent polyfill
++// can omit the browser `source` getter expected by CDP websocket clients under
++// newer Xcode/Hermes toolchains. Keep the getter read-only and null, matching
++// browser MessageEvent semantics for non-window messages.
++if (
++  global.MessageEvent?.prototype &&
++  !Object.getOwnPropertyDescriptor(global.MessageEvent.prototype, 'source')
++) {
++  Object.defineProperty(global.MessageEvent.prototype, 'source', {
++    configurable: true,
++    enumerable: true,
++    get() {
++      return null;
++    },
++  });
++}
++
+ class AbortError extends Error {
+   constructor(message) {
+     super(message);

package/adapters/mobile/start-metro.sh

@@ -77,6 +77,45 @@ default_metro_workers() {
 # shellcheck disable=SC1091
 . "$SCRIPT_DIR/lib/tmux-viewer.sh"
 
+# Bridgeless RN gates console→Metro forwarding on console._isPolyfilled, which is
+# false with the Hermes native console — device logs (incl. DevLogger) never reach
+# metro.log. The forwarder attaches over CDP and appends them back. Kill switch:
+# METAMASK_RECIPE_CONSOLE_FORWARD=0.
+start_console_forwarder() {
+  local forwarder="$SCRIPT_DIR/bridge-runtime/console-forwarder.cjs"
+  local fwd_pid_file="$LOG_DIR/console-forwarder.pid"
+  [ "${METAMASK_RECIPE_CONSOLE_FORWARD:-1}" != "0" ] || return 0
+  { [ -f "$forwarder" ] && command -v node >/dev/null 2>&1; } || return 0
+  # Only one debugger can own a React Native page. Reap any forwarder already
+  # attached to this Metro port, even if it was launched from another checkout or
+  # package install path and therefore does not own this runtime dir's pid file.
+  local pid cmd
+  while read -r pid cmd; do
+    case "$cmd" in
+      *console-forwarder.cjs*" --port $PORT "*|*console-forwarder.cjs*" --port=$PORT "*)
+        kill "$pid" 2>/dev/null || true
+        ;;
+    esac
+  done < <(ps -axo pid=,command= 2>/dev/null || true)
+  if [ -f "$fwd_pid_file" ]; then
+    local old_fwd
+    old_fwd="$(cat "$fwd_pid_file" 2>/dev/null || true)"
+    # A crash can leave a stale pid file and the OS can recycle the pid for an
+    # unrelated process — only kill when the command line is really ours.
+    if [ -n "$old_fwd" ]; then
+      case "$(ps -p "$old_fwd" -o command= 2>/dev/null)" in
+        *console-forwarder.cjs*) kill "$old_fwd" 2>/dev/null ;;
+      esac
+    fi
+    rm -f "$fwd_pid_file"
+  fi
+  nohup node "$forwarder" --port "$PORT" --out "$LOG_FILE" \
+    </dev/null >> "$LOG_DIR/console-forwarder.err" 2>&1 &
+  echo "$!" > "$fwd_pid_file"
+  disown 2>/dev/null || true
+  printf 'Device console → metro.log (CDP forwarder pid %s)\n' "$(cat "$fwd_pid_file")" >&2
+}
+
 write_metro_runner() {
   local runner="$1"
   local clear_flag=""
@@ -140,6 +179,7 @@ if metro_ready; then
     rm -f "$PID_FILE"
   elif metro_listener_valid; then
     printf 'Metro already running and valid on port %s\n' "$PORT" >&2
+    start_console_forwarder
     exit 0
   else
     stop_metro_listener || exit 1
@@ -229,6 +269,7 @@ if [ "$READY" = true ]; then
   first_ready_pid="${ready_pids%% *}"
   [ -z "$first_ready_pid" ] || printf '%s\n' "$first_ready_pid" > "$PID_FILE"
   printf 'Metro ready on port %s\n' "$PORT" >&2
+  start_console_forwarder
   printf '  Next: mm-harness logs  (tail Metro)\n' >&2
   exit 0
 fi

package/adapters/mobile/verify.sh

@@ -261,19 +261,76 @@ check_file "package.json"
 check_file "app/dev-tools/AgenticService/AgenticService.ts"
 
 if ! grep -q "AgenticService.install" "$TARGET/app/core/NavigationService/NavigationService.ts" 2>/dev/null; then
-  checks+=("{\"name\":\"NavigationService agentic bridge\",\"status\":\"fail\"}")
+  checks+=("{\"name\":\"NavigationService patch\",\"status\":\"fail\"}")
   status="fail"
 else
-  checks+=("{\"name\":\"NavigationService agentic bridge\",\"status\":\"pass\"}")
+  checks+=("{\"name\":\"NavigationService patch\",\"status\":\"pass\"}")
 fi
 
 if ! grep -q "AgentStepHud" "$TARGET/app/components/Nav/App/App.tsx" 2>/dev/null; then
-  checks+=("{\"name\":\"App AgentStepHud\",\"status\":\"fail\"}")
+  checks+=("{\"name\":\"App AgentStepHud patch\",\"status\":\"fail\"}")
   status="fail"
 else
-  checks+=("{\"name\":\"App AgentStepHud\",\"status\":\"pass\"}")
+  checks+=("{\"name\":\"App AgentStepHud patch\",\"status\":\"pass\"}")
 fi
 
+# Drift detection (read-only): compare the in-repo AgenticService/HUD against
+# the resolved runner overlay, not a runner-owned copy. The runner is the only
+# MetaMask-aware source of truth for Mobile injection.
+overlay_drift_check="$(
+  HARNESS_DIR_FOR_DRIFT="$HARNESS_DIR" TARGET_FOR_DRIFT="$TARGET" node <<'NODE'
+const fs = require('fs');
+const path = require('path');
+const name = 'agentic overlay matches runner (HUD freshness)';
+const harnessDir = process.env.HARNESS_DIR_FOR_DRIFT;
+const targetDir = path.join(process.env.TARGET_FOR_DRIFT, 'app', 'dev-tools', 'AgenticService');
+function readTrimmed(file) {
+  try { return fs.readFileSync(file, 'utf8').trim(); } catch { return ''; }
+}
+let runnerDir = readTrimmed(path.join(harnessDir, 'runner', '.runner-source'));
+if (!runnerDir) {
+  try {
+    const manifest = JSON.parse(fs.readFileSync(path.join(harnessDir, 'manifest.json'), 'utf8'));
+    runnerDir = manifest && manifest.source && manifest.source.runnerDir || '';
+  } catch {}
+}
+if (!runnerDir) {
+  process.stdout.write(JSON.stringify({ name, status: 'warn', detail: 'runner source unavailable; overlay freshness compare skipped' }));
+  process.exit(0);
+}
+const overlayDir = path.join(runnerDir, 'adapters', 'mobile', 'overlay', 'app', 'dev-tools', 'AgenticService');
+let checked = 0;
+const drifted = [];
+const missing = [];
+try {
+  for (const entry of fs.readdirSync(overlayDir)) {
+    if (!entry.endsWith('.patch')) continue;
+    if (/\.test\./u.test(entry)) continue;
+    const base = entry.slice(0, -'.patch'.length);
+    const targetFile = path.join(targetDir, base);
+    if (!fs.existsSync(targetFile)) { missing.push(base); continue; }
+    checked += 1;
+    if (fs.readFileSync(path.join(overlayDir, entry), 'utf8') !== fs.readFileSync(targetFile, 'utf8')) {
+      drifted.push(base);
+    }
+  }
+} catch (error) {
+  process.stdout.write(JSON.stringify({ name, status: 'warn', detail: 'runner overlay compare skipped: ' + String((error && error.message) || error) }));
+  process.exit(0);
+}
+if (drifted.length || missing.length) {
+  const parts = [];
+  if (drifted.length) parts.push('behind runner: ' + drifted.join(', '));
+  if (missing.length) parts.push('absent in repo: ' + missing.join(', '));
+  process.stdout.write(JSON.stringify({ name, status: 'warn', detail: parts.join('; ') + ' — rerun mm-harness install --force-overlay or mm-harness fixtures sync to refresh the in-repo HUD/AgenticService from the runner' }));
+} else if (checked === 0) {
+  process.stdout.write(JSON.stringify({ name, status: 'pass' }));
+} else {
+  process.stdout.write(JSON.stringify({ name, status: 'pass' }));
+}
+NODE
+)"
+checks+=("$overlay_drift_check")
 run_with_timeout() {
   local log_path="$1"
   local timeout_s="$2"

package/adapters/mobile/wait-for-bridge.sh

@@ -24,10 +24,10 @@ REQUIRE_PLATFORM=""
 
 while [ "$#" -gt 0 ]; do
   case "$1" in
-    --target)     [ "$#" -ge 2 ] || { echo "Missing value for --target" >&2; exit 2; }; TARGET="$2"; shift 2 ;;
-    --port)       [ "$#" -ge 2 ] || { echo "Missing value for --port" >&2; exit 2; }; PORT="$2"; shift 2 ;;
-    --max-polls)  [ "$#" -ge 2 ] || { echo "Missing value for --max-polls" >&2; exit 2; }; MAX_POLLS="$2"; shift 2 ;;
-    --platform)   [ "$#" -ge 2 ] || { echo "Missing value for --platform" >&2; exit 2; }; REQUIRE_PLATFORM="$2"; shift 2 ;;
+    --target)     TARGET="$2"; shift 2 ;;
+    --port)       PORT="$2"; shift 2 ;;
+    --max-polls)  MAX_POLLS="$2"; shift 2 ;;
+    --platform)   REQUIRE_PLATFORM="$2"; shift 2 ;;
     -h|--help)
       printf 'Usage: wait-for-bridge.sh [--target <dir>] [--port <n>] [--max-polls <n>] [--platform ios|android]\n'
       exit 0
@@ -36,12 +36,7 @@ while [ "$#" -gt 0 ]; do
   esac
 done
 
-case "$MAX_POLLS" in
-  ''|*[!0-9]*) echo "wait-for-bridge: --max-polls must be an integer of at least 2." >&2; exit 2 ;;
-esac
-[ "$MAX_POLLS" -ge 2 ] || { echo "wait-for-bridge: --max-polls must be at least 2 for stable readiness." >&2; exit 2; }
-
-TARGET="$(cd "$TARGET" && pwd -P)"
+TARGET="$(cd "$TARGET" && pwd)"
 
 # The matcher reads the required platform from the environment so the value survives
 # into the node subprocess that runs the shared matcher against the status output.
@@ -133,24 +128,15 @@ try {
 ' "$MATCH_LIB" "$STATUS_LOG" 2>/dev/null || printf 'none'
 }
 
-READY_STREAK=0
 for ATTEMPT in $(seq 1 "$MAX_POLLS"); do
   if bridge_has_route; then
-    READY_STREAK=$((READY_STREAK + 1))
-    # The bridge can appear briefly while React Native is still completing its
-    # startup navigation/reload. Require two consecutive healthy snapshots so a
-    # following command never inherits that transient gap.
-    if [ "$READY_STREAK" -ge 2 ]; then
-      printf 'Mobile bridge ready\n' >&2
-      exit 0
-    fi
-  else
-    READY_STREAK=0
+    printf 'Mobile bridge ready\n' >&2
+    exit 0
   fi
   if [ "$ATTEMPT" = "1" ] || [ $((ATTEMPT % 5)) -eq 0 ]; then
     printf 'Waiting for Mobile bridge (%s/%s): %s\n' "$ATTEMPT" "$MAX_POLLS" "$(bridge_wait_reason)" >&2
   fi
-  [ "$ATTEMPT" -ge "$MAX_POLLS" ] || sleep 2
+  sleep 2
 done
 
 cat "$STATUS_LOG" >&2 || true

package/adapters/shared/harness-source-fingerprint.mjs

@@ -0,0 +1,49 @@
+// harness-source-fingerprint.mjs — deterministic fingerprint of the runner files
+// that get injected into a slot's harness overlay.
+//
+// inject.mjs stamps this into the slot manifest at install time; the launch-time
+// freshness guard recomputes it and re-injects when they differ, so a slot can
+// never silently run a stale injected launcher after the runner changes. This is
+// what makes the runner the single source of truth: edit a runner adapter file and
+// the next launch refreshes every slot from it.
+//
+// stat-only (size + mtime) so it is cheap enough to run on every launch; no file
+// contents are read and no Date.now()/random is used (both would break determinism).
+import fs from 'node:fs';
+import path from 'node:path';
+import crypto from 'node:crypto';
+
+// Trees whose contents are copied into <slot>/harness by inject.mjs. Any change
+// here means injected slots are stale.
+const SOURCE_DIRS = ['adapters/extension', 'adapters/shared', 'library'];
+
+export function harnessSourceFingerprint(runnerDir) {
+  const entries = [];
+  for (const rel of SOURCE_DIRS) {
+    collect(path.join(runnerDir, rel), runnerDir, entries);
+  }
+  entries.sort();
+  return crypto.createHash('sha256').update(entries.join('\n')).digest('hex');
+}
+
+function collect(dir, root, out) {
+  let dirents;
+  try {
+    dirents = fs.readdirSync(dir, { withFileTypes: true });
+  } catch {
+    return; // absent tree contributes nothing
+  }
+  for (const dirent of dirents) {
+    // Skip hidden noise (.DS_Store, editor swap files) so the fingerprint tracks
+    // only real source and does not thrash re-injects.
+    if (dirent.name.startsWith('.')) continue;
+    const full = path.join(dir, dirent.name);
+    if (dirent.isDirectory()) {
+      collect(full, root, out);
+      continue;
+    }
+    if (!dirent.isFile()) continue;
+    const stat = fs.statSync(full);
+    out.push(`${path.relative(root, full)}|${stat.size}|${Math.floor(stat.mtimeMs)}`);
+  }
+}

package/adapters/shared/install-repo-deps.sh

@@ -4,11 +4,7 @@ set -euo pipefail
 TARGET=""
 while [[ $# -gt 0 ]]; do
   case "$1" in
-    --target)
-      [[ $# -ge 2 ]] || { echo "Usage: install-repo-deps.sh --target <checkout>" >&2; exit 2; }
-      TARGET="$2"
-      shift 2
-      ;;
+    --target) TARGET="$2"; shift 2 ;;
     -h|--help)
       echo "Usage: install-repo-deps.sh --target <checkout>"
       exit 0