@dedesfr/prompter 0.7.8 → 0.7.9

package/skills/laravel-code-review/references/php84-features.md

@@ -0,0 +1,442 @@
+# PHP 8.4 Features Reference
+
+Quick reference for PHP 8.4 features to use and deprecations to avoid.
+
+---
+
+## New Features to Adopt
+
+### Property Hooks (PHP 8.4)
+
+```php
+// ✅ New: Property hooks
+class User
+{
+    public string $fullName {
+        get => $this->firstName . ' ' . $this->lastName;
+        set => [$this->firstName, $this->lastName] = explode(' ', $value, 2);
+    }
+    
+    public string $email {
+        set => strtolower($value);
+    }
+}
+```
+
+### Asymmetric Visibility (PHP 8.4)
+
+```php
+// ✅ New: Different visibility for get/set
+class User
+{
+    public private(set) string $id;
+    public protected(set) string $name;
+}
+
+// Can read $user->id publicly
+// Can only set $user->id privately
+```
+
+### new Without Parentheses (PHP 8.4)
+
+```php
+// ❌ Old: Required parentheses
+$user = (new User())->setName('John');
+
+// ✅ New: No parentheses needed
+$user = new User()->setName('John');
+```
+
+### Array Find Functions (PHP 8.4)
+
+```php
+// ✅ New: array_find()
+$users = [
+    ['name' => 'John', 'active' => false],
+    ['name' => 'Jane', 'active' => true],
+];
+
+$activeUser = array_find($users, fn($u) => $u['active']);
+// Returns: ['name' => 'Jane', 'active' => true]
+
+// ✅ New: array_find_key()
+$key = array_find_key($users, fn($u) => $u['active']);
+// Returns: 1
+
+// ✅ New: array_any()
+$hasActive = array_any($users, fn($u) => $u['active']);
+// Returns: true
+
+// ✅ New: array_all()
+$allActive = array_all($users, fn($u) => $u['active']);
+// Returns: false
+```
+
+### HTML5 DOM Support (PHP 8.4)
+
+```php
+// ✅ New: Native HTML5 parsing
+$dom = Dom\HTMLDocument::createFromString($html);
+$dom = Dom\HTMLDocument::createFromFile('page.html');
+```
+
+---
+
+## PHP 8.3 Features (Ensure Usage)
+
+### #[Override] Attribute
+
+```php
+// ✅ Use Override for overridden methods
+class CustomHandler extends BaseHandler
+{
+    #[\Override]
+    public function handle(): void
+    {
+        // Implementation
+    }
+}
+```
+
+### Typed Class Constants
+
+```php
+// ✅ Type constants
+class Status
+{
+    public const string PENDING = 'pending';
+    public const string ACTIVE = 'active';
+    public const int MAX_RETRY = 3;
+}
+```
+
+### json_validate()
+
+```php
+// ❌ Old: Decode to validate
+$valid = json_decode($json) !== null;
+
+// ✅ New: Direct validation
+$valid = json_validate($json);
+```
+
+### Randomizer Additions
+
+```php
+// ✅ New random methods
+$randomizer = new Random\Randomizer();
+$randomizer->getBytesFromString('abc', 10);
+$randomizer->nextFloat();
+$randomizer->getFloat(0.0, 1.0);
+```
+
+---
+
+## PHP 8.2 Features (Ensure Usage)
+
+### Readonly Classes
+
+```php
+// ✅ Entire class readonly
+readonly class UserDTO
+{
+    public function __construct(
+        public string $name,
+        public string $email,
+    ) {}
+}
+```
+
+### Null/False/True Types
+
+```php
+// ✅ Standalone null type
+function alwaysNull(): null
+{
+    return null;
+}
+
+// ✅ Standalone false type
+function failed(): false
+{
+    return false;
+}
+```
+
+### Disjunctive Normal Form Types
+
+```php
+// ✅ Complex union types
+function process((A&B)|null $value): void {}
+```
+
+---
+
+## PHP 8.1 Features (Ensure Usage)
+
+### Enums
+
+```php
+// ✅ Backed enums
+enum OrderStatus: string
+{
+    case Pending = 'pending';
+    case Processing = 'processing';
+    case Completed = 'completed';
+    case Cancelled = 'cancelled';
+    
+    public function label(): string
+    {
+        return match($this) {
+            self::Pending => 'Order Pending',
+            self::Processing => 'In Progress',
+            self::Completed => 'Completed',
+            self::Cancelled => 'Cancelled',
+        };
+    }
+}
+```
+
+### Readonly Properties
+
+```php
+// ✅ Immutable properties
+class User
+{
+    public function __construct(
+        public readonly int $id,
+        public readonly string $email,
+    ) {}
+}
+```
+
+### First-Class Callables
+
+```php
+// ❌ Old: Closure::fromCallable
+$fn = Closure::fromCallable([$this, 'method']);
+
+// ✅ New: First-class callable syntax
+$fn = $this->method(...);
+```
+
+### Intersection Types
+
+```php
+// ✅ Require multiple interfaces
+function process(Countable&Iterator $items): void {}
+```
+
+### Fibers
+
+```php
+// ✅ Fiber for async
+$fiber = new Fiber(function() {
+    $value = Fiber::suspend('paused');
+    return $value;
+});
+
+$result = $fiber->start();
+$final = $fiber->resume('resumed');
+```
+
+---
+
+## PHP 8.0 Features (Ensure Usage)
+
+### Constructor Property Promotion
+
+```php
+// ❌ Old
+class User
+{
+    private string $name;
+    
+    public function __construct(string $name)
+    {
+        $this->name = $name;
+    }
+}
+
+// ✅ New: Property promotion
+class User
+{
+    public function __construct(
+        private readonly string $name,
+    ) {}
+}
+```
+
+### Named Arguments
+
+```php
+// ✅ Named arguments for clarity
+$user = new User(
+    name: 'John',
+    email: 'john@example.com',
+    isAdmin: false,
+);
+```
+
+### Match Expression
+
+```php
+// ❌ Old: Switch
+switch ($status) {
+    case 'pending':
+        $color = 'yellow';
+        break;
+    default:
+        $color = 'gray';
+}
+
+// ✅ New: Match
+$color = match($status) {
+    'pending' => 'yellow',
+    'approved' => 'green',
+    default => 'gray',
+};
+```
+
+### Nullsafe Operator
+
+```php
+// ❌ Old: Null checks
+$country = null;
+if ($user !== null && $user->address !== null) {
+    $country = $user->address->country;
+}
+
+// ✅ New: Nullsafe
+$country = $user?->address?->country;
+```
+
+### Union Types
+
+```php
+// ✅ Union types
+function parse(string|int $value): string|false {}
+```
+
+### Attributes
+
+```php
+// ✅ Native attributes
+#[Route('/users', methods: ['GET'])]
+public function index(): Response {}
+
+#[Deprecated('Use newMethod() instead')]
+public function oldMethod(): void {}
+```
+
+---
+
+## Deprecations to Fix
+
+### PHP 8.4 Deprecations
+
+```php
+// ❌ Deprecated: Implicit nullable
+function foo(string $value = null) {}
+
+// ✅ Fixed: Explicit nullable
+function foo(?string $value = null) {}
+
+// ❌ Deprecated: session_register()
+session_register('var');
+
+// ✅ Fixed: Use $_SESSION
+$_SESSION['var'] = $value;
+```
+
+### PHP 8.2 Deprecations
+
+```php
+// ❌ Deprecated: Dynamic properties
+class User
+{
+    public string $name;
+}
+$user = new User();
+$user->undefined = 'value'; // Deprecated!
+
+// ✅ Fixed: Define property or use #[AllowDynamicProperties]
+#[\AllowDynamicProperties]
+class User
+{
+    public string $name;
+}
+```
+
+### PHP 8.1 Deprecations
+
+```php
+// ❌ Deprecated: ${var} in strings
+$name = 'John';
+echo "Hello ${name}"; // Deprecated!
+
+// ✅ Fixed: Use {$var}
+echo "Hello {$name}";
+
+// ❌ Deprecated: Passing null to non-nullable
+strlen(null); // Deprecated!
+
+// ✅ Fixed: Check for null
+strlen($value ?? '');
+```
+
+---
+
+## Type Safety Improvements
+
+### Strict Return Types
+
+```php
+// ❌ Poor: No return type
+public function getUsers()
+{
+    return User::all();
+}
+
+// ✅ Good: Explicit return type
+public function getUsers(): Collection
+{
+    return User::all();
+}
+
+// ✅ Good: Never return type
+public function fail(): never
+{
+    throw new Exception('Failed');
+}
+
+// ✅ Good: Void return type
+public function log(string $message): void
+{
+    Log::info($message);
+}
+```
+
+### Strict Parameter Types
+
+```php
+// ❌ Poor: No parameter types
+public function process($data, $options)
+
+// ✅ Good: Typed parameters
+public function process(array $data, ProcessOptions $options): Result
+```
+
+---
+
+## Detection Patterns
+
+| Issue              | Detection Pattern                                           |
+| ------------------ | ----------------------------------------------------------- |
+| Missing readonly   | Class properties without `readonly` that are never modified |
+| Missing match      | Switch statements that return values                        |
+| Missing nullsafe   | Nested null checks with `&&`                                |
+| Missing named args | Constructor calls with 4+ positional parameters             |
+| Implicit nullable  | Parameters with `= null` but no `?` type                    |
+| Dynamic properties | Property access on undefined properties                     |
+| Old string syntax  | `${var}` instead of `{$var}`                                |

package/src/cli/index.ts

@@ -18,7 +18,7 @@ const program = new Command();
 program
     .name('prompter')
     .description('Enhance prompts directly in your AI coding workflow')
-    .version('0.7.8');
+    .version('0.7.9');
 
 program
     .command('init')

package/src/core/config.ts

@@ -28,7 +28,9 @@ export const SUPPORTED_TOOLS: ToolChoice[] = [
     { name: 'Codex', value: 'codex', available: true, successLabel: 'Codex' },
     { name: 'GitHub Copilot', value: 'github-copilot', available: true, successLabel: 'GitHub Copilot' },
     { name: 'OpenCode', value: 'opencode', available: true, successLabel: 'OpenCode' },
-    { name: 'Kilo Code', value: 'kilocode', available: true, successLabel: 'Kilo Code' }
+    { name: 'Kilo Code', value: 'kilocode', available: true, successLabel: 'Kilo Code' },
+    { name: 'Forge', value: 'forge', available: true, successLabel: 'Forge' },
+    { name: 'Droid', value: 'droid', available: true, successLabel: 'Droid' }
 ];
 
 export const AVAILABLE_PROMPTS: PromptChoice[] = [

package/src/core/configurators/slash/droid.ts

@@ -0,0 +1,40 @@
+import { SlashCommandConfigurator } from './base.js';
+import { SlashCommandId } from '../../templates/index.js';
+
+const FILE_PATHS: Record<SlashCommandId, string> = {
+    enhance: '.factory/commands/prompter/enhance.md',
+    'prd-generator': '.factory/commands/prompter/prd-generator.md',
+    'prd-agent-generator': '.factory/commands/prompter/prd-agent-generator.md',
+    'product-brief': '.factory/commands/prompter/product-brief.md',
+    'epic-single': '.factory/commands/prompter/epic-single.md',
+    'epic-generator': '.factory/commands/prompter/epic-generator.md',
+    'story-single': '.factory/commands/prompter/story-single.md',
+    'story-generator': '.factory/commands/prompter/story-generator.md',
+    'qa-test-scenario': '.factory/commands/prompter/qa-test-scenario.md',
+    'skill-creator': '.factory/commands/prompter/skill-creator.md',
+    'ai-humanizer': '.factory/commands/prompter/ai-humanizer.md',
+    'api-contract-generator': '.factory/commands/prompter/api-contract-generator.md',
+    'apply': '.factory/commands/prompter/apply.md',
+    'archive': '.factory/commands/prompter/archive.md',
+    'design-system': '.factory/commands/prompter/design-system.md',
+    'erd-generator': '.factory/commands/prompter/erd-generator.md',
+    'fsd-generator': '.factory/commands/prompter/fsd-generator.md',
+    'proposal': '.factory/commands/prompter/proposal.md',
+    'tdd-generator': '.factory/commands/prompter/tdd-generator.md',
+    'tdd-lite-generator': '.factory/commands/prompter/tdd-lite-generator.md',
+    'wireframe-generator': '.factory/commands/prompter/wireframe-generator.md',
+    'document-explainer': '.factory/commands/prompter/document-explainer.md'
+};
+
+export class DroidConfigurator extends SlashCommandConfigurator {
+    readonly toolId = 'droid';
+    readonly isAvailable = true;
+
+    protected getRelativePath(id: SlashCommandId): string {
+        return FILE_PATHS[id];
+    }
+
+    protected getFrontmatter(id: SlashCommandId): string | undefined {
+        return undefined;
+    }
+}

package/src/core/configurators/slash/forge.ts

@@ -0,0 +1,40 @@
+import { SlashCommandConfigurator } from './base.js';
+import { SlashCommandId } from '../../templates/index.js';
+
+const FILE_PATHS: Record<SlashCommandId, string> = {
+    enhance: '.forge/commands/prompter/enhance.md',
+    'prd-generator': '.forge/commands/prompter/prd-generator.md',
+    'prd-agent-generator': '.forge/commands/prompter/prd-agent-generator.md',
+    'product-brief': '.forge/commands/prompter/product-brief.md',
+    'epic-single': '.forge/commands/prompter/epic-single.md',
+    'epic-generator': '.forge/commands/prompter/epic-generator.md',
+    'story-single': '.forge/commands/prompter/story-single.md',
+    'story-generator': '.forge/commands/prompter/story-generator.md',
+    'qa-test-scenario': '.forge/commands/prompter/qa-test-scenario.md',
+    'skill-creator': '.forge/commands/prompter/skill-creator.md',
+    'ai-humanizer': '.forge/commands/prompter/ai-humanizer.md',
+    'api-contract-generator': '.forge/commands/prompter/api-contract-generator.md',
+    'apply': '.forge/commands/prompter/apply.md',
+    'archive': '.forge/commands/prompter/archive.md',
+    'design-system': '.forge/commands/prompter/design-system.md',
+    'erd-generator': '.forge/commands/prompter/erd-generator.md',
+    'fsd-generator': '.forge/commands/prompter/fsd-generator.md',
+    'proposal': '.forge/commands/prompter/proposal.md',
+    'tdd-generator': '.forge/commands/prompter/tdd-generator.md',
+    'tdd-lite-generator': '.forge/commands/prompter/tdd-lite-generator.md',
+    'wireframe-generator': '.forge/commands/prompter/wireframe-generator.md',
+    'document-explainer': '.forge/commands/prompter/document-explainer.md'
+};
+
+export class ForgeConfigurator extends SlashCommandConfigurator {
+    readonly toolId = 'forge';
+    readonly isAvailable = true;
+
+    protected getRelativePath(id: SlashCommandId): string {
+        return FILE_PATHS[id];
+    }
+
+    protected getFrontmatter(id: SlashCommandId): string | undefined {
+        return undefined;
+    }
+}

package/src/core/configurators/slash/index.ts

@@ -6,3 +6,5 @@ export { CodexConfigurator } from './codex.js';
 export { GithubCopilotConfigurator } from './github-copilot.js';
 export { OpenCodeConfigurator } from './opencode.js';
 export { KiloCodeConfigurator } from './kilocode.js';
+export { ForgeConfigurator } from './forge.js';
+export { DroidConfigurator } from './droid.js';

package/src/core/configurators/slash/registry.ts

@@ -5,6 +5,8 @@ import { CodexConfigurator } from './codex.js';
 import { GithubCopilotConfigurator } from './github-copilot.js';
 import { OpenCodeConfigurator } from './opencode.js';
 import { KiloCodeConfigurator } from './kilocode.js';
+import { ForgeConfigurator } from './forge.js';
+import { DroidConfigurator } from './droid.js';
 
 export class ConfiguratorRegistry {
     private configurators: Map<string, SlashCommandConfigurator> = new Map();
@@ -16,6 +18,8 @@ export class ConfiguratorRegistry {
         const githubCopilot = new GithubCopilotConfigurator();
         const opencode = new OpenCodeConfigurator();
         const kilocode = new KiloCodeConfigurator();
+        const forge = new ForgeConfigurator();
+        const droid = new DroidConfigurator();
 
         this.configurators.set(antigravity.toolId, antigravity);
         this.configurators.set(claude.toolId, claude);
@@ -23,6 +27,8 @@ export class ConfiguratorRegistry {
         this.configurators.set(githubCopilot.toolId, githubCopilot);
         this.configurators.set(opencode.toolId, opencode);
         this.configurators.set(kilocode.toolId, kilocode);
+        this.configurators.set(forge.toolId, forge);
+        this.configurators.set(droid.toolId, droid);
     }
 
     get(toolId: string): SlashCommandConfigurator | undefined {