@decocms/parity 0.15.0 → 0.16.0

package/CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [0.16.0](https://github.com/decocms/parity/compare/v0.15.1...v0.16.0) (2026-07-28)
+
+### Added
+
+* **Configurable `minicartPanel` selector for open-minicart reveal detection (issue #149).** `isCartUiVisible` and the title-scope sweep in `validateCartContainsTitleQuick` used a hardcoded list of name-based patterns (`[role='dialog']`, `[class*='minicart']`, etc.) to detect that the cart drawer was open. Any site built with utility-CSS (Tailwind) and `data-qa-*` testing attributes — a common modern stack — has no class/attribute those patterns can match, so detection always returns `null` and the step reports "failed" even when the drawer is genuinely open. The new `minicartPanel` selector key (`.parityrc.json`) is tried first, ahead of all hardcoded patterns. Built-in defaults cover `[data-qa-minicart]`, `[data-minicart]`, `[data-minicart-drawer]`, `[data-testid='minicart']` and common class patterns — so the `data-qa-*` case is handled out-of-the-box. Override with a single selector that matches the drawer root for your specific site.
+
+### Fixed
+
+* **`dismissOverlays` stall in `openMinicart` (issue #151).** The named-selector sweep inside `dismissOverlays` used a 400ms per-selector cap; with 12+ selectors none of which match, that's ~5s minimum before `openMinicart` could proceed — and on heavy pages the CDP calls could stall much longer, causing 50-100s gaps with zero debug output. Fixed by: (1) tightening the per-selector probe to 80ms (fast-failing `count()=0` before any `isVisible` call), (2) adding `dlog` at the entry of `dismissOverlays` and `openMinicart` so slow sweeps show up in `DEBUG_PARITY=1` output, and (3) wrapping the `dismissOverlays` call inside `openMinicart` with a 4s hard cap so it degrades gracefully instead of silently consuming the step budget.
+
 ## [0.15.0](https://github.com/decocms/parity/compare/v0.14.0...v0.15.0) (2026-07-27)
 
 ### Added

package/dist/cli.js

@@ -41389,6 +41389,7 @@ var ParityRc = z.object({
     quantityInput: z.string().optional(),
     minicartCount: z.string().optional(),
     cartOpenedIndicator: z.string().optional(),
+    minicartPanel: z.string().optional(),
     searchTrigger: z.string().optional(),
     searchInput: z.string().optional(),
     searchSuggestions: z.string().optional(),
@@ -49545,6 +49546,7 @@ var SelectorKey = z2.enum([
   "quantityInput",
   "minicartCount",
   "cartOpenedIndicator",
+  "minicartPanel",
   "searchTrigger",
   "searchInput",
   "searchSuggestions",
@@ -49949,6 +49951,17 @@ var DEFAULT_SELECTORS = {
     "[role='dialog']:has-text('adicionado')",
     "[role='dialog']:has-text('added')"
   ],
+  minicartPanel: [
+    "[data-qa-minicart]",
+    "[data-minicart]",
+    "[data-minicart-drawer]",
+    "[data-drawer='minicart']",
+    "[data-testid='minicart']",
+    "[data-testid='cart-drawer']",
+    "[class*='minicart' i]",
+    "[class*='cart-drawer' i]",
+    "[class*='drawer-cart' i]"
+  ],
   cartItemRow: [
     "[data-cart-item]",
     "[data-testid='cart-item']",
@@ -50706,15 +50719,21 @@ async function dismissBlockingOverlay(page, ctx, target) {
 function describe(b) {
   return `${b.tag}${b.id ? `#${b.id}` : ""}${b.className ? `.${b.className.split(/\s+/)[0]}` : ""}`;
 }
+var OVERLAY_PROBE_CAP_MS = 80;
 async function dismissOverlays(page, ctx) {
+  const sels = overlaySelectorsFor(ctx.rc);
+  dlog2(ctx, `  dismissOverlays: checking ${sels.length} selector(s)…`);
   const dismissals = [];
-  for (const sel of overlaySelectorsFor(ctx.rc)) {
+  for (const sel of sels) {
     try {
       const overlay = page.locator(sel).first();
-      if (!await withCap(overlay.isVisible({ timeout: 200 }).catch(() => false), 400, false))
+      const cnt = await withCap(overlay.count(), OVERLAY_PROBE_CAP_MS, 0);
+      if (cnt === 0)
+        continue;
+      if (!await withCap(overlay.isVisible({ timeout: OVERLAY_PROBE_CAP_MS }).catch(() => false), OVERLAY_PROBE_CAP_MS, false))
         continue;
       const closer = overlay.locator(CLOSE_BUTTON_SELECTOR).first();
-      if (await withCap(closer.isVisible({ timeout: 200 }).catch(() => false), 400, false)) {
+      if (await withCap(closer.isVisible({ timeout: OVERLAY_PROBE_CAP_MS }).catch(() => false), OVERLAY_PROBE_CAP_MS, false)) {
         await closer.click({ timeout: 1500 }).catch(() => {
           return;
         });
@@ -50750,8 +50769,10 @@ async function readCartCount(page, ctx) {
   }
   return 0;
 }
-async function isCartUiVisible(page) {
+async function isCartUiVisible(page, ctx) {
+  const configured = ctx ? [...selFor(ctx, "minicartPanel"), ...selFor(ctx, "cartOpenedIndicator")] : [];
   return firstVisible(page, [
+    ...configured,
     "[role='dialog']:visible",
     "[aria-modal='true']:visible",
     "[data-minicart][aria-hidden='false']",
@@ -50837,16 +50858,17 @@ async function detectCartRevealMode(page, trigger, drawerAlreadyOpen, viewport)
     return "click-drawer";
   return "unknown";
 }
-async function isCartRevealed(page, expectedProductTitle) {
+async function isCartRevealed(page, expectedProductTitle, ctx) {
   if (expectedProductTitle) {
-    const v = await validateCartContainsTitleQuick(page, expectedProductTitle);
+    const v = await validateCartContainsTitleQuick(page, expectedProductTitle, ctx);
     if (v)
       return `title-found:${v}`;
   }
-  return isCartUiVisible(page);
+  return isCartUiVisible(page, ctx);
 }
-async function validateCartContainsTitleQuick(page, expectedTitle) {
+async function validateCartContainsTitleQuick(page, expectedTitle, ctx) {
   const quickSelectors = [
+    ...ctx ? selFor(ctx, "minicartPanel") : [],
     "[role='dialog']",
     "[class*='minicart' i]",
     "[class*='cart' i]",
@@ -50881,9 +50903,14 @@ async function waitForCartHydration(page) {
 }
 async function openMinicart(page, trigger, ctx, expectedProductTitle) {
   const beforeUrl = page.url();
-  await dismissOverlays(page, ctx);
+  dlog2(ctx, `  openMinicart: starting — trigger=${trigger.selector} title=${expectedProductTitle?.slice(0, 40) ?? "none"}`);
+  await Promise.race([
+    dismissOverlays(page, ctx),
+    new Promise((resolve) => setTimeout(resolve, 4000))
+  ]);
+  dlog2(ctx, "  openMinicart: dismissOverlays done — checking alreadyOpen…");
   await page.waitForTimeout(800);
-  const alreadyOpen = await isCartRevealed(page, expectedProductTitle);
+  const alreadyOpen = await isCartRevealed(page, expectedProductTitle, ctx);
   if (alreadyOpen) {
     dlog2(ctx, `  openMinicart: already-open (matched ${alreadyOpen})`);
     return { method: "already-open", url: beforeUrl, visibleMarker: alreadyOpen };
@@ -50896,7 +50923,7 @@ async function openMinicart(page, trigger, ctx, expectedProductTitle) {
       return;
     });
     await page.waitForTimeout(1500);
-    const hoverOpened = await isCartRevealed(page, expectedProductTitle);
+    const hoverOpened = await isCartRevealed(page, expectedProductTitle, ctx);
     if (hoverOpened) {
       dlog2(ctx, `  openMinicart: hover opened drawer (${hoverOpened})`);
       return { method: "hover", url: page.url(), visibleMarker: hoverOpened };
@@ -50921,7 +50948,7 @@ async function openMinicart(page, trigger, ctx, expectedProductTitle) {
       return { method: "click-navigate", url: page.url(), visibleMarker: null };
     }
     await page.waitForTimeout(800);
-    const tapOpened = await isCartRevealed(page, expectedProductTitle);
+    const tapOpened = await isCartRevealed(page, expectedProductTitle, ctx);
     if (tapOpened) {
       dlog2(ctx, `  openMinicart: tap opened drawer (${tapOpened})`);
       return { method: "click", url: page.url(), visibleMarker: tapOpened };
@@ -50946,7 +50973,7 @@ async function openMinicart(page, trigger, ctx, expectedProductTitle) {
     return { method: "click-navigate", url: page.url(), visibleMarker: null };
   }
   await page.waitForTimeout(1500);
-  const clickOpened = await isCartRevealed(page, expectedProductTitle);
+  const clickOpened = await isCartRevealed(page, expectedProductTitle, ctx);
   if (clickOpened) {
     dlog2(ctx, `  openMinicart: click opened drawer (${clickOpened})`);
     return { method: "click", url: afterClickUrl, visibleMarker: clickOpened };
@@ -50957,7 +50984,7 @@ async function openMinicart(page, trigger, ctx, expectedProductTitle) {
       return;
     });
     await page.waitForTimeout(1500);
-    const hoverOpened = await isCartRevealed(page, expectedProductTitle);
+    const hoverOpened = await isCartRevealed(page, expectedProductTitle, ctx);
     if (hoverOpened) {
       dlog2(ctx, `  openMinicart: hover opened drawer (${hoverOpened})`);
       return { method: "hover", url: page.url(), visibleMarker: hoverOpened };
@@ -51003,7 +51030,16 @@ function titlesMatch(observed, expected) {
   return false;
 }
 async function validateCartContainsTitle(page, expectedTitle, ctx) {
+  const panelScopedTitleSelectors = selFor(ctx, "minicartPanel").flatMap((p) => [
+    `${p} a[href*='/p']`,
+    `${p} [class*='name' i]`,
+    `${p} [class*='title' i]`,
+    `${p} [class*='product' i]`,
+    `${p} [data-cart-item-name]`,
+    `${p} [data-qa-product-name]`
+  ]);
   const titleSelectors = [
+    ...panelScopedTitleSelectors,
     "[data-cart-item-name]",
     "[data-cart-item] [class*='title' i]",
     "[data-cart-item] [class*='name' i]",
@@ -51861,7 +51897,7 @@ async function flowPurchaseJourney(ctx) {
     let cartOpenMethod = "failed";
     let miniText = "";
     let cartRevealMode = "unknown";
-    const drawerAlreadyOpen = await isCartRevealed(page, expectedProductTitle) !== null;
+    const drawerAlreadyOpen = await isCartRevealed(page, expectedProductTitle, ctx) !== null;
     if (miniHit) {
       miniText = await miniHit.locator.innerText().catch(() => "");
       cartRevealMode = await detectCartRevealMode(page, miniHit.locator, drawerAlreadyOpen, ctx.viewport).catch(() => "unknown");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@decocms/parity",
-  "version": "0.15.0",
+  "version": "0.16.0",
   "description": "E2E parity validator for site migrations. Compares prod vs cand and reports UI, functional, SEO, visual, and Web Vitals deltas with an LLM-ranked HTML report.",
   "type": "module",
   "license": "MIT",