@decocms/apps-vtex 7.43.0 → 7.43.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@decocms/apps-vtex",
-  "version": "7.43.0",
+  "version": "7.43.1",
   "type": "module",
   "description": "Deco commerce app: VTEX integration",
   "repository": {
@@ -51,10 +51,10 @@
     "lint:unused": "knip"
   },
   "dependencies": {
-    "@decocms/blocks": "7.43.0",
-    "@decocms/apps-commerce": "7.43.0",
-    "@decocms/apps-website": "7.43.0",
-    "@decocms/tanstack": "7.43.0"
+    "@decocms/blocks": "7.43.1",
+    "@decocms/apps-commerce": "7.43.1",
+    "@decocms/apps-website": "7.43.1",
+    "@decocms/tanstack": "7.43.1"
   },
   "peerDependencies": {
     "@tanstack/react-query": ">=5.0.0",

package/src/utils/buildOfferShelf.test.ts

@@ -0,0 +1,59 @@
+import { describe, expect, it } from "vitest";
+import type { AggregateOffer, Offer, UnitPriceSpecification } from "@decocms/apps-commerce/types";
+import { useOffer } from "@decocms/apps-commerce/sdk/useOffer";
+import { buildOfferShelf } from "./transform";
+
+const installment = (
+	over: Partial<UnitPriceSpecification>,
+): UnitPriceSpecification =>
+	({
+		"@type": "UnitPriceSpecification",
+		priceType: "https://schema.org/SalePrice",
+		priceComponentType: "https://schema.org/Installment",
+		...over,
+	}) as UnitPriceSpecification;
+
+const offerWith = (specs: UnitPriceSpecification[]): Offer =>
+	({
+		"@type": "Offer",
+		price: 100,
+		priceSpecification: [
+			{ "@type": "UnitPriceSpecification", priceType: "https://schema.org/ListPrice", price: 120 },
+			{ "@type": "UnitPriceSpecification", priceType: "https://schema.org/SalePrice", price: 100 },
+			...specs,
+		],
+	}) as Offer;
+
+const pickInstallment = (offer: Offer) =>
+	useOffer({ "@type": "AggregateOffer", offers: [offer] } as AggregateOffer).installment;
+
+describe("buildOfferShelf installment selection", () => {
+	it("keeps the same installment useOffer picks on PLP/PDP (shelf == detail)", () => {
+		// 12x whose stated total (100) is the lowest and duration the highest, but VTEX
+		// rounding makes 12 * 8.34 = 100.08 — the old 1-cent isNoInterest check rejected
+		// it and the shelf fell back to 10x, diverging from the detail page's 12x.
+		const full = offerWith([
+			installment({ name: "PIX", billingDuration: 1, billingIncrement: 100, price: 100 }),
+			installment({ name: "Visa", billingDuration: 10, billingIncrement: 10, price: 100 }),
+			installment({ name: "Visa", billingDuration: 12, billingIncrement: 8.34, price: 100 }),
+			installment({ name: "Visa", billingDuration: 6, billingIncrement: 17.67, price: 106 }),
+		]);
+
+		const lean = buildOfferShelf(full);
+
+		expect(pickInstallment(lean)).toEqual(pickInstallment(full));
+		expect(pickInstallment(lean)?.billingDuration).toBe(12);
+	});
+
+	it("keeps the lowest-total plan even when every installment has interest", () => {
+		const full = offerWith([
+			installment({ name: "Visa", billingDuration: 3, billingIncrement: 34, price: 102 }),
+			installment({ name: "Visa", billingDuration: 6, billingIncrement: 18, price: 108 }),
+		]);
+
+		const lean = buildOfferShelf(full);
+
+		expect(pickInstallment(lean)).toEqual(pickInstallment(full));
+		expect(pickInstallment(lean)?.price).toBe(102);
+	});
+});

package/src/utils/transform.ts

@@ -20,6 +20,7 @@ import type {
 	SiteNavigationElement,
 	UnitPriceSpecification,
 } from "@decocms/apps-commerce/types";
+import { bestInstallment } from "@decocms/apps-commerce/sdk/useOffer";
 import { DEFAULT_IMAGE } from "@decocms/apps-commerce/utils/constants";
 import { formatRange } from "@decocms/apps-commerce/utils/filters";
 import { pick } from "./pickAndOmit";
@@ -509,61 +510,48 @@ export const toProduct = <P extends LegacyProductVTEX | ProductVTEX>(
 	};
 };
 
-/**
- * Determines if an installment has no interest by checking if
- * billingDuration * billingIncrement ≈ total price (within 1 cent tolerance).
- */
-const isNoInterest = (spec: UnitPriceSpecification): boolean => {
-	if (spec.billingDuration == null || spec.billingIncrement == null || spec.price == null) {
-		return false;
-	}
-	return Math.abs(spec.billingDuration * spec.billingIncrement - spec.price) < 0.01;
-};
-
 /**
  * Build a lean offer for shelf display. Keeps only:
  * - ListPrice, SalePrice, SRP price types
  * - PIX installment (name?.toUpperCase() === "PIX")
- * - Best no-interest installment (highest billingDuration)
+ * - Best installment, chosen with the SAME `bestInstallment` heuristic `useOffer`
+ *   applies on PLP/PDP (lowest total price, tie-broken by highest billingDuration).
+ *   Reusing it means shelf cards and detail pages always show the same installment.
  * Drops: inventoryLevel, giftSkuIds, priceValidUntil
  */
-const buildOfferShelf = (offer: Offer): Offer => {
+export const buildOfferShelf = (offer: Offer): Offer => {
 	const leanSpecs: UnitPriceSpecification[] = [];
-
-	let bestNoInterest: UnitPriceSpecification | null = null;
+	const installmentSpecs: UnitPriceSpecification[] = [];
 
 	for (const spec of offer.priceSpecification ?? []) {
-		// Keep base price types
+		// Keep base (non-installment) price types
 		if (
-			spec.priceType === SCHEMA_LIST_PRICE ||
-			spec.priceType === SCHEMA_SALE_PRICE ||
-			spec.priceType === SCHEMA_SRP
+			(spec.priceType === SCHEMA_LIST_PRICE ||
+				spec.priceType === SCHEMA_SALE_PRICE ||
+				spec.priceType === SCHEMA_SRP) &&
+			spec.priceComponentType !== SCHEMA_INSTALLMENT
 		) {
-			if (spec.priceComponentType !== SCHEMA_INSTALLMENT) {
-				leanSpecs.push(spec);
-				continue;
-			}
+			leanSpecs.push(spec);
+			continue;
 		}
 
-		// Keep PIX installment
+		// Keep PIX installment (also feeds the bestInstallment reducer below via leanSpecs)
 		if (spec.priceComponentType === SCHEMA_INSTALLMENT && spec.name?.toUpperCase() === "PIX") {
 			leanSpecs.push(spec);
 			continue;
 		}
 
-		// Track best no-interest installment (highest billingDuration)
-		if (
-			spec.priceComponentType === SCHEMA_INSTALLMENT &&
-			isNoInterest(spec) &&
-			(bestNoInterest == null ||
-				(spec.billingDuration ?? 0) > (bestNoInterest.billingDuration ?? 0))
-		) {
-			bestNoInterest = spec;
+		if (spec.priceComponentType === SCHEMA_INSTALLMENT) {
+			installmentSpecs.push(spec);
 		}
 	}
 
-	if (bestNoInterest) {
-		leanSpecs.push(bestNoInterest);
+	// Keep the single installment useOffer would pick from the full list. PIX is kept
+	// separately above, so useOffer on the lean offer still reduces over {PIX, best}
+	// and matches the detail page's reduce over the full set.
+	const best = installmentSpecs.reduce(bestInstallment, null as UnitPriceSpecification | null);
+	if (best) {
+		leanSpecs.push(best);
 	}
 
 	return {