@decocms/apps-commerce 7.72.0 → 8.0.0-next.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@decocms/apps-commerce",
-  "version": "7.72.0",
+  "version": "8.0.0-next.0",
   "type": "module",
   "description": "Deco commerce apps: shared types, app-registry, and portable commerce utilities",
   "repository": {
@@ -26,7 +26,7 @@
     "lint:unused": "knip"
   },
   "dependencies": {
-    "@decocms/blocks": "7.72.0"
+    "@decocms/blocks": "8.0.0-next.0"
   },
   "peerDependencies": {
     "react": "^19.0.0",

package/src/instrumentation-guardrail.test.ts

@@ -9,18 +9,18 @@
  * does NOT prove the fetch is actually reached at runtime — for VTEX/Shopify/
  * Magento that still depends on the *site* calling `setXFetch(createXFetch())`
  * at boot (they fall back to an uninstrumented `globalThis.fetch` otherwise).
- * Only Salesforce is auto-wired via `createHttpClient`'s default fetcher. So
- * this catches "a provider shipped with no instrumented fetch at all"; it does
- * not catch "a site forgot to wire it".
+ * So this catches "a provider shipped with no instrumented fetch at all"; it
+ * does not catch "a site forgot to wire it".
  *
  * This test reads sibling package source from disk (it does NOT import app
  * modules) so it stays within the one-way dependency graph. If you add a new
  * commerce provider, add it to REQUIRED below and give it a
  * `src/utils/instrumentedFetch.ts` that wires the two symbols.
  *
- * Known exception: `apps-algolia` uses the `algoliasearch` SDK, which owns its
- * own transport + cache, so it has no framework-instrumented fetch and is not
- * listed here.
+ * Thin clients (/next/upstream-clients) are checked separately below: each
+ * client module must build its requests on `createInstrumentedFetch` from
+ * `@decocms/blocks/fetch`, which measures every request itself, and must not
+ * call `fetch` in any form. A new thin client goes in V8_CLIENTS.
  */
 import { existsSync, readFileSync } from "node:fs";
 import { dirname, join } from "node:path";
@@ -42,7 +42,7 @@ function findRepoRoot(): string {
 const repoRoot = findRepoRoot();
 
 /** Commerce apps whose upstream egress must be instrumented. */
-const REQUIRED = ["apps-vtex", "apps-shopify", "apps-magento", "apps-salesforce"] as const;
+const REQUIRED = ["apps-vtex", "apps-shopify", "apps-magento"] as const;
 
 describe("commerce apps instrumentation guardrail", () => {
   for (const app of REQUIRED) {
@@ -62,3 +62,37 @@ describe("commerce apps instrumentation guardrail", () => {
     });
   }
 });
+
+/**
+ * v8 thin clients (/next/upstream-clients): each client module creates its
+ * requests with `createInstrumentedFetch` from `@decocms/blocks/fetch` under
+ * its own provider name, and never calls a fetch around it. Unlike the v7
+ * factories above, nothing has to be wired at boot: the instrumented fetch is
+ * the only way the client reaches the network. Each client's own tests assert
+ * the operation labels.
+ */
+const V8_CLIENTS: Record<string, { file: string; provider: string }> = {
+  "apps-shopify": { file: "src/v8/client.ts", provider: "shopify" },
+  "apps-vtex": { file: "src/vtexClient.ts", provider: "vtex" },
+  "apps-wake": { file: "src/wakeClient.ts", provider: "wake" },
+  "apps-magento": { file: "src/magentoClient.ts", provider: "magento" },
+  "apps-algolia": { file: "src/index.ts", provider: "algolia" },
+  "apps-resend": { file: "src/emails.ts", provider: "resend" },
+  "apps-sfmc-personalization": { file: "src/index.ts", provider: "sfmc-personalization" },
+};
+
+describe("v8 upstream clients use the instrumented fetch", () => {
+  for (const [app, { file, provider }] of Object.entries(V8_CLIENTS)) {
+    it(`${app} sends every request through createInstrumentedFetch as "${provider}"`, () => {
+      const src = readFileSync(join(repoRoot, "packages", app, file), "utf8");
+      const code = src.replace(/\/\*[\s\S]*?\*\//g, "").replace(/\/\/[^\n]*/g, "");
+      expect(src).toMatch(
+        /import\s*\{[^}]*\bcreateInstrumentedFetch\b[^}]*\}\s*from\s*"@decocms\/blocks\/fetch"/,
+      );
+      expect(src).toMatch(
+        new RegExp(`createInstrumentedFetch\\(\\s*\\{[^}]*\\bprovider:\\s*"${provider}"`),
+      );
+      expect(code, `${app} must not call fetch directly`).not.toMatch(/\bfetch\s*\(/);
+    });
+  }
+});