@decibelsystems/tools 2.2.0-beta.0 → 3.0.0

package/dist/httpServer.js

@@ -36,9 +36,12 @@ import { drainCommands, setSessionToken, getSessionToken, dropSessionToken, ackO
 import { settleCommandFromAck, ORG_ID } from './agentCommands.js';
 import { isSupabaseConfigured, getSupabaseServiceClient } from './lib/supabase.js';
 import { shouldQueueForAgent, parseToolCall } from './httpQueueDetection.js';
+import { getExtensionDiagnostics } from './kernel.js';
 import { getLicenseValidator } from './license.js';
 import { listProjects } from './projectRegistry.js';
 import { setDaemonPort } from './daemon.js';
+import { RUNTIME_PROTOCOL_VERSION } from './runtime/protocol.js';
+import { wrapSuccess, wrapError, envelopeHttpStatus, } from './lib/envelope.js';
 import { listEpics, listRepoIssues, isProjectResolutionError, } from './tools/sentinel.js';
 import { voiceInboxAdd, } from './tools/voice.js';
 import { generateImage, getImageStatus, meshyGenerate, getMeshyStatus, meshyDownload, tripoGenerate, getTripoStatus, tripoDownload, klingGenerateVideo, klingGenerateTextVideo, klingGenerateAvatar, getKlingStatus, listTasks, } from './tools/studio/index.js';
@@ -208,43 +211,6 @@ function formatUptime(ms) {
         return `${minutes}m ${seconds % 60}s`;
     return `${seconds}s`;
 }
-/**
- * Wrap a successful result in status envelope
- */
-function wrapSuccess(data) {
-    return { status: 'executed', ...data };
-}
-/**
- * Wrap an error in status envelope
- */
-/**
- * Sanitize error messages to prevent information disclosure.
- * Removes absolute file paths and replaces with generic placeholders.
- * Preserves URLs and relative paths.
- */
-function sanitizeErrorMessage(message) {
-    let sanitized = message;
-    // Step 1: Preserve paths containing .decibel (keep the .decibel part, strip prefix)
-    // /home/user/project/.decibel/foo -> .decibel/foo
-    sanitized = sanitized.replace(/(?:\/[^\s:'"]+)?\/\.decibel\//g, '.decibel/');
-    sanitized = sanitized.replace(/(?:[A-Z]:\\[^\s:'"]+)?\\\.decibel\\/gi, '.decibel\\');
-    // Step 2: Remove absolute Unix paths (must start with / and have at least one more /)
-    // But exclude URLs (http://, https://, file://)
-    // Match: /home/user/file.txt, /var/log/app.log
-    // Don't match: http://example.com, ./relative/path
-    sanitized = sanitized.replace(/(?<!:)\/(?:home|Users|var|tmp|opt|usr|etc|media|mnt)\/[^\s:'"]+/g, '[path]');
-    // Step 3: Remove Windows absolute paths (C:\, D:\, etc.)
-    sanitized = sanitized.replace(/[A-Z]:\\[^\s:'"]+/gi, '[path]');
-    // Step 4: Sanitize any remaining usernames in paths that weren't caught
-    sanitized = sanitized.replace(/\/home\/[^\/\s]+\//g, '/home/[user]/');
-    sanitized = sanitized.replace(/\/Users\/[^\/\s]+\//g, '/Users/[user]/');
-    sanitized = sanitized.replace(/C:\\Users\\[^\\]+\\/gi, 'C:\\Users\\[user]\\');
-    return sanitized;
-}
-function wrapError(error, code) {
-    const sanitized = sanitizeErrorMessage(error);
-    return { status: 'error', error: sanitized, ...(code && { code }) };
-}
 /**
  * Send JSON response with status envelope
  */
@@ -346,20 +312,30 @@ async function executeTool(tool, args, req, tierOverride) {
             requestId: req.headers['x-request-id'],
             tier: tierOverride,
             allowedFacades,
-        } : tierOverride ? { tier: tierOverride } : undefined;
+            transport: 'http',
+        } : tierOverride ? { tier: tierOverride, transport: 'http' } : { transport: 'http' };
         const toolResult = await kernel.dispatch(tool, args, context);
         const text = toolResult.content[0]?.text;
         if (toolResult.isError) {
             return wrapError(text || 'Tool execution failed', 'TOOL_ERROR');
         }
-        // Parse JSON result or wrap as message
+        // Parse the tool's payload, or carry it as prose when it isn't JSON.
+        //
+        // The prose branch is legitimate — some tools return markdown — but it used
+        // to be indistinguishable from a data response that failed to parse. A
+        // caller expecting `events` got an object with no `events` key, `ok: true`,
+        // and no indication that anything unusual happened. That is how a
+        // concatenated feedback prompt (fixed in tools/shared/response.ts) turned
+        // one call in fifteen into a silent empty result for every HTTP consumer.
+        // `payload_format` makes the two cases tellable apart.
         let result;
         if (text) {
             try {
                 result = JSON.parse(text);
             }
             catch {
-                result = { message: text };
+                log(`HTTP: tool ${tool} returned non-JSON text (${text.length} bytes) — carrying it as prose`);
+                result = { message: text, payload_format: 'text' };
             }
         }
         else {
@@ -406,6 +382,7 @@ async function queueForAgent(facade, action, args, agentId, projectId) {
     }
     return {
         status: 'queued',
+        ok: true,
         queue_id: data.id,
         message: 'Queued for local sync. Use agentic queue_status to check result.',
     };
@@ -424,7 +401,7 @@ function getAvailableTools() {
  * Get tools in OpenAI function calling format (facade-based)
  */
 function getOpenAITools() {
-    return kernel.getMcpToolDefinitions('full').map(def => ({
+    return kernel.getMcpToolDefinitions('full', { transport: 'http' }).map(def => ({
         type: 'function',
         function: {
             name: def.name,
@@ -630,6 +607,10 @@ export async function startHttpServer(server, kernelInstance, options) {
                 status: 'ok',
                 version: PKG.version,
                 api_version: 'v1',
+                // Wire-contract version, negotiated by ensureRuntime(). Distinct from
+                // `version` — a long-lived daemon can outlive the clients connecting to
+                // it, and most releases do not change the contract. See runtime/protocol.ts.
+                protocol_version: RUNTIME_PROTOCOL_VERSION,
                 uptime_ms: uptimeMs,
                 uptime_human: formatUptime(uptimeMs),
                 pid: process.pid,
@@ -642,6 +623,17 @@ export async function startHttpServer(server, kernelInstance, options) {
                 pro: licenseTier !== 'core',
                 license_tier: licenseTier,
                 supabase_configured: isSupabaseConfigured(),
+                // Facades whose dependency is failing. `{}` is the healthy case — a
+                // non-empty object means calls to those facades are being refused fast
+                // rather than left to time out. See runtime/circuitBreaker.ts.
+                circuits: kernel.circuitSnapshot(),
+                // Private facades loaded from the allowlist, and every entry refused.
+                // Reported because the alternative is silence: an extension that failed
+                // to load looks exactly like one that was never configured, and this
+                // daemon has already shipped one bug of that shape — a broken voice
+                // inbox that read as "0 messages" for five hours. See
+                // runtime/extensions.ts.
+                extensions: getExtensionDiagnostics(),
             }));
             return;
         }
@@ -785,6 +777,23 @@ export async function startHttpServer(server, kernelInstance, options) {
         // Simple REST Endpoints (for external AI agents)
         // ========================================================================
         // GET /tools - List available tools
+        // MCP tool definitions, verbatim — the shape a `tools/list` response needs.
+        //
+        // This is what lets a stdio client stop building its own kernel. /tools
+        // above is a human/OpenAI-shaped summary; this one is the exact array the
+        // MCP handler returns, so a thin adapter can serve tools/list by forwarding
+        // it rather than loading 195 tool modules to produce the same bytes.
+        if (path === '/mcp/tools' && req.method === 'GET') {
+            const tierParam = url.searchParams.get('tier');
+            const tier = (tierParam === 'compact' || tierParam === 'micro' ? tierParam : 'full');
+            sendJson(res, 200, wrapSuccess({
+                version: PKG.version,
+                protocol_version: RUNTIME_PROTOCOL_VERSION,
+                tier,
+                tools: kernel.getMcpToolDefinitions(tier, { transport: 'http' }),
+            }));
+            return;
+        }
         if (path === '/tools' && req.method === 'GET') {
             sendJson(res, 200, wrapSuccess({
                 version: PKG.version,
@@ -1151,7 +1160,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const tier = await resolveTier(req, configLicenseKey);
                 log(`HTTP: /call tool=${tool} tier=${tier}`);
                 const result = await executeTool(tool, args, req, tier);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1191,10 +1200,30 @@ export async function startHttpServer(server, kernelInstance, options) {
                     requestId: req.headers['x-request-id'] || bodyContext.requestId,
                     allowedFacades: bodyContext.allowedFacades,
                     tier,
+                    // Set here, never read from the request: a caller that could name its
+                    // own transport could name 'stdio' and walk straight through the
+                    // local-only gate.
+                    transport: 'http',
                 };
                 log(`HTTP: /batch — ${calls.length} calls (agent=${context.agentId || 'anonymous'}, tier=${tier})`);
                 const results = await kernel.batch(calls, context);
-                sendJson(res, 200, { status: 'executed', results });
+                // `ok` reflects STRUCTURAL validity: did every call name something this
+                // runtime actually has. A call that ran and returned isError leaves ok
+                // true — partial failure is a normal batch outcome and callers depend on
+                // that. A call naming a facade that is not registered does not.
+                //
+                // The status stays 200 because the body still carries real results for
+                // the other calls in the batch, and throwing those away behind a 4xx
+                // would trade one silent failure for another.
+                const unknown = results.filter(r => r.code === 'UNKNOWN_FACADE');
+                if (unknown.length > 0) {
+                    log(`HTTP: /batch — ${unknown.length} unknown facade(s): ${unknown.map(r => r.facade).join(', ')}`);
+                }
+                sendJson(res, 200, {
+                    status: unknown.length > 0 ? 'error' : 'executed',
+                    ok: unknown.length === 0,
+                    results,
+                });
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1223,7 +1252,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log(`HTTP: /api/tools/${toolName}`);
                 const result = await executeTool(toolName, body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1240,7 +1269,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /dojo/wish');
                 const result = await executeTool('dojo_add_wish', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1254,7 +1283,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /dojo/propose');
                 const result = await executeTool('dojo_create_proposal', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1268,7 +1297,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /dojo/scaffold');
                 const result = await executeTool('dojo_scaffold_experiment', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1282,7 +1311,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /dojo/run');
                 const result = await executeTool('dojo_run_experiment', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1296,7 +1325,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /dojo/results');
                 const result = await executeTool('dojo_read_results', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1317,7 +1346,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 }
                 log('HTTP: /dojo/list');
                 const result = await executeTool('dojo_list', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1337,7 +1366,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 }
                 log('HTTP: /dojo/wishes');
                 const result = await executeTool('dojo_list_wishes', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1351,7 +1380,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /dojo/can-graduate');
                 const result = await executeTool('dojo_can_graduate', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1365,7 +1394,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /dojo/artifact');
                 const result = await executeTool('dojo_read_artifact', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1379,7 +1408,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /dojo/bench');
                 const result = await executeTool('dojo_bench', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1396,7 +1425,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /bench/run');
                 const result = await executeTool('decibel_bench', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1410,7 +1439,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /bench/compare');
                 const result = await executeTool('decibel_bench_compare', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1427,7 +1456,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /context/refresh');
                 const result = await executeTool('decibel_context_refresh', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1441,7 +1470,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /context/pin');
                 const result = await executeTool('decibel_context_pin', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1455,7 +1484,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /context/unpin');
                 const result = await executeTool('decibel_context_unpin', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1475,7 +1504,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 }
                 log('HTTP: /context/list');
                 const result = await executeTool('decibel_context_list', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1489,7 +1518,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /event/append');
                 const result = await executeTool('decibel_event_append', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1517,7 +1546,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 }
                 log('HTTP: /event/search');
                 const result = await executeTool('decibel_event_search', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1531,7 +1560,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /artifact/list');
                 const result = await executeTool('decibel_artifact_list', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -1545,7 +1574,7 @@ export async function startHttpServer(server, kernelInstance, options) {
                 const body = await parseBody(req);
                 log('HTTP: /artifact/read');
                 const result = await executeTool('decibel_artifact_read', body);
-                sendJson(res, result.status === 'error' ? 400 : 200, result);
+                sendJson(res, envelopeHttpStatus(result), result);
             }
             catch (error) {
                 const message = error instanceof Error ? error.message : String(error);
@@ -2203,36 +2232,8 @@ ${authToken ? '║  Auth:     Bearer token required
         },
     };
 }
-/**
- * Parse command line arguments for HTTP mode
- */
-export function parseHttpArgs(args) {
-    const httpMode = args.includes('--http');
-    const portIndex = args.indexOf('--port');
-    // --port flag wins; else honor PORT env (Render sets it); else leave undefined
-    // so daemonConfig's default (4888) applies downstream instead of being
-    // short-circuited by a baked-in default here. See server.ts port/host resolution.
-    const port = portIndex !== -1
-        ? parseInt(args[portIndex + 1], 10)
-        : process.env.PORT
-            ? parseInt(process.env.PORT, 10)
-            : undefined;
-    // SECURITY: Prefer env var for auth token (CLI args visible in ps/history)
-    // Fall back to --auth-token for backwards compatibility
-    const authIndex = args.indexOf('--auth-token');
-    const authToken = process.env.DECIBEL_AUTH_TOKEN ||
-        (authIndex !== -1 ? args[authIndex + 1] : undefined);
-    const hostIndex = args.indexOf('--host');
-    // --host flag wins; else leave undefined so daemonConfig host (127.0.0.1, daemon
-    // mode) or the transport default applies instead of being short-circuited here.
-    const host = hostIndex !== -1 ? args[hostIndex + 1] : undefined;
-    // SSE/Connection tuning arguments
-    const keepaliveIndex = args.indexOf('--sse-keepalive');
-    const sseKeepaliveMs = keepaliveIndex !== -1 ? parseInt(args[keepaliveIndex + 1], 10) : undefined;
-    const timeoutIndex = args.indexOf('--timeout');
-    const timeoutMs = timeoutIndex !== -1 ? parseInt(args[timeoutIndex + 1], 10) : undefined;
-    const retryIndex = args.indexOf('--sse-retry');
-    const retryIntervalMs = retryIndex !== -1 ? parseInt(args[retryIndex + 1], 10) : undefined;
-    return { httpMode, port, authToken, host, sseKeepaliveMs, timeoutMs, retryIntervalMs };
-}
+// parseHttpArgs moved to ./httpArgs.js so that argv parsing carries no
+// dependencies. Re-exported here because it has always been part of this
+// module's surface.
+export { parseHttpArgs } from './httpArgs.js';
 //# sourceMappingURL=httpServer.js.map